Re: [Piglit] [PATCH v2 2/5] fbo-storage-formats: enable tests for OpenGl 3.0 formats.

2013-09-03 Thread Chad Versace
On 08/23/2013 11:51 AM, Kenney Phillis wrote: Enable the Floating point and Interformats that are introduced in the OpenGL 3.0 specification. Currently the test uses an OpenGL 3.1 Core context for Mesa based drivers, and this test should also work just fine when Compatibility contexts support

Re: [Piglit] [PATCH] gs: Test interaction between gl_PrimitiveIDIn and primitive restart.

2013-09-03 Thread Chad Versace
On 08/26/2013 11:38 PM, Paul Berry wrote: Verified using the NVIDIA proprietary driver for linux. --- tests/all.tests| 9 + .../glsl-1.50/execution/geometry/CMakeLists.gl.txt | 1 + .../execution/geometry/primitive-id-restart.c | 265

Re: [Piglit] [PATCH 3/3] GL 3.2: Test layered framebuffers clear the depth attachment properly.

2013-09-05 Thread Chad Versace
On 09/04/2013 12:34 PM, Paul Berry wrote: This needs to be: glClearBufferfv(GL_DEPTH, 0, clearDepth); With this fixed, the test passes, which surprised me, because I expected it to fail (I've looked at the code in Mesa, and we haven't implemented proper handling for layered depth clears

[Piglit] [PATCH 4/4] ext_image_dma_buf_import: Fix build with mesa 9.2

2013-09-10 Thread Chad Versace
in image_common.h. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/spec/ext_image_dma_buf_import/image_common.h | 30 ++ .../spec/ext_image_dma_buf_import/sample_common.c | 4 +-- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/tests/spec

[Piglit] [PATCH 3/4] cmake, dma_buf: Require libdrm_intel=2.4.38 to build dma_buf tests

2013-09-10 Thread Chad Versace
The dma_buf tests, when running on Intel hardware, use DRM prime buffers. Support for prime buffers arrived in libdrm_intel=2.4.38. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[Piglit] [PATCH 0/4] Fix build on systems with Mesa 9.2 or without libdrm

2013-09-10 Thread Chad Versace
` emits a fatal CMake error with message: PIGLIT_BUILD_DMA_BUF_TESTS require libdrm, libdrm_intel=2.4.38, and xcb-dri2 The series lives on my branch 'fix-build-dma-buf'. Chad Versace (4): cmake,dma_buf: Refactor decisions to build dma_buf tests cmake,dma_buf: Require xcb-dri2

[Piglit] [PATCH 1/4] cmake, dma_buf: Refactor decisions to build dma_buf tests

2013-09-10 Thread Chad Versace
of PIGLIT_BUILD_DMA_BUF_TESTS based on what packages are present on the system. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt | 27 ++ .../ext_image_dma_buf_import/CMakeLists.gles1.txt | 4 ++-- .../ext_image_dma_buf_import

[Piglit] [PATCH 2/4] cmake, dma_buf: Require xcb-dri2 for dma_buf tests

2013-09-10 Thread Chad Versace
xcb-dri2 is an optional build dependency for the dma_buf tests. If xcb-dri2 is present, then the tests use it to gain DRM authentication. Otherwise, the tests must be ran as root. No one likes running tests as root, so require xcb-dri2 for these tests. Signed-off-by: Chad Versace chad.vers

Re: [Piglit] [PATCH v2 1/3] piglit-summary-html.py: Replace .read().split('\n') with .readlines()

2013-09-10 Thread Chad Versace
There is typo in comments to patch 3: reutrns. Other than that, this series is Reviewed-by: Chad Versace chad.vers...@linux.intel.com On 08/29/2013 01:56 PM, Dylan Baker wrote: This is equivalent but simpler. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit-summary-html.py | 2

Re: [Piglit] [PATCH] gs: Test that input arrays can be accessed dynamically.

2013-09-10 Thread Chad Versace
On 09/04/2013 02:22 PM, Paul Berry wrote: Most geometry shaders access their input arrays using a constant index (or an index that is constant after loop unrolling). This test checks that we get the right results if we access a geometry shader input array using a non-constant index. ---

Re: [Piglit] [PATCH 1/2] Move gs-emits-too-few-verts.c into the correct folder

2013-09-10 Thread Chad Versace
'] = concurrent_test('glsl-1.50-gs-emits-too-few-verts') None of the other glsl-1.50/execution tests duplicate 'glsl-1.50' in their name. Change this to +spec['glsl-1.50']['gs-emits-too-few-verts'] = concurrent_test('glsl-1.50-gs-emits-too-few-verts') and patch 1 is Reviewed-by: Chad Versace

Re: [Piglit] [PATCH V2] util: Add multiple shader version of piglit_build_simple_program functions

2013-09-10 Thread Chad Versace
This looks mostly right. I have a few suggestions to make the code easier to read, and to remove some redundant code, and fix one risky bug. Also, if someone reviewed v1 of a patch, it's a really good idea to add him to the cc list on v2. So I've CC'd Ian for you. On 09/04/2013 04:45 PM, Jacob

Re: [Piglit] [PATCH] GL 3.2: Fix layered clear color test to work with MSVC.

2013-09-10 Thread Chad Versace
-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/2] Change the geometry shader output layouts from 'triangles' to 'triangle_strip' because 'triangles' should be invalid

2013-09-10 Thread Chad Versace
| 2 +- tests/spec/glsl-1.50/linker/gs-without-vs.shader_test | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) Looks good to me. Patch 2 is Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH 3/3 V2] GL 3.2: Test layered framebuffers clear the depth attachment properly.

2013-09-10 Thread Chad Versace
On 09/10/2013 01:47 PM, Jacob Penner wrote: --- tests/all.tests| 1 + .../gl-3.2/layered-rendering/CMakeLists.gl.txt | 1 + tests/spec/gl-3.2/layered-rendering/clear-depth.c | 224 + 3 files changed, 226 insertions(+) create

Re: [Piglit] [PATCH v2] gs: Test that input arrays can be accessed dynamically.

2013-09-10 Thread Chad Versace
a slightly more complex calculation that allows each vertex to have a different value of index (suggested by Chad Versace chad.vers...@linux.intel.com). --- .../geometry/dynamic_input_array_index.shader_test | 71 ++ 1 file changed, 71 insertions(+) create mode 100644 tests

Re: [Piglit] [PATCH 2/4] cmake, dma_buf: Require xcb-dri2 for dma_buf tests

2013-09-12 Thread Chad Versace
On 09/11/2013 05:35 AM, Pohjolainen, Topi wrote: On Tue, Sep 10, 2013 at 11:07:52AM -0700, Chad Versace wrote: xcb-dri2 is an optional build dependency for the dma_buf tests. If xcb-dri2 is present, then the tests use it to gain DRM authentication. Otherwise, the tests must be ran as root

Re: [Piglit] [PATCH 4/4] ext_image_dma_buf_import: Fix build with mesa 9.2

2013-09-12 Thread Chad Versace
On 09/11/2013 05:34 AM, Pohjolainen, Topi wrote: On Tue, Sep 10, 2013 at 11:07:54AM -0700, Chad Versace wrote: The extension EGL_EXT_image_dma_buf_import is a recent extension, published 2013-02-09, and therefore the eglext.h on many systems do not define it. The first Mesa version in which

Re: [Piglit] Could use your help with a bug involving piglit, waffle, and egl.

2013-09-16 Thread Chad Versace
CC'ing Piglit. On 09/14/2013 08:54 AM, Paul Berry wrote: I'm investigating a failure in spec/OES_fixed_point/attribute-arrays, specifically the command line /home/pberry/.platform/piglit-mesa/piglit/build/bin/oes_fixed_point-attribute-arrays -auto -fbo. It's segfaulting during piglit/waffle

Re: [Piglit] [PATCH V3] util: Add multiple shader version of piglit_build_simple_program functions

2013-09-17 Thread Chad Versace
)) { + glDeleteProgram(prog); + prog = 0; + piglit_report_result(PIGLIT_FAIL); + } + + return prog; +} Fix the my small quibbles (two spacing issues and naming inconsistency) and this is Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [Piglit] [PATCH 3/3 V2] GL 3.2: Test layered framebuffers clear the depth attachment properly.

2013-09-17 Thread Chad Versace
On 09/17/2013 10:59 AM, Paul Berry wrote: On 14 September 2013 09:25, Henri Verbeet hverb...@gmail.com mailto:hverb...@gmail.com wrote: On 13 September 2013 23:40, Paul Berry stereotype...@gmail.com mailto:stereotype...@gmail.com wrote: Looking at the specs yesterday, I *thought*

Re: [Piglit] [PATCH] oes_matrix_get: Add basic test for GL_OES_matrix_get

2013-09-17 Thread Chad Versace
` regardless of the queried matrix target, it's ripe for a false positive. Store a unique matrix into each matrix target and this gets Reviewed-by: Chad Versace chad.vers...@linux.intel.com Oh yeah, the -fbo crashing thing really sucks. ___ Piglit mailing

Re: [Piglit] [PATCH 1/2] framework: When a test fails, try it again to see if it's consistent.

2013-09-17 Thread Chad Versace
Series is Reviewed-by: Chad Versace chad.vers...@linux.intel.com I tested the unstable patch with `./piglit-run.py -t fbo-sys -t front -t timer`, and the html summary looks good to me. ___ Piglit mailing list Piglit@lists.freedesktop.org http

Re: [Piglit] [PATCH] piglit: Remove gtf.tests.

2013-09-19 Thread Chad Versace
On 09/18/2013 01:31 PM, Eric Anholt wrote: It was breaking my test systems, apparently because of the refactor to not import * in the caller of this file. At this point I think everyone's got es3conform building, which includes es2conform, so no point in still supporting the old one. ---

Re: [Piglit] [PATCH 1/3] piglit-run: add back -c0

2013-09-19 Thread Chad Versace
On 09/17/2013 08:43 AM, Dylan Baker wrote: On Monday 16 September 2013 20:08:33 Marek Olšák wrote: --- piglit-run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/piglit-run.py b/piglit-run.py index e8e11b7..7945b21 100755 --- a/piglit-run.py +++ b/piglit-run.py @@

[Piglit] [PATCH] egl-1.4: Add test egl-terminate-then-unbind-context

2013-09-20 Thread Chad Versace
-fbo` crashes on Intel for each GLES1 test. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69622 CC: Ian Romanick i...@freedesktop.org CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/all.tests| 1

[Piglit] [PATCH 2/3] util/egl: Add piglit_egl_bind_api()

2013-09-20 Thread Chad Versace
This is a wrapper for eglBindAPI() that does error-checking. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util-egl.c | 31 +++ tests/util/piglit-util-egl.h | 12 2 files changed, 43 insertions(+) diff --git a/tests/util

[Piglit] [PATCH 0/3] egl: Fix tests for context flags and add test for debug flag

2013-09-20 Thread Chad Versace
Chad Versace (3): egl_khr_create_context: Fix tests for invalid flags util/egl: Add piglit_egl_bind_api() egl_khr_create_context: Test the debug flag tests/all.tests| 2 + .../spec/egl_khr_create_context/CMakeLists.gl.txt | 1

[Piglit] [PATCH 1/3] egl_khr_create_context: Fix tests for invalid flags

2013-09-20 Thread Chad Versace
According to version 15 of the EGL_KHR_create_context spec, EGL_CONTEXT_OPENGL_DEBUG_BIT_KHR is a valid flag for OpenGL ES contexts. But the test EGL_KHR_create_context/invalid flag GLES verifies that it is an *invalid* flag. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- .../spec

[Piglit] [PATCH 3/3] egl_khr_create_context: Test the debug flag

2013-09-20 Thread Chad Versace
that EGL_BAD_MATCH is emitted. On Mesa 9.2 with Intel Haswell, the GL test passes, but the GLES tests fail because eglCreateContext emits EGL_BAD_ATTRIBUTE. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69624 Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/all.tests

Re: [Piglit] [PATCH 1/3] piglit-run: add back -c0

2013-09-24 Thread Chad Versace
On 09/21/2013 01:28 PM, Kenneth Graunke wrote: On 09/16/2013 11:08 AM, Marek Olšák wrote: --- piglit-run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/piglit-run.py b/piglit-run.py index e8e11b7..7945b21 100755 --- a/piglit-run.py +++ b/piglit-run.py @@ -62,7 +62,7

Re: [Piglit] [PATCH v2 01/10] GL3.2 GL_ARB_sync: Test to check the correct error messages are returned for invalid inputs for ClientWaitSync

2013-09-27 Thread Chad Versace
On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables, rewrite loop through all bit masks --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/ClientWaitSync-errors.c | 103 2 files changed, 104 insertions(+)

Re: [Piglit] [PATCH v2 01/10] GL3.2 GL_ARB_sync: Test to check the correct error messages are returned for invalid inputs for ClientWaitSync

2013-09-27 Thread Chad Versace
On 09/27/2013 04:22 PM, Chad Versace wrote: On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables, rewrite loop through all bit masks --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/ClientWaitSync-errors.c | 103

Re: [Piglit] [PATCH v2 05/10] GL3.2 GL_ARB_sync: Test for the correct error messages caused by invalid input to FenceSync

2013-09-27 Thread Chad Versace
(pass ? PIGLIT_PASS : PIGLIT_FAIL); +} This test looks correct, but the patch needs to to add it to all.tests. Do that and patch 5 is Reviewed-by: Chad Versace chad.vers...@linux.intel.com I'm done reviewing today, since it's a Friday afternoon. I'll pick the series back up on Monday

Re: [Piglit] [PATCH v2 04/10] GL3.2 GL_ARB_sync: Basic test for DeleteSync

2013-09-30 Thread Chad Versace
On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, add test for passing invalid sync to IsSync(), change variable types. --- tests/spec/arb_sync/CMakeLists.gl.txt | 2 +- tests/spec/arb_sync/DeleteSync.c | 71 +++ 2 files changed, 72

Re: [Piglit] [PATCH v2 06/10] GL3.2 GL_ARB_sync: Test that GetSynciv sets correct error codes.

2013-09-30 Thread Chad Versace
On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/GetSynciv-errors.c | 94 ++ 2 files changed, 95 insertions(+) create mode 100644

Re: [Piglit] [PATCH v2 07/10] GL3.2 GL_ARB_sync: Test that IsSync returns true/false if it is given a valid/invalid sync object name

2013-09-30 Thread Chad Versace
On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/IsSync.c | 82 +++ 2 files changed, 83 insertions(+) create mode 100644

Re: [Piglit] [PATCH v2 08/10] GL3.2 GL_ARB_sync: Test that a sync object is initialized with the correct properties

2013-09-30 Thread Chad Versace
On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, add extra checks for length variable being modified --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/sync-initialize.c | 125 ++ 2 files changed, 126 insertions(+) create

Re: [Piglit] [PATCH v2 10/10] Add the arb_sync tests to all.tests

2013-09-30 Thread Chad Versace
On 08/20/2013 11:26 AM, Nicholas Mack wrote: --- tests/all.tests | 8 1 file changed, 8 insertions(+) diff --git a/tests/all.tests b/tests/all.tests index 7491cae..f97c65b 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -989,8 +989,16 @@

Re: [Piglit] [PATCH v2 02/10] GL3.2 GL_ARB_sync: Test for valid return values from ClientWaitSync

2013-09-30 Thread Chad Versace
On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables. Still need to figure out if GPU commands needed before testing these. --- tests/spec/arb_sync/CMakeLists.gl.txt| 3 +- tests/spec/arb_sync/ClientWaitSync-returns.c | 109

Re: [Piglit] [PATCH] GL 3.2: Test that GetTexLevelParameterfv() generates an error when passed TEXTURE_BORDER

2013-09-30 Thread Chad Versace
On 09/27/2013 03:07 PM, Nicholas Mack wrote: --- tests/spec/gl-3.2/CMakeLists.gl.txt | 1 + tests/spec/gl-3.2/texture-border-deprecated.c | 63 +++ 2 files changed, 64 insertions(+) create mode 100644 tests/spec/gl-3.2/texture-border-deprecated.c This

[Piglit] [ANNOUNCE] waffle-1.3.0

2013-09-30 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Waffle 1.3.0 (30 Sept 2013) === Waffle 1.3.0 is now available. This release introduces the ability create forward-compatible and debug contexts as well as improved support for Mac OS. Details below. As usual, the release is

Re: [Piglit] [PATCH 1/3] egl_khr_create_context: Fix tests for invalid flags

2013-10-01 Thread Chad Versace
On 10/01/2013 02:49 PM, Matt Turner wrote: On Fri, Sep 20, 2013 at 7:02 PM, Chad Versace chad.vers...@linux.intel.com wrote: According to version 15 of the EGL_KHR_create_context spec, EGL_CONTEXT_OPENGL_DEBUG_BIT_KHR is a valid flag for OpenGL ES contexts. But the test EGL_KHR_create_context

Re: [Piglit] [PATCH 3/3] egl_khr_create_context: Test the debug flag

2013-10-01 Thread Chad Versace
On 10/01/2013 02:48 PM, Matt Turner wrote: On Fri, Sep 20, 2013 at 7:02 PM, Chad Versace chad.vers...@linux.intel.com wrote: Test eglCreateContext with with EGL_CONTEXT_OPENGL_BIT_KHR set for GL, GLES1, GLES2, and GLES3. If context creation succeeds, then verify the context is really a debug

[Piglit] [PATCH] egl_khr_create_context: Test the debug flag (v2)

2013-10-01 Thread Chad Versace
Turner matts...@gmail.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69624 Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/all.tests| 2 + .../spec/egl_khr_create_context/CMakeLists.gl.txt | 1 + .../spec/egl_khr_create_context

Re: [Piglit] [PATCH 1/4] util: Add utility function to accumulate results of subtests

2013-10-07 Thread Chad Versace
On 10/07/2013 09:02 AM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: From: Ian Romanick ian.d.roman...@intel.com This looks a lot like piglit_merge_result. Agreed. Let's re-use piglit_merge_result(). ___ Piglit mailing list

Re: [Piglit] [PATCH 2/4] util: Add common framework for command-line invoked subtests

2013-10-07 Thread Chad Versace
On 10/04/2013 06:10 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com There are two parts to this. First, command line options of the form -subtest foo have their argument (the foo part) stored in a list in the piglit_gl_test_config. Tests can use this functionality without

Re: [Piglit] [PATCH 3/4] util: Add a -list-subtests option that will list all the subtests

2013-10-07 Thread Chad Versace
On 10/04/2013 06:11 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com This required some ugly hacking about to get the list of subtests to process_args. Suggestions? Let's avoid these ugly hacks. Here's my suggestion, which covers patches 2 and 3. Patch 2/4 moves `struct

Re: [Piglit] [PATCH 3/4] util: Add a -list-subtests option that will list all the subtests

2013-10-07 Thread Chad Versace
On 10/07/2013 04:19 PM, Ian Romanick wrote: On 10/07/2013 11:02 AM, Chad Versace wrote: On 10/04/2013 06:11 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com This required some ugly hacking about to get the list of subtests to process_args. Suggestions? Let's avoid

[Piglit] [PATCH 2/5] util/gl: Support creation of forward-compatible contexts

2013-10-10 Thread Chad Versace
Add a new boolean flag to the PIGLIT_GL_TEST_CONFIG block, `config.require_forward_compatible_context`. If the test is unable to create a foward-compatible context, then the test skips. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl.h

[Piglit] [PATCH 3/5] util/gl: Support creation of debug contexts

2013-10-10 Thread Chad Versace
Add a new boolean flag to the PIGLIT_GL_TEST_CONFIG block, `config.require_debug_context`. If the test is unable to create a debug context, then the test skips. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl.h | 8 tests

[Piglit] [PATCH 0/5] Support creation of debug and forward-compatible contexts

2013-10-10 Thread Chad Versace
Patches 1-4 enable creation of debug and forward-compatible contexts. Patch 5 adds a basic test for forward-compatible contexts. This series lives on fwd-compat-and-debug-contexts branch. Chad Versace (5): cmake: If using Waffle, require waffle = 1.3 util/gl: Support creation of forward

[Piglit] [PATCH 4/5] util/wfl: Remove hacks for compat contexts

2013-10-10 Thread Chad Versace
forward-compatible contexts, because, according to thw EGL_KHR_create_context spec, requesting a forward-compatible context for OpenGL versions less than 3.0 will generate an error. Remove the hack. Pass the requested context version to Waffle. Signed-off-by: Chad Versace chad.vers

[Piglit] [PATCH 0/8] Tests for EGL_EXT_client_extensions

2013-10-12 Thread Chad Versace
lives on my egl-ext-client-extensions branch. I tested it against my Mesa branch of the same name. Chad Versace (8): util/gl: Define GL_GLEXT_PROTOTYPES for all GLES1 tests util/egl: Include eglext.h from piglit-util-egl.h ext_image_dma_buf_import: Cleanup up #includes util: Move EGL utilities

[Piglit] [PATCH 2/8] util/egl: Include eglext.h from piglit-util-egl.h

2013-10-12 Thread Chad Versace
If you're writing an EGL test, you likely want access to the extensions. This makes piglit-util-egl.h's behavior match that of piglit-util-gl-common.h, which defines (transitively through gl_wrap.h) all the GL/GLES extensions. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests

[Piglit] [PATCH 3/8] ext_image_dma_buf_import: Cleanup up #includes

2013-10-12 Thread Chad Versace
, we might as well also clean up the #includes by removing redundancy. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/spec/ext_image_dma_buf_import/image_common.c | 1 - tests/spec/ext_image_dma_buf_import/image_common.h | 6 -- tests/spec

[Piglit] [PATCH 4/8] util: Move EGL utilities from libpiglitutil_gl to libpiglitutil

2013-10-12 Thread Chad Versace
Many EGL tests make no GL calls. This is one step towards enabling those tests on platforms having OpenGL ES but not OpenGL. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/CMakeLists.no_api.txt | 12 tests/util/CMakeLists.txt| 11 --- tests

[Piglit] [PATCH 6/8] util: Add piglit_split_string_to_array()

2013-10-12 Thread Chad Versace
This splits a string into an array of strings, which is useful for splitting the string returned by eglQueryString(EGL_EXTENSIONS). Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util-gl-common.c | 23 +-- tests/util/piglit-util.c

[Piglit] [PATCH 8/8] egl_ext_client_extensions: Add initial tests

2013-10-12 Thread Chad Versace
Add tests for the conformance tests listed in the EGL_EXT_client_extensions spec. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/all.tests| 5 + tests/egl/spec/CMakeLists.txt | 1 + .../CMakeLists.no_api.txt

[Piglit] [PATCH 5/8] egl: Fix CMake traversal into egl/spec dir

2013-10-12 Thread Chad Versace
CMake should traverse into subdirectories independent of the current OpenGL. That is, the generic CMakeLists.txt should call add_subdirectory(xxx), not the api-specific CMakeLists.$api.txt. For precedent, see tests/spec/CMakeLists.txt. Signed-off-by: Chad Versace chad.vers...@linux.intel.com

Re: [Piglit] [PATCH 1/8] GL3.2 GL_ARB_sync: Test to check the correct error messages are returned for invalid inputs for ClientWaitSync

2013-10-14 Thread Chad Versace
Thanks for the cleanups and fixes. I've committed patches 1,3-7 with minor fixes. I've added a v4 annotation for each patch. As for the patch subject, the convention is that we use a simpler prefix. If a test is for an extension that was later promoted to a real OpenGL version, like

Re: [Piglit] [PATCH 8/8] GL3.2 GL_ARB_sync: Test that the correct error messages are returned from invalid input for WaitSync

2013-10-14 Thread Chad Versace
On 10/07/2013 08:46 AM, Nicholas Mack wrote: v2: Fix comments, remove redundant code v3: Add to all.tests --- tests/all.tests | 1 + tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/WaitSync-errors.c | 82 +++ 3 files

[Piglit] [PATCH] cmake: Detect if system has POSIX clocks

2013-10-14 Thread Chad Versace
Set CMake cache var PIGLIT_HAS_POSIX_CLOCKS if if clock_gettime() is available. Tests that need to measure time, such as GL_ARB_sync tests, will use Posix clocks. CC: Nicholas Mack nichm...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt | 11 +++ 1

Re: [Piglit] [PATCH] glut framework: skip if implementation doesn't support required GL version.

2013-10-14 Thread Chad Versace
the check manually, since GLUT always just creates the highest GL version context it can. --- .../piglit-framework-gl/piglit_glut_framework.c| 28 ++ 1 file changed, 28 insertions(+) Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [Piglit] [PATCH 2/8] GL3.2 GL_ARB_sync: Test for valid return values from ClientWaitSync

2013-10-14 Thread Chad Versace
On 10/07/2013 08:46 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables. Still need to figure out if GPU commands needed before testing these. v3: Rewrite test cases, fix comment and config block and add to all.tests --- tests/all.tests | 1 +

Re: [Piglit] [PATCH 0/5] Support creation of debug and forward-compatible contexts

2013-10-14 Thread Chad Versace
On 10/14/2013 09:21 AM, Ian Romanick wrote: On 10/13/2013 05:38 AM, Timothy Arceri wrote: Hi Chad, I successfully tested the patches for creating a debug-context with an Intel GPU but if I added config.require_debug_context = true; to tests/spec/arb_debug_output/api_error.c and run on a PC

[Piglit] [PATCH 1/4] cmake: Remove unused PIGLIT_HAS_EGL

2013-10-16 Thread Chad Versace
CC: Ian Romanick i...@freedesktop.org Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4ec5ddf..82a9d4a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -272,7 +272,6

[Piglit] [PATCH 2/4] cmake: Add option PIGLIT_BUILD_EGL_TESTS

2013-10-16 Thread Chad Versace
This defaults to true on Linux and false elswhere. If set, then CMake requires that EGL be installed onto the system. CC: Ian Romanick i...@freedesktop.org Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt | 21 - 1 file changed, 12 insertions(+), 9

Re: [Piglit] [PATCH 4/8] util: Move EGL utilities from libpiglitutil_gl to libpiglitutil

2013-10-16 Thread Chad Versace
On 10/14/2013 03:27 PM, Ian Romanick wrote: On 10/14/2013 03:25 PM, Ian Romanick wrote: I think this needs a bit more love in the CMakeLists. It can't find EGL/egl.h and friends when they're not installed in the default places. I sure wish cmake and pkgconfig were better friends. :(

[Piglit] [PATCH 0/4] cmake: Use pkg-config to find EGL

2013-10-16 Thread Chad Versace
Should fix Ian's build failure with egl-terminate-then-unbind-context.c. Windows doesn't have pkg-config. So, if Piglit ever wants to support the EGL tests on Windows, we will need to create a wrapper that calls into pkg_check_modules() or find_package() based on OS. Chad Versace (4): cmake

Re: [Piglit] [PATCH 03/10] piglit-util: add piglit_get_microseconds

2013-10-16 Thread Chad Versace
On 10/15/2013 04:33 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Cc: Chad Versace chad.vers...@linux.intel.com --- Chad, this conflicts with your Detect if system has POSIX clocks patch, but it could be tweaked to follow your version. I'm not opposed

Re: [Piglit] [PATCH] cmake: Detect if system has POSIX clocks

2013-10-16 Thread Chad Versace
On 10/16/2013 09:55 AM, Jordan Justen wrote: On Wed, Oct 16, 2013 at 9:24 AM, Ian Romanick i...@freedesktop.org wrote: On 10/14/2013 04:37 PM, Jordan Justen wrote: Chad, I wanted a similar feature, but I was also thinking of adding a piglit-util function (piglit_get_microseconds). I think it

Re: [Piglit] [PATCH 4/4] cmake: Use pkg-config to find EGL

2013-10-16 Thread Chad Versace
On 10/16/2013 03:38 PM, Ken Phillis Jr wrote: I think it may be a good idea to mirror this change for glesv1_cm and glesv2 I agree, and I plan on doing that next if this series gets accepted. ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH 2/2] piglit-util: add piglit_get_microseconds

2013-10-17 Thread Chad Versace
On 10/17/2013 02:22 PM, Jordan Justen wrote: On Thu, 2013-10-17 at 13:56 -0700, Chad Versace wrote: On 10/17/2013 10:52 AM, Jordan Justen wrote: v2: * Use Chad's cmake detection * return value is signed, and a negative indicates an error Signed-off-by: Jordan Justen jordan.l.jus

[Piglit] [PATCH] util/x11: Propagate window resize events to piglit_width/height

2013-10-18 Thread Chad Versace
this long for anyone to fix it. People must rarely resize Piglit windows). CC: Jordan Justen jordan.l.jus...@intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl/piglit_x11_framework.c | 19 +++ 1 file changed, 19 insertions(+) diff

Re: [Piglit] [PATCH] util/x11: Propagate window resize events to piglit_width/height

2013-10-18 Thread Chad Versace
On 10/18/2013 11:21 AM, Jordan Justen wrote: Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Fri, 2013-10-18 at 11:12 -0700, Chad Versace wrote: When I switched Piglit from GLUT to Waffle, I broke detection of X11 window resizes. When the user resized the window, Piglit called

Re: [Piglit] [PATCH 1/5] util: Move command-line parsing out of piglit_gl_test_config_init

2013-10-21 Thread Chad Versace
function that does this, tests can call it inside the BEGIN/END block. This may be useful for tests that expect certain arguments to be in specific positions. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Chad Versace chad.vers...@linux.intel.com --- tests/texturing/shaders

Re: [Piglit] [PATCH v3 2/5] util: Add common framework for command-line invoked subtests

2013-10-21 Thread Chad Versace
On 10/21/2013 11:29 AM, Paul Berry wrote: On 15 October 2013 17:32, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com @@ -43,6 +43,20 @@ enum piglit_gl_visual { }; /** + * An idividual subtest that makes up part of a test group. + */ +struct

Re: [Piglit] [PATCH 4/5] util: Add function to get the set of subtests selected from the command-line

2013-10-21 Thread Chad Versace
On 10/15/2013 05:32 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl.c | 7 +++ tests/util/piglit-framework-gl.h | 3 +++ 2 files

Re: [Piglit] [PATCH v3 5/5] arb_transform_feedback2: Misc. API error checks

2013-10-21 Thread Chad Versace
On 10/15/2013 05:32 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com This covers most of the errors mentioned in the spec that aren't already covered in cannot-bind-when-active.c and gen-names-only.c. Most of the other errors should be covered by existing

Re: [Piglit] [PATCH 0/8] Various Fixes on Cmake and opengl.

2013-10-22 Thread Chad Versace
install Piglit to test machines, so the improvements help me. Until now, I have used a custom installation script rather than relying on CMake, due to the bugs you found and solved. Now I can use the real 'install' rule and abandon my hacky script. Patches 1-4 6-8 are Reviewed-by: Chad Versace

Re: [Piglit] [PATCH 5/8] cmake: Increase minimum version from 2.6 to 2.8.

2013-10-22 Thread Chad Versace
On 10/02/2013 12:19 PM, Dylan Baker wrote: On Tuesday, October 01, 2013 10:42:39 PM Ken Phillis Jr wrote: That's all fine, however, system dependencies should always be the lowest usable version. if 2.4 would work then we should request 2.4. The availability of a new version is not

[Piglit] [PATCH] docmentation: Remove directory

2013-10-22 Thread Chad Versace
This directory contained two files: - GPL-2: A copy of the GPL-2 license. This file duplicates licenses/GPL-2. - build-results.sh: An ancient script superseded by Piglit's Python scripts. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- documentation/GPL-2

Re: [Piglit] [PATCH v4] GL3.2 GL_ARB_sync: Test for valid return values from ClientWaitSync

2013-10-28 Thread Chad Versace
On 10/21/2013 02:11 PM, Nicholas Mack wrote: v2: Fix comments, initialize variables. Still need to figure out if GPU commands needed before testing these. v3: Rewrite test cases, fix comment and config block and add to all.tests v4: Make test work with POSIX_CLOCKS and some other minor

Re: [Piglit] [PATCH] cl: Fix build on systems where clock_gettime is only avaiable in librt

2013-10-30 Thread Chad Versace
(piglit_cl_add_test) add_executable(${ARGV}) endfunction(piglit_cl_add_test) Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] depthstencil-render-miplevels for GL_TEXTURE_2D_ARRAY

2013-10-30 Thread Chad Versace
If you care about 2d-array depthbuffers, I've extended depthstencil-render-miplevels to handle that case. You can find it here: git://people.freedesktop.org/~chadversary/piglit.git branch=depthstencil-cruelty The branch isn't ready for publication yet. I wanted to inform people, though, in

Re: [Piglit] [PATCH] update the HACKING file's Coding style section

2013-11-01 Thread Chad Versace
On 11/01/2013 08:14 AM, Brian Paul wrote: I've tried to describe Piglit's coding style and conventions in more detail. Hopefully, new contributors will read this and it'll save some some time and effort for the reviewers. Please feel free to add/update this info. --- HACKING | 57

Re: [Piglit] [PATCH 1/7] glsl-1.10: Delete bogus generated test.

2013-11-07 Thread Chad Versace
Patches 1-3, 6-7 are Reviewed-by: Chad Versace chad.vers...@linux.intel.com Glad I wasn't the only one confused by the removal of glClear. By the way, I have some patches that do similar things for the python test generators. The patches make the tests run faster on simulation. I need to revive

[Piglit] [PATCH 1/3] util: Add piglit_split_string_to_array()

2013-11-26 Thread Chad Versace
This splits a string into an array of strings, which is useful for splitting the string returned by eglQueryString(EGL_EXTENSIONS). Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util-gl-common.c | 23 +-- tests/util/piglit-util.c

[Piglit] [PATCH 2/3] util: Move piglit_strip_arg()

2013-11-26 Thread Chad Versace
Move it from piglit-framework-gl.h to piglit-util.h. This is a generic utility that should not be restricted GL tests. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl.c | 18 -- tests/util/piglit-framework-gl.h | 1 - tests/util/piglit

Re: [Piglit] [PATCH 0/5] Support creation of debug and forward-compatible contexts

2013-12-02 Thread Chad Versace
On 11/27/2013 12:52 PM, Timothy Arceri wrote: On Mon, 2013-10-14 at 14:46 -0700, Chad Versace wrote: On 10/14/2013 09:21 AM, Ian Romanick wrote: On 10/13/2013 05:38 AM, Timothy Arceri wrote: Hi Chad, I successfully tested the patches for creating a debug-context with an Intel GPU but if I

Re: [Piglit] [PATCH 0/5] Support creation of debug and forward-compatible contexts

2013-12-06 Thread Chad Versace
On 11/27/2013 12:52 PM, Timothy Arceri wrote: On Mon, 2013-10-14 at 14:46 -0700, Chad Versace wrote: On 10/14/2013 09:21 AM, Ian Romanick wrote: On 10/13/2013 05:38 AM, Timothy Arceri wrote: Hi Chad, I successfully tested the patches for creating a debug-context with an Intel GPU but if I

[Piglit] [PATCH 2/8] util/waffle: Print more info when context creation fails

2013-12-19 Thread Chad Versace
When waffle_config_choose() or waffle_context_create() fails, print Waffle's error message to stderr. Several people (Carl, Ian, Timothy Arceri) have requested this. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl/piglit_wfl_framework.c | 7 --- 1

[Piglit] [PATCH 8/8] gl-3.0: Add test for the forward-compatible bit

2013-12-19 Thread Chad Versace
Create a context with or without the forward-compatible bit, according to a command line flag. Then verify that GL_CONTEXT_FLAGS does or does not contain GL_CONTEXT_FLAG_FORWARD_COMPATIBLE_BIT. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/all.tests

[Piglit] [PATCH 1/8] cmake: If using Waffle, require waffle = 1.3

2013-12-19 Thread Chad Versace
Subsequent patches will enable creation of forward-compatible and debug contexts, which arrived in waffle-1.3. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index

[Piglit] [PATCH 0/8 v2] Support creation of debug and forward-compatible contexts

2013-12-19 Thread Chad Versace
/~chadversary/piglit branch=fwd-compat-and-debug-contexts I found no regressions when running against mesa-10.0 on GLX with Ivybridge. Chad Versace (8): cmake: If using Waffle, require waffle = 1.3 util/waffle: Print more info when context creation fails util/wfl: Refactor

Re: [Piglit] [PATCH] fbo-generatemipmap-formats: Fix uninitialized variable warnings.

2013-12-26 Thread Chad Versace
Thanks, pushed. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] clipflat: Fix uninitialized variable warning.

2013-12-26 Thread Chad Versace
Thanks, pushed. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] fbo-depth: Fix uninitialized variable warning.

2013-12-26 Thread Chad Versace
Thanks, pushed. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] fbo-depthstencil: Fix uninitialized variable warning.

2013-12-26 Thread Chad Versace
Thanks, pushed. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

<    1   2   3   4   5   6   >