This uses mako to render tests. It's faster than the previous method,
and is much easier to understand.
v2: - set write mode to 'w' instead of 'w+'. w+ is a development
artifact and should have been set to 'w' before submission
Signed-off-by
This creates main() function and puts things in it. This is good python
style.
Signed-off-by: Dylan Baker
---
generated_tests/gen_const_builtin_equal_tests.py | 55 +---
1 file changed, 29 insertions(+), 26 deletions(-)
diff --git a/generated_tests
On Monday, May 19, 2014 20:50:17 Ilia Mirkin wrote:
> Series is
>
> Reviewed-by: Ilia Mirkin
>
> Thanks for bearing with my nitpicks :)
no problem, you're a much better programmer than I am, I
always learn something new and better for your nitpicks :)
[snip]
signature.asc
Description: This is
Patches 1-6 rename the directories used by generated tests to be
consistant with the names used by the static tests in the tests/ folder.
The difference is that in tests/ all extension names are lowered, but in
generated_tests/ they use mixed caps keeping consistancy with the spec
names.
Patch 7 c
This makes generated tests consistent with static tests
Signed-off-by: Dylan Baker
---
generated_tests/gen_builtin_packing_tests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generated_tests/gen_builtin_packing_tests.py
b/generated_tests/gen_builtin_packing_tests.py
This makes generated_tests/ consistent in naming with tests/
Signed-off-by: Dylan Baker
---
generated_tests/gen_builtin_uniform_tests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generated_tests/gen_builtin_uniform_tests.py
b/generated_tests
This makes generated_tests/ consistent in naming with tests/
Signed-off-by: Dylan Baker
---
generated_tests/gen_constant_array_size_tests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generated_tests/gen_constant_array_size_tests.py
b/generated_tests
This makes generated_tests/ consistent in naming with tests/
Signed-off-by: Dylan Baker
---
generated_tests/gen_shader_bit_encoding_tests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generated_tests/gen_shader_bit_encoding_tests.py
b/generated_tests
This makes generated_tests/ consistent in naming with tests/
Signed-off-by: Dylan Baker
---
generated_tests/gen_texture_lod_tests.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/generated_tests/gen_texture_lod_tests.py
b/generated_tests/gen_texture_lod_tests.py
This is a trivial change that renames generated tests from 01, 02, 03...
to names that express what is actually being tested. This information
was already available to the function generating the tests, it just
wasn't used.
Signed-off-by: Dylan Baker
---
generated_tests/gen_texture_lod_tes
This makes generated_tests/ consistent in naming with tests/
Signed-off-by: Dylan Baker
---
generated_tests/gen_texture_query_lod_tests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generated_tests/gen_texture_query_lod_tests.py
b/generated_tests
Adds shader_tests for +=, -=, *=, /=, %=, <<=, >>=, &=, ^=, and |=
This generates 816 new tests by extending gen_builtin_unform_tests.
Signed-off-by: Dylan Baker
---
generated_tests/builtin_function.py | 92 +++-
generated_tests/gen_constant_arr
-by: Dylan Baker
---
generated_tests/gen_texture_lod_tests.py | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/generated_tests/gen_texture_lod_tests.py
b/generated_tests/gen_texture_lod_tests.py
index f6bc086..6101341 100644
--- a/generated_tests
On Tuesday, May 27, 2014 12:29:08 Ilia Mirkin wrote:
> Hello,
>
> I'm seeing an issue where if I use "old" piglit results (I think
> something was done to the subtest logic), I see an explosion of
> results. I see
>
> ARB_texture_rg
> -> texwrap formats-int bordercolor-swizzled
> -> GL_R16I, s
gt;
> > -----Original Message-
> > From: Piglit [mailto:piglit-boun...@lists.freedesktop.org] On Behalf
Of Dylan
> > Baker
> > Sent: Thursday, May 22, 2014 5:10 AM
> > To: piglit@lists.freedesktop.org
> > Subject: [Piglit] [PATCH 7/7] gen_texture_lod_tests.py
On Tuesday, May 27, 2014 17:50:06 Ilia Mirkin wrote:
> On Tue, May 27, 2014 at 5:42 PM, Dylan Baker
wrote:
> > On Tuesday, May 27, 2014 12:29:08 Ilia Mirkin wrote:
> >
> >> Hello,
> >
> >>
> >
> >> I'm seeing an issue where if I use "
eedesktop.org/archives/piglit/2014-May/010898.html ? If
> > so, fairly sure it's entirely unrelated to this thread.
> >
> > -ilia
> >>
> >> Marek
> >>
> >> On Tue, Mar 18, 2014 at 9:34 PM, Dylan Baker
wrote:
> >>> Cool, I was mostl
On Thursday, May 29, 2014 13:15:54 Michel Dänzer wrote:
> On 29.05.2014 13:09, Matt Turner wrote:
> > On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin
wrote:
> >> Dylan, I'm sure you hate this, but it does seem to work for me. Not
sure
> >> where you are with your fix, but this is a tool that lots of
On Wednesday, May 28, 2014 22:17:55 Ilia Mirkin wrote:
> Old files have duplicated entries for each subtest, in addition to a
> filled subtest dictionary. Detect that the current test name is also a
> subtest and treat it as though it were a complete test. This may have
> false-negatives, but they'
This adds a class that wraps python functions to work around a bug in
nose. The bug has to do with the way nose test generators and python
instances interact, but the short is that all generated tests that raise
an error will get the description of the last test run, rather than
their own. This wor
On Sunday, June 01, 2014 03:03:21 PM Brian Paul wrote:
> Otherwise, the file path we're passing to programs such as shader_runner
> is in Unix style, which Windows programs don't understand.
> ---
> tests/all.py |5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/all.py b/tests
On Sunday, June 01, 2014 03:03:21 PM Brian Paul wrote:
> Otherwise, the file path we're passing to programs such as shader_runner
> is in Unix style, which Windows programs don't understand.
> ---
> tests/all.py |5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/all.py b/tests
On Sunday, June 01, 2014 03:03:22 PM Brian Paul wrote:
> Use os.path.join() to build up file paths instead of using string
> concatenation. In plain_test(), split up the arguments string
> using string.split() instead of shlex.split() because the later
> removes the '\' characters in Windows paths
dd(test)
> +self.tests['changes'].add(test)
> elif first < last:
> self.tests['regressions'].add(test)
> self.tests['changes'].add(test)
Reviewed-by: Dylan Baker
signature.asc
Description: This is
On Monday, June 02, 2014 08:22:27 AM Ilia Mirkin wrote:
> On Mon, Jun 2, 2014 at 7:17 AM, Dylan Baker wrote:
> > On Monday, June 02, 2014 12:46:59 PM Marek Olšák wrote:
> >> From: Marek Olšák
> >>
> >> ---
> >>
> >> framew
x27;-d', testsDir]) +
> testsDir = testsDir.replace('\n', '') # remove trailing newline
you could simplify this by calling subprocess.check_output().rstrip() instead
of replace().
without arguments rstrip() removes trailing whitespace
With that change:
Reviewed-by: Dylan Bake
T_BUILD_DIR',
> - path.join(testsDir, '..')),
> - 'generated_tests'))
> +os.environ.get('PIGLIT_BUILD_DIR', path.join(testsDir, '..')),
> +'generated_tests'))
>
> # Quick wrapper for PiglitTest for ou
27;/spec/arb_gpu_shader5', [''])
> @@ -3238,7 +3239,8 @@ add_plain_test(fast_color_clear,
> 'fcc-read-to-pbo-after-clear') asmparsertest = {}
> def add_asmparsertest(group, shader):
> asmparsertest[group + '/' + shader] = concurrent_test(
> -&
#x27;)[-1]
> if ext in ['vert', 'geo', 'frag']:
> - add_glsl_parser_test(glslparsertest, path.join(testsDir,
> 'glslparsertest/glsl2', filename), 'glsl2/' + filename) +
> add_glsl_parser_test(glslparsertest, os.path.join(testsDir,
> 'glslparsertest/glsl2', filename), 'glsl2/' + filename) # end group
> glslparsertest ---
>
> hiz = {}
Reviewed-by: Dylan Baker
signature.asc
Description: This is a digitally signed message part.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Tuesday, June 03, 2014 06:58:37 PM jfons...@vmware.com wrote:
> From: José Fonseca
>
> Windows doesn't support #!. Instead it knows how to invoke scripts
> based off the file extension.
> ---
> CMakeLists.txt | 7 ++-
> piglit | 4
> 2 files changed, 10 insertions(+), 1 dele
On Wednesday, June 04, 2014 02:09:14 AM Jose Fonseca wrote:
> - Original Message -
>
> > On Tuesday, June 03, 2014 06:58:37 PM jfons...@vmware.com wrote:
> > > From: José Fonseca
> > >
> > > Windows doesn't support #!. Instead it knows how to invoke scripts
> > > based off the file exte
On Thursday, June 05, 2014 12:50:26 PM Michel Dänzer wrote:
> On 25.04.2014 07:51, Marek Olšák wrote:
> > There are 3 categories of tests:
> > - concurrent, these are off-screen and can be run anytime
> > - non-concurrent, because they render to a window (usually a front
> > buffer) and may take fo
On Thursday, June 05, 2014 03:29:51 PM Ilia Mirkin wrote:
> On Thu, Jun 5, 2014 at 3:20 PM, wrote:
> > From: José Fonseca
> >
> > - Prevent the use of reserved characters in filenames (e.g., '>' and '<'
> >
> > which are used in several cases.)
> >
> > - Handle mixture of backward and forwa
igned-off-by: Dylan Baker
---
framework/results.py | 21 +
framework/tests/dmesg_tests.py | 5 ++---
2 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/framework/results.py b/framework/results.py
index c9831f7..bb92348 100644
--- a/framework/results.py
Use super() instead of an explicit call to the parent class in one case,
and make all classes descend from object (make them new-style classes)
Signed-off-by: Dylan Baker
---
framework/results.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/framework/results.py b
it forces version 1, and adds
support for updating versions
Patch 8 removes some work-arounds for these bugs that are present in the
summary code.
Dylan Baker (8):
framework: Split code out of framework.core
results.py: Replace JSONEncoder subclass with default method
results.py: Modernize s
This simplifies TestrunResult.write() to use a generator expression.
This method isn't currently used, but it will be useful in a patch later
in this series.
This also adds a testcase for this function to ensure that what it
writes is equivalent to what it reads.
Signed-off-by: Dylan
This splits results code out of core into its own module. This makes the
code cleaner and easier to understand, and is groundwork for coming
patches.
---
framework/core.py| 286 ---
framework/exectest.py| 3 +-
framework/programs/run.py
These are mostly from one of two sources:
1. overriding builtin names
2. pep8 compliance issues
A couple of the other errors:
- an unused keyword argument
- extra grouping parens
Signed-off-by: Dylan Baker
---
framework/results.py | 24 +++-
1 file changed, 11 insertions
of this update a one time cost.
Signed-off-by: Dylan Baker
---
framework/programs/run.py| 4 +-
framework/results.py | 126 ---
framework/tests/results_tests.py | 158 +--
framework/tests/utils.py | 2 +
These work-arounds are no longer necissary since they are handled by the
result format updater on load.
---
framework/summary.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index d5cfb71..4ef9765 100644
--- a/framework/summary.py
+++ b/framewor
This moves all of the code for writing the name, the options, etc out of
run and resume and into a single method of JSONWriter. This should
reduce errors, code duplication, and help abstract a lot of problems
with future changes to the json away.
Signed-off-by: Dylan Baker
---
framework
On Thursday, June 05, 2014 06:45:52 PM Ilia Mirkin wrote:
> On Thu, Jun 5, 2014 at 6:26 PM, Dylan Baker wrote:
> > This patch updates our json to version 1. Changes from version 0 to
> > version 1 are as follows:
> >
> > - renamed 'main' to 'results.
of this update a one time cost.
v2: - Handle non-writable directories and files, this also fixes using
file-descriptors as inputs
Signed-off-by: Dylan Baker
---
framework/programs/run.py| 4 +-
framework/results.py | 131 +---
framework/te
Cool.
On Friday, June 06, 2014 03:36:27 AM Jose Fonseca wrote:
> Thanks for reviewing. I've applied all your suggestions, re-tested and took
> the liberty of pushing.
>
> Jose
>
> - Original Message -
>
> > On Thursday, June 05, 2014 03:29:51 PM Ilia Mirkin wrote:
> > > On Thu, Jun 5, 2
Ilia, I've tested this with your use case, does seem reasonable?
On Thursday, June 05, 2014 04:33:00 PM Dylan Baker wrote:
> This patch updates our json to version 1. Changes from version 0 to
> version 1 are as follows:
>
> - renamed 'main' to 'results.json
On Friday, June 06, 2014 04:57:28 PM Ilia Mirkin wrote:
> On Fri, Jun 6, 2014 at 4:54 PM, Dylan Baker wrote:
> > Ilia, I've tested this with your use case, does seem reasonable?
>
> The general idea seems reasonable, but I haven't had a chance to
> actually review
On Sunday, June 08, 2014 12:12:17 PM Ilia Mirkin wrote:
> On Fri, Jun 6, 2014 at 5:02 PM, Dylan Baker wrote:
> > On Friday, June 06, 2014 04:57:28 PM Ilia Mirkin wrote:
> >> On Fri, Jun 6, 2014 at 4:54 PM, Dylan Baker
wrote:
> >> > Ilia, I've tested this with
On Sunday, June 08, 2014 12:54:09 PM Ilia Mirkin wrote:
> On Sun, Jun 8, 2014 at 12:12 PM, Ilia Mirkin wrote:
> > On Fri, Jun 6, 2014 at 5:02 PM, Dylan Baker
wrote:
> >> On Friday, June 06, 2014 04:57:28 PM Ilia Mirkin wrote:
> >>> On Fri, Jun 6, 2014 a
Do you have s3tc installed?
On Tuesday, June 10, 2014 08:42:26 AM Tapani Pälli wrote:
> On 06/09/2014 05:44 PM, Ilia Mirkin wrote:
> > On Mon, Jun 9, 2014 at 5:58 AM, Tapani Pälli
wrote:
> >> Hi;
> >>
> >> I'm running Piglit tests on SNB machine and many of the tests crash like
> >> this:
> >>
this patch is:
Reviewed-by: Dylan Baker
signature.asc
Description: This is a digitally signed message part.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Tuesday, June 10, 2014 08:16:04 PM jfons...@vmware.com wrote:
> From: José Fonseca
>
> Just like piglit_report_result(PIGLIT_SKIP) does.
>
> Otherwise these tests are considered failures or -- with my commit
> 058e0f8a1e536b68ef43d27ada80645845a39e19 -- crashes.
> ---
> framework/exectest.py
I don't think so, It's a pretty common reason to not get a 3.x+ context
though.
On Wednesday, June 11, 2014 10:48:18 AM Tapani wrote:
> On 06/10/2014 04:55 PM, Dylan Baker wrote:
> > Do you have s3tc installed?
>
> Yes I believe I have. Does this have some effec
This test won't actually get run unless its added to tests/all.py
You probably also should put a license header in the source file. MIT is the
usual license.
On Wednesday, June 11, 2014 11:57:24 AM Iago Toral Quiroga wrote:
> This tests correct rendering of polygons using antialised GL_LINE mode
_run_command returns, if
self.results['result'] has been set to skip then Test.run() returns
immediately.
Signed-off-by: Dylan Baker
Jose, here's a different aproach to the problem, and I think this one is
better because it is more consistent with the way the python framework
handles skip
On Wednesday, June 11, 2014 01:03:20 PM Iago Toral Quiroga wrote:
> This tests correct rendering of polygons using antialised GL_LINE mode for
> one face and GL_FILL for the other one. On some Intel hardware at least
> this used to require special handling that has caused regressions in the
> past.
On Wednesday, June 11, 2014 03:31:26 AM Dylan Baker wrote:
> If the except block is hit in Test._run_command(), the test has a status
> of skip, but the test continues to run anyway. This is not consistent
> with the way Test.check_for_skip_scenario() works, and means more time
>
This series replaces the use of eval() in
exectest.PiglitTest.interpret_restul() with json.loads(). This has a
couple of advantages. First, eval compiles code on the fly, and is known
to be slow. It's better not to use eval whenever possible for that
reason alone. But the more serious problem is th
@g'
It was then hand edited to fix whitespace errors introduced by tabs not
being 8 spaces.
Signed-off-by: Dylan Baker
---
framework/programs/run.py| 2 +-
generated_tests/gen_constant_array_size_tests.py | 2 +-
tests/all.py
, and case 3 if piglit is
installed as piglit.py.
Signed-off-by: Dylan Baker
---
piglit | 45 +
1 file changed, 33 insertions(+), 12 deletions(-)
diff --git a/piglit b/piglit
index bf53876..ea73268 100755
--- a/piglit
+++ b/piglit
@@ -36,18 +36,39
Patch 2 seems to have been held up in the list, and I have many comments about
patch 2, I do have a few about this one as well.
On Friday, June 13, 2014 07:44:34 AM Chad Versace wrote:
> This patch removes the files piglit-util-gl*-enum.c and instead replaces
> them with a single piglit-util-gl-e
Is there an obvious way for us to tell when our version of gl.xml has drifted
out of date with the upstream khronos version?
On Friday, June 13, 2014 07:44:32 AM Chad Versace wrote:
> Import revision 26792 on 2014-05-22 from
> (https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/g
This is groundwork to do away with import ... from
Signed-off-by: Dylan Baker
---
framework/tests/dmesg_tests.py | 46 +-
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/framework/tests/dmesg_tests.py b/framework/tests/dmesg_tests.py
index
These are all formatting warnings, so there is zero functional change in
this patch.
Signed-off-by: Dylan Baker
---
framework/tests/dmesg_tests.py | 42 ++
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/framework/tests/dmesg_tests.py b
Signed-off-by: Dylan Baker
---
framework/tests/log_tests.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/framework/tests/log_tests.py b/framework/tests/log_tests.py
index e53b95b..d2cb336 100644
--- a/framework/tests/log_tests.py
+++ b/framework/tests
Signed-off-by: Dylan Baker
---
framework/tests/test_lists.py | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/framework/tests/test_lists.py b/framework/tests/test_lists.py
index fe5ec13..5343b44 100644
--- a/framework/tests/test_lists.py
+++ b/framework/tests
Signed-off-by: Dylan Baker
---
framework/tests/dmesg_tests.py | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/framework/tests/dmesg_tests.py b/framework/tests/dmesg_tests.py
index ced3d9a..166f98f 100644
--- a/framework/tests/dmesg_tests.py
+++ b/framework/tests
Signed-off-by: Dylan Baker
---
framework/tests/dmesg_tests.py | 45 ++
1 file changed, 24 insertions(+), 21 deletions(-)
diff --git a/framework/tests/dmesg_tests.py b/framework/tests/dmesg_tests.py
index 38d158b..ced3d9a 100644
--- a/framework/tests
This series is a collection of work I've done to make the piglit
framework testing better over the last few weeks, and I want to get some
of it landed before this turns into 50 patches in one giant series.
Patch 1 has already been permanently deleted by the time you're reading
this, it's meant to
Signed-off-by: Dylan Baker
---
framework/tests/dmesg_tests.py | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/framework/tests/dmesg_tests.py b/framework/tests/dmesg_tests.py
index ccc3144..4e6ce7d 100644
--- a/framework/tests
This drops some unused variable assignments, and refactors a test that
uses a test for providing data.
---
framework/tests/dmesg_tests.py | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/framework/tests/dmesg_tests.py b/framework/tests/dmesg_tests.py
index 4e
break Environment for testing purposes
This is a proof of concept patch for the wrapper object in
framework/tests/utils.py, not meant to be committed to upstream
To demonstrate check out this patch and run:
nosetests framework/tests/core_tests.py
what you'll see is something like:
'Test that Pig
Signed-off-by: Dylan Baker
---
framework/tests/status_tests.py | 45 +++--
1 file changed, 21 insertions(+), 24 deletions(-)
diff --git a/framework/tests/status_tests.py b/framework/tests/status_tests.py
index 599225f..f4ae74a 100644
--- a/framework/tests
Signed-off-by: Dylan Baker
---
framework/tests/core_tests.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/framework/tests/core_tests.py b/framework/tests/core_tests.py
index 44462ce..a6ac803 100644
--- a/framework/tests/core_tests.py
+++ b/framework/tests/core_tests.py
@@ -38,6 +38,7
This gives more fine-grained results
---
framework/tests/status_tests.py | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/framework/tests/status_tests.py b/framework/tests/status_tests.py
index f4ae74a..a053de5 100644
--- a/framework/tests/status_te
Signed-off-by: Dylan Baker
---
framework/tests/summary_tests.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/framework/tests/summary_tests.py b/framework/tests/summary_tests.py
index 8961e1a..61cfbfe 100644
--- a/framework/tests/summary_tests.py
+++ b/framework/tests/summary_tests.py
This makes it very easy to exclude only the tests that use sudo, so
running "nostests framework/tests -e sudo" will run all tests except
the ones that need privileged support.
Signed-off-by: Dylan Baker
---
framework/tests/dmesg_tests.py | 3 ++-
framework/tests/utils.py
This makes things nicer
Signed-off-by: Dylan Baker
---
framework/tests/dmesg_tests.py | 51 +-
1 file changed, 26 insertions(+), 25 deletions(-)
diff --git a/framework/tests/dmesg_tests.py b/framework/tests/dmesg_tests.py
index 364d633..a3ad28e 100644
- replace oldstyle class with newstyle class
- add self to arguments for DummyLog methods
Signed-off-by: Dylan Baker
---
framework/tests/dmesg_tests.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/framework/tests/dmesg_tests.py b/framework/tests/dmesg_tests.py
d line per generator.
Signed-off-by: Dylan Baker
---
framework/tests/utils.py | 58
1 file changed, 58 insertions(+)
diff --git a/framework/tests/utils.py b/framework/tests/utils.py
index f337b1e..e4a6cd4 100644
--- a/framework/tests/utils.py
+++ b/frame
magic methods, because they are designed to be used by
helper functions).
Signed-off-by: Dylan Baker
---
framework/tests/status_tests.py | 122
1 file changed, 122 insertions(+)
diff --git a/framework/tests/status_tests.py b/framework/tests/status_tests.py
that a large number of tests that
previously needed sudo no longer need sudo.
With this patch nose reports our coverage at 92%, and the remaining 8%
isn't relevant for testing.
Signed-off-by: Dylan Baker
---
framework/tests/dmesg_tests.py | 63 --
tween update_dmesg() and update_result(), which makes it
easier to test update_result() without needing privileged access (or
even a posix machine).
Signed-off-by: Dylan Baker
---
framework/dmesg.py | 116 +++--
1 file changed, 86 insertions(+
or: 'Tuple' object has no attribute 'id'
>
> I bisected this to the following commit:
>
> commit 6755d9195bc05bbee2445eeac6af6b0e0ecf5160
> Author: Thomas Wood
> Date: Wed Jun 4 11:07:30 2014 +0100
>
> templates: add the totals to
This replaces #!/usr/bin/env python with #!/usr/bin/env python2, which
fixes the build on archlinux. This has been proposed before, but at that
time debian didn't provide a python2 executable, so it would break
debian. Debian sid as of today provides python2.
Signed-off-by: Dylan
On Monday, June 16, 2014 05:50:03 PM Ilia Mirkin wrote:
> What about piglit (the command)?
>
> On Mon, Jun 16, 2014 at 5:41 PM, Dylan Baker
wrote:
> > This replaces #!/usr/bin/env python with #!/usr/bin/env python2, which
> > fixes the build on archlinux. This has been pr
d-off-by: Dylan Baker
---
generate-glean-tests.py | 2 +-
piglit | 2 +-
piglit-merge-results.py | 2 +-
piglit-print-commands.py | 2 +-
piglit-resume.py | 2 +-
piglit-run.py| 2 +-
piglit-summary-html.py | 2 +-
piglit-summary-junit.py | 2 +-
p
at 5:54 PM, Dylan Baker
wrote:
> > This replaces #!/usr/bin/env python with #!/usr/bin/env python2, which
> > fixes the build on archlinux. This has been proposed before, but at that
> > time debian didn't provide a python2 executable, so it would break
> > debian. De
Test generators are not called using the ./ syntax, so no need have the
executable bit set.
Signed-off-by: Dylan Baker
---
generated_tests/gen_texture_query_lod_tests.py | 0
generated_tests/generate-cl-int-builtins.py| 0
2 files changed, 0 insertions(+), 0 deletions(-)
mode change 100755
Nothing in framework/ or generated_tests/ is called directly using the
./syntax, instead it is called from cmake using python explicitly. With
that in mind none of them need a she-bang
Signed-off-by: Dylan Baker
---
framework/gtest.py | 2 --
framework/opencv.py
On Tuesday, June 17, 2014 11:26:11 AM Thomas Wood wrote:
> On 17 June 2014 00:51, Ian Romanick wrote:
> > On 06/16/2014 02:19 PM, Dylan Baker wrote:
> >> On Monday, June 16, 2014 12:32:35 PM Ian Romanick wrote:
> >>> When I run piglit-summary-html.py, it cr
Previously spec['glsl-3.30'] was initialized to {} twice, meaning all
tests added before the second assignment were discarded.
Signed-off-by: Dylan Baker
---
tests/all.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/all.py b/tests/all.py
index 2c592f
This is a pretty trivial bugfix, I'm gonna push it at the end of the day if no
one objects before then
On Tuesday, June 17, 2014 08:45:49 AM Dylan Baker wrote:
> Previously spec['glsl-3.30'] was initialized to {} twice, meaning all
> tests added before the second assi
Thanks for doing this Thomas.
There is only one more thing you might want to take care of, and that's
comparisons to None. Python style is to use 'is' and 'is not' instead of '=='
and '!=' when comparing None.
But whether you do that or not this pat
bump
On Saturday, June 14, 2014 08:05:09 AM Dylan Baker wrote:
> This series is a collection of work I've done to make the piglit
> framework testing better over the last few weeks, and I want to get some
> of it landed before this turns into 50 patches in one giant series.
>
bump
On Wednesday, June 11, 2014 04:32:30 PM Dylan Baker wrote:
> This series replaces the use of eval() in
> exectest.PiglitTest.interpret_restul() with json.loads(). This has a
> couple of advantages. First, eval compiles code on the fly, and is known
> to be slow. It's bette
This reverts commit 40b5d5288991fec2cc76ea4af7050555be467126.
The patch to be reverted breaks users of *BSD, solaris, and OSX which
don't provide a python2 symlink, making it a regression.
The patch however, fixes python for arch users whos python executable
incorrectly is python3. This is a bug
form. This implementation doesn't assume
that, instead it makes a blind leap that the tools is available, and
then is caught if its wrong.
Signed-off-by: Dylan Baker
---
framework/core.py | 49 ++-
framework/programs/run.py | 4 ++--
2 files changed
Use super() instead of an explicit call to the parent class in one case,
and make all classes descend from object (make them new-style classes)
Signed-off-by: Dylan Baker
---
framework/results.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/framework/results.py b
This splits results code out of core into its own module. This makes the
code cleaner and easier to understand, and is groundwork for coming
patches.
Signed-off-by: Dylan Baker
---
framework/core.py| 286 ---
framework/exectest.py| 3
701 - 800 of 3756 matches
Mail list logo
