Re: [Piglit] [PATCH] egl-util: remove GL include

2014-08-18 Thread Daniel Kurtz
On Mon, Aug 18, 2014 at 5:43 PM, Ken Phillis Jr kphilli...@gmail.com wrote: I think a ifdef is needed since egl can create opengl contexts. EGL can create an OpenGL context using an EGLConfig that has EGL_RENDERABLE_TYPE with EGL_OPENGL_BIT. It does so by first binding to the OpenGL API,

Re: [Piglit] Support for waffle WGL and related cleanups

2014-08-18 Thread Emil Velikov
On 13/08/14 14:08, Brian Paul wrote: On 08/12/2014 11:18 AM, Emil Velikov wrote: Hello list, The series adds a piglit_wgl_framework based on my Add WGL support to waffle GSoC this summer. A sizeable chunk of the waffle code is not yet upstream, although I would expect that to change soon :P

Re: [Piglit] [PATCH 05/12] cmake: cleanup PIGLIT_USE_WAFFLE builds

2014-08-18 Thread Jose Fonseca
On 12/08/14 18:18, Emil Velikov wrote: [...] - Use WAFFLE_LIBRARIES over WAFFLE_LDFLAGS for linking purposes. [...] Emil, This particular change is causing the build to fail when libwaffle-1.so is not on a standard library directory (ie., outside /usr/lib or /usr/local/lib). This

Re: [Piglit] [PATCH 05/12] cmake: cleanup PIGLIT_USE_WAFFLE builds

2014-08-18 Thread Emil Velikov
On 18/08/14 15:22, Jose Fonseca wrote: On 12/08/14 18:18, Emil Velikov wrote: [...] - Use WAFFLE_LIBRARIES over WAFFLE_LDFLAGS for linking purposes. [...] Emil, This particular change is causing the build to fail when libwaffle-1.so is not on a standard library directory (ie., outside

Re: [Piglit] [PATCH 05/12] cmake: cleanup PIGLIT_USE_WAFFLE builds

2014-08-18 Thread Jose Fonseca
On 18/08/14 15:51, Emil Velikov wrote: On 18/08/14 15:22, Jose Fonseca wrote: On 12/08/14 18:18, Emil Velikov wrote: [...] - Use WAFFLE_LIBRARIES over WAFFLE_LDFLAGS for linking purposes. [...] Emil, This particular change is causing the build to fail when libwaffle-1.so is not on a

[Piglit] [RFC] ARB_shader_precision tests

2014-08-18 Thread Micah Fedke
Hi all, I'm working on adding ARB_shader_precision tests to piglit. My primary goal is ensure that the intel driver supports this GL 4.x feature correctly, but the tests really ought to work for all mesa drivers, where possible. The GL_ARB_shader_precision spec has a list of rather innocent

[Piglit] [PATCH 1/3] core: Initialize ConfigParser with allow_no_value=True

2014-08-18 Thread Tom Stellard
--- framework/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/core.py b/framework/core.py index d3922a9..950ed7e 100644 --- a/framework/core.py +++ b/framework/core.py @@ -37,7 +37,7 @@ __all__ = ['PIGLIT_CONFIG', 'parse_listfile']

[Piglit] [PATCH 2/3] oclconform: Add test class for ocl conformance tests

2014-08-18 Thread Tom Stellard
--- framework/oclconform.py | 91 + piglit.conf.example | 34 ++ 2 files changed, 125 insertions(+) create mode 100644 framework/oclconform.py diff --git a/framework/oclconform.py b/framework/oclconform.py new file mode 100644

[Piglit] [PATCH 3/3] all_cl: Add ocl conformance tests to test list

2014-08-18 Thread Tom Stellard
--- tests/all_cl.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/all_cl.py b/tests/all_cl.py index b62b6c1..45de569 100644 --- a/tests/all_cl.py +++ b/tests/all_cl.py @@ -25,6 +25,8 @@ # from tests.cl import profile +from framework.oclconform import add_oclconform_tests from

[Piglit] [PATCH] cmake: WAFFLE_LIBRARIES - WAFFLE_LDFLAGS

2014-08-18 Thread jfonseca
From: José Fonseca jfons...@vmware.com Otherwise the build fails when libwaffle-1.so is not on a standard library directory (ie., outside /usr/lib or /usr/local/lib). --- tests/util/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/CMakeLists.txt

Re: [Piglit] [PATCH] egl-util: remove GL include

2014-08-18 Thread Kristian Høgsberg
On Sun, Aug 17, 2014 at 5:32 PM, Daniel Kurtz djku...@chromium.org wrote: On Aug 18, 2014 3:49 AM, Kristian Høgsberg k...@bitplanet.net wrote: On Sun, Aug 17, 2014 at 7:19 AM, Ken Phillis Jr kphilli...@gmail.com wrote: This patch looks good to me. On Aug 17, 2014 7:39 AM, Daniel Kurtz

Re: [Piglit] [PATCH] egl-util: remove GL include

2014-08-18 Thread Chad Versace
On 08/18/2014 11:15 AM, Kristian Høgsberg wrote: On Sun, Aug 17, 2014 at 5:32 PM, Daniel Kurtz djku...@chromium.org wrote: On Aug 18, 2014 3:49 AM, Kristian Høgsberg k...@bitplanet.net wrote: It certainly shouldn't be in the header, but egl-util.c needs it and breaks if you remove it.

Re: [Piglit] [PATCH 2/3] oclconform: Add test class for ocl conformance tests

2014-08-18 Thread Dylan Baker
On Monday, August 18, 2014 10:44:41 AM Tom Stellard wrote: --- framework/oclconform.py | 91 + piglit.conf.example | 34 ++ 2 files changed, 125 insertions(+) create mode 100644 framework/oclconform.py diff --git

Re: [Piglit] [PATCH 1/3] core: Initialize ConfigParser with allow_no_value=True

2014-08-18 Thread Dylan Baker
On Monday, August 18, 2014 10:44:40 AM Tom Stellard wrote: --- framework/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/core.py b/framework/core.py index d3922a9..950ed7e 100644 --- a/framework/core.py +++ b/framework/core.py @@ -37,7 +37,7 @@

Re: [Piglit] [PATCH] egl_khr_fence_sync: check for EGL_KHR_reusable_sync

2014-08-18 Thread Chad Versace
On 08/13/2014 07:13 PM, Daniel Kurtz wrote: On Thu, Aug 14, 2014 at 6:41 AM, Chad Versace chad.vers...@linux.intel.com mailto:chad.vers...@linux.intel.com wrote: On 08/07/2014 04:09 AM, Daniel Kurtz wrote: These tests all require EGL_KHR_reusable_sync. No they don't,

Re: [Piglit] [PATCH] Add tests arb_conditional_render_inverted

2014-08-18 Thread Ilia Mirkin
Mostly looks good. Some of the comments could use a bit of work. There's no such thing as inverted conditional rendering. It's just conditional rendering -- the conditions themselves happen to be inverted though. I made a few suggestions inline: On Sun, Aug 17, 2014 at 3:11 PM, Tobias Klausmann

Re: [Piglit] [PATCH] egl_khr_fence_sync: check for EGL_KHR_reusable_sync

2014-08-18 Thread Daniel Kurtz
On Tue, Aug 19, 2014 at 7:05 AM, Chad Versace chad.vers...@linux.intel.com wrote: On 08/13/2014 07:13 PM, Daniel Kurtz wrote: On Thu, Aug 14, 2014 at 6:41 AM, Chad Versace chad.vers...@linux.intel.com mailto:chad.vers...@linux.intel.com wrote: On 08/07/2014 04:09 AM, Daniel Kurtz