Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 2 November 2016 at 15:23, Martín Ferrari wrote: > On 02/11/16 01:26, Martín Ferrari wrote: > > On 02/11/16 00:05, Martín Ferrari wrote: > >> On 01/11/16 21:44, Michael Hudson-Doyle wrote: > >> > >>> Go 1.6 did that too, but the special behaviour here was removed for > 1.7. > >>> gccgo-6 still has a version of the go tool based on 1.6 though, so > >>> (unfortunately) the GOROOT hack that > >>> 3852c129b5154b63e2b86ba5db13390096ba calls "uneeded" is, in fact, > >>> needed for a little longer. > > Well, after a few tries, I am not being able to make this work again. > Did this ever work for gccgo? > Hm, possibly not, I don't think it ever built on powerpc on Ubuntu. Cheers, mwh ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 02/11/16 01:26, Martín Ferrari wrote: > On 02/11/16 00:05, Martín Ferrari wrote: >> On 01/11/16 21:44, Michael Hudson-Doyle wrote: >> >>> Go 1.6 did that too, but the special behaviour here was removed for 1.7. >>> gccgo-6 still has a version of the go tool based on 1.6 though, so >>> (unfortunately) the GOROOT hack that >>> 3852c129b5154b63e2b86ba5db13390096ba calls "uneeded" is, in fact, >>> needed for a little longer. Well, after a few tries, I am not being able to make this work again. Did this ever work for gccgo? First, the symlinking to /usr/lib/go does not work, as that directory does not exist when using gccgo. But even if I avoid compiling godoc altogether, I get tons of other errors when running the tests, about core libraries not being found: /home/tincho/golang-golang-x-tools-0.0~git20161028.0.b814a3b+ds/obj-mipsel-linux-gnu/src/golang.org/x/tools/go/types/typeutil/imports.go:9:8: could not import go/types (cannot find package "go/types" in any of: /usr/src/go/types (from $GOROOT) Does anybody understand this? -- Martín Ferrari (Tincho) ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 02/11/16 00:05, Martín Ferrari wrote: > On 01/11/16 21:44, Michael Hudson-Doyle wrote: > >> Go 1.6 did that too, but the special behaviour here was removed for 1.7. >> gccgo-6 still has a version of the go tool based on 1.6 though, so >> (unfortunately) the GOROOT hack that >> 3852c129b5154b63e2b86ba5db13390096ba calls "uneeded" is, in fact, >> needed for a little longer. > > Indeed, I remembered seeing that change. That's what I was referring to > in my previous email. Hah, I had forgotten it was me who removed that :-b -- Martín Ferrari (Tincho) ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 01/11/16 21:44, Michael Hudson-Doyle wrote: > Go 1.6 did that too, but the special behaviour here was removed for 1.7. > gccgo-6 still has a version of the go tool based on 1.6 though, so > (unfortunately) the GOROOT hack that > 3852c129b5154b63e2b86ba5db13390096ba calls "uneeded" is, in fact, > needed for a little longer. Indeed, I remembered seeing that change. That's what I was referring to in my previous email. -- Martín Ferrari (Tincho) ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 2 November 2016 at 09:31, Tianon Gravi wrote: > On 1 November 2016 at 11:28, Martín Ferrari wrote: > > Now it is failing to build on gccgo arches [0], possibly due to some > > tool still hardcoding the location for godoc. It would be great if > > somebody can take a look, I have already spent way too much time on this > > this week :) > > Here's the relevant build log snippet: > > | go install -v -p 1 golang.org/x/tools/benchmark/parse ... > golang.org/x/tools/refactor/satisfy > | ... > | golang.org/x/tools/cmd/godoc > | go install golang.org/x/tools/cmd/godoc: open /usr/bin/godoc: > permission denied > | golang.org/x/tools/imports > | ... > > So it appears that gccgo's "go install" is trying to "install" godoc > into "/usr/bin" instead of "$GOPATH/bin" for some reason. :/ > Go 1.6 did that too, but the special behaviour here was removed for 1.7. gccgo-6 still has a version of the go tool based on 1.6 though, so (unfortunately) the GOROOT hack that 3852c129b5154b63e2b86ba5db13390096ba calls "uneeded" is, in fact, needed for a little longer. Cheers, mwh ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 1 November 2016 at 11:28, Martín Ferrari wrote: > Now it is failing to build on gccgo arches [0], possibly due to some > tool still hardcoding the location for godoc. It would be great if > somebody can take a look, I have already spent way too much time on this > this week :) Here's the relevant build log snippet: | go install -v -p 1 golang.org/x/tools/benchmark/parse ... golang.org/x/tools/refactor/satisfy | ... | golang.org/x/tools/cmd/godoc | go install golang.org/x/tools/cmd/godoc: open /usr/bin/godoc: permission denied | golang.org/x/tools/imports | ... So it appears that gccgo's "go install" is trying to "install" godoc into "/usr/bin" instead of "$GOPATH/bin" for some reason. :/ ♥, - Tianon 4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4 ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 31/10/16 21:45, Potter, Tim (HPE Linux Support) wrote: > Great - thanks Martin! I think that's probably what I should have done in the > first place instead of trying to get everything working. (-: Oh well, it is hard to get this mess right :) Now it is failing to build on gccgo arches [0], possibly due to some tool still hardcoding the location for godoc. It would be great if somebody can take a look, I have already spent way too much time on this this week :) [0] https://buildd.debian.org/status/package.php?p=golang-golang-x-tools -- Martín Ferrari (Tincho) ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 1 Nov 2016, at 8:31 AM, Martín Ferrari wrote: > > On 31/10/16 14:20, Martín Ferrari wrote: >> Unless somebody thinks it is a bad idea, I will split x-tools into more >> packages, at least to keep the web crap away from the important stuff. >> >> I am undecided if I should also split the source package, to maximise >> isolation. Thoughts? > > In the end, I did a big clean-up. I realised that by dropping > cmd/heapview, I could solve the most pressing problems now. So I have > just done that: heapview is not included in x-tools any more, after this > migrates to testing, we can reintroduce it in a separate binary package. > > I also repackaged the source to completely remove third party js code, > and static.go blobs. I patched godoc to use on-disk files instead. > > Also, solved the inconsistencies where godoc and others were using files > that belonged to the -dev package. > > Hopefully, in 5 more days this will migrate. Great - thanks Martin! I think that's probably what I should have done in the first place instead of trying to get everything working. (-: Tim. signature.asc Description: Message signed with OpenPGP using GPGMail ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 31/10/16 14:20, Martín Ferrari wrote: > Unless somebody thinks it is a bad idea, I will split x-tools into more > packages, at least to keep the web crap away from the important stuff. > > I am undecided if I should also split the source package, to maximise > isolation. Thoughts? In the end, I did a big clean-up. I realised that by dropping cmd/heapview, I could solve the most pressing problems now. So I have just done that: heapview is not included in x-tools any more, after this migrates to testing, we can reintroduce it in a separate binary package. I also repackaged the source to completely remove third party js code, and static.go blobs. I patched godoc to use on-disk files instead. Also, solved the inconsistencies where godoc and others were using files that belonged to the -dev package. Hopefully, in 5 more days this will migrate. -- Martín Ferrari (Tincho) ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
Unless somebody thinks it is a bad idea, I will split x-tools into more packages, at least to keep the web crap away from the important stuff. I am undecided if I should also split the source package, to maximise isolation. Thoughts? -- Martín Ferrari (Tincho) ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 31/10/16 11:14, Martín Ferrari wrote: > I was asking the same question on #-release just now.. I thought this > was because of the cyclic dependency with google-cloud, but the latter > finally migrated 2 days ago. I don't know what's going on with x-tools... Adam shone some light on this: [11:22:30] it's failing due to installability problems on armel [11:24:44] because it depends on node-typescript, which depends on nodejs, which doesn't exist on armel [11:25:11] fwiw [11:25:13] (zcat /srv/mirrors/debian/dists/unstable/main/binary-armel/Packages.gz | grep-dctrl -S golang-golang-x-tools; zcat /srv/mirrors/debian/dists/testing/main/binary-armel/Packages.gz | grep-dctrl -v -S golang-golang-x-tools) | dose-debcheck --explain --failures --checkonly golang-golang-x-tools [11:25:22] replace paths as appropriate -- Martín Ferrari (Tincho) ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
Re: [pkg-go] golang-golang-x-tools not migrating to testing, why?
On 31/10/16 00:34, Potter, Tim (HPE Linux Support) wrote: > Does anyone have any idea why the golang-golang-x-tools package is not > migrating to testing? > > If this doesn't happen many other packages will fall out as well which is > going to be annoying. > > According to the QA page, the package is a valid candidate for migration by > britney, but I > can't see any reason why this hasn't happened, or has failed to happened. I was asking the same question on #-release just now.. I thought this was because of the cyclic dependency with google-cloud, but the latter finally migrated 2 days ago. I don't know what's going on with x-tools... -- Martín Ferrari (Tincho) ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
