Re: Bug#703376: javahelper: Remove Maven support from jh_makepkg
On Tue Apr 09 18:00, Thomas Koch wrote: Niels Thykier: I am planning on a rewrite of jh_makepkg and have therefore not applied your patch as-is. I wasn't aware (forgot) about jh_makepkg and just had a look at it. I don't think we should have 2 dh-make-* style programs in the java team: jh_makepkg and mh_make. It's already enough logic duplication between dh-make, dh-make- perl, dh-make-php, dh-make-drupal, gem2deb, python-stdeb, haskell-devscripts, Well, mh_make just does maven packages, whereas jh_makepkg (was intended) to cover all the common options. Perhaps they should be merged, but that's up to the mh folks. Only having mh_make would be sad, I think. Matt signature.asc Description: Digital signature __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Re: Bug#703376: javahelper: Remove Maven support from jh_makepkg
Niels Thykier: I am planning on a rewrite of jh_makepkg and have therefore not applied your patch as-is. I wasn't aware (forgot) about jh_makepkg and just had a look at it. I don't think we should have 2 dh-make-* style programs in the java team: jh_makepkg and mh_make. It's already enough logic duplication between dh-make, dh-make- perl, dh-make-php, dh-make-drupal, gem2deb, python-stdeb, haskell-devscripts, ... We might be the only language team that does not use its own programming language for this kind of tool. While I'm more fluent in Python, it might be better to converge on Perl as much of javahelper is already written in Perl. Niels: What are your plans for the jh_makepkg rewrite? Regards, Thomas Koch, http://www.koch.ro __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Bug#703376: javahelper: Remove Maven support from jh_makepkg
Control: tags -1 confirmed On 2013-03-18 23:04, Hilko Bengen wrote: Package: javahelper Version: 0.43 Severity: normal Tags: patch jh_makepkg's template for Maven projects produces a debian/rules file that uses /usr/bin/mvn-debian whose maintainer does not support production use. The comment at the top of /usr/bin/mvn-debian is correct: The template produced by jh_makepkg cannot even determine in a robust way if the build attempt by mvn-debian has been successful or not. Yet, production use is exactly what is implied by templates for building Debian packages that are output by a script. In its current form, this template does more harm and frustration than good for unsuspecting users (DDs such as myself who just want to package some Maven-built software). On the other hand, supporting Maven seems to be a bigger, more complicated, task that is better served by mh_make from the maven-debian-helper package. I suggest removing maven support from jh_makepkg altogether; see my patch below. Cheers, -Hilko [...] I will probably have jh_makepkg recommend mh_make for this instead instead of just removing the options. But definitely seconded. I am planning on a rewrite of jh_makepkg and have therefore not applied your patch as-is. ~Niels __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Processed: Re: Bug#703376: javahelper: Remove Maven support from jh_makepkg
Processing control commands: tags -1 confirmed Bug #703376 [javahelper] javahelper: Remove Maven support from jh_makepkg Added tag(s) confirmed. -- 703376: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703376 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
Bug#703376: javahelper: Remove Maven support from jh_makepkg
Package: javahelper Version: 0.43 Severity: normal Tags: patch jh_makepkg's template for Maven projects produces a debian/rules file that uses /usr/bin/mvn-debian whose maintainer does not support production use. The comment at the top of /usr/bin/mvn-debian is correct: The template produced by jh_makepkg cannot even determine in a robust way if the build attempt by mvn-debian has been successful or not. Yet, production use is exactly what is implied by templates for building Debian packages that are output by a script. In its current form, this template does more harm and frustration than good for unsuspecting users (DDs such as myself who just want to package some Maven-built software). On the other hand, supporting Maven seems to be a bigger, more complicated, task that is better served by mh_make from the maven-debian-helper package. I suggest removing maven support from jh_makepkg altogether; see my patch below. Cheers, -Hilko commit 70ce2c9b74292543625eec6a52bf7d4d1d0af0a9 (HEAD, refs/heads/master) Author: Hilko Bengen ben...@debian.org Date: Mon Mar 18 22:58:26 2013 +0100 Remove Maven support Modified jh_makepkg diff --git a/jh_makepkg b/jh_makepkg index c83dfce..32e9eb7 100755 --- a/jh_makepkg +++ b/jh_makepkg @@ -1,7 +1,7 @@ #!/bin/bash -- # options: -#make, maven, ant, byhand +#make, ant, byhand #app, library #gcj @@ -28,7 +28,6 @@ syntax() echo -e \t-a --app: This is an application package echo -e \tPick One: echo -e \t-t --ant: Builds with ant - echo -e \t-M --maven: Builds with maven2 echo -e \t-k --makefiles: Builds with make echo -e \t-n --none: Create own buildsystem echo -e \tPick One: @@ -44,7 +43,7 @@ syntax() exit 1 } -ARGS=p package m maintainer e email v upstream l library a app t ant k makefile n none g gcj o openjdk o7 openjdk7 M maven d default parseargs $@ +ARGS=p package m maintainer e email v upstream l library a app t ant k makefile n none g gcj o openjdk o7 openjdk7 d default parseargs $@ BUILDDIR=`pwd` @@ -170,8 +169,6 @@ esac if [ -n `getarg t ant` ]; then BUILD=ant -elif [ -n `getarg M maven` ]; then - BUILD=maven elif [ -n `getarg k makefiles` ]; then BUILD=make elif [ -n `getarg n none` ]; then @@ -181,7 +178,6 @@ else echo Select: echo -e \t[A] Ant echo -e \t[M] Makefiles - echo -e \t[V] Maven echo -e \t[N] None---make one for me (Default) echo -n [Namv] $ read t @@ -195,10 +191,6 @@ else BUILD=make echo Selected: Makefiles ;; - V|v) - BUILD=maven - echo Selected: Maven - ;; *) BUILD=byhand echo Selected: No upstream build system @@ -211,9 +203,6 @@ case $BUILD in ant) DEPENDS=$DEPENDS, ant ;; - maven) - DEPENDS=$DEPENDS, maven2, maven-debian-helper - ;; byhand) ;; esac @@ -354,15 +343,6 @@ END case $BUILD in ant) ;; - maven) - cat debian/rules END -override_dh_auto_build: - # Build the package - mvn-debian build -override_dh_auto_clean: - mvn-debian clean -END - ;; make) ;; byhand) __ This is the maintainer address of Debian's Java team http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. Please use debian-j...@lists.debian.org for discussions and questions.
