Re: [Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu
Roland Mas, 2014-04-03 17:22:16 +0200 : François-Régis, 2014-04-01 23:08:00 +0200 : Hi dears pkg-javascript members, I've pushed jquery-simpletreemenu on anonscm [1], could someone have a look at it and tell me how horrible it is ? Not too much, from what I can see. Thanks for all criticismes and advices. I can't think of anything that should block the inclusion of this package in Debian. If no official member of pkg-javascript steps up to do the upload, I'll do it in a few days. For some reason this fell through the cracks. I'm doing the upload right now. Roland. -- Roland Mas Certains disent que les vrais hommes ne font pas de backups. Mais ils disent aussi que même les vrais hommes pleurent parfois. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu
Hi François-Régis, Sorry for the delayed answer. 2014-04-04 1:39 GMT+02:00 François-Régis frv-deb...@miradou.com: Hi Emilien, Le 04/04/2014 00:02, Emilien Klein a écrit : 2014-04-03 23:52 GMT+02:00 François-Régis frv-deb...@miradou.com: Le 03/04/2014 22:46, Emilien Klein a écrit : 2014-04-01 23:08 GMT+02:00 François-Régis frv-deb...@miradou.com: I've pushed jquery-simpletreemenu on anonscm [1], could someone have a look at it and tell me how horrible it is ? - d/copyright: * inconsistent name of upstream contact (Freytag vs. Freitag). According to github, it's Simon Freytag You're right, done. * Include upstream email address as part of Upstream-Contact (from his website: si...@freytag.org.uk) Did'nt find it, thank you, done. Great. As a side note, regarding the discussion around the copyright file in general, since the use of that format is optional anyway, I guess this is indeed more of a best-practice approach (standardized way to find the upstream maintainer's name and contact details) should someone need to get in touch with him/her. But that's thus likely also open to interpretation, so don't take that as word of law. I was writing a response but short story : french law does'nt accept you to give up your authoring on anything but you can give up or sell any use of it. In fact the french law is ; whatever you might have say, signed contracted or whatever, you're still the author. And depending on what you have authored, you can claim to the respect of your work. As the common practice is to put the debian packaging stuff under the same licence as upstream, adding the packager name in copyright has no effect regarding french law. Please tell me if I'm following you right: - You are fine with the licensing of your works be under the same license as upstream - French law mandates you stay the author, and as such claim copyright on your works - Because you're fine with same-as-upstream license and French law indicating you are copyright owner, you don't deem necessary to indicate you are the copyright owner of the debian/* files If that's correct, I'd say let's prevent any future misunderstanding, and just add the extra 3-4 lines explicitly indicating your copyright. That way, if someone else picks up the packaging in 3-4 years and considerably rewrites it (e.g. splitting package with an example or demo package, or integrates it directly in js-goodies) there will be no time-consuming hunt to try to figure who owns the copyright, under what license, trying to contact you, not reaching you should you have stopped contributing to Debian, etc. Again, if you're clear on your intentions it's better to just state them explictly. For a highly distributed structure as Debian, depending on implicit is not always easy ;) * you have to mention the copyright on the debian/* files (you can use same-as-upstream, but have to list yourself as copyright holder) See next mail. (you might already have seen my response to David) Next mail was not supposed to be this on but it is * Upstream-Name is incorrect (likely Simple Tree Menu) You're (again) right, my Upstream-Name is wrong. What induce you to propose Simple Tree Menu ? Would'nt be better to take the github name: Simple-Tree-Menu ? Simple Tree Menu is the name that is used at all the places on the upstream website: http://www.freytag.org.uk/html/stm/index.html I suspect the dashes in the github repository name is because you can't create a repo name containing spaces? I don't know if it's possible,but in fact I don't know what should be the upstream name. To me it's clear: the name that upstream uses consistently on their website about their product is the upstream name. The name in the URL of a github repo has a lower priority. - d/upstream-changelog: the file ends with Version 1.5.0: Moved to github, effectively ending this changelog; changes will now just be the [git log] Do you plan to update it with the actual git log? Otherwise I'm not sure this file brings much benefit in including in the Debian package, as it will only be a forever outdated changelog. I've just added this file to have sort of history before github, it's not intended to be updated as upstream shows they will not maintain further changelog. I assume (might be wrong) that the benefit of having a changelog file included in the Debian package is for Debian users to be able to review what changed in the e.g. latest version. I assume there is only very limited advantage in what changed 2 years before the package was even included in the Debian archive? Honnestly I don't know... You can include it, but I don't see the benefit. In my opinion, this can only induce confusion/frustration for the user that really wants to see what changed in the last version, looking up the file only to find out it's already several years outdated while a new version was just installed on his system. No big deal anyway.
Re: [Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu
François-Régis, 2014-04-01 23:08:00 +0200 : Hi dears pkg-javascript members, I've pushed jquery-simpletreemenu on anonscm [1], could someone have a look at it and tell me how horrible it is ? Not too much, from what I can see. Thanks for all criticismes and advices. I can't think of anything that should block the inclusion of this package in Debian. If no official member of pkg-javascript steps up to do the upload, I'll do it in a few days. Roland. -- Roland Mas Any sufficiently advanced technology is indistinguishable from magic. -- Arthur C. Clarke ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu
Hi François-Régis, 2014-04-01 23:08 GMT+02:00 François-Régis frv-deb...@miradou.com: Hi dears pkg-javascript members, I've pushed jquery-simpletreemenu on anonscm [1], could someone have a look at it and tell me how horrible it is ? - d/copyright: * inconsistent name of upstream contact (Freytag vs. Freitag). According to github, it's Simon Freytag * Include upstream email address as part of Upstream-Contact (from his website: si...@freytag.org.uk) * you have to mention the copyright on the debian/* files (you can use same-as-upstream, but have to list yourself as copyright holder) * Upstream-Name is incorrect (likely Simple Tree Menu) * Where did you get the year 2010 as start of copyright? The git repo starts in 2012 with a mention of a previous manual zip file. - d/upstream-changelog: the file ends with Version 1.5.0: Moved to github, effectively ending this changelog; changes will now just be the [git log] Do you plan to update it with the actual git log? Otherwise I'm not sure this file brings much benefit in including in the Debian package, as it will only be a forever outdated changelog. +Emilien ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Emilien, Le 03/04/2014 16:46, Emilien Klein a écrit : * you have to mention the copyright on the debian/* files (you […] have to list yourself as copyright holder) Why do you want to enforce that? FTPmasters allow one to not enforce being a copyright holder (especially for trivial packaging work). Regards David -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQEcBAEBCAAGBQJTPcrYAAoJEAWMHPlE9r08PkUIAKP1d83syWHZOIuV/NiUgCdt 10FzRwpW/wZkzE8JyMFXZK6or/xa3hQkaLbo/EmH7kVvqEMXg3pAqHoUZdJIwBHa eQHCys2UAMXsr+vU5opvClgu8Bk057NCjRAQETjTDyvgQcMCuXaRI5RqqI9mpH47 G91knWElw74+ZSdlAdr8ANtl74afb3C7AAYRjjVqmR+CO7uaUdrUgIoO88fE6d9d 5sOE+OyHGM4Uj8vAoAywAmPULWG7Iw99Nv60JU7gsvWg3kr/5YQvsBNljgr6BCuc Oej4FHCgw2bjqzFb2tDQGyWuKhcpsx5jOPw1faOAWGNmv+QMOeT1dFFPyyOnDA8= =gtmj -END PGP SIGNATURE- ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu
Hi Emilien, Thanks for your review, Le 03/04/2014 22:46, Emilien Klein a écrit : 2014-04-01 23:08 GMT+02:00 François-Régis frv-deb...@miradou.com: I've pushed jquery-simpletreemenu on anonscm [1], could someone have a look at it and tell me how horrible it is ? - d/copyright: * inconsistent name of upstream contact (Freytag vs. Freitag). According to github, it's Simon Freytag You're right, done. * Include upstream email address as part of Upstream-Contact (from his website: si...@freytag.org.uk) Did'nt find it, thank you, done. * you have to mention the copyright on the debian/* files (you can use same-as-upstream, but have to list yourself as copyright holder) See next mail. * Upstream-Name is incorrect (likely Simple Tree Menu) You're (again) right, my Upstream-Name is wrong. What induce you to propose Simple Tree Menu ? Would'nt be better to take the github name: Simple-Tree-Menu ? * Where did you get the year 2010 as start of copyright? The git repo starts in 2012 with a mention of a previous manual zip file. I've found it by searching the original source and I should have kept the link but I did'nt and can't find the source anymore... I drop 2010 (It's a pity as I'm sure it was the first release... ). - d/upstream-changelog: the file ends with Version 1.5.0: Moved to github, effectively ending this changelog; changes will now just be the [git log] Do you plan to update it with the actual git log? Otherwise I'm not sure this file brings much benefit in including in the Debian package, as it will only be a forever outdated changelog. I've just added this file to have sort of history before github, it's not intended to be updated as upstream shows they will not maintain further changelog. Thanks Emilien, it's always a pleasure to read youre reviews. Regards, PS; I delay push until finding the good upstream name... -- François-Régis ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu
Hi François-Régis, 2014-04-03 23:52 GMT+02:00 François-Régis frv-deb...@miradou.com: Hi Emilien, Thanks for your review, Le 03/04/2014 22:46, Emilien Klein a écrit : 2014-04-01 23:08 GMT+02:00 François-Régis frv-deb...@miradou.com: I've pushed jquery-simpletreemenu on anonscm [1], could someone have a look at it and tell me how horrible it is ? - d/copyright: * inconsistent name of upstream contact (Freytag vs. Freitag). According to github, it's Simon Freytag You're right, done. * Include upstream email address as part of Upstream-Contact (from his website: si...@freytag.org.uk) Did'nt find it, thank you, done. Great. As a side note, regarding the discussion around the copyright file in general, since the use of that format is optional anyway, I guess this is indeed more of a best-practice approach (standardized way to find the upstream maintainer's name and contact details) should someone need to get in touch with him/her. But that's thus likely also open to interpretation, so don't take that as word of law. * you have to mention the copyright on the debian/* files (you can use same-as-upstream, but have to list yourself as copyright holder) See next mail. (you might already have seen my response to David) * Upstream-Name is incorrect (likely Simple Tree Menu) You're (again) right, my Upstream-Name is wrong. What induce you to propose Simple Tree Menu ? Would'nt be better to take the github name: Simple-Tree-Menu ? Simple Tree Menu is the name that is used at all the places on the upstream website: http://www.freytag.org.uk/html/stm/index.html I suspect the dashes in the github repository name is because you can't create a repo name containing spaces? * Where did you get the year 2010 as start of copyright? The git repo starts in 2012 with a mention of a previous manual zip file. I've found it by searching the original source and I should have kept the link but I did'nt and can't find the source anymore... I drop 2010 (It's a pity as I'm sure it was the first release... ). By all means leave it in. I was just wondering why 2010, and not any other date. If the software stated being developed in 2010, better to leave that in indeed. - d/upstream-changelog: the file ends with Version 1.5.0: Moved to github, effectively ending this changelog; changes will now just be the [git log] Do you plan to update it with the actual git log? Otherwise I'm not sure this file brings much benefit in including in the Debian package, as it will only be a forever outdated changelog. I've just added this file to have sort of history before github, it's not intended to be updated as upstream shows they will not maintain further changelog. I assume (might be wrong) that the benefit of having a changelog file included in the Debian package is for Debian users to be able to review what changed in the e.g. latest version. I assume there is only very limited advantage in what changed 2 years before the package was even included in the Debian archive? Thanks Emilien, it's always a pleasure to read youre reviews. I'm still pretty new to reviewing, but I guess it's as good as any other way to contribute to making Debian the best possible ;) +Emilien ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu
Hi Emilien, Le 04/04/2014 00:02, Emilien Klein a écrit : 2014-04-03 23:52 GMT+02:00 François-Régis frv-deb...@miradou.com: Le 03/04/2014 22:46, Emilien Klein a écrit : 2014-04-01 23:08 GMT+02:00 François-Régis frv-deb...@miradou.com: I've pushed jquery-simpletreemenu on anonscm [1], could someone have a look at it and tell me how horrible it is ? - d/copyright: * inconsistent name of upstream contact (Freytag vs. Freitag). According to github, it's Simon Freytag You're right, done. * Include upstream email address as part of Upstream-Contact (from his website: si...@freytag.org.uk) Did'nt find it, thank you, done. Great. As a side note, regarding the discussion around the copyright file in general, since the use of that format is optional anyway, I guess this is indeed more of a best-practice approach (standardized way to find the upstream maintainer's name and contact details) should someone need to get in touch with him/her. But that's thus likely also open to interpretation, so don't take that as word of law. I was writing a response but short story : french law does'nt accept you to give up your authoring on anything but you can give up or sell any use of it. In fact the french law is ; whatever you might have say, signed contracted or whatever, you're still the author. And depending on what you have authored, you can claim to the respect of your work. As the common practice is to put the debian packaging stuff under the same licence as upstream, adding the packager name in copyright has no effect regarding french law. * you have to mention the copyright on the debian/* files (you can use same-as-upstream, but have to list yourself as copyright holder) See next mail. (you might already have seen my response to David) Next mail was not supposed to be this on but it is * Upstream-Name is incorrect (likely Simple Tree Menu) You're (again) right, my Upstream-Name is wrong. What induce you to propose Simple Tree Menu ? Would'nt be better to take the github name: Simple-Tree-Menu ? Simple Tree Menu is the name that is used at all the places on the upstream website: http://www.freytag.org.uk/html/stm/index.html I suspect the dashes in the github repository name is because you can't create a repo name containing spaces? I don't know if it's possible,but in fact I don't know what should be the upstream name. - d/upstream-changelog: the file ends with Version 1.5.0: Moved to github, effectively ending this changelog; changes will now just be the [git log] Do you plan to update it with the actual git log? Otherwise I'm not sure this file brings much benefit in including in the Debian package, as it will only be a forever outdated changelog. I've just added this file to have sort of history before github, it's not intended to be updated as upstream shows they will not maintain further changelog. I assume (might be wrong) that the benefit of having a changelog file included in the Debian package is for Debian users to be able to review what changed in the e.g. latest version. I assume there is only very limited advantage in what changed 2 years before the package was even included in the Debian archive? Honnestly I don't know... Thanks Emilien, it's always a pleasure to read youre reviews. I'm still pretty new to reviewing, but I guess it's as good as any other way to contribute to making Debian the best possible ;) It's always benefit to have review and perhaps fresher are better... Kindky, -- François-Régis ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
