Re: Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
Am 15.06.2010 13:13, schrieb Thibaut VARENE: The one you posted, since it's known to work fine ;-) It's in our current git, so if one of the fellow pkg-multimedia DDs finds some time... ;) ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
On Tue, Jun 15, 2010 at 1:06 PM, Fabian Greffrath wrote: > Am 15.06.2010 12:30, schrieb Thibaut VARENE: >> >> Could you consider, as a mitigation between two extreme options, that >> in the event upstream fails to fix this bug in a timely fashion, >> whenever you upload a new version of libflac you'd include this patch >> with it? It can easily be reverted to whatever upstream finds sensible >> afterwards, and will at least ensure that newer versions of libflac >> aren't plagued with this bug. Since Debian is unaffected per se, the >> sourceful rebuild of affected packages is not necessarily mandatory, >> but there again, it would ensure that newer packages aren't affected >> anymore... Does that make sense? > > Yes, this sounds reasonable. With "this patch" do you mean the one I already > posted to this bug report or do you have another (maybe less invasive) one > at hand? The one you posted, since it's known to work fine ;-) Thanks -- Thibaut VARENE http://www.parisc-linux.org/~varenet/ ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
Am 15.06.2010 12:30, schrieb Thibaut VARENE: Could you consider, as a mitigation between two extreme options, that in the event upstream fails to fix this bug in a timely fashion, whenever you upload a new version of libflac you'd include this patch with it? It can easily be reverted to whatever upstream finds sensible afterwards, and will at least ensure that newer versions of libflac aren't plagued with this bug. Since Debian is unaffected per se, the sourceful rebuild of affected packages is not necessarily mandatory, but there again, it would ensure that newer packages aren't affected anymore... Does that make sense? Yes, this sounds reasonable. With "this patch" do you mean the one I already posted to this bug report or do you have another (maybe less invasive) one at hand? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
On Tue, Jun 15, 2010 at 11:44 AM, Fabian Greffrath wrote: > forwarded 579025 > https://sourceforge.net/tracker/?func=detail&atid=113478&aid=3016381&group_id=13478 > severity 579025 normal > thanks > > I have forwarded your bug report to upstream's bug tracker at > sourceforge. I think this is an upstream bug and it should get fixed > upstream. > > Fixing it in Debian would mean an undesirable deviation from upstream > and force the sourceful uploads of 43 packages, including > re-autoconf'ing. I don't think it's worth the effort, since currently no > single package in Debian is actually affected by this bug (the default > prefix for autotools is /usr/local, so every package in Debian needs to > run configure with at least --prefix=/usr, which hides the bug) and the > workaround is quite simple (e.g. run configure with --prefix=/usr/local, > which is the default anyway). Hope you agree! I agree with your reasoning from Debian's PoV. Now, I would really like to see this bug fixed before Squeeze is released, because I do not agree with how you seem to underestimate how important this bug is for people releasing source package using libFLAC.m4. I now have to make sure that the machine I'm generating my source package on has a properly patched libFLAC.m4. Of course, any update of libflac-dev will overwrite the patch, adding to the burden. This bug was first reported to me by people running the (very common) "./configure && make && make install" on my package, and experiencing FTBFS on it because it was generated against buggy libFLAC.m4. It took me quite a while to figure what was going on (and I humbly believe that I'm more experienced than the average user of my package), thus I think you cannot expect average people who barely know how to build a package to "guess" that when they see such a cryptic error as "libtool: link: require no space between `-L' and `-lFLAC'"; that they should pass --prefix=/usr/local to fix it... I hope you agree with me ;-P Could you consider, as a mitigation between two extreme options, that in the event upstream fails to fix this bug in a timely fashion, whenever you upload a new version of libflac you'd include this patch with it? It can easily be reverted to whatever upstream finds sensible afterwards, and will at least ensure that newer versions of libflac aren't plagued with this bug. Since Debian is unaffected per se, the sourceful rebuild of affected packages is not necessarily mandatory, but there again, it would ensure that newer packages aren't affected anymore... Does that make sense? Thanks T-Bone -- Thibaut VARENE http://www.parisc-linux.org/~varenet/ ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Processed: Re: Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
Processing commands for cont...@bugs.debian.org: > forwarded 579025 > https://sourceforge.net/tracker/?func=detail&atid=113478&aid=3016381&group_id=13478 Bug #579025 [libflac-dev] libflac-dev: libFLAC.m4 may set empty -L flag Set Bug forwarded-to-address to 'https://sourceforge.net/tracker/?func=detail&atid=113478&aid=3016381&group_id=13478'. > severity 579025 normal Bug #579025 [libflac-dev] libflac-dev: libFLAC.m4 may set empty -L flag Severity set to 'normal' from 'important' > thanks Stopping processing here. Please contact me if you need assistance. -- 579025: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579025 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
forwarded 579025 https://sourceforge.net/tracker/?func=detail&atid=113478&aid=3016381&group_id=13478 severity 579025 normal thanks I have forwarded your bug report to upstream's bug tracker at sourceforge. I think this is an upstream bug and it should get fixed upstream. Fixing it in Debian would mean an undesirable deviation from upstream and force the sourceful uploads of 43 packages, including re-autoconf'ing. I don't think it's worth the effort, since currently no single package in Debian is actually affected by this bug (the default prefix for autotools is /usr/local, so every package in Debian needs to run configure with at least --prefix=/usr, which hides the bug) and the workaround is quite simple (e.g. run configure with --prefix=/usr/local, which is the default anyway). Hope you agree! - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
Am 14.06.2010 10:44, schrieb Thibaut VARÈNE: for the same reason my package didn't FTBFS *in Debian*: rules define --prefix, which masks the bug. The bug is hit when there's no defined prefix and the configure script has to guess it. I thought this was clear enough from my initial bug report: "when configure is called without arguments"... Alright, thanks. I've forwarded your initial bug report to the upstream mailing list. Since I want to avoid deviation from upstream as far as possible, I'd like to hear their opinion first. - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
Le 14 juin 10 à 10:10, Fabian Greffrath a écrit : Am 27.04.2010 19:25, schrieb Thibaut VARÈNE: It does, provided of course that the target package's configure script is properly re-generated against the fixed libFLAC.m4 Ugh, don't want! This means that any package that was autoconf'd against the broken m4 file will fail to build when its configure script is executed without any option. You might want to add a note about that somewhere... How come that no package in Debian that builds against libflac-dev FTBFS so far? for the same reason my package didn't FTBFS *in Debian*: rules define --prefix, which masks the bug. The bug is hit when there's no defined prefix and the configure script has to guess it. I thought this was clear enough from my initial bug report: "when configure is called without arguments"... HTH T-Bone ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
Am 27.04.2010 19:25, schrieb Thibaut VARÈNE: It does, provided of course that the target package's configure script is properly re-generated against the fixed libFLAC.m4 Ugh, don't want! This means that any package that was autoconf'd against the broken m4 file will fail to build when its configure script is executed without any option. You might want to add a note about that somewhere... How come that no package in Debian that builds against libflac-dev FTBFS so far? - Fabian -- Dipl.-Phys. Fabian Greffrath Ruhr-Universität Bochum Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT) Universitätsstr. 150, IB 3/134 D-44780 Bochum Telefon: +49 (0)234 / 32-26334 Fax: +49 (0)234 / 32-14227 E-Mail: greffr...@leat.ruhr-uni-bochum.de ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
Le 26 avr. 10 à 10:05, Fabian Greffrath a écrit : So, can you confirm the attached patch fixes this issue? It does, provided of course that the target package's configure script is properly re-generated against the fixed libFLAC.m4 This means that any package that was autoconf'd against the broken m4 file will fail to build when its configure script is executed without any option. You might want to add a note about that somewhere... Also plagues libflac-dev in lenny, btw. my 2c T-Bone -- Thibaut VARÈNE http://www.parisc-linux.org/~varenet/ ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
So, can you confirm the attached patch fixes this issue? - Fabian --- flac-1.2.1.orig/src/libFLAC/libFLAC.m4 +++ flac-1.2.1/src/libFLAC/libFLAC.m4 @@ -14,14 +14,18 @@ AC_ARG_WITH(libFLAC-includes,[ --with-l AC_ARG_ENABLE(libFLACtest, [ --disable-libFLACtest Do not try to compile and run a test libFLAC program],, enable_libFLACtest=yes) if test "x$libFLAC_libraries" != "x" ; then -LIBFLAC_LIBDIR="$libFLAC_libraries" +LIBFLAC_LIBS="-L$libFLAC_libraries" + elif test "x$libFLAC_prefix" = "xno" || test "x$libFLAC_prefix" = "xyes" ; then +LIBFLAC_LIBS="" elif test "x$libFLAC_prefix" != "x" ; then -LIBFLAC_LIBDIR="$libFLAC_prefix/lib" - elif test "x$prefix" != "xNONE" ; then -LIBFLAC_LIBDIR="$libdir" +LIBFLAC_LIBS="-L$libFLAC_prefix/lib" + elif test "x$prefix" != "xNONE"; then +LIBFLAC_LIBS="-L$prefix/lib" fi - LIBFLAC_LIBS="-L$LIBFLAC_LIBDIR -lFLAC $OGG_LIBS -lm" + if test "x$libFLAC_prefix" != "xno" ; then +LIBFLAC_LIBS="$LIBFLAC_LIBS -lFLAC $OGG_LIBS -lm" + fi if test "x$libFLAC_includes" != "x" ; then LIBFLAC_CFLAGS="-I$libFLAC_includes" ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#579025: libflac-dev: libFLAC.m4 may set empty -L flag
Package: libflac-dev Version: 1.2.1-2+b1 Severity: important In /usr/share/aclocal/libFLAC.m4: if test "x$libFLAC_libraries" != "x" ; then LIBFLAC_LIBDIR="$libFLAC_libraries" elif test "x$libFLAC_prefix" != "x" ; then LIBFLAC_LIBDIR="$libFLAC_prefix/lib" elif test "x$prefix" != "xNONE" ; then LIBFLAC_LIBDIR="$libdir" fi LIBFLAC_LIBS="-L$LIBFLAC_LIBDIR -lFLAC $OGG_LIBS -lm" In configure.ac, the usual: AM_PATH_LIBFLAC( [], [echo "*Coun't find FLAC library, disabling FLAC support"; flac=false]) Result in Makefile when configure is called without arguments: LIBFLAC_LIBS = -L -lFLAC -lm Triggers the following error during build (at link time): libtool: link: require no space between `-L' and `-lFLAC' Fix: see /usr/share/aclocal/vorbis.m4 (from libvorbis-dev): if test "x$vorbis_libraries" != "x" ; then VORBIS_LIBS="-L$vorbis_libraries" elif test "x$vorbis_prefix" = "xno" || test "x$vorbis_prefix" = "xyes" ; then VORBIS_LIBS="" elif test "x$vorbis_prefix" != "x" ; then VORBIS_LIBS="-L$vorbis_prefix/lib" elif test "x$prefix" != "xNONE"; then VORBIS_LIBS="-L$prefix/lib" fi if test "x$vorbis_prefix" != "xno" ; then VORBIS_LIBS="$VORBIS_LIBS -lvorbis -lm" fi This bug actually prevents packages using AM_PATH_LIBFLAC to build HTH -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: hppa (parisc64) Kernel: Linux 2.6.31.1 (SMP w/2 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash Versions of packages libflac-dev depends on: ii libflac81.2.1-2+b1 Free Lossless Audio Codec - runtim ii libogg-dev 1.2.0~dfsg-1 Ogg bitstream library development libflac-dev recommends no packages. libflac-dev suggests no packages. -- no debconf information ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
