Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
On Thu, Mar 10, 2011 at 15:11:27 (CET), Fabian Greffrath wrote: Am Dienstag, den 08.03.2011, 20:44 + schrieb Adam D. Barratt: libmms 0.6.2-2 has just entered testing without any complaints. Please go ahead with the stable upload. the package is already prepared in the stable branch of our libmms git repo. Please upload if you find some time. ;) Uploaded and waiting for a SRM to have it processed. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Am 16.03.2011 07:21, schrieb Adam D. Barratt: Unfortunately the upload hit p-u-NEW after things had been frozen for 6.0.1; it will therefore not be processed until after 6.0.1 has been released and will be included in 6.0.2. Oh, come on. Isn't it possible to still get this into 6.0.1? It's such a tiny patch... - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
On Wed, Mar 16, 2011 at 09:04:52AM +0100, Fabian Greffrath wrote: Am 16.03.2011 07:21, schrieb Adam D. Barratt: Unfortunately the upload hit p-u-NEW after things had been frozen for 6.0.1; it will therefore not be processed until after 6.0.1 has been released and will be included in 6.0.2. Oh, come on. Isn't it possible to still get this into 6.0.1? It's such a tiny patch... Sorry, no. There's a reason for freezing p-u and that's not patch size. (Rather buildd delays, announcements that get drafted, calls for testing, etc.) Kind regards Philipp Kern signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Am 10.03.2011 15:11, schrieb Fabian Greffrath: libmms 0.6.2-2 has just entered testing without any complaints. Please go ahead with the stable upload. the package is already prepared in the stable branch of our libmms git repo. Please upload if you find some time. ;) Ping ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
On Mon, Mar 14, 2011 at 09:38:33 (CET), Fabian Greffrath wrote: Am 10.03.2011 15:11, schrieb Fabian Greffrath: libmms 0.6.2-2 has just entered testing without any complaints. Please go ahead with the stable upload. the package is already prepared in the stable branch of our libmms git repo. Please upload if you find some time. ;) Ping uploaded -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
On Mon, 2011-03-07 at 09:32 +0100, Fabian Greffrath wrote: Am 21.02.2011 13:58, schrieb Adam D. Barratt: Yes, the fix would need to be applied to unstable first, so we can discover if any further issues occur. libmms 0.6.2-2 has just entered testing without any complaints. Please go ahead with the stable upload. Regards, Adam ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Am 21.02.2011 13:58, schrieb Adam D. Barratt: Yes, the fix would need to be applied to unstable first, so we can discover if any further issues occur. libmms 0.6.2-2 has just entered testing without any complaints. - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Hi all, Note a patch fixing bswap.h to do things properly has now been pushed to the libmms git repo on sourceforge. Regards, Hans ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Hey release team, this is the patch in question: http://libmms.git.sourceforge.net/git/gitweb.cgi?p=libmms/libmms;a=commitdiff;h=487d4dc7ea330d14d6e43e6cce092c4ffac926eb Do you want me to add it to the package targetted at s-p-u for clarification, or should I apply it in unstable first? How about Hans' suggestion to accept libmms 0.6.2 in stable? Best Regards, Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
On Mon, February 21, 2011 12:28, Fabian Greffrath wrote: this is the patch in question: http://libmms.git.sourceforge.net/git/gitweb.cgi?p=libmms/libmms;a=commitdiff;h=487d4dc7ea330d14d6e43e6cce092c4ffac926eb Do you want me to add it to the package targetted at s-p-u for clarification, or should I apply it in unstable first? Yes, the fix would need to be applied to unstable first, so we can discover if any further issues occur. How about Hans' suggestion to accept libmms 0.6.2 in stable? Even after excluding build system noise, the difference between the current stable and unstable packages comes to 29 files changed, 1094 insertions(+), 1459 deletions(-) including a bunch of code rearrangement. That's really too large and non-specific for a stable update, I'm afraid. Regards, Adam ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Am 21.02.2011 13:58, schrieb Adam D. Barratt: Yes, the fix would need to be applied to unstable first, so we can discover if any further issues occur. Prepared in git. siretart? ;) including a bunch of code rearrangement. That's really too large and non-specific for a stable update, I'm afraid. I see, thanks for the analysis! - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SRM] Approval for libmms_0.6-1squeeze1
On Mon, Feb 7, 2011 at 10:52:43 +0100, Fabian Greffrath wrote: +--- libmms.orig/src/bswap.h libmms/src/bswap.h +@@ -21,23 +21,50 @@ + */ + + +-/* Go cheap now, will rip out glib later. *Sigh* */ +-#include glib.h ++#include stdint.h + +-/* NOTE: +- * Now, to clear up confusion: LE_XX means from LE to native, XX bits wide +- * I know it's not very clear naming (tell me about it, I +- * misinterpreted in first version and caused bad nasty bug, *sigh*), +- * but that's inherited code, will clean up as things go +- * Oh, and one more thing -- they take *pointers*, not actual ints +- */ +- +-#define LE_16(val) (GINT16_FROM_LE (*((u_int16_t*)(val +-#define BE_16(val) (GINT16_FROM_BE (*((u_int16_t*)(val +-#define LE_32(val) (GINT32_FROM_LE (*((u_int32_t*)(val +-#define BE_32(val) (GINT32_FROM_BE (*((u_int32_t*)(val +- +-#define LE_64(val) (GINT64_FROM_LE (*((u_int64_t*)(val +-#define BE_64(val) (GINT64_FROM_BE (*((u_int64_t*)(val ++#define SWAP_ENDIAN_16(val) \ ++(val[1] | (val[0] 8)) So this looks weird to me. That macro looks like it's doing big endian to native, not swap. And the SAME_ENDIAN_* macros smell like little endian to native. Which means this is broken on BE. Am I missing something? ++#define SWAP_ENDIAN_32(val) \ ++(val[3] | (val[2] 8) | (val[1] 16) | (val[0] 24)) ++#define SWAP_ENDIAN_64(val) \ ++(val[7] | (val[6] 8) | (val[5] 16) | (val[4] 24) | \ ++((uint64_t)val[3] 32) | ((uint64_t)val[2] 40) | \ ++((uint64_t)val[1] 48) | ((uint64_t)val[0] 56)) ++ ++#define SAME_ENDIAN_16(val) \ ++(val[0] | (val[1] 8)) ++#define SAME_ENDIAN_32(val) \ ++(val[0] | (val[1] 8) | (val[2] 16) | (val[3] 24)) ++#define SAME_ENDIAN_64(val) \ ++(val[0] | (val[1] 8) | (val[2] 16) | (val[3] 24) | \ ++((uint64_t)val[4] 32) | ((uint64_t)val[5] 40) | \ ++((uint64_t)val[6] 48) | ((uint64_t)val[7] 56)) ++ Cheers, Julien ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Dear Hans, could you please comment on this? I'd like to backport this patch from trunk to the version in Debian squeeze (libmms 0.6), because it is known to fix the alignment bug on ARM, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=611791 - Fabian Am Samstag, den 19.02.2011, 16:40 +0100 schrieb Julien Cristau: On Mon, Feb 7, 2011 at 10:52:43 +0100, Fabian Greffrath wrote: +--- libmms.orig/src/bswap.h libmms/src/bswap.h +@@ -21,23 +21,50 @@ + */ + + +-/* Go cheap now, will rip out glib later. *Sigh* */ +-#include glib.h ++#include stdint.h + +-/* NOTE: +- * Now, to clear up confusion: LE_XX means from LE to native, XX bits wide +- * I know it's not very clear naming (tell me about it, I +- * misinterpreted in first version and caused bad nasty bug, *sigh*), +- * but that's inherited code, will clean up as things go +- * Oh, and one more thing -- they take *pointers*, not actual ints +- */ +- +-#define LE_16(val) (GINT16_FROM_LE (*((u_int16_t*)(val +-#define BE_16(val) (GINT16_FROM_BE (*((u_int16_t*)(val +-#define LE_32(val) (GINT32_FROM_LE (*((u_int32_t*)(val +-#define BE_32(val) (GINT32_FROM_BE (*((u_int32_t*)(val +- +-#define LE_64(val) (GINT64_FROM_LE (*((u_int64_t*)(val +-#define BE_64(val) (GINT64_FROM_BE (*((u_int64_t*)(val ++#define SWAP_ENDIAN_16(val) \ ++ (val[1] | (val[0] 8)) So this looks weird to me. That macro looks like it's doing big endian to native, not swap. And the SAME_ENDIAN_* macros smell like little endian to native. Which means this is broken on BE. Am I missing something? ++#define SWAP_ENDIAN_32(val) \ ++ (val[3] | (val[2] 8) | (val[1] 16) | (val[0] 24)) ++#define SWAP_ENDIAN_64(val) \ ++ (val[7] | (val[6] 8) | (val[5] 16) | (val[4] 24) | \ ++ ((uint64_t)val[3] 32) | ((uint64_t)val[2] 40) | \ ++ ((uint64_t)val[1] 48) | ((uint64_t)val[0] 56)) ++ ++#define SAME_ENDIAN_16(val) \ ++ (val[0] | (val[1] 8)) ++#define SAME_ENDIAN_32(val) \ ++ (val[0] | (val[1] 8) | (val[2] 16) | (val[3] 24)) ++#define SAME_ENDIAN_64(val) \ ++ (val[0] | (val[1] 8) | (val[2] 16) | (val[3] 24) | \ ++ ((uint64_t)val[4] 32) | ((uint64_t)val[5] 40) | \ ++ ((uint64_t)val[6] 48) | ((uint64_t)val[7] 56)) ++ Cheers, Julien ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Hi, On 02/19/2011 10:05 PM, Fabian Greffrath wrote: Dear Hans, could you please comment on this? I'd like to backport this patch from trunk to the version in Debian squeeze (libmms 0.6), because it is known to fix the alignment bug on ARM, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=611791 Oh, good catch. So the story goes like this, indeed the SAME_ENDIAN and SWAP_ENDIAN macros should be called LITTLE_ENDIAN_TO_NATIVE resp. BIG_ENDIAN_TO_NATIVE, iow they indeed will do the wrong thing on bigendian if used as intended, but the WORDS_BIGENDIAN define which is checked for does not get defined by standard C headers, so we end up using the /* Little endian */ block on big endian machines too. So this is a case were 2 wrongs make a right. I'll change this (really fix it) in git soonish, likely tomorrow. BTW, note that I strongly believe that the 0.6.1 and 0.6.2 releases are bugfix only releases, fixing a number of small but nice to have fixed bugs. Ok I must admit that the ipv6 changes could be called a feature, then again not supporting ipv6 now a days can also plainly be called a bug. So I think it would be best to just rebase the packages to 0.6.2, rather then do a backport. Regards, Hans ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
On Di, Feb 08, 2011 at 08:44:51 (CET), Fabian Greffrath wrote: Am 07.02.2011 22:50, schrieb Adam D. Barratt: From the bug report, it appears that this issue also affects the package in unstable? If so, please apply the fix to unstable first, and we can then look at a stable update assuming no issues arise. Could one of the pkg-multimedia team mates please upload libmms_0.6.2-1 from the master branch in our git repo? Uploaded. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Hi, On Mon, 2011-02-07 at 10:52 +0100, Fabian Greffrath wrote: please consider the attached diff for libmms in stable. It fixes an alignment issue that makes the whole library rather useless on e.g. ARM. From the bug report, it appears that this issue also affects the package in unstable? If so, please apply the fix to unstable first, and we can then look at a stable update assuming no issues arise. Regards, Adam ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1
Am 07.02.2011 22:50, schrieb Adam D. Barratt: From the bug report, it appears that this issue also affects the package in unstable? If so, please apply the fix to unstable first, and we can then look at a stable update assuming no issues arise. Could one of the pkg-multimedia team mates please upload libmms_0.6.2-1 from the master branch in our git repo? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
