Re: [SCM] gmerlin-avdecoder/master: clean up on 'clean'
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2011-01-16 22:19, Jonas Smedegaard wrote: the problem is: - - we strip some directories to get dfsg-clean code - - we patch autotools to reflect these changes - - when doing clean, the quilt-patches are not applied, thus autotools do not know about the missing directories, thus make distclean fails I believe you are wrong about the last part. I believe unpatching is done _after_ cleaning. hmm, well i guess this all depends. clean is probably called several times in the build process. - - it is called implicitely when doing a full build just before anything (this is probably what you are talking about) - - it can be called explicitely after a build (e.g. by providing -tc as dpkb-buildpackage flag, or by just running debian/rules clean) (this is what i am talking about). according to http://build-common.alioth.debian.org/cdbs-doc.html#fig:buildcore the clean target will simply be called without further ado. in any case, i don't see anything bad in removing a handful of files in order to get a completely clean source tree in _any_ case. fgmasdr IOhannes -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0z+PAACgkQkX2Xpv6ydvRcaQCdE/PPt1PEynZ6oAwdQljI5OHY u64AoNnjyXxOCfmWQbbkmhD2bHVY0MA6 =0eju -END PGP SIGNATURE- smime.p7s Description: S/MIME Cryptographic Signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] gmerlin-avdecoder/master: clean up on 'clean'
On Mon, Jan 17, 2011 at 09:08:16AM +0100, IOhannes m zmoelnig wrote: On 2011-01-16 22:19, Jonas Smedegaard wrote: the problem is: - - we strip some directories to get dfsg-clean code - - we patch autotools to reflect these changes - - when doing clean, the quilt-patches are not applied, thus autotools do not know about the missing directories, thus make distclean fails I believe you are wrong about the last part. I believe unpatching is done _after_ cleaning. hmm, well i guess this all depends. clean is probably called several times in the build process. - - it is called implicitely when doing a full build just before anything (this is probably what you are talking about) - - it can be called explicitely after a build (e.g. by providing -tc as dpkb-buildpackage flag, or by just running debian/rules clean) (this is what i am talking about). according to http://build-common.alioth.debian.org/cdbs-doc.html#fig:buildcore the clean target will simply be called without further ado. Build tools work on top of the packaging source. Patching historically was applied op top too, but with dpkg-source is done below from the POV of build tools. This caused us problems with our preferred way of working with our VCS, so we chose to set a flag requesting dpkg-source to unapply patches as a final step. So all in all, we chose ourselves the smallest of evils: If our clean target is affected by patches, then we need to manually re-apply them before an explicit clean. In all other situations it Just Works(tm). in any case, i don't see anything bad in removing a handful of files in order to get a completely clean source tree in _any_ case. Ok. I'll rest my case. But beware that only removals are possible to handle like that. More complex cleanup is involved, like renaming files put aside during build, it may still fail if invoking clean explicitly without first re-applying patches. The official correct routine for our packaging style is to manually re-apply patches before explicitly cleaning. due to our choice of enabling unapply-patches in local-options. So remember to mention that if anyone consider filing a bugreport against CDBS or debhelper ;-) - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] gmerlin-avdecoder/master: clean up on 'clean'
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/15/2011 11:28 AM, Jonas Smedegaard wrote: On Fri, Jan 14, 2011 at 07:11:45PM +, zmoelnig-gu...@users.alioth.debian.org wrote: clean up on 'clean' the clean target fails to remove some files, because of the dfsg-stripping of the sources, which removed some directories, making make distclean fail in the lib/ directory and not finishing its job Seems better to me then to patch autotools than partly reinvent upstream clean target. i'm not sure whether i really understand. the problem is: - - we strip some directories to get dfsg-clean code - - we patch autotools to reflect these changes - - when doing clean, the quilt-patches are not applied, thus autotools do not know about the missing directories, thus make distclean fails fgmsdr IOhannes PS: please send replies to [SCM] to -maintainers, as i thinkthat this is the appropriate list for discussion. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0zWBIACgkQkX2Xpv6ydvSJOwCcDjyeaPCmwPwPisqzImlnwNA0 RhcAn1HxSoLw0eGmyMWu9z8owG59fFUX =U/mu -END PGP SIGNATURE- ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] gmerlin-avdecoder/master: clean up on 'clean'
On Sun, Jan 16, 2011 at 09:41:54PM +0100, IOhannes m zmölnig wrote: On 01/15/2011 11:28 AM, Jonas Smedegaard wrote: On Fri, Jan 14, 2011 at 07:11:45PM +, zmoelnig-gu...@users.alioth.debian.org wrote: clean up on 'clean' the clean target fails to remove some files, because of the dfsg-stripping of the sources, which removed some directories, making make distclean fail in the lib/ directory and not finishing its job Seems better to me then to patch autotools than partly reinvent upstream clean target. i'm not sure whether i really understand. the problem is: - - we strip some directories to get dfsg-clean code - - we patch autotools to reflect these changes - - when doing clean, the quilt-patches are not applied, thus autotools do not know about the missing directories, thus make distclean fails I believe you are wrong about the last part. I believe unpatching is done _after_ cleaning. If interrupted during build (which often happens when tuning the build routines) then all sorts of odd things can occur, but with dpkg-source format 3.0 (quit) patches are applied _before_ invoking any rules, and thus should re unapplied _after_ cleanup. PS: please send replies to [SCM] to -maintainers, as i thinkthat this is the appropriate list for discussion. You are absolutely right. My fingers are just programmed to hit L in Mutt when targeting a list - not G which somewhat counterintuitively is the appropriate action when commenting on commit messages. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
