Re: new version of milkytracker
On Sat, Jan 08, 2011 at 08:27:04PM +0100, Jonas Smedegaard wrote:
> On Sat, Jan 08, 2011 at 07:22:10PM +0100, Alessandro Ghedini wrote:
> >On Sat, Jan 08, 2011 at 06:46:20PM +0100, Jonas Smedegaard wrote:
> >>On Sat, Jan 08, 2011 at 05:56:07PM +0100, Alessandro Ghedini wrote:
> Files: src/milkyplay/drivers/generic/rtaudio/oss/soundcard.h
> Copyright: *No copyright*
> License: other-restricted!
> FIXME
> >>>
> >>>This is clearly not DFSG-compliant... I also think that it can
> >>be >removed and substituted with the soundcard.h provided by the
> >>>oss4-dev package (which seems to be free).
> >>
> >>Ok, should be ripped out, then. But instead of substituting I
> >>guess it is better to build-depend on oss4-dev and patch source
> >>to include that.
> >
> >Yeah, that was what I meant... the code builds fine also against
> >the provided by libc-dev so there's no need to
> >add another dependency.
>
> Ok. I was wondering why OSS4 was needed, but assumed you knew better.
>
> ...and now you do :-P
>
>
> Files: resources/reference/xmeffects.html
> Copyright: INTERNET ARCHIVE
> 2006, Yury Aliaev 2006
> License: GFDL and UNKNOWN
> FIXME
> >>>
> >>>This has to be removed as well (GNU FDL is not DFSG-compatible).
> >>
> >>I believe GNU FSL _is_ DFSG-compliant as long as it has no invariant
> >>sections.
> >>
> >>Reason I tagged it as FIXME was the INTERNET ARCHIVE JavaScript code
> >>being copyright protected with no licensing!
> >
> >The code can be patched easily (it seem to not do anything).
>
> Ahem. It is documentation, not code.
>
> Besides, licensing is not only if we are allowed to link things
> together, but also if we are allowed to redistribute at all - so if
> licensing is missing, the file must be ripped out from source
> distribution as well, not acceptable to just patch it for the binary
> packages.
I meant HTML/JS code... but yes, I realised that I said an idiocy after I
sent that mail.
> >>>Also, for the generic 'LGPL' what version should be used?
> >>
> >>Best would be to investigate what version was actually intended.
> >>Lack of that, we should assume version 1, I believe.
> >
> >Since the copyright years start from 1999 (when LGPL v2.1 came
> >out) can we assume that the version is that one?
>
> Nope. GPL-3 is out now, but some still choose to license using GPL-2.
>
> Best is to get in touch with the author and get a clarification of
> the licensing, or a statement on relicensing.
>
> Project need not rerelease with that improved licensing info
> embedded: We can just quote an email from the author in our
> debian/copyright file as proof.
In the meantime I checked upstream [0] and it seems that the license is
LGPL-2.
> >The libzzip package in Debian does not provide any clarification [0].
> >
> >[0]
> >http://packages.debian.org/changelogs/pool/main/z/zziplib/zziplib_0.13.56-1/libzzip-0-13.copyright
>
> Two wrongs don't make a right.
>
> But hey - this brings another issue: Milkytracker should link
> against that system library!
It does. See the use-system-zziplib-and-zlib patch.
> So we can be lazy and simply strip that annoyingly licensed code from
> source (as we are repackaging anyway for other reasons).
>
> Please double-check if there are other library code embedded that we
> should patch to link against system libs instead.
I didn't find any other libraries, but maybe also the additional/ and
the whole resources/reference/ folders should be removed (no license or
copyright).
Anyhow, I am on my way out the door, I'll do all the work tomorrow.
Cheers
[0] http://sourceforge.net/projects/zziplib/
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Sat, Jan 08, 2011 at 07:22:10PM +0100, Alessandro Ghedini wrote: On Sat, Jan 08, 2011 at 06:46:20PM +0100, Jonas Smedegaard wrote: On Sat, Jan 08, 2011 at 05:56:07PM +0100, Alessandro Ghedini wrote: >>Files: src/milkyplay/drivers/generic/rtaudio/oss/soundcard.h >>Copyright: *No copyright* >>License: other-restricted! >>FIXME > >This is clearly not DFSG-compliant... I also think that it can be >removed and substituted with the soundcard.h provided by the >oss4-dev package (which seems to be free). Ok, should be ripped out, then. But instead of substituting I guess it is better to build-depend on oss4-dev and patch source to include that. Yeah, that was what I meant... the code builds fine also against the provided by libc-dev so there's no need to add another dependency. Ok. I was wondering why OSS4 was needed, but assumed you knew better. ...and now you do :-P >>Files: resources/reference/xmeffects.html >>Copyright: INTERNET ARCHIVE >> 2006, Yury Aliaev 2006 >>License: GFDL and UNKNOWN >> FIXME > >This has to be removed as well (GNU FDL is not DFSG-compatible). I believe GNU FSL _is_ DFSG-compliant as long as it has no invariant sections. Reason I tagged it as FIXME was the INTERNET ARCHIVE JavaScript code being copyright protected with no licensing! The code can be patched easily (it seem to not do anything). Ahem. It is documentation, not code. Besides, licensing is not only if we are allowed to link things together, but also if we are allowed to redistribute at all - so if licensing is missing, the file must be ripped out from source distribution as well, not acceptable to just patch it for the binary packages. >Also, for the generic 'LGPL' what version should be used? Best would be to investigate what version was actually intended. Lack of that, we should assume version 1, I believe. Since the copyright years start from 1999 (when LGPL v2.1 came out) can we assume that the version is that one? Nope. GPL-3 is out now, but some still choose to license using GPL-2. Best is to get in touch with the author and get a clarification of the licensing, or a statement on relicensing. Project need not rerelease with that improved licensing info embedded: We can just quote an email from the author in our debian/copyright file as proof. The libzzip package in Debian does not provide any clarification [0]. [0] http://packages.debian.org/changelogs/pool/main/z/zziplib/zziplib_0.13.56-1/libzzip-0-13.copyright Two wrongs don't make a right. But hey - this brings another issue: Milkytracker should link against that system library! So we can be lazy and simply strip that annoyingly licensed code from source (as we are repackaging anyway for other reasons). Please double-check if there are other library code embedded that we should patch to link against system libs instead. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Sat, Jan 08, 2011 at 07:22:10PM +0100, Alessandro Ghedini wrote:
> > >>Files: resources/reference/xmeffects.html
> > >>Copyright: INTERNET ARCHIVE
> > >> 2006, Yury Aliaev 2006
> > >>License: GFDL and UNKNOWN
> > >> FIXME
> > >
> > >This has to be removed as well (GNU FDL is not DFSG-compatible).
> >
> > I believe GNU FSL _is_ DFSG-compliant as long as it has no invariant
> > sections.
> >
> > Reason I tagged it as FIXME was the INTERNET ARCHIVE JavaScript code
> > being copyright protected with no licensing!
>
> The code can be patched easily (it seem to not do anything).
>
I said an idiocy. Anyway, I think that the code is not free [0]:
>Some of the content available through the Archive may be governed by local,
>national, and/or international laws and regulations, and your use of such
>content is solely at your own risk. You agree to abide by all applicable
>laws and regulations, including intellectual property laws, in connection
>with your use of the Archive. In particular, you certify that your use of
>any part of the Archive's Collections will be noncommercial and will be
>limited to noninfringing or fair use under copyright law.
I am not a lawyer but the noncommercial use sounds non-free to me.
[0] http://www.archive.org/about/terms.php
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Sat, Jan 08, 2011 at 06:46:20PM +0100, Jonas Smedegaard wrote:
> On Sat, Jan 08, 2011 at 05:56:07PM +0100, Alessandro Ghedini wrote:
> >I had a look at the FIXMEs and there are indeed some problems
> >(sorry, if I didn't notice that before):
> >
> >>Files: src/milkyplay/drivers/generic/rtaudio/asio/asio.cpp
> >>Copyright: 1997, - 2005, Steinberg Media Technologies GmbH
> >>License: UNKNOWN
> >>FIXME
> >
> >I couldn't find a license for the asio driver, but I think that it
> >can be safely removed, since it is not needed on Linux (this
> >applies for every file under the
> >'src/milkyplay/drivers/generic/rtaudio/asio/' folder).
>
> Ok.
>
> Repackaging can be done elegantly using CDBS. Should I do that or
> do you want to try?
I think I can do this.
> >>Files: src/milkyplay/drivers/generic/rtaudio/oss/soundcard.h
> >>Copyright: *No copyright*
> >>License: other-restricted!
> >>FIXME
> >
> >This is clearly not DFSG-compliant... I also think that it can be
> >removed and substituted with the soundcard.h provided by the
> >oss4-dev package (which seems to be free).
>
> Ok, should be ripped out, then. But instead of substituting I guess
> it is better to build-depend on oss4-dev and patch source to include
> that.
Yeah, that was what I meant... the code builds fine also against the
provided by libc-dev so there's no need to add
another dependency.
> >>Files: resources/reference/xmeffects.html
> >>Copyright: INTERNET ARCHIVE
> >> 2006, Yury Aliaev 2006
> >>License: GFDL and UNKNOWN
> >> FIXME
> >
> >This has to be removed as well (GNU FDL is not DFSG-compatible).
>
> I believe GNU FSL _is_ DFSG-compliant as long as it has no invariant
> sections.
>
> Reason I tagged it as FIXME was the INTERNET ARCHIVE JavaScript code
> being copyright protected with no licensing!
The code can be patched easily (it seem to not do anything).
> >There is something I don't understand: is it really needed to have
> >both 'GPL+Milkytracker-3+' and 'GPL-3+' licenses, since they are
> >the same license?
>
> It is a new understanding of mine, but I believe so: Debian Policy
> mandated including "verbatim copy" of the licensing info. Which
> means we may rewrap (and I consistently wrap at 72 chars) but not
> "replace" words.
>
> You are right that both declare same licensing, but that is the file
> shipped below /usr/share/common-licenses/ . The text here is is not
> the actual license, only an indirect licensing _statement_.
>
> Feel free to run it by the debian-legal@ list. I might be wrong...
It's fine for me, anyway it does not do any harm.
> >Also, for the generic 'LGPL' what version should be used?
>
> Best would be to investigate what version was actually intended.
> Lack of that, we should assume version 1, I believe.
Since the copyright years start from 1999 (when LGPL v2.1 came out) can
we assume that the version is that one?
The libzzip package in Debian does not provide any clarification [0].
[0]
http://packages.debian.org/changelogs/pool/main/z/zziplib/zziplib_0.13.56-1/libzzip-0-13.copyright
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Sat, Jan 08, 2011 at 05:56:07PM +0100, Alessandro Ghedini wrote: I had a look at the FIXMEs and there are indeed some problems (sorry, if I didn't notice that before): Files: src/milkyplay/drivers/generic/rtaudio/asio/asio.cpp Copyright: 1997, - 2005, Steinberg Media Technologies GmbH License: UNKNOWN FIXME I couldn't find a license for the asio driver, but I think that it can be safely removed, since it is not needed on Linux (this applies for every file under the 'src/milkyplay/drivers/generic/rtaudio/asio/' folder). Ok. Repackaging can be done elegantly using CDBS. Should I do that or do you want to try? Files: src/milkyplay/drivers/generic/rtaudio/oss/soundcard.h Copyright: *No copyright* License: other-restricted! FIXME This is clearly not DFSG-compliant... I also think that it can be removed and substituted with the soundcard.h provided by the oss4-dev package (which seems to be free). Ok, should be ripped out, then. But instead of substituting I guess it is better to build-depend on oss4-dev and patch source to include that. Files: resources/reference/xmeffects.html Copyright: INTERNET ARCHIVE 2006, Yury Aliaev 2006 License: GFDL and UNKNOWN FIXME This has to be removed as well (GNU FDL is not DFSG-compatible). I believe GNU FSL _is_ DFSG-compliant as long as it has no invariant sections. Reason I tagged it as FIXME was the INTERNET ARCHIVE JavaScript code being copyright protected with no licensing! There is something I don't understand: is it really needed to have both 'GPL+Milkytracker-3+' and 'GPL-3+' licenses, since they are the same license? It is a new understanding of mine, but I believe so: Debian Policy mandated including "verbatim copy" of the licensing info. Which means we may rewrap (and I consistently wrap at 72 chars) but not "replace" words. You are right that both declare same licensing, but that is the file shipped below /usr/share/common-licenses/ . The text here is is not the actual license, only an indirect licensing _statement_. Feel free to run it by the debian-legal@ list. I might be wrong... Also, for the generic 'LGPL' what version should be used? Best would be to investigate what version was actually intended. Lack of that, we should assume version 1, I believe. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Sat, Jan 08, 2011 at 04:44:54PM +0100, Jonas Smedegaard wrote:
> On Thu, Jan 06, 2011 at 09:26:45PM +0100, Jonas Smedegaard wrote:
> >On Thu, Jan 06, 2011 at 12:24:55PM +0100, Alessandro Ghedini wrote:
> >>Isn't this ready for upload now, since the switch to CDBS is
> >>completed?
> >
> >Sorry, I got distracted.
> >
> >No, I want to finish a copyright-check I am conducting - there
> >seem to be some issues. More on that when I am done.
>
> Please check all the FIXMEs in debian/copyright.
>
> Please don't just "make them go away" - ask if an issue isn't obvious.
I had a look at the FIXMEs and there are indeed some problems (sorry, if
I didn't notice that before):
> Files: src/milkyplay/drivers/generic/rtaudio/asio/asio.cpp
> Copyright: 1997, - 2005, Steinberg Media Technologies GmbH
> License: UNKNOWN
> FIXME
I couldn't find a license for the asio driver, but I think that it can
be safely removed, since it is not needed on Linux (this applies for every
file under the 'src/milkyplay/drivers/generic/rtaudio/asio/' folder).
> Files: src/milkyplay/drivers/generic/rtaudio/oss/soundcard.h
> Copyright: *No copyright*
>License: other-restricted!
> FIXME
This is clearly not DFSG-compliant... I also think that it can be removed
and substituted with the soundcard.h provided by the oss4-dev package
(which seems to be free).
> Files: resources/reference/xmeffects.html
> Copyright: INTERNET ARCHIVE
> 2006, Yury Aliaev 2006
> License: GFDL and UNKNOWN
> FIXME
This has to be removed as well (GNU FDL is not DFSG-compatible).
There is something I don't understand: is it really needed to have
both 'GPL+Milkytracker-3+' and 'GPL-3+' licenses, since they are the
same license?
Also, for the generic 'LGPL' what version should be used?
Thanks
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Thu, Jan 06, 2011 at 09:26:45PM +0100, Jonas Smedegaard wrote: On Thu, Jan 06, 2011 at 12:24:55PM +0100, Alessandro Ghedini wrote: Isn't this ready for upload now, since the switch to CDBS is completed? Sorry, I got distracted. No, I want to finish a copyright-check I am conducting - there seem to be some issues. More on that when I am done. Please check all the FIXMEs in debian/copyright. Please don't just "make them go away" - ask if an issue isn't obvious. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Thu, Jan 06, 2011 at 12:24:55PM +0100, Alessandro Ghedini wrote: Isn't this ready for upload now, since the switch to CDBS is completed? Sorry, I got distracted. No, I want to finish a copyright-check I am conducting - there seem to be some issues. More on that when I am done. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
Isn't this ready for upload now, since the switch to CDBS is completed?
Cheers
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Tue, Jan 04, 2011 at 12:32:10PM +0100, Jonas Smedegaard wrote:
> Good. Then I assume it is ok I introduce the use of control.in
> then. Since indeed it is quite useful to me to help maintain
> accurate build-dependencies which vary with the features enabled in
> each package.
Not sure. Wouldn't it just make things more complicated than needed?
I mean, the Build-depends look pretty simple, is it really needed to use
control.in?
But maybe I don't fully understand what control.in really do (since I never
used it), can you please explain?
Cheers
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Tue, Jan 04, 2011 at 12:14:57PM +0100, Alessandro Ghedini wrote: On Mon, Jan 03, 2011 at 11:36:56PM +0100, Jonas Smedegaard wrote: Was that the "many problems" or did you have other concerns regarding CDBS? Yep, that's all. Maybe the "many problems" was a bit too exaggerated :D Good. Then I assume it is ok I introduce the use of control.in then. Since indeed it is quite useful to me to help maintain accurate build-dependencies which vary with the features enabled in each package. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Mon, Jan 03, 2011 at 11:36:56PM +0100, Jonas Smedegaard wrote:
> Was that the "many problems" or did you have other concerns
> regarding CDBS?
Yep, that's all. Maybe the "many problems" was a bit too exaggerated :D
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Mon, Jan 03, 2011 at 05:48:23PM +0100, Alessandro Ghedini wrote: On Mon, Jan 03, 2011 at 04:52:15PM +0100, Jonas Smedegaard wrote: What "many problems" are you referring to? I was reffering to the use of the auto-updating Build-Depends via DEB_AUTO_UPDATE_DEBIAN_CONTROL (and #311724), but I noticed now that you use @cdbs@ without the DEB_AUTO_UPDATE_* thing. Correct, I do - for some years now - only enable this and other policy-violating features conditional to a special variable being set: DEB_MAINTAINER_MODE. Was that the "many problems" or did you have other concerns regarding CDBS? - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Mon, Jan 03, 2011 at 04:52:15PM +0100, Jonas Smedegaard wrote:
> What "many problems" are you referring to?
I was reffering to the use of the auto-updating Build-Depends via
DEB_AUTO_UPDATE_DEBIAN_CONTROL (and #311724), but I noticed now that you
use @cdbs@ without the DEB_AUTO_UPDATE_* thing.
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Mon, Jan 03, 2011 at 04:20:16PM +0100, Alessandro Ghedini wrote: On Sat, Jan 01, 2011 at 03:46:28AM +0100, Jonas Smedegaard wrote: I am uncertain how happy others here are about other changes that I would wanna do - starting with enabling build-dependency auto-resolving a.k.a. that debian/control.in file discussed tonight regarding a PureData package. So I hesitate doing more work just now. I am not sure how much a debian/control.in file would be helpful (AFAIK it is often cause of many problems). I think that the debian/control file looks pretty simple and there is no need to make things more complicated. What "many problems" are you referring to? What are the other changes you want to do? Please see recent commits of other packages for inspiration. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Sat, Jan 01, 2011 at 03:46:28AM +0100, Jonas Smedegaard wrote:
> I am uncertain how happy others here are about other changes that I
> would wanna do - starting with enabling build-dependency
> auto-resolving a.k.a. that debian/control.in file discussed tonight
> regarding a PureData package. So I hesitate doing more work just
> now.
I am not sure how much a debian/control.in file would be helpful (AFAIK
it is often cause of many problems). I think that the debian/control file
looks pretty simple and there is no need to make things more complicated.
What are the other changes you want to do?
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Sun, Jan 02, 2011 at 02:24:46PM +0100, Alessandro Ghedini wrote: On Fri, Dec 31, 2010 at 01:35:22PM -0300, Felipe Sateler wrote: I've pushed the basic switch (autotools + debhelper). Since you are more familiar with the get-orig-source rule, please you do it. The *.desktop file does not get installed on my system. I think that DEB_DH_INSTALL_ALL in debian/rules should be DEB_DH_INSTALL_ARGS. That seems right. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 01:35:22PM -0300, Felipe Sateler wrote:
> I've pushed the basic switch (autotools + debhelper). Since you are
> more familiar with the get-orig-source rule, please you do it.
The *.desktop file does not get installed on my system.
I think that DEB_DH_INSTALL_ALL in debian/rules should be
DEB_DH_INSTALL_ARGS.
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 01:35:22PM -0300, Felipe Sateler wrote: On Fri, Dec 31, 2010 at 11:09, Jonas Smedegaard wrote: On Fri, Dec 31, 2010 at 02:54:15PM +0100, Alessandro Ghedini wrote: On Fri, Dec 31, 2010 at 09:59:45AM -0300, Felipe Sateler wrote: I do prefer CDBS. But since I do not plan to do regular work on this package (and you do), I think your opinion on this matter weights more than mine. I do volunteer to do the switch to CDBS if that is your choice, though. I don't have much experience with CDBS (neither with dh though), but if you do the hard work I'm fine. So please do it. I'd be happy too to help with the switch (as with any other CDBS-specific tuning later on as well). Just tell me explicitly if needed. Or put differently: I'll wait for an explicitl "go!" from Felipe, to avoid us doing double work :-) I've pushed the basic switch (autotools + debhelper). Since you are more familiar with the get-orig-source rule, please you do it. Done! I am uncertain how happy others here are about other changes that I would wanna do - starting with enabling build-dependency auto-resolving a.k.a. that debian/control.in file discussed tonight regarding a PureData package. So I hesitate doing more work just now. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 01:35:22PM -0300, Felipe Sateler wrote: On Fri, Dec 31, 2010 at 11:09, Jonas Smedegaard wrote: On Fri, Dec 31, 2010 at 02:54:15PM +0100, Alessandro Ghedini wrote: On Fri, Dec 31, 2010 at 09:59:45AM -0300, Felipe Sateler wrote: I do prefer CDBS. But since I do not plan to do regular work on this package (and you do), I think your opinion on this matter weights more than mine. I do volunteer to do the switch to CDBS if that is your choice, though. I don't have much experience with CDBS (neither with dh though), but if you do the hard work I'm fine. So please do it. I'd be happy too to help with the switch (as with any other CDBS-specific tuning later on as well). Just tell me explicitly if needed. Or put differently: I'll wait for an explicitl "go!" from Felipe, to avoid us doing double work :-) I've pushed the basic switch (autotools + debhelper). Since you are more familiar with the get-orig-source rule, please you do it. Ok :-) - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 11:09, Jonas Smedegaard wrote: > On Fri, Dec 31, 2010 at 02:54:15PM +0100, Alessandro Ghedini wrote: >> >> On Fri, Dec 31, 2010 at 09:59:45AM -0300, Felipe Sateler wrote: >>> >>> I do prefer CDBS. But since I do not plan to do regular work on this >>> package (and you do), I think your opinion on this matter weights more than >>> mine. I do volunteer to do the switch to CDBS if that is your choice, >>> though. >> >> I don't have much experience with CDBS (neither with dh though), but if >> you do the hard work I'm fine. So please do it. > > I'd be happy too to help with the switch (as with any other CDBS-specific > tuning later on as well). Just tell me explicitly if needed. > > Or put differently: I'll wait for an explicitl "go!" from Felipe, to avoid > us doing double work :-) I've pushed the basic switch (autotools + debhelper). Since you are more familiar with the get-orig-source rule, please you do it. -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 10:54, Alessandro Ghedini wrote: > On Fri, Dec 31, 2010 at 09:59:45AM -0300, Felipe Sateler wrote: >> I do prefer CDBS. But since I do not plan to do regular work on this >> package (and you do), I think your opinion on this matter weights more >> than mine. I do volunteer to do the switch to CDBS if that is your >> choice, though. > > I don't have much experience with CDBS (neither with dh though), but if you > do the hard work I'm fine. So please do it. OK, I've started it. >> is there a reason that work was not incorporated here? > > Yes. It included some non-free sources (the lha code) and another directory > (autom4te.cache) I preferred to remove from orig.tar. Also, it didn't > integrate the work already done in git to clean up the package (removing > the bundled libraries, using the 3.0 (quilt) format and other changes to > packaging stuff). I found easier to start "from scratch" instead of > upgrading that version. OK then. -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 02:54:15PM +0100, Alessandro Ghedini wrote: On Fri, Dec 31, 2010 at 09:59:45AM -0300, Felipe Sateler wrote: I do prefer CDBS. But since I do not plan to do regular work on this package (and you do), I think your opinion on this matter weights more than mine. I do volunteer to do the switch to CDBS if that is your choice, though. I don't have much experience with CDBS (neither with dh though), but if you do the hard work I'm fine. So please do it. I'd be happy too to help with the switch (as with any other CDBS-specific tuning later on as well). Just tell me explicitly if needed. Or put differently: I'll wait for an explicitl "go!" from Felipe, to avoid us doing double work :-) - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 09:59:45AM -0300, Felipe Sateler wrote:
> I do prefer CDBS. But since I do not plan to do regular work on this
> package (and you do), I think your opinion on this matter weights more
> than mine. I do volunteer to do the switch to CDBS if that is your
> choice, though.
I don't have much experience with CDBS (neither with dh though), but if you
do the hard work I'm fine. So please do it.
> Please submit it, so that others benefit from Gurkan's work too.
Ok
> Ah yes. The description (and name) of the patch is misleading then.
Right, I changed that.
> is there a reason that work was not incorporated here?
Yes. It included some non-free sources (the lha code) and another directory
(autom4te.cache) I preferred to remove from orig.tar. Also, it didn't
integrate the work already done in git to clean up the package (removing
the bundled libraries, using the 3.0 (quilt) format and other changes to
packaging stuff). I found easier to start "from scratch" instead of
upgrading that version.
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
Also, I just read bug 567319... is there a reason that work was not incorporated here? -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 09:47, Alessandro Ghedini wrote: > On Fri, Dec 31, 2010 at 09:22:00AM -0300, Felipe Sateler wrote: >> Would you mind if I try switching to CDBS? This should greatly >> simplify debian/rules. > > I've already switched to short-form dh (patch attached). If you want to > convert it to use cdbs I don't mind (dh or cdbs are the same for me)... you > can use my work if you want. I do prefer CDBS. But since I do not plan to do regular work on this package (and you do), I think your opinion on this matter weights more than mine. I do volunteer to do the switch to CDBS if that is your choice, though. > >> - Has milkiplay been submitted upstream? > > I don't think so. It was there from the package's previous version, but > there's no trace of it on upstream website. Please submit it, so that others benefit from Gurkan's work too. > >> - There is no need to patch out libzzip and zlib, as long as the build >> system is patched to not use it. If you really want to get rid of it, >> then I think purging it at the orig.tar.gz is the right option, since >> we are already repackaging it. > > I have updated that patch to not remove the sources, but to only edit the > various Makefile.* and the "include" (commit c55c824ab1). Ah yes. The description (and name) of the patch is misleading then. -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 09:22:00AM -0300, Felipe Sateler wrote:
> Would you mind if I try switching to CDBS? This should greatly
> simplify debian/rules.
I've already switched to short-form dh (patch attached). If you want to
convert it to use cdbs I don't mind (dh or cdbs are the same for me)... you
can use my work if you want.
> - Has milkiplay been submitted upstream?
I don't think so. It was there from the package's previous version, but
there's no trace of it on upstream website.
> - There is no need to patch out libzzip and zlib, as long as the build
> system is patched to not use it. If you really want to get rid of it,
> then I think purging it at the orig.tar.gz is the right option, since
> we are already repackaging it.
I have updated that patch to not remove the sources, but to only edit the
various Makefile.* and the "include" (commit c55c824ab1).
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
>From 568cb34f212979fc9879481581a39be5d404fa45 Mon Sep 17 00:00:00 2001
From: Alessandro Ghedini
Date: Thu, 30 Dec 2010 23:27:07 +0100
Subject: [PATCH] Switch to short-form dh
---
debian/control |2 +-
debian/docs |1 +
debian/milkytracker.desktop |2 +-
debian/milkytracker.install |3 ++
debian/rules| 73 +-
5 files changed, 15 insertions(+), 66 deletions(-)
create mode 100644 debian/milkytracker.install
diff --git a/debian/control b/debian/control
index 13d3d97..6c1bb1f 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,7 @@ Priority: optional
Maintainer: Debian Multimedia Maintainers
Uploaders: Gürkan Sengün ,
Alessandro Ghedini
-Build-Depends: debhelper (>= 7),
+Build-Depends: debhelper (>= 7.0.50~),
autotools-dev,
libsdl1.2-dev,
libjack-dev,
diff --git a/debian/docs b/debian/docs
index 0cd58f2..c8feffa 100644
--- a/debian/docs
+++ b/debian/docs
@@ -1,3 +1,4 @@
docs/MilkyTracker.html
docs/FAQ.html
docs/readme_unix
+docs/ChangeLog.html
diff --git a/debian/milkytracker.desktop b/debian/milkytracker.desktop
index bdf1b8f..917f81d 100644
--- a/debian/milkytracker.desktop
+++ b/debian/milkytracker.desktop
@@ -6,7 +6,7 @@ Terminal=false
TryExec=milkytracker
Exec=milkytracker %f
Type=Application
-Icon=milkytracker.png
+Icon=/usr/share/pixmaps/milkytracker/carton.png
Categories=GNOME;AudioVideo;Audio;Video;
MimeType=audio/x-xm
X-Desktop-File-Install-Version=0.10
diff --git a/debian/milkytracker.install b/debian/milkytracker.install
new file mode 100644
index 000..17b75fe
--- /dev/null
+++ b/debian/milkytracker.install
@@ -0,0 +1,3 @@
+debian/milkytracker.desktop usr/share/applications
+resources/pictures/carton.png usr/share/pixmaps/milkytracker
+debian/milkyplay/milkyplay usr/bin
diff --git a/debian/rules b/debian/rules
index 0bdb142..ae7d3dd 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,75 +1,20 @@
#!/usr/bin/make -f
-# Uncomment this to turn on verbose mode.
-#export DH_VERBOSE=1
+export DH_OPTIONS
-# These are used for cross-compiling and for saving the configure script
-# from having to guess our platform (since we know it already)
-DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
-DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
+%:
+ dh $@
-config.status: configure
- dh_testdir
-ifneq "$(wildcard /usr/share/misc/config.sub)" ""
- cp -f /usr/share/misc/config.sub config.sub
-endif
-ifneq "$(wildcard /usr/share/misc/config.guess)" ""
- cp -f /usr/share/misc/config.guess config.guess
-endif
- ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs -lzzip"
+override_dh_auto_configure:
+ dh_auto_configure -- LDFLAGS="-Wl,-z,defs -lzzip"
-build: build-stamp
-
-build-stamp: config.status
- dh_testdir
- $(MAKE)
- $(MAKE) -C debian/milkyplay
- touch $@
-
-clean:
- dh_testdir
- dh_testroot
- rm -f build-stamp
- [ ! -f Makefile ] || $(MAKE) distclean
+override_dh_clean:
$(MAKE) -C debian/milkyplay clean
- rm -f config.sub config.guess
dh_clean
rm -rf src/compression/zziplib/generic/.deps/
-install: build
- dh_testdir
- dh_testroot
- dh_prep
- dh_installdirs
- $(MAKE) -C debian/milkyplay DESTDIR=$(CURDIR)/debian/milkytracker install
- $(MAKE) DESTDIR=$(CURDIR)/debian/milkytracker install
- dh_install resources/pictures/carton.png usr/share/icons/
- mv $(CURDIR)/debian/milkytracker/usr/share/icons/carton.png $(CURDIR)/debian/milkytracker/usr/share/icons/milkytracker.png
-
-# Build architecture-independent files here.
-binary-indep: build install
-# We have nothing to do by default.
-
-# Build architecture-dependent files here.
-binary-arch: build install
- dh_testdir
- dh_testroot
- dh_installchangelogs docs/ChangeLog.html
- dh_installdocs
- dh_installmenu
- dh_install debian/*.desktop usr/share/applications/
- dh_installman
- dh_link
- dh_strip
- dh_compr
Re: new version of milkytracker
On Fri, Dec 31, 2010 at 08:38, Alessandro Ghedini wrote: > On Thu, Dec 30, 2010 at 06:05:11PM -0300, Felipe Sateler wrote: >> Is there a special reason this package does not use any packaging helper? > > Nope. I just kept the rules file from the previous version. Would you mind if I try switching to CDBS? This should greatly simplify debian/rules. Comments: - Has milkiplay been submitted upstream? - There is no need to patch out libzzip and zlib, as long as the build system is patched to not use it. If you really want to get rid of it, then I think purging it at the orig.tar.gz is the right option, since we are already repackaging it. -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Thu, Dec 30, 2010 at 06:05:11PM -0300, Felipe Sateler wrote:
> Is there a special reason this package does not use any packaging helper?
Nope. I just kept the rules file from the previous version.
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of milkytracker
On Thu, Dec 30, 2010 at 12:07, Alessandro Ghedini wrote: > Hi all, > in the last couple of days I worked to package the new upstream version > of milkytracker. > > Can someone please test and review it? You can find everything on git [0]. Is there a special reason this package does not use any packaging helper? -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
new version of milkytracker
Hi all,
in the last couple of days I worked to package the new upstream version
of milkytracker.
Can someone please test and review it? You can find everything on git [0].
Thanks
[0] http://git.debian.org/?p=pkg-multimedia/milkytracker.git;a=summary
--
perl -E'$_=q;$/= @{...@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
