Re: [Pkg-osm-maint] SJJB Map Icons Package
On Sun, Sep 25, 2011 at 3:40 PM, David Paleino wrote: > "-" does not really have a special meaning. It's used as a word separator -- > for example, openstreetmap-map-icons-scalable. Nothing special there :) > > I'd go for sjjb-map-icons. Thanks. I've updated this and the changes from the previous email and pushed the result to http://git.debian.org/pkg-osm/sjjb-map-icons.git ___ Pkg-osm-maint mailing list Pkg-osm-maint@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-osm-maint
Re: [Pkg-osm-maint] SJJB Map Icons Package
On Sun, 25 Sep 2011 13:39:48 +1000, Andrew Harvey wrote: > Hi David, Hello, > On Sun, Sep 25, 2011 at 5:31 AM, David Paleino wrote: > > - you need to add Vcs-* fields in debian/control, after you create a > > repository on vasks, and push there. > > Done. But I haven't made the git repo on vasks yet. Before doing that > I think we should decide on the package name. Originally I used > sjjb-map-icons but then I used sjjbmapicons as existing package names > have '-' for some special usage. eg. -data -dbg -doc, and also > libboost-foo, python- to split up the boost, python libraries, etc. > > I'm not really sure which is better sjjb-map-icons or sjjbmapicons, > but I think maybe the second due to the special use of '-' in existing > packages. What do you think? After I know what to use, I'll make it > consistent within the package and make the git repo on vasks, with all > my changes. "-" does not really have a special meaning. It's used as a word separator -- for example, openstreetmap-map-icons-scalable. Nothing special there :) I'd go for sjjb-map-icons. Kindly, David -- . ''`. Debian developer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://deb.li/dapal `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature ___ Pkg-osm-maint mailing list Pkg-osm-maint@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-osm-maint
Re: [Pkg-osm-maint] SJJB Map Icons Package
Hi David, On Sun, Sep 25, 2011 at 5:31 AM, David Paleino wrote: > - as for leaflet, you should've filed an ITP, not an RFP. Please fix this :) Done. Thanks. > - "Debian OpenStreetMap Team " should > be > set as the package maintainer in debian/control Done. > - you need to add Vcs-* fields in debian/control, after you create a > repository > on vasks, and push there. Done. But I haven't made the git repo on vasks yet. Before doing that I think we should decide on the package name. Originally I used sjjb-map-icons but then I used sjjbmapicons as existing package names have '-' for some special usage. eg. -data -dbg -doc, and also libboost-foo, python- to split up the boost, python libraries, etc. I'm not really sure which is better sjjb-map-icons or sjjbmapicons, but I think maybe the second due to the special use of '-' in existing packages. What do you think? After I know what to use, I'll make it consistent within the package and make the git repo on vasks, with all my changes. > - in debian/rules, I'm not sure you need to override_dh_clean. Maybe > listing that directory in debian/clean works (it works with files for sure, > can't tell for directories) Listing the directory in debian/clean didn't work dh_clean says: rm: cannot remove `pngall': Is a directory dh_clean: rm -f -- pngall returned exit code 1 > - in debian/rules, get-orig-source target: to avoid harcoding the upstream > tarball name, you can pass "--rename" to uscan. This will cause the tarball > to be named like "foo_1.2.orig.tar.gz" -- which you already remove. You save > a couple lines of code :) Done. > - again get-orig-source: why are you passing --group, --user and --mode to tar > when you repack the tarball? I'm not sure, but I've changed it now to avoid doing this. > Please fix these issues; I'll review the package once again. I can upload these changes to git.debian.org once we sort out the package name. Thanks for you help. ___ Pkg-osm-maint mailing list Pkg-osm-maint@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-osm-maint
Re: [Pkg-osm-maint] SJJB Map Icons Package
On Sun, 31 Jul 2011 18:23:06 +1000, Andrew Harvey wrote: > Hi, Hello Andrew, > I've made a debian package for the SJJB Map icons > http://www.sjjb.co.uk/mapicons/downloads. > > At the moment, I don't think anything packaged in debian uses these > icons, but in the future it may prove to be useful. I'm sure I've made > some packaging mistakes so I'm open to feedback. > > For now my files are at http://173.230.151.169/deb-repo/ I took the package from mentors, as you stated later. - as for leaflet, you should've filed an ITP, not an RFP. Please fix this :) - "Debian OpenStreetMap Team " should be set as the package maintainer in debian/control - you need to add Vcs-* fields in debian/control, after you create a repository on vasks, and push there. - in debian/rules, I'm not sure you need to override_dh_clean. Maybe listing that directory in debian/clean works (it works with files for sure, can't tell for directories) - in debian/rules, get-orig-source target: to avoid harcoding the upstream tarball name, you can pass "--rename" to uscan. This will cause the tarball to be named like "foo_1.2.orig.tar.gz" -- which you already remove. You save a couple lines of code :) - again get-orig-source: why are you passing --group, --user and --mode to tar when you repack the tarball? Please fix these issues; I'll review the package once again. Kindly, David -- . ''`. Debian developer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://deb.li/dapal `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature ___ Pkg-osm-maint mailing list Pkg-osm-maint@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-osm-maint
Re: [Pkg-osm-maint] SJJB Map Icons Package
I've migrated this package to mentors.debian.net at http://mentors.debian.net/package/sjjbmapicons On Sun, Jul 31, 2011 at 6:23 PM, Andrew Harvey wrote: > Hi, > > I've made a debian package for the SJJB Map icons > http://www.sjjb.co.uk/mapicons/downloads. > > At the moment, I don't think anything packaged in debian uses these > icons, but in the future it may prove to be useful. I'm sure I've made > some packaging mistakes so I'm open to feedback. > > For now my files are at http://173.230.151.169/deb-repo/ > ___ Pkg-osm-maint mailing list Pkg-osm-maint@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-osm-maint
[Pkg-osm-maint] SJJB Map Icons Package
Hi, I've made a debian package for the SJJB Map icons http://www.sjjb.co.uk/mapicons/downloads. At the moment, I don't think anything packaged in debian uses these icons, but in the future it may prove to be useful. I'm sure I've made some packaging mistakes so I'm open to feedback. For now my files are at http://173.230.151.169/deb-repo/ ___ Pkg-osm-maint mailing list Pkg-osm-maint@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-osm-maint
