KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 115 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/115/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Feb 2018 06:34:22 + Build duration: 54 min and counting JUnit Tests

D5209: Load translations from KPackage files if bundled

avaragic added a dependency: D10215: Make KReport use marble component, KEXI & KEXI frameworks stable is 3.1. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks,

D10181: Removed the "fastblur" path

avaragic added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D10181#198862, @fredrik wrote: > Code wise this LGTM. > > Consider it accepted if the VDG has no objections. REPOSITORY R108 KWin REVISION DETAIL

D10236: [libinput] Ensure Event::device returns a proper Device

Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10236 To: graesslin, #kwin, #plasma, fvogt Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg,

D10236: [libinput] Ensure Event::device returns a proper Device

graesslin updated this revision to Diff 26362. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Make m_device mutable and always lazy load it. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10236?vs=26337=26362

Re: Plasma 4 bug reports: Open for bugs

Am 2018-02-01 22:19, schrieb David Edmundson: In bugzilla a product can be "Open for bug entry" or not. It can also be done at a per-version level. When unset a user will not see it in the "enter bug" list, or the version won't be listed. If they force it, they'll get a message like:

D10243: Disconnected wi-fi icons are almost invisible BUG:384018

ngraham added a comment. We need screenshots! This is impossible to review without applying the diff without before-and-after screenshots. Also, the title becomes the commit message, and should therefore follow standard commit message guidelines: describe the fix, use the imperative

D10224: Give a default player name

nicolasfella added a comment. Well, I am trying to fix PBI. The problem is that my Firefox (58.0.1) does not get recognized as such. Chrome works fine. I will try to dig into the underlying issue. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D10243: Disconnected wi-fi icons are almost invisible BUG:384018

andreask edited the summary of this revision. andreask added reviewers: Plasma, Plasma Accessibility, sebas, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. F5687564: What it looks like.png Nice! There are a few polish changes I'd like to see: - Add a header label saying "Top reviews",

Plasma 4 bug reports: Open for bugs

In bugzilla a product can be "Open for bug entry" or not. It can also be done at a per-version level. When unset a user will not see it in the "enter bug" list, or the version won't be listed. If they force it, they'll get a message like: https://bugs.kde.org/enter_bug.cgi?product=Aktion

D10236: [libinput] Ensure Event::device returns a proper Device

fvogt added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D10236#199259, @graesslin wrote: > In https://phabricator.kde.org/D10236#199252, @fvogt wrote: > > > Now you can remove the initial setting of `m_device` as well.

D10236: [libinput] Ensure Event::device returns a proper Device

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D10236#199252, @fvogt wrote: > Now you can remove the initial setting of `m_device` as well. I thought about it while doing the change. I decided against

D10225: Define property in Units.qml for the Plasma styles

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a02e91a271c3: Define property in Units.qml for the Plasma styles (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D10236: [libinput] Ensure Event::device returns a proper Device

fvogt added a comment. Restricted Application edited projects, added KWin; removed Plasma. Now you can remove the initial setting of `m_device` as well. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10236 To: graesslin, #kwin, #plasma, fvogt Cc: plasma-devel, kwin,

D10217: Choose source with a combobox, but only on the desktop view

ngraham added a comment. We were not able to achieve consensus, I'm afraid. If you'd like to be involved in Discover's design, please let me know and I'll invite you to the Discover-Design Telegram room, where we discuss these things. REPOSITORY R134 Discover Software Store REVISION

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 114 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/114/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Feb 2018 18:02:57 + Build duration: 4 min 6 sec and counting CONSOLE

D10237: Bring back embedded top3 reviews on the ApplicationPage

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10237

D10057: Require libinput and udev

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. If nobody objects by Sunday I'm going to push this. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10057 To: graesslin, #kwin, #plasma Cc: mart, plasma-devel, kwin, ZrenBot,

D10234: LibInput: Queue native libinput events instead of LibInput::Event

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. alternative approach in https://phabricator.kde.org/D10236 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10234 To: fvogt, #plasma, graesslin Cc: kwin, plasma-devel, #kwin,

D10236: [libinput] Ensure Event::device returns a proper Device

graesslin created this revision. graesslin added reviewers: KWin, Plasma, fvogt. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed

D10235: [server] Add support for the frame semantics of Pointer version 5

graesslin created this revision. graesslin added reviewers: KWin, Plasma, Frameworks. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. Restricted Application edited projects,

D10234: LibInput: Queue native libinput events instead of LibInput::Event

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D10234#199165, @fvogt wrote: > In https://phabricator.kde.org/D10234#199148, @graesslin wrote: > > > I had another idea: when the Event gets processed and the

D10234: LibInput: Queue native libinput events instead of LibInput::Event

fvogt added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D10234#199148, @graesslin wrote: > I had another idea: when the Event gets processed and the m_device is null, we just update it again from the event. > >

D10170: Added optional transparency/blur to menu frames

hpereiradacosta added a comment. In https://phabricator.kde.org/D10170#199153, @anemeth wrote: > Now only enabled blur when the frame is transparent. > > @hpereiradacosta > drawPanelMenuPrimitive only runs once per panel creation and not 60 times per second, right? Well it

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

This revision was automatically updated to reflect the committed changes. Closed by commit R116:e1673f18e942: Adjust spacing between text and plotter line in Speed tab of nm applet (authored by kamathraghavendra, committed by nicolasfella). REPOSITORY R116 Plasma Network Management Applet

D10225: Define property in Units.qml for the Plasma styles

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D10225 To: apol, #plasma, mart Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff,

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.9 - Build # 58 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/58/ Project: Plasma discover stable-kf5-qt5 SUSEQt5.9 Date of build: Thu, 01 Feb 2018 16:07:10 + Build duration: 7 min 6 sec and counting JUnit Tests

KDE CI: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20FreeBSDQt5.9/45/ Project: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Feb 2018 16:05:59 + Build duration: 4 min 59 sec and counting JUnit

D10170: Added optional transparency/blur to menu frames

anemeth marked 4 inline comments as done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26329. anemeth added a comment. Now only enabled blur when the frame is transparent. @hpereiradacosta drawPanelMenuPrimitive only runs once per panel creation and not 60 times per second, right? This is what enabled blur behind a window:

tars up for Plasma 5.12.0

Hello, Tars are up for Plasma 5.12.0 on racnoss for packagers to package. release is signed by my key, fingerprint is in signature. https://www.kde.org/info/plasma-5.12.0.php Plasma devs: any last minute bug fixes ask me for a re-roll of tars. Errata

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.9 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/57/ Project: Plasma discover stable-kf5-qt5 SUSEQt5.9 Date of build: Thu, 01 Feb 2018 16:01:49 + Build duration: 5 min 20 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 - Build # 44 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20FreeBSDQt5.9/44/ Project: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Feb 2018 16:01:49 + Build duration: 3 min 16 sec and counting CONSOLE

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

jgrulich accepted this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D10183 To: kamathraghavendra, davidedmundson, #plasma, broulik, jgrulich, ngraham Cc: ngraham, plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai,

D10234: LibInput: Queue native libinput events instead of LibInput::Event

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. I had another idea: when the Event gets processed and the m_device is null, we just update it again from the event. Something like if (!event->device()) { event->updateDevice();

D10234: LibInput: Queue native libinput events instead of LibInput::Event

fvogt edited the summary of this revision. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10234 To: fvogt, #plasma, graesslin Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai,

D10234: LibInput: Queue native libinput events instead of LibInput::Event

fvogt created this revision. fvogt added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin. fvogt requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY

D10232: Include a pixel more in the dirty area

mart created this revision. mart added reviewers: Plasma, Konsole. Restricted Application added projects: Plasma, Konsole. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY withfractional scaling sometimes there are visual

D10223: Improve preview thumbnail quality

hein added a comment. In https://phabricator.kde.org/D10223#199103, @hein wrote: > In https://phabricator.kde.org/D10223#199099, @kossebau wrote: > > > Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 x large in pixels, given you scale 2x in two dimensions

D10223: Improve preview thumbnail quality

hein added a comment. In https://phabricator.kde.org/D10223#199099, @kossebau wrote: > Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 x large in pixels, given you scale 2x in two dimensions ;) https://www.youtube.com/watch?v=RbTUTNenvCY=9s REPOSITORY

D10223: Improve preview thumbnail quality

kossebau added a comment. Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 x large in pixels, given you scale 2x in two dimensions ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10223 To: hein, #plasma Cc: kossebau,

D10225: Define property in Units.qml for the Plasma styles

apol created this revision. apol added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. apol requested review of this revision. REVISION SUMMARY Much like it is specified by kirigami itself TEST

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/26/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Feb 2018 12:47:18 + Build duration: 22 min and counting

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 113 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/113/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Feb 2018 12:17:16 + Build duration: 45 min and counting CONSOLE OUTPUT

D10170: Added optional transparency/blur to menu frames

hpereiradacosta added a comment. In https://phabricator.kde.org/D10170#199003, @fredrik wrote: > > I think the "blur" option should go. Blur should be controlled centrally by the desktop effect. In other words: BlurBehind should always be set to true, and then left to kwin to handle.

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/25/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Feb 2018 12:08:38 + Build duration: 38 min and counting

D10170: Added optional transparency/blur to menu frames

fredrik added a comment. > I think the "blur" option should go. Blur should be controlled centrally by the desktop effect. In other words: BlurBehind should always be set to true, and then left to kwin to handle. Having an extra option here seems like micro-management. Why would you need

D10224: Give a default player name

apol requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10224 To: nicolasfella, broulik, apol Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10224: Give a default player name

apol added a comment. Is this a workaround because Plasma Browser Integration doesn't provide an identity? Because if so I'd say the PBI should be fixed. Here if anything it should add "Default" or "Unknown". REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D10224: Give a default player name

nicolasfella created this revision. nicolasfella added a reviewer: broulik. nicolasfella added a project: Plasma. nicolasfella requested review of this revision. REVISION SUMMARY Default to "Plasma Browser Integration" as a default MPRIS player identity. This makes KDE Connect look prettier.

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In https://phabricator.kde.org/D10170#198972, @hpereiradacosta wrote: > IMHO this change somewhat muddies Breeze's identity (flat and simple, not bloated) for no real gain. This said, I do appreciate your work. The exact opposite. By default the Breeze

D10170: Added optional transparency/blur to menu frames

hpereiradacosta added reviewers: colomar, alake. hpereiradacosta added a subscriber: alake. hpereiradacosta added a comment. Hello, thanks for taking care of 1, 2 and 3. for 4 (the use case), I am adding @alake (one of the original designers of the breeze style) and @colomar as

D10223: Improve preview thumbnail quality

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This patch does two things: - Instead of giving the KAbstractViewAdapter the actual icon size, we overprovision by giving it