D10397: Use Qt.openUrlExternally instead of Kio

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D10397 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10396: Support "phone" form factor

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10396 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10395: Use plasmoid.icon instead of Logic.icon()

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D10395 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10400: Use KDEInstallDir variables instead of custom calculated install paths

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Consistent usage of install variables avoids mismatches for

D10398: [krunner] No need to duplicate work of KAboutData::setApplicationData

kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also let KAboutData handle app arguments REPOSITORY R120

D7481: RFC: Batch window changes events on XCB

broulik added a comment. Pingeliping. INLINE COMMENTS > xwindowsystemeventbatcher.cpp:34 > +connect(KWindowSystem::self(), ::windowRemoved, this, > [this](WId wid) { > +if (m_cache.contains(wid)) { > +emit windowChanged(wid, m_cache[wid].properties, >

D10397: Use Qt.openUrlExternally instead of Kio

broulik created this revision. broulik added reviewers: Plasma, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY No need to import a separate module for this. TEST PLAN

D10396: Support "phone" form factor

broulik created this revision. broulik added reviewers: Plasma, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY My Bluetooth paired phone has a form factor of "phone" and

D10395: Use plasmoid.icon instead of Logic.icon()

broulik created this revision. broulik added reviewers: Plasma, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoid creating an instance of logic.js which is not a

D10386: Fix LnF theme data for window decoration

This revision was automatically updated to reflect the committed changes. Closed by commit R31:ed754c8ba48d: Fix LnF theme data for window decoration (authored by kossebau). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10386?vs=26758=26790 REVISION DETAIL

D10384: Fix LnF theme data for window decoration

This revision was automatically updated to reflect the committed changes. Closed by commit R113:0f9d5c8e1bdc: Fix LnF theme data for window decoration (authored by kossebau). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10384?vs=26756=26789 REVISION

D9638: [effects] replace old slide effect with a new one

zzag added reviewers: graesslin, ngraham. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin,

D9638: [effects] replace old slide effect with a new one

zzag updated this revision to Diff 26788. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. rebase onto master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9638?vs=26137=26788 BRANCH effects/slide REVISION DETAIL

D10386: Fix LnF theme data for window decoration

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R31 Breeze BRANCH fixlnfthemewindeco REVISION DETAIL https://phabricator.kde.org/D10386 To: kossebau, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10384: Fix LnF theme data for window decoration

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R113 Oxygen Theme BRANCH fixlnfthemewindeco REVISION DETAIL https://phabricator.kde.org/D10384 To: kossebau, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10386: Fix LnF theme data for window decoration

kossebau added a comment. Once confirmed, would also fix the same with the normal Breeze package (which I only now found, being in plasma-workspace, while I expected plasma-desktop). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10386 To: kossebau, mart Cc:

D10388: allow to have more than one default activity

ivan added inline comments. INLINE COMMENTS > Activities.cpp:125 > +//NOTE: config key still singular for retrocompatibility > +const QStringList names = cg.readEntry("defaultActivityName", > QStringList({i18n("Default")})); > + `QStringList{i18n("Default")}` should be enough

D10297: Add new "Tools" button above System Monitor's process list

anthonyfieroni added inline comments. INLINE COMMENTS > ksysguardprocesslist.cpp:199 > KSysGuardProcessListPrivate(KSysGuardProcessList* q, const QString > ) > -: mModel(q, hostName), mFilterModel(q), mUi(new > Ui::ProcessWidget()), mProcessContextMenu(nullptr),

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. In https://phabricator.kde.org/D10297#203193, @ngraham wrote: > macOS uses a little gear icon for these kinds of menus: +1, if Breeze had offered it (or did I just fail to find it so far?), I would've chosen it for Spectacle. To me it seems quite

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. macOS uses a little gear icon for these kinds of menus: F5698887: lrlLcWn.png I've always rather liked it. Seems to connote "Action, tools, stuff here!" Would be even better with text, like we have. REPOSITORY R111

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau added a comment. Okay, got my test user setup working again and thus finally can test how the code behaves in real life, next to the unit test. Turns out that the "bug" is not opposed to the user by some magic things happening. In the normal usage the new setting is somehow

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. I just did a quick search for "menu" in the icon name: F5698881: grafik.png Sadly, the one, that is not so bold, looks rather strange. REPOSITORY R111 KSysguard Library REVISION DETAIL

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. In https://phabricator.kde.org/D10297#203184, @andreaska wrote: > Where do you need an icon? The two examples didnt work cause you mix different stuff in one non saying drop down button this doesnt work. > > E.g. spectacle you mix print with screen recording.

D10297: Add new "Tools" button above System Monitor's process list

andreaska added a comment. Where do you need an icon? The two examples didnt work cause you mix different stuff in one non saying drop down button this doesnt work. E.g. spectacle you mix print with screen recording. This is unrelated. Why should l open a screen recording software with

D10391: Ensure Registry gets destroyed before the Wayland connection

This revision was automatically updated to reflect the committed changes. Closed by commit R102:a7e887975d01: Ensure Registry gets destroyed before the Wayland connection (authored by graesslin). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D10346: check for EGL_KHR_platform_gbm extension as well

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > davidedmundson wrote in egl_gbm_backend.cpp:107 > this is going to crash and burn

Re: 5.8 LTS support period

Am 2018-02-08 17:54, schrieb Jonathan Riddell: We had one last 5.8 release scheduled for April but instead we did it this week and I think the idea of releases as required by security updates is a sensible way forward. But for how much longer? Any distro packagers have an opinion of how long

Re: Powerdevil bug help needed

It looks like I was wrong. I've ended up copying compiled service files into /usr/share/dbus-1 and I still couldn't trigger neither backlight notification nor powerdevil. dbus-monitor shows no activity either. On my regular plasma desktop I can see dbus messages like [1]. I'm also including my

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. @andreaska We are looking for an icon (new or existing) which says "Here are various tools and functions related to the app", like the Tools menu you find in Kate and other apps, but as a button. Examples: F5698814: grafik.png

D10223: Improve preview thumbnail quality

christianlopez added a comment. Hi, i was playing a bit with the code and i'm noticing you can get good looking images without activating the smooth and without making the thumbnails look blurry, also i think i know the reason why the thumbnails look distorted. At the line 239 in

D10391: Ensure Registry gets destroyed before the Wayland connection

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R102 KInfoCenter BRANCH fix-wayland-5.12 REVISION DETAIL https://phabricator.kde.org/D10391 To: graesslin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D10391: Ensure Registry gets destroyed before the Wayland connection

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY Registry was parented to WaylandModule, but the

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a subscriber: andreaska. ngraham added a comment. In https://phabricator.kde.org/D10297#203143, @rkflx wrote: > In https://phabricator.kde.org/D10297#203140, @gregormi wrote: > > > Do we really need that icon? > > > My two cents: A button without icon looks

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. In https://phabricator.kde.org/D10297#203140, @gregormi wrote: > Do we really need that icon? My two cents: A button without icon looks broken/naked/unfinished. Can we request a new one? REPOSITORY R111 KSysguard Library REVISION DETAIL

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. In https://phabricator.kde.org/D10297#203138, @ngraham wrote: > One more thought. For for consistency, maybe the tools menu should have a horrible hamburger menu icon like the otherwise identiacal one we added to Spectacle recently? Do we really need

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. One more thought. For for consistency, maybe the tools menu should have a horrible hamburger menu icon like the otherwise identiacal one we added to Spectacle recently? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To:

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. Looks awesome, +1 from me feature-wise. Just a few a naive code comments for now. INLINE COMMENTS > ksysguardprocesslist.cpp:360 > > - > //Sort by username by default Let's do unrelated whitespace/style cleanup in another patch. >

D10297: Add new "Tools" button above System Monitor's process list

gregormi edited the summary of this revision. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

gregormi updated this revision to Diff 26779. gregormi edited the summary of this revision. gregormi added a comment. - Do not show KSysGuard item if we are within KSysGuard REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10297?vs=26767=26779

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. In https://phabricator.kde.org/D10297#203118, @ngraham wrote: > Feature-wise, I love it. My only objection is that I'd really like to somehow remove the redundant KSysGuard entry from the menu if it was opened as a standalone app, not via the [alt] + [⎋]

D10346: check for EGL_KHR_platform_gbm extension as well

garg added a comment. Restricted Application edited projects, added KWin; removed Plasma. BTW this patch works as tested on both the Rock64 and Pinebook, but kwin fails in another place now. Will continue investigating. REPOSITORY R108 KWin REVISION DETAIL

Re: Default SDDM and KScreenLocker backgrounds

Talking of which, could the VDG get start thinking about the 5.13 wallpaper. But I liked those anyway, so that's easily solved. >> > > I'd strongly approve, and that would solve a multitude of bugs and user > complaints about the default theme being unreadable on light backgrounds: > -

[Breeze] [Bug 381407] SDDM's Breeze theme should have a prettier background than just a flat blue color

https://bugs.kde.org/show_bug.cgi?id=381407 David Edmundson changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: Default SDDM and KScreenLocker backgrounds

On 02/08/2018 08:07 AM, David Edmundson wrote: I hope you're aware the move to the blue the VDG request at the time too. Yes, I'm aware. It came up numerous times in our multi-day discussion! :) We need to be careful we're not treating the user's desktop as some sort of experimental

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. Feature-wise, I love it. My only objection is that I'd really like to somehow remove the redundant KSysGuard entry from the menu if it was opened as a standalone app, not via the [alt] + [⎋] shortcut. REPOSITORY R111 KSysguard Library REVISION DETAIL

D10297: Add new "Tools" button above System Monitor's process list

gregormi edited the summary of this revision. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. In https://phabricator.kde.org/D10297#203110, @ngraham wrote: > How about a new screenshot in the Summary section? ;) How could I forget that :-). I'll add one. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297

5.8 LTS support period

We had one last 5.8 release scheduled for April but instead we did it this week and I think the idea of releases as required by security updates is a sensible way forward. But for how much longer? Any distro packagers have an opinion of how long they'd like it to be supported? Jonathan

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. How about a new screenshot in the Summary section? ;) REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

[Breeze] [Bug 381407] SDDM's Breeze theme should have a prettier background than just a flat blue color

https://bugs.kde.org/show_bug.cgi?id=381407 --- Comment #4 from Nate Graham --- We actually managed to get some VDG consensus on this recently: https://phabricator.kde.org/T7914 I sent an email th plasma-devel about it, but we could open a new Bugzilla ticket if

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a reviewer: Plasma. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

graesslin removed a reviewer: floeser. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi Cc: rkflx, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: plasma-desktop-5.12.0 bug report

Hi, thanks for the report! however, please consider to use bugzilla at bugs.kde.org product: plasmashell On giovedì 8 febbraio 2018 10:07:23 CET David Binderman wrote: > Hello there, > > > > plasma-desktop-5.12.0/kcms/kfontinst/lib/Misc.cpp:294]: (style) Same > expression on both sides of

D10388: allow to have more than one default activity

davidedmundson added inline comments. INLINE COMMENTS > Activities.cpp:233 > > setActivityState(activity, Running); > We'll end up toggling between activities on startup. Can we avoid this? REPOSITORY R161 KActivity Manager Service REVISION DETAIL

D10388: allow to have more than one default activity

mart added reviewers: ivan, bshah. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D10388 To: mart, #plasma, ivan, bshah Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10388: allow to have more than one default activity

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY since addActivity in layout.js is the wrong place and extremely fragile,

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. In https://phabricator.kde.org/D10297#203027, @ngraham wrote: > Maybe make it a PushButton instead of a ToolButton, and it will magically work? Here's how @rkflx implemented an appropriate Tools menu in Spectacle recently: D10371: Move printing to a new tools

D10297: Add new "Tools" button above System Monitor's process list

gregormi updated this revision to Diff 26767. gregormi added a comment. - Use to PushButton instead of QToolButton to put the down arrow to right side. Still no manual setting of the icon needed. REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

Re: Default SDDM and KScreenLocker backgrounds

I hope you're aware the move to the blue the VDG request at the time too. We need to be careful we're not treating the user's desktop as some sort of experimental playground for flip-flopping about indecisively on. But ultimately, sure. One technical objection: Unless there's a significant

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 26765. gregormi added a comment. Rebase to master. Tested again successfully. Ready from my side. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=26764=26765 BRANCH arcpatch-D7087 REVISION DETAIL

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a subscriber: rkflx. ngraham added a comment. Maybe make it a PushButton instead of a ToolButton, and it will magically work? Here's how @rkflx implemented an appropriate Tools menu in Spectacle recently: D10371: Move printing to a new tools button

D7087: Add "Copy Info" button to the About System KCM

gregormi marked 2 inline comments as done. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, dhaumann Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7087: Add "Copy Info" button to the About System KCM

gregormi marked an inline comment as done. gregormi added inline comments. INLINE COMMENTS > gregormi wrote in Module.cpp:29 > This was a suggestion from the discussion on ReviewBoard. Is there an obvious > way to tell arc to do this in a separate commit? Otherwise I'll try to > separate this

D7087: Add "Copy Info" button to the About System KCM

gregormi marked an inline comment as done. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, dhaumann Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 26764. gregormi added a comment. - remove unrelated change REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=26493=26764 BRANCH arcpatch-D7087 REVISION DETAIL https://phabricator.kde.org/D7087 AFFECTED

D7087: Add "Copy Info" button to the About System KCM

gregormi added a comment. In https://phabricator.kde.org/D7087#201065, @gregormi wrote: > In https://phabricator.kde.org/D7087#200541, @gregormi wrote: > > > - Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does not work (I will remove it if that's not easily

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. The "All processes" button is a QCombobox. It feels like a dirty hack to turn QCombobox into a drop down menu just to get the arrow at the correct position. @ngraham: Just to be sure, do you think this is the way to go? REPOSITORY R111 KSysguard Library REVISION

Re: plasma-desktop-5.12.0 bug report

Hi David, Thanks for the report! In KDE, we typically track these kinds of issues with bugzilla tickets, so I would recommend that you file one for it. Here is the documentation for that: https://community.kde.org/Get_Involved#Bug_Reporting If you would like to submit a patch for the issue,

D10383: Fix pinning apps when their .desktop file has a space in the file name.

hein added a reviewer: ivan. hein added a comment. Ivan, could you weigh in on the KActivities spaces angle? INLINE COMMENTS > broulik wrote in startuptasksmodel.cpp:208 > `QUrl::toPercentEncoding` encodes *all* UTF-8 characters and slashes and what > not whereas in `toString` you only tell

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

fabianr accepted this revision. fabianr added a comment. This revision is now accepted and ready to land. To keep the notification open when it is not visible is the suggested action in the notification draft too: https://community.kde.org/Plasma/Notifications#Behaviour_2 REPOSITORY R120

D10386: Fix LnF theme data for window decoration

kossebau created this revision. kossebau added a reviewer: mart. kossebau added a project: Plasma. kossebau requested review of this revision. REVISION SUMMARY Plasma LnF KCM reads the window decoration data from cg = KConfigGroup(conf, "kwinrc"); cg = KConfigGroup(,

D10384: Fix LnF theme data for window decoration

kossebau created this revision. kossebau added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Plasma LnF KCM reads the window decoration data from cg =

Plasma 5.13 Kickoff Meeting 12:00UTC Monday

No perfect time for a Kickoff meeting is seems so we're going with 12:00UTC on Monday in #plasma Do have a look at the Todo ahead of time and triage stuff you're involved with https://phabricator.kde.org/project/view/35/ We also hope to plan a separate Wayland focused meeting for those

plasma-desktop-5.12.0 bug report

Hello there, plasma-desktop-5.12.0/kcms/kfontinst/lib/Misc.cpp:294]: (style) Same expression on both sides of '||'. Source code is return "font/otf"==mime || "font/ttf"==mime || "application/x-font-type1"==mime || "application/x-font-ttf"==mime ||

D10383: Fix pinning apps when their .desktop file has a space in the file name.

broulik added a comment. > Is rejecting scheme-less URLs going to break anything? I think we're doing a quite good job of ensuring we have a `file:` or other scheme, so this //should'nt// cause behavior changes. > Can we be confident QUrl::operator== will abstract over this?

D10383: Fix pinning apps when their .desktop file has a space in the file name.

hein created this revision. hein added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Things I have concerns about with this patch and would appreciate thoughtful input on: - To get URLs through

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 37 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/37/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 08:55:30 + Build duration: 7 min 24 sec and counting

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 134 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/134/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Feb 2018 08:46:11 + Build duration: 4 min 8 sec and counting CONSOLE

D10382: [Task Manager] Load only icons in tooltip that we end up showing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6ae9528c1ce9: [Task Manager] Load only icons in tooltip that we end up showing (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D3562: [Task Manager] Create toolTipDelegate on demand

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Sometimes I wish we'd implement lazy loading in the backends instead (e.g. why is heavy when it's never been visible). The more we optimize our QML the more we go procedural/non-declarative

D3562: [Task Manager] Create toolTipDelegate on demand

broulik updated this revision to Diff 26749. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Rebase ontop of master - Populate in `aboutToShow` (cf. https://phabricator.kde.org/D10381) - Destroy `toolTipDelegate` when

D10382: [Task Manager] Load only icons in tooltip that we end up showing

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10382 To: broulik, #plasma, hein, romangg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10382: [Task Manager] Load only icons in tooltip that we end up showing

broulik created this revision. broulik added reviewers: Plasma, hein, romangg. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Only launchers show the window icon, don't load it

D10381: [ToolTipArea] Add "aboutToShow" signal

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is emitted just before the tooltip is