D27608: Fixes for applet configuration layout.

gvgeo added inline comments. INLINE COMMENTS > AppletConfiguration.qml:117 > Kirigami.Separator { > -visible: configDialog.configModel > -anchors.left: sidebar.right > -height: root.height > -} > - > -Kirigami.Separator { > +id: topSeparator >

D27626: refactor: fix various compiler warnings

romangg added inline comments. INLINE COMMENTS > output_model.h:90 > {} > +Output(Output &&) noexcept = default; > Output(KScreen::OutputPtr _ptr, const QPoint &_pos) Why to add and why noexcept? REPOSITORY R104 KScreen REVISION DETAIL

D27212: Have pullback toolbars on scrollable pages also for footers

camiloh marked 2 inline comments as done. camiloh added a comment. everythign is now fixed :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27212 To: camiloh, #kirigami, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra,

D24623: Missing links to pagepool source files

This revision was automatically updated to reflect the committed changes. Closed by commit R169:51205eba731a: Missing links to pagepool source files (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24623?vs=67873=76338 REVISION DETAIL

D27212: Have pullback toolbars on scrollable pages also for footers

camiloh updated this revision to Diff 76337. camiloh added a comment. downgrade qqc2 version to 2.4 and remove white spaces REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27212?vs=75195=76337 BRANCH arcpatch-D27212 REVISION DETAIL

D27638: allow to take qqc2 actions and fix issues with it not having the visible prop

camiloh created this revision. camiloh added reviewers: ahiemstra, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY This allows to correctly display the QQC2 Actions too, the issue was due to the loader

D27096: Refactoring, improve validation in kcm, optimize

alex added a comment. First of all thanks for the idea, but is the QString API needed ? These strings are just used for reading the config and if you have a look at the implementation of the readEntry method: QStringList KConfigGroup::readEntry(const QString , const QStringList )

D27636: Remove redundant match for mountpoints

bruns created this revision. bruns added reviewers: Baloo, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY m_excludeList is populated from m_settings->excludeFolders(), so one of the

D27613: Remove bogus mount points check when starting baloo on save

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9dc634bdb1ec: Remove bogus mount points check when starting baloo on save (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27612: Remove unused functions

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cd52299862ea: Remove unused functions (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27612?vs=76252=76331 REVISION DETAIL

D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint

This revision was automatically updated to reflect the committed changes. Closed by commit R119:31e823b6a67a: Invert logic of shouldShowMountPoint - ignoredMountPoint (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint

bruns updated this revision to Diff 76329. bruns retitled this revision from "Invert logic of shouldShowMountPoint -> ignoreMountPoint" to "Invert logic of shouldShowMountPoint -> ignoredMountPoint". bruns edited the summary of this revision. bruns added a comment. Update commit message (I

D27166: Refactor converter runner

alex added a comment. Yes, I had a look, but I thought there may be a way to solve this using the KDE conversion API. The new changes now support 12 different currency symbols instead of just 3. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To:

D27166: Refactor converter runner

alex updated this revision to Diff 76324. alex added a comment. Add support for other currency symbols, use named groups for regex Now the plugin can evaluate queries like "4$>￥. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27608: Fixes for applet configuration layout.

ngraham added subscribers: filipf, ngraham. ngraham added a reviewer: filipf. ngraham added a comment. Looks quite sane overall, modulo a few questions and comments. Adding @filipf as a reviewer since I know he's done some work here too. INLINE COMMENTS > AppletConfiguration.qml:117 >

Re: Plasma Sprint 2020 in Augsburg, Germany

пн, 24 февр. 2020 г. в 11:10, Kai Uwe Broulik : > > 2. May we please merge "Arrival/Leaving" columns in the attendance > > table so I can answer e.g. "weekends: 18-19, then 25-26"? > > So you're coming only on the weekends. Do you have a place to stay? Hi Kai, Thanks for your answers! My plan

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76320. gvgeo added a comment. style restore REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=76319=76320 BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76319. gvgeo retitled this revision from "Fix applet configuration ovelap with top line" to "Fixes for applet configuration layout.". gvgeo edited the summary of this revision. gvgeo edited the test plan for this revision. gvgeo added a comment. Added all

D27629: [plasma-session] Load startup and shutdown on demand

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. +1 patch makes sense to me overall. INLINE COMMENTS > startplasma.cpp:396 > > -if (exitCode == 255) { > -// Startup error > -messageBox(QStringLiteral("startkde: Could

D27629: [plasma-session] Load startup and shutdown on demand

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Currently startplasma spawns plasma-session then sits around waiting for

D27595: Watch for language change events, and forward those to the QML engine

vkrause added a comment. In D27595#616544 , @apol wrote: > I'm fine with this being done here for convenience, but it feels like it's something that should be in QQmlEngine itself. Right, or at least in QQmlApplicationEngine. REPOSITORY

D27532: [applets/notes] Rename to "Sticky Note"

This revision was automatically updated to reflect the committed changes. Closed by commit R114:35bd616bcd3a: [applets/notes] Rename to Sticky Note (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27532?vs=76072=76314 REVISION

D27530: Use appropriate icon for unconfigured applets' "Configure..." buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cb46e52aad66: Use appropriate icon for unconfigured applets Configure... buttons (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

gikari updated this revision to Diff 76312. gikari marked an inline comment as done. gikari added a comment. Code style changes REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27380?vs=75858=76312 BRANCH font-style REVISION DETAIL

D27530: Use appropriate icon for unconfigured applets' "Configure..." buttons

ngraham updated this revision to Diff 76311. ngraham added a comment. `settings-configure` -> `configure` (they're the same icon, but `configure` is the parent while the other is a symlink to it REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27449: [applets/mediacontroller] Fix Playback button icon sizes

ngraham abandoned this revision. ngraham added a comment. Fixed better in D27628 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27449 To: ngraham, #plasma Cc: mart, broulik, plasma-devel, Orage, LeGast00n,

D27260: [applets/systemtray] Set pin button's size correctly

ngraham added a comment. Fixed better in D27628 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27260 To: ngraham, #plasma, ndavis Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir added a comment. In D25961#617057 , @apol wrote: > +1 cool stuff, much better than using kwallet for it. Thanks! :) > Have you checked how well it works regarding startup? In Discover we do a bunch of queries at start for

D27577: [KCM]Fix content below scrollbars

ngraham added a comment. We can wait a bit to get more eyes on it and target 5.18.3. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ngraham, apol,

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

apol added a comment. +1 cool stuff, much better than using kwallet for it. Have you checked how well it works regarding startup? In Discover we do a bunch of queries at start for every KNSEngine and we need to make sure we don't block the whole thing (more than QNAM does, at least)

D27608: Fix applet configuration ovelap with top line

gvgeo planned changes to this revision. gvgeo added a comment. Will add more related changes here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27096: Refactoring, improve validation in kcm, optimize

dvratil added inline comments. INLINE COMMENTS > config_keys.h:23 > > -#include > +static const char CONFIG_TRIGGERWORD[] = "triggerWord"; > +static const char CONFIG_ALIASES[] = "aliases"; You could use `static constexpr QStringView CONFIG_TRIGGERWORD = u"triggerWord"` to get something

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. Today for 5.18.2 or can wait? Apol only looked the code for the first change. And I don't know why vertical margins create bind loop, or if Item as a proxy is good. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

apol added a comment. Makes sense. Have you tested that this works? You should probably pass KF5::GuiAddons to the target_link_libraries as well. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D27518 To: ahmadsamir, #plasma, apol Cc: plasma-devel, Orage,

D27166: Refactor converter runner

sitter added a comment. Have you had a look at https://doc.qt.io/qt-5/qlocale.html#currencySymbol REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma, sitter Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir updated this revision to Diff 76309. leinir added a comment. - Switch to using the kaccounts cmake commands REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25961?vs=76049=76309 BRANCH switch-attica-plugin-to-kaccounts (branched from master)

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > spellchecking.cpp:30 > +#include > +#include > +#include Good opportunity to switch to the camel case includes? > spellchecking.cpp:40 >

Feature requests re: 5.18 changes

Hey Plasma fellows, I recently upgraded to 5.18 and had a couple simple feature requests I wanted to put out there. First, I liked the old notification style with the linear countdown meter; I don't know what about the new style rubs me the wrong way, but I think it would be neat to have a

D27581: Use K_PLUGIN_CLASS_WITH_JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R133:6d551e4754f3: Use K_PLUGIN_CLASS_WITH_JSON (authored by nicolasfella). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27581?vs=76186=76307 REVISION DETAIL

D27626: refactor: fix various compiler warnings

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Fixes pessimizing move, implicit copy assignment operator, copies in range for loops,

D27577: [KCM]Fix content below scrollbars

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D27577#616919 , @gvgeo wrote: > > The other change to center labels > > They were already centered. Oops, my bad. Seems

D27260: [applets/systemtray] Set pin button's size correctly

ngraham added a comment. No, it's still broken for me even with that commit. :( F8128762: photo_2020-02-24_07-26-43.jpg REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27260 To: ngraham, #plasma, ndavis Cc: mart,

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8f1043c641a2: KCM/ComponentChooser Treat cases when there is no app for a usage (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. I would not call them stylistic choice, the position didn't change. And there are included in description. Make Header always fit inside the scrollview area. They had 2 different problems, when the text is too big. As enabled they would cut text left and

D27625: fix: handle when backend fails to load/initialize

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Fixes a null pointer dereference in GetConfigOperation when BackendManager fails to load a

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven marked an inline comment as done. meven added a comment. Is it fine for other reviewers ? REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D27395 REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi, davidedmundson, #plasma Cc: anthonyfieroni,

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounter.cpp:111 > This is rather odd. A too eager search and replace? ;-) Thanks indeed > ervin wrote in AutomounterSettings.cpp:23 > I guess you could have used `using > AutomounterSettingsBase::AutomounterSettingsBase;`

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

meven updated this revision to Diff 76294. meven marked 7 inline comments as done. meven added a comment. Rebase, review fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27480?vs=75923=76294 BRANCH arcpatch-D27480 REVISION DETAIL

D27618: fix(kwayland): wait longer for connection timeout and retry

This revision was automatically updated to reflect the committed changes. Closed by commit R110:691c85879caf: fix(kwayland): wait longer for connection timeout and retry (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

This revision was automatically updated to reflect the committed changes. Closed by commit R119:07b4f3fb6c3c: Solid-device-automounter/kcm: Use KConfigXT in ui (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=76286=76289

D27577: [KCM]Fix content below scrollbars

ngraham added a comment. As far as I can tell, the other four changes are related to the scrollbar/view sizing/positioning. The other change to center labels may fix an issue, but it still represents a stylistic change. It should either be in a separate patch, or else it needs to be

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven updated this revision to Diff 76286. meven marked 3 inline comments as done. meven added a comment. Fix indentation and add intermediate variable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=75891=76286 BRANCH arcpatch-D27127_1

D27618: fix(kwayland): wait longer for connection timeout and retry

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Thanks. This m_isValid variable was really uselsess. ;) REPOSITORY R110 KScreen Library BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27618 To: dvratil,

D27621: [startkde] Rename method startKSMServer to reflect real behaviour

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Since ksmserver was split, start-plasma launches plasma-session which in

D27482: Update kdeglobals config file for Breeze widgetStyle

ervin added inline comments. INLINE COMMENTS > bport wrote in style_widgetstyle_default_breeze.pl:8 > This will fix only for Breeze theme > This will fix existing case but we also need to fix the root cause (i.e. how > we end up with a lowercase name). Sure but that would be a different patch

Re: monday meeting notes for 24/2/2020

Aand, forgot my part :) * was away on friday, worked mostly on otherstuff, but plasma related things are # Plasma * continued with the panel centering spacer, i think is pretty much ready: https://phabricator.kde.org/D27481 * continued layout fixing for plasmacomponents3 buttons:

monday meeting notes for 24/2/2020

David R * I investigated wy sometimes icon were not colored correctly when plasma theme and color scheme were different Diff 27589 "Try to apply the colorscheme of the current theme to QIcons" [Accepted] https://phabricator.kde.org/D27589 * Maybe needs some implementation critique since it

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ervin added a comment. A minor style nitpick, otherwise LGTM. As mentioned by the author, this likely require extensive testing before going in. INLINE COMMENTS > configvalueprovider.cpp:53 > > +QString ConfigValueProvider::fontStyleHelper(const QFont& font) const > +{ Space should be

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. I guess extra care will need to be taken with your other patch moving away from the singleton (dunno which one is based on which, I might review out of order). REPOSITORY R119 Plasma

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DeviceAutomounterKCM.cpp:44 > : KCModule(parent, args)//DeviceAutomounterKCMFactory::componentData(), > parent) > - , m_devices(new

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DeviceAutomounterKCM.cpp:44 > : KCModule(parent, args)//DeviceAutomounterKCMFactory::componentData(), > parent) > + , m_devices(new

D27521: Various fixes to make autotests run and pass

This revision was automatically updated to reflect the committed changes. Closed by commit R169:1011bcc9f618: Various fixes to make autotests run and pass (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27521?vs=76051=76276 REVISION

D26857: Unify ksysguard cpu clock speed names

This revision was automatically updated to reflect the committed changes. Closed by commit R106:4e656a45df16: Unify ksysguard cpu clock speed names (authored by davidedmundson). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26857?vs=74186=76275 REVISION

Re: Plasma Sprint 2020 in Augsburg, Germany

Hi, 1. Is it OK to join the sprint for those who don't touch Plasma source code on a regular basis? Would this make the sponsored office space overcrowded? (Asking for myself. Of course I won't request travel support.) I think we could host another person ;) 2. May we please merge

D27394: [applets/notes] Only show configure button when focussed

This revision was automatically updated to reflect the committed changes. Closed by commit R114:9abedfec9d23: [applets/notes] Only show configure button when focussed (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27529: [applets/weather] Remove outdated extra configure button

This revision was automatically updated to reflect the committed changes. Closed by commit R114:2c7737f8fe8d: [applets/weather] Remove outdated extra configure button (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27590: Calculate needsSave on checkbox toggle not on change

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1dd4668f1bf1: Calculate needsSave on checkbox toggle not on change (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27618: fix(kwayland): fix crash when KWayland connection times out

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY During login creating the connection to Wayland server may take longer than 1 second (KWin

D27449: [applets/mediacontroller] Fix Playback button icon sizes

mart added a comment. so: the latest, long discussed buttons revision is to have button icons that can scale automatically downand up to the "small" (and smallmedium for toolbuttons) size, as this is the behavior of qwidget buttons, and the goal at some point was to make the controls in

D27260: [applets/systemtray] Set pin button's size correctly

mart closed this revision. mart added a comment. this has been superseeded by R242:ba0b637de94a REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27260 To: ngraham, #plasma, ndavis

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76266. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. find_package() KGuiAddons REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27518?vs=76265=76266 BRANCH l-khelp (branched

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir added a comment. I wonder how to make systemsettings depend on KGuiAddons (if that's needed here)? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D27518 To: ahmadsamir, #plasma, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76265. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Change BUG: REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27518?vs=76259=76265 BRANCH l-khelp (branched from master)

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76259. ahmadsamir retitled this revision from "Only enable the "Help" button if khelpcenter is available" to "If KHelpCenter isn't available fallback to opening doc at docs.kde.org". ahmadsamir edited the summary of this revision. ahmadsamir removed a