ngraham added subscribers: filipf, ngraham. ngraham added a reviewer: filipf. ngraham added a comment.
Looks quite sane overall, modulo a few questions and comments. Adding @filipf as a reviewer since I know he's done some work here too. INLINE COMMENTS > AppletConfiguration.qml:117 > Kirigami.Separator { > - visible: configDialog.configModel > - anchors.left: sidebar.right > - height: root.height > - } > - > - Kirigami.Separator { > + id: topSeparator > anchors.top: root.top Hmm, mking the separator always span the full width introduces a row of pixels on top of the sidebar that is slightly unsightly when the top category is focused: F8129488: Screenshot_20200224_143600.png <https://phabricator.kde.org/F8129488> > AppletConfiguration.qml:152 > + Layout.preferredWidth: units.gridUnit * 7 > + Layout.bottomMargin: units.smallSpacing > + contentWidth: -1 What's this for? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart