D27669: [kstyle] Tools area

ngraham accepted this revision. ngraham added a comment. Much better, thanks. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham Cc: maartens, abstractdevelop, IlyaBizyaev, davidre,

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng added a comment. ping? :) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28859 To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27669: [kstyle] Tools area

cblack updated this revision to Diff 80594. cblack added a comment. Rebase on master REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=79010=80594 BRANCH arcpatch-D27669_1 REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 80598. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79070=80598 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D28317

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

ngraham updated this revision to Diff 80593. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26695?vs=74052=80593 BRANCH standardshortcuts-minimum-size (branched from master) REVISION DETAIL

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

ngraham updated this revision to Diff 80595. ngraham added a comment. 700 -> 600 to accommodate people who still have netbooks or run Plasma in a VM with a tiny window because guest tools aren't installed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27669: [kstyle] Tools area

cblack updated this revision to Diff 80597. cblack added a comment. Properly rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=80594=80597 BRANCH arcpatch-D27669_1 REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:8e0f525a9633: [KCMs/Standard Actions] Give KCMShell window a sane default size (authored by ngraham). REPOSITORY

D27669: [kstyle] Tools area

cblack updated this revision to Diff 80603. cblack added a comment. Fix menubar quirks REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=80597=80603 BRANCH arcpatch-D27669_1 REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley: > Hi all, > > Another breakage in Qt? Should be fixed now (restarted build now completed), with similar traps also removed for the future, thanks to David Faure for the work done and Ade for the root detecting investigations.

Re: Kickoff menu with empty history tab

Thank you David. I'm sorry for my late reply : I only noticed that I sent my mail to a mailing list after seeing the notification telling me a moderator had to approve my post. After a few research, I found out that kactivitymanagerd is (hopefully) correctly started with

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure: > On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > > Hi all, > > > > Please see below - any ideas as to why KHelpCenter no longer successfully > > builds? > > > > It doesn't look like KHelpCenter has changed... > >

D28997: [applet] Improve tooltip text for single connected device use case

This revision was automatically updated to reflect the committed changes. Closed by commit R97:c810d1f3c8f2: [applet] Improve tooltip text for single connected device use case (authored by ngraham). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE

D28997: [applet] Improve tooltip text for single connected device use case

ngraham added a comment. Or would "connected to [device]" be better? I'm not a heavy user of bluetooth and don't have a strong opinion on the matter. REPOSITORY R97 Bluedevil BRANCH better-single-device-tooltip (branched from master) REVISION DETAIL https://phabricator.kde.org/D28997

D28997: [applet] Improve tooltip text for single connected device use case

ngraham created this revision. ngraham added reviewers: VDG, Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Also fixes the bug that was making the popup be too wide in this case because we're

D28996: Converted to page and added heading

ngraham added a comment. Great! However the footer looks a bit weird since it doesn't touch the edges: F8247573: Screenshot_20200419_154306.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28996 To:

D28985: [Kickoff] Disable tabBar's mouseArea when searching

davidedmundson resigned from this revision. davidedmundson added a comment. Ah, I see. name: "Search" PropertyChanges { target: tabBar opacity: 0 } It's opacity zero, but technically still visible, still enabled and with the same

KDE CI: Plasma » kactivitymanagerd » stable-kf5-qt5 FreeBSDQt5.14 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/stable-kf5-qt5%20FreeBSDQt5.14/3/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 19 Apr 2020 21:20:01 + Build duration: 1 min 44 sec and counting

D28996: Converted to page and added heading

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY screenshots coming REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL

D28985: [Kickoff] Disable tabBar's mouseArea when searching

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't understand. Why is the search page a special case that should affect the tab bar behaviour? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28988: Port hotplug from KRun::runCommand to CommandLauncherJob.

dfaure added a comment. As it is currently implemented, CommandLauncherJob is very unlikely to ever fail. It doesn't even fail on non-existing executable in the command (because it delegates to bash) so apart from QProcess cannot fork, it never fails. Probably not worth doing something

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

dfaure updated this revision to Diff 80586. dfaure added a comment. Use KNotificationJobUiDelegate REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28990?vs=80568=80586 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28990 AFFECTED

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

dfaure added a comment. Agreed about notification delegate, will do. Does this really use KServiceAction anywhere? I don't see that. Confusing this one and D28988 ? [which however can't use the KServiceAction because of special support for %D and

D28988: Port hotplug from KRun::runCommand to CommandLauncherJob.

broulik added a comment. In principle dataengine actions are jobs, so they could communicate a result back REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28988 To: dfaure, davidedmundson, sitter Cc: broulik, plasma-devel, Orage, LeGast00n,

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik added a comment. Also actually this should probably be refactored completely to use `KServiceAction` rather passing the exec to QML and then back here :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28990 To: dfaure, drosca, davidedmundson, broulik

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik added a comment. Since it's an applet and thus run inside Plasma, do we not rather want the `KNotificationJobUiDelegate`? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28990 To: dfaure, drosca, davidedmundson, broulik Cc: plasma-devel, Orage,

KDE CI: Plasma » kactivitymanagerd » stable-kf5-qt5 FreeBSDQt5.14 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/stable-kf5-qt5%20FreeBSDQt5.14/2/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 19 Apr 2020 20:17:53 + Build duration: 1 min 24 sec and counting CONSOLE

D28985: [Kickoff] Disable tabBar's mouseArea when searching

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent! Please land on the `Plasma/5.18` branch and then merge to master. Let me know if you need a hand with that. REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff

D28576: Converted to page and added Heading

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7d0a74721c5f: Converted to page and added Heading (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28576?vs=79484=80583 REVISION

D28744: Rewrite of the global shortcuts kcm

ngraham added inline comments. INLINE COMMENTS > shortcutsmodel.cpp:440 > +} > +const QString = m_components[index.row()].uniqueName); > +auto watcher = new > QDBusPendingCallWatcher(m_globalAccelInterface->getComponent(uniqueName)); compile error REPOSITORY R119 Plasma Desktop

D27669: [kstyle] Tools area

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Found an interesting issue today: When you hide and show the menubar in Dolphin, this happens: F8247334: Screenshot_20200419_134038.png .

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

ngraham added a comment. Well, they don't extend so far into the center of the screen as they used to. There's no way to make a notification pop-up not block anything. This patch is what feels best for me, as most of the tools and tabs I'm going to be using are more towards the edges of

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

IlyaBizyaev added a comment. On the screenshots, the notifications block tab bars and toolbars in 3 apps :) Are you sure it's more convenient? REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL

Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

Hi all, Another breakage in Qt? Cheers, Ben -- Forwarded message - From: CI System Date: Sun, Apr 19, 2020 at 11:44 PM Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing! To: *BUILD FAILURE* Build URL

D27669: [kstyle] Tools area

ngraham added a comment. Needs a rebase REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf updated this revision to Diff 80582. filipf added a comment. remove the separator instead of just shortening it REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25728?vs=70873=80582 BRANCH no-unwanted-titlebar-separator (branched from

D28985: [Kickoff] Disable tabBar's mouseArea when searching

bugseforuns added a comment. Patch also working on Neon unstable edition. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28985 To: trmdi, #plasma, hein Cc: bugseforuns, dginovker, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

broulik accepted this revision. broulik added a comment. The lack of spacing looks bad but whatever REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg,

D28619: BookmarksRunner: Remove caching of profile database path

alex updated this revision to Diff 80580. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=80578=80580 REVISION DETAIL https://phabricator.kde.org/D28619 AFFECTED FILES runners/bookmarks/browsers/firefox.cpp To: alex, #plasma, bruns, broulik Cc: plasma-devel, Orage,

D28619: BookmarksRunner: Remove caching of profile database path

alex updated this revision to Diff 80578. alex added a comment. Implement requested changes Thanks, I will do that after the bugfix is done :-) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=79466=80578 BRANCH arcpatch-D28619

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

ngraham added a comment. Heh, sorry! REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, cblack, plasma-devel, Orage,

D28619: BookmarksRunner: Remove caching of profile database path

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please just remove the `writeEntry`. You can then propose "But what about renaming the dbfile entry, maybe to alternate_dbfile?" as another review. REPOSITORY R120 Plasma

D28619: BookmarksRunner: Remove caching of profile database path

alex added a comment. Friendly ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28619 To: alex, #plasma, bruns, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

ndavis added a comment. Oof, what a sad set of example notifications  REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D27098: Konsole Runner: optimize and simplify

alex added a comment. @ngraham and others, may I ship this? REPOSITORY R114 Plasma Addons BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, broulik Cc: apol, plasma-devel, Orage,

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

dfaure created this revision. dfaure added reviewers: drosca, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN Builds, but untested. REPOSITORY R114 Plasma Addons BRANCH master REVISION

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Somehow the notification pop-up's positioning has never felt quite right to me.

D28988: Port hotplug from KRun::runCommand to CommandLauncherJob.

dfaure created this revision. dfaure added reviewers: davidedmundson, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. REVISION SUMMARY Is there a better way to report error from this code than the dialog box that KRun

D28914: Include the Plasma Vault name in the mount dialog title

ngraham added a comment. Landed on master since adding or changing strings in the stable branch isn't allowed. Thanks for the contribution! REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D28914 To: ksmanis, #plasma, davidedmundson, ivan, #vdg, ngraham Cc:

D28914: Include the Plasma Vault name in the mount dialog title

This revision was automatically updated to reflect the committed changes. Closed by commit R845:6944aab19e86: Include the Plasma Vault name in the mount dialog title (authored by ksmanis, committed by ngraham). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE

D28985: [Kickoff] Disable tabBar's mouseArea when searching

dginovker added a comment. Hi - I'm the original bug reporter, hopefully I'm allowed to comment here. The patch provided works, tested on 2 machines running Manjaro KDE :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28985 To: trmdi, #plasma, hein Cc:

D28970: [applets/digital clock] Make tooltip spacing and text nicer and more consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R120:44d338fcb105: [applets/digital clock] Make tooltip spacing and text nicer and more consistent (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28970?vs=80514=80559#toc

D28971: Persist state between launches

ngraham added a comment. Window geometry and position is supposed to be saved automatically by KXMLGui, at least for widgets apps. If that's not possible to do here, perhaps we should have Kirigami do this at the frameworks level so it doesn't need to be done by every single app.

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex updated this revision to Diff 80557. pereira.alex added a comment. Trying to fix the bug: So reverted the changed did and focused on fixing the bug. It was missing a connection to list view mode change. So now one can change view mode, change icon size in icon view

D28985: [Kickoff] Disable tabBar's mouseArea when searching

trmdi created this revision. trmdi added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY When the root is in the "Search" state, we can safely disable it. BUG: 420282 REPOSITORY

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

ahmadsamir added a reviewer: broulik. ahmadsamir added a comment. I had trouble finding what urlPatterns would look like, and only found trash:/ and run:/, also couldn't find any documentation about X-Plasma-DropUrlPatterns. Porting regex, especially with the pesky QRegExp::Wildcard,

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 80553. davidre added a comment. - Make loading async - Make everything async REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80405=80553 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

apol added a comment. I wonder, while this will work with all our uses of DropUrlPatterns, this would have been able to work with something like `scheme:/*potato*` which after this patch won't work. In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate feedback from

D28651: Load and use global animation settings

sandsmark updated this revision to Diff 80551. sandsmark added a comment. Remove the duplication of animation control, and don't override the animation settings if people haven't adjusted it globally. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmadsamir requested review of this revision. REVISION SUMMARY AFAICS, from grep'ing for "DropUrlPatterns" in

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

broulik added a comment. It's just a `QAbstractListModel`, if any, it does some `columnCount` behavior. I emit `dataChanged`, yes. Will check the actual column count later. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28649 To: broulik, #plasma Cc:

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

dfaure added a comment. Wait, even if the jobs model is empty (no rows), what's its columnCount()? If that's fixed, then it should all be fine. Maybe my analysis (and testcase) is incorrect. Can you check the columnCount() of the Concat model? I assume the notifications model

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

broulik added a comment. :( I see. Thanks! At least by then I'll be able to use `sourceModels()` so I could make the mapping up the chain generic REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28649 To: broulik, #plasma Cc: davidre, dfaure,

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

dfaure added a comment. OK I see why this is happening. KConcatenateProxyModel's columnCount is the number of columns of the first source model. Which leads to strange things if other models have less columns. QConcatenateProxyModel takes the smallest number of columns of all source

D28958: [kcm_nightcolor] Set 2 decimal places precision for coordinates

This revision was automatically updated to reflect the committed changes. Closed by commit R119:35e18420a76a: [kcm_nightcolor] Set 2 decimal places precision for coordinates (authored by shubham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE