On Fri, Sep 18, 2020 at 3:45 PM Kai Uwe Broulik
wrote:
> Hi,
>
>
> > Is it possible for the application to change its own "show in history"
> > setting, instead of the user going to System Settings to do this?
>
> It is not.
>
Let's back up a bit, what's the end goal we're trying to achieve for
>yet it gets built on windows. shall we stop
doing that
AFAIK it is used and this was something explicitly requested.
There is a KF6 workboard task to get into frameworks for kf6
David
davidedmundson added a comment.
But I could still just copy the relevant lines into kcmshell directly instead
of linking.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D23883
To: heikobecker, #plasma
Cc: davidedmundson, asturmlechner, plasma-devel, Orage,
davidedmundson added a comment.
> Any update here? Can this hack be dropped now?
I did follow up on that. A distro is still wanting to do the setup which
requires this opt-in hack.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D23883
To: heikobecker,
>* Mimic absolute positioning via relative positioning. It's good as a
short-term solution, but imho, we need something better
I'm not quite sure I understand which way you're describing:
Do you mean having plasma code still do absolute co-ordinates and then have
us turn it into relative
On Fri, Aug 21, 2020 at 6:21 PM Nicolas Fella wrote:
> Hi,
>
> do we have any rules on the C++ standard used in Plasma?
All our rules can be boiled down to one point:
- Don't break distros
>Given that kactivitymanagerd is technically part of Plasma we even have
precedence of using C++17
Right now the component "plasma-widget" is filled with bugs about common
klipper code.
If we move the component to plasmashell that's not going to change.
Unless you have a new idea on making it really "applet only" we're
ultimately just going to spread bug reports out across two places, and
On Wed, Jul 29, 2020 at 1:25 PM Bhushan Shah wrote:
> On Wed, Jul 29, 2020 at 05:47:02PM +0530, Bhushan Shah wrote:
> > If you have any ack/nack regarding this, please reply to this thread.
>
> Personally speaking I'd say it makes sense to enable this so we do not
> miss any merge requests
Gitlab has a new "approve" feature. I think it naturally makes sense to use
this instead of the labels as our official workflow.
One thing to note is that (like labels) the approve button does not send
any emails to the recipient.
David
https://bugs.kde.org/show_bug.cgi?id=353463
David Edmundson changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REOPENED
Investigated, kwin is just failing as BSD is missing some frameworks
changes. All good from a Plasma POV.
On Mon, Jul 13, 2020 at 8:15 PM Bernie Innocenti wrote:
> On 13/07/2020 17.48, David Edmundson wrote:
> >
> >
> > On Sun, Jul 12, 2020 at 5:29 PM Bernie Innocenti > <mailto:ber...@codewiz.org>> wrote:
> >
> > (re-posting because most sub
>2. KWin | multihead
Technically not that at all. Multihead is something we had 10 years ago.
I don't think we can do anything to accept the mess of bugs coming in and
triage appropriately once we can get a good description from the reporter.
I think most plasma devs look at all plasma bugs
I'm sorry to hear there are issues.
So just to confirm:
with "confirm logout" enabled:
- everything works correctly
with "confirm logout" disabled:
- the menu works correctly
- the logout widget sometimes does the wrong thing and shuts down instead
of logging out.
David
On Sun, Jul 12, 2020 at 5:29 PM Bernie Innocenti wrote:
> (re-posting because most subscribers might have missed my previous post
> due to an excessively strict DKIM policy applied by my domain).
>
>
> I'm trying to fix this longstanding bug where there are dangling user
> processes after the
davidedmundson added a comment.
Just push it.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D28651
To: sandsmark, #breeze
Cc: cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel,
#breeze, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
Select "plasma (wayland)" from SDDM.
David
> You have this button from commit page, not merge request page.
>
> https://i.imgur.com/9kgdpVy.png
Found it, that's perfect thanks.
That's also a useful feature in the current workflow.
Seems you can cherry-pick a commit in a work/branch to a new merge request.
> If you use git cherry-pick
On Thu, Jun 25, 2020 at 3:46 PM Bhushan Shah wrote:
> Hello everyone!
>
> This is a proposal to change our workflow regarding release branches and
> our merge workflow,
>
> # Current workflow
>
> - Current workflow is that we commit to stable branch and then merge it
> upwords until master
We all agree we should have a custom QStyle and QtQuick Controls style that
can load a theme written in some declarative text + image format then we
use the native toolkit support to render that in the best way. Only this
would be supported.
However:
- Realistically this is not feasible for
So to clarify, there are two allowed gitlab workflows.
MRs for chains of nicely done rebased commits
MRs where one MR represents a single logical commit to be squashed and the
list of actual commits uploaded is garbage.
>
> One issue with such a workflow is that code reviewers will have to
>
Everything is in note form. I've tried to tidy things up to be readable,
but please do ping if there are questions.
We've made quite a few porting goals of things we should try and do within
Plasma 5.
Systemsettings:
- QtQuick only
- Use binary plasma-settings for everything,
- Generally working well
- There seems to be an uptick in new contributors \o/
- We had a discussion about how to make review queues a big more
manageable.
We intend to use some labels.
Action plan is to copy + paste the labels Krita uses...as if it works for
them, they're probably
Distros,
We're in the process of determining our dependencies for Plasma 5.20, our
release in about 4 months.
Ideally we would like to depend on Qt5.15, we can land some wayland fixes
that would be otherwise hard to #ifdef as well as do some big code cleanup.
Obviously we're only comfortable
Chris Holland (or zren) has written an applet that lists gitlab merge
requests in a plasmoid.
It's /amazing/
https://store.kde.org/p/1381655/
Despite the name, it also shows pending merge requests which is quite
useful. It's sort of like an RSS feed, but better. I would recommend it to
all the
davidedmundson added a comment.
Sorry! pushed.
Please do feel free to nag if I forget things.
REPOSITORY
R885 Redshift Control for Plasma
REVISION DETAIL
https://phabricator.kde.org/D17960
To: kvanton, #plasma
Cc: ltoscano, davidedmundson, plasma-devel, Orage, LeGast00n,
Can everyone send topics they want to discuss to this ML. Then maybe we can
assemble some sort of program.
David
On Mon, Jun 1, 2020 at 12:46 PM Mikhail Zolotukhin
wrote:
> Hello,
>
> I am the de facto maintainer of the kde-gtk-config repository. As of now
> the name of this repository on GitLab is "KDE GTK Configurator" and the
> description is "Syncs KDE settings to GTK applications". I think there
>
One thing I'm missing when I'm doing reviews is I don't have a nice way to
separate merge requests that need review, and merge requests that are
awaiting changes.
I think this could be achieved with a label, that reviewers can set and
authors can clear when they're ready.
Somehow it's possible to
Yes, we should remove stale personal branches
git push origin :someBranchName (with the colon)
for non-stale branches you use the prefix "work/someBranchName" and you
can use that directly from gitlab without a fork which you can force push
to.
Gitlab has a button to auto-remove those on
davidedmundson added a comment.
It's an SNI, I thought the systemtray could already filter SNIs in the
enties tab of the system tray?
> I made different attempts to achieve this. The class was imagined like a
singleton, but it's not really a singleton, anyway it's initialized
davidedmundson abandoned this revision.
davidedmundson added a comment.
Moving to invent
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29476
To: davidedmundson, #kwin
Cc: ngraham, cblack, apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n,
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:b62b7719c7e1: Elide sensor names in config view (authored
by davidedmundson).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29682?vs=82670=83037
Pasting relevant gitlab factoids from the meeting:
All of Plasma is on gitlab now. New review requests should go there.
New review requests are *not* currently coming to come to this mailing list.
If you are a maintainer you can subscribe to all of plasma by going to:
>
> > It is sad, however, to see some regressions in translations. I cannot
> test by
> > myself but there are reports that some parts of the new KWin Rules KCM
> are
> > untranslatable:
> >
> > https://phabricator.kde.org/D29413
> >
> > Can somebody test if it's true?
>
Reading the code I can't
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REPOSITORY
R106 KSysguard
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29757
AFFECTED FILES
CMakeLists.txt
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:053d42077d6c: Only build autotests when enabled (authored
by davidedmundson).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29753?vs=82849=82856
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:ae6c4ac8e39d: Prefix disk name on size labels (authored
by davidedmundson).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29752?vs=82848=82855
REVISION DETAIL
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
BUG: 421514
REPOSITORY
R106 KSysguard
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29753
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
labels for CPU frequency are "CPU 1 Clock Frequency". Network speeds
have the interface name at front. Partitions
davidedmundson abandoned this revision.
davidedmundson added a comment.
Arjen suggested in a PM that we already have the concept of "total sensor"
being optional or not. No point hiding it at a UI level when we should be doing
it at a data level.
REPOSITORY
R111 KSysguard Library
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:644648e165fb: Fix translation domain for ksysguard
plugins (authored by davidedmundson).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29717?vs=82757=82822
>
> Opinions?
It's a tough situation, with no good answer.
>SOLUTION 2:
> * Ignore it and hope people will read my blog
https://tsdgeos.blogspot.com/2020/05/kwallet-pam-5184-and-ecryptfs-homes.html
We can simplify the bit about needing another user. If you use
sudo mount --bind /
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
more context never hurts. Good idea
REPOSITORY
R106 KSysguard
BRANCH
translation_context
REVISION DETAIL
https://phabricator.kde.org/D29721
To: ahiemstra, #plasma,
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REPOSITORY
R106 KSysguard
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29717
AFFECTED FILES
davidedmundson added a comment.
Who extracts and loads the translations for:
./ConfigAppearance.qml
./ConfigSensors.qml
./FaceDetailsConfig.qml
./UsedSensorsView.qml
in the top level of faces but not in an individual package.
code for the other stuff looks
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
To control the large "20%" text in the middle of a pie which can be
davidedmundson added a comment.
We need a fix for https://bugs.kde.org/show_bug.cgi?id=421431
Which could just be me removing making it hidden.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29157
To: mart, #plasma, ngraham
Cc: davidedmundson,
davidedmundson added a comment.
> Show me where the documentation for this QtWaylandClientExtension is and
where you documented that we "agreed" on using that in Plasma exclusively and
we can talk about libkscreen using it in 5.20
It was documented here
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
TEST PLAN
Eyes
REPOSITORY
R111 KSysguard Library
BRANCH
master
REVISION DETAIL
davidedmundson added inline comments.
INLINE COMMENTS
> kstart.cpp:121
> +} else {
> +printf("%d\n", job->pid());
> +}
I know it's copied but, there's no need to randomly go to C to use std::cout
> kstart.cpp:128
> +if (job->error()) {
> +
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
> Still, I think this behavior is actually the only one usable,
Indeed. A user shouldn't be expected to know what each thread is doing
inside an app, there isn't
davidedmundson updated this revision to Diff 82650.
davidedmundson added a comment.
shuffle files about
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29476?vs=82106=82650
BRANCH
davidedmundson/clipboard2
REVISION DETAIL
davidedmundson added a comment.
> These are not specific issues but some general complains about the overall
concept chosen here without providing an alternative solution.
Well yes, it makes sense to do high level discussion first.
With the Plasma agreed "new approach" that we will
davidedmundson added a comment.
It's still got this pointless plugin within plugin situation.
> For that at least one Wayland event loop has to be launched
It needs a roundrip after the registry is fetched. That doesn't need an event
loop.
REPOSITORY
R110 KScreen Library
davidedmundson added a comment.
thanks
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29623
To: meven, #plasma, ahiemstra, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas,
davidedmundson added a comment.
> Does the mechanism of standard shortcuts really apply here?
It's not implementing it yet, but that's the entire point.
The bigger problem is someone added some vim shortcuts to krunner a year ago:
(plasma-workspace
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
KDE has a concept of "standard shortcuts". Instead of duplicating this same
code everywhere with various combinations for people doing all sorts of crazy
davidedmundson added a comment.
From my POV. +1
I still need a reply on:
"Which release?"
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D28154
REVISION DETAIL
https://phabricator.kde.org/D28154
To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi,
davidedmundson added inline comments.
INLINE COMMENTS
> cblack wrote in kcm.cpp:121
> that looks like it could possibly run into race conditions, as the applyjob
> is executed asynchronously and IIRC is able to still be running when
> everything else, including this, has destructed and removed
davidedmundson added inline comments.
INLINE COMMENTS
> cblack wrote in kcm.cpp:121
> whoever is normally cleaning up tempfiles
Normally the app creating a temp file would clean it up.
A quick fix would be
file = new QTemporaryFile(this);
It's sort of leaking the object, but on exit it'll
davidedmundson added inline comments.
INLINE COMMENTS
> cblack wrote in kcm.cpp:97
> taking the initials of a user's real name
OH!
Initial-ise
not initialise as in "to prepare"
Makes sense :)
> usermodel.cpp:37
> +connect(m_dbusInterface, ::UserAdded,
> this, [this](const
davidedmundson added a comment.
> There's going to be enough breakage as it is, let's do things that can be
done now, now, instead of waiting for some nebulous "Plasma 6".
That's a good argument when it comes to adding new code.
For flipping defaults it doesn't really apply. We support
davidedmundson added a comment.
Which release?
We need to remove user-manager. We're technically in a repo freeze, and this
would involve changing (removing) a repo a breakage of that.
Generally this looks quite neat and tidy. A big simplification +++
INLINE COMMENTS
davidedmundson updated this revision to Diff 82106.
davidedmundson added a comment.
Fix the klipper code to handle detecting null buffer better
X code expected a valid QMimeData object with no contents
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:75333fc13159: Add a new daemon for stats monitoring
(authored by davidedmundson).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28333?vs=81871=82105
REVISION
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Wayland has an entire new protocol for getting and setting clipboard
when we
davidedmundson added a comment.
That doesn't explain why we're changing the step size.
No-one wants to click the up arrow 100 times.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D29431
To: kurmikon
Cc: davidedmundson, ngraham, plasma-devel, Orage,
davidedmundson updated this revision to Diff 81871.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.
Clear up plugin loading
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28333?vs=81087=81871
BRANCH
master
REVISION
davidedmundson added inline comments.
INLINE COMMENTS
> romangg wrote in Output.qml:60
> Is the change making this unnecessary? I.e. do the graphics still look
> "smooth"?
Default is true so it makes no difference.
There's generally no reason to set it to false.
REPOSITORY
R104 KScreen
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:cfd95e6bff4b: fix(kcm): avoid recursive OpacityMask which
leads to teardown crash (authored by davidedmundson).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
davidedmundson abandoned this revision.
davidedmundson added a comment.
There have been changes since. I think the new code is better at being self
documenting, and that's at least up to date. I'll just rm this file
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
In the current code OpacityMask's source is the parent which contains
itself, which doesn't make sense. Docs
davidedmundson added a comment.
I don't like this "assistant" object that is just an opaque pointer being
passed around from QML space. It's not very declarative.
Either we should register this item as a singleton with some nice invokable
methods to show KNS dialogs, which could be a
davidedmundson added inline comments.
INLINE COMMENTS
> WidgetExplorer.qml:66
> Component.onCompleted: {
> if (!root.widgetExplorer) {
> +if (!root.widgetExplorerAssistant) {
This existing code is horrible.
It's a very bad idea to reference objects outside our scope.
davidedmundson added a comment.
> Iincluding the removal of KNS functionality?
It's there. It's in widgetexplorerassistant
To help rephrase the commit message.
- WidgetExplorer opens dialogs
- WidgetExplorer has a limited lifespan and can be recreated each time it's
shown.
davidedmundson updated this revision to Diff 81093.
davidedmundson added a comment.
rebase
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28305?vs=80412=81093
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28305
AFFECTED FILES
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in ksysguarddaemon.cpp:58
> needs to be always polling every half a second? could it be somewhat
> adjustable (maybe depending on ac/on battery?)
Indeed, the current code is
davidedmundson updated this revision to Diff 81087.
davidedmundson marked 23 inline comments as done.
davidedmundson added a comment.
all the changes
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28333?vs=78977=81087
BRANCH
master
REVISION DETAIL
davidedmundson added a comment.
See https://github.com/systemd/systemd/pull/15226
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28424
To: hchain, davidedmundson, broulik, dfaure, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
davidedmundson added a comment.
Generally +1
INLINE COMMENTS
> waylandintegration.cpp:452
> +connect(m_registry, ::Client::Registry::screencastingAnnounced,
> this, [this] (quint32 name, quint32 version) {
> +qDebug() << "screen!";
> +m_screencasting =
davidedmundson added a comment.
A new dependency also needs to actually solve an actual problem.
If we say we should support wl_roots' protocol for wlroots users. Fair
enough. There are some parts of Plasma used by 3rd parties.
I'd certainly be very happy for us both to switch to a
davidedmundson added a comment.
assuming others are merged of course
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29056
To: bport, broulik, davidedmundson, zzag, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
I don't see why we should have that in KDE code.
As per manifesto
> The project stays true to established practices common to similar KDE
projects
davidedmundson added a comment.
KScreen already is a plugin system.
We don't need to go all inception, and have a plugin load plugins. It doesn't
look to bring anything other than complexity.
If there is any duplication, we can just add some extra base classes in the
lib using the
davidedmundson added a comment.
So the problem we're solving is that we want to go
Qt5.12 - QQC2.5
Qt5.13 - QQC2.6
Qt5.14 - QQC2.7
Qt5.15 - QQC2.15
correct?
We now know all Qt5 versions, and we know that Qt6 won't have versions.
I don't see why need this complicated
davidedmundson resigned from this revision.
davidedmundson added a comment.
Ah, I see.
name: "Search"
PropertyChanges {
target: tabBar
opacity: 0
}
It's opacity zero, but technically still visible, still enabled and with the
same
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
I don't understand.
Why is the search page a special case that should affect the tab bar
behaviour?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
davidedmundson added a comment.
Concept makes sense.
QStandardPaths is ordered: "The list of directories is sorted from high to
low priority, starting with writableLocation()"
so we can cut this code in half by doing some sort of
void runEnvironmentScripts()
{
const
davidedmundson added inline comments.
INLINE COMMENTS
> hchain wrote in plasma-core@.target:3
> can we make this `plasma-kwin@%i.service` ?
can do, the _ is just to match the binary name
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28305
To:
davidedmundson updated this revision to Diff 80412.
davidedmundson added a comment.
support x11 and wayland ...ish
we now call target plasma-workspace@x11 or plasma-workspace@wayland it then
can call the right services
but kwin_wayland is still currently spawned before the systemd
davidedmundson added inline comments.
INLINE COMMENTS
> davidedmundson wrote in OsdSelector.qml:34
> Why are we going for this instead of a binding?
>
> Is it so X and Y remain unset on X?
That was confusing, I'll rephrase.
Is it so the property "x" remains unset when running under the x
davidedmundson added inline comments.
INLINE COMMENTS
> OsdSelector.qml:34
> +
> +onScreenGeometryChanged: {
> +root.x = screenGeometry.x + (screenGeometry.width - mainItem.width)
> / 2
Why are we going for this instead of a binding?
Is it so X and Y remain unset on X?
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
beautiful
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28906
To: broulik, #plasma, hein, davidedmundson
Cc: davidedmundson,
davidedmundson added a comment.
I don't understand.
We're still running this at compile time, so what's the practical difference?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D28859
To: xuetianweng, #plasma, rizzitello,
Either kactivitymanagerd not running, or it's database being corrupted.
Running kactivitymanagerd manually might tell you.
David
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:262389b1e49b: Avoid creating subwindow on internal page
widget (authored by davidedmundson).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28832?vs=80133=80138
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
KWallet::openWallet takes a windowId as a parameter.
QWidget->winId()
davidedmundson accepted this revision.
davidedmundson added a comment.
Using the protocol makes sense, using a class that does it already makes more
sense than duplicating/
Especially as the other OSD is already a dialog.
From a plasma side, ship it
REPOSITORY
R104 KScreen
davidedmundson added a comment.
Technically this introduces a visual change.
Dialog draws a border and shadow by default which appears outside our red
border from the QML.
I'm pretty sure you can disable it in Dialog, but frankly this looks way
better so maybe it's a feature.
101 - 200 of 8194 matches
Mail list logo
