dfaure added a reviewer: mck182.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1840
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, mck182
Cc: plasma-devel, sebas
dfaure created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
org.kde.plasma.digitalclock/contents/ui/main.qml:51: TypeError: Cannot read
property 'width' of null
REPOSITORY
rPLASMAWORKSPACE Plasma
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb399cd908e53: systemtray container: fix
m_internalSystray nullptr crash (authored by dfaure).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
dfaure added a comment.
In https://phabricator.kde.org/D1826#33876, @davidedmundson wrote:
> Surely we should have already returned at line 94.
m_innerContainment was not null, only m_internalSystray was.
> Do you have the bt still?
Unfortunately not.
REPOSITORY
dfaure created this revision.
dfaure added a reviewer: mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Not sure how to trigger it, but gdb was clear about the issue.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128055/#review96041
---
Ship it!
Ship It!
- David Faure
On May 30, 2016, 1:17
tps://git.reviewboard.kde.org/r/128055/#comment64955>
This could all be done with a single line,
QDir().mkpath(packagesDirName);
No need to check if it exists already, mkpath will do that for you anyway.
- David Faure
On May 30, 2016, 12:33 p.m., Wolfgang Bauer
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Fixed in kservice, CI is green, you can discard this patch.
Thanks for the analysis of the issue, it really helped!
REPOSITORY
rKDECLITOOLS KDE CLI Utilities
REVISION
> On May 22, 2016, 11:49 a.m., David Faure wrote:
> > Looks fine to me, except for the reasoning in the commit log. It's
> > perfectly fine to reimplement an existing virtual method from a base class
> > into a derived class, this doesn't break ABI.
>
> Kai Uwe B
> On May 17, 2016, 2:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated
> > osx-integration repository for it as well.
>
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I've played with that idea.
>
>
VERIFY(!...)
- David Faure
On May 19, 2016, 9:37 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
dfaure added a comment.
Right. kservicetest was still failing too, but after adding debug output it
now passes every time
I committed the additional debug output in kdirwatch and enabled kdirwatch
debug output in filetypestest. Can you kick a build again and let me know the
result?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127918/#review95550
---
Ship it!
Ship It!
- David Faure
On May 17, 2016, 5:40
de.org/r/127918/#comment64744>
simpleConfigGroup.name() could be simplified to sourceGroup :)
- David Faure
On May 17, 2016, 4:42 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
it a single method that takes care of
opening both source and kde4 dest, and doing the copyTo. But if what I mean is
unclear to you, just ship it and I'll do the refactoring I have in mind.
- David Faure
On May 16, 2016, 8:52 p.m., Hrvoje
meTest::loadSvgIcon()
{
const auto *iconTheme = KIconLoader::global()->theme();
QString iconPath;
if (iconTheme) {
iconPath = iconTheme->iconPath(QLatin1String("konversation.svg"), 48,
KIconLoader::MatchBest);
}
m_svg->setImagePath(iconPath);
dfaure added a comment.
Haha, don't assume my code is stupid on purpose, it can also be stupid by
oversight :-)
I pushed a fix for kservice, can you check if it fixes your issue?
http://commits.kde.org/kservice/f82de1626f8efdb56ca810fc827d40bf7eed4601
REPOSITORY
rKDECLITOOLS KDE CLI
tps://git.reviewboard.kde.org/r/127875/#comment64730>
Could q->theme() be NULL here in some cases?
See
https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/testReport/(root)/TestSuite/khtml_parttest/
- David Faure
On May 13, 2016, 9:46 a.m., Marco Mar
erence
with the other KSharedConfig::Ptr from above ("profile").
- David Faure
On May 14, 2016, 6:48 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
quot;copyTo" that the bug mentions, then it has to be
fixed differently.
- David Faure
On April 7, 2015, 6:50 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.
just confusing, as this patch shows
- David Faure
On April 7, 2015, 11:46 a.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.
dfaure added a comment.
I'm seeing similar failures in the kservice framework, so I think we should
rather fix kservice to emit databaseChanged upon first creation too.
REPOSITORY
rKDECLITOOLS KDE CLI Utilities
REVISION DETAIL
https://phabricator.kde.org/D1583
EMAIL PREFERENCES
=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/kwayland_testWaylandOutputDevice/
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman
dfaure added a comment.
I'm pretty sure it should work. What changed in QUrl is that setPath used to
normalize the path and doesn't do that anymore.
(qtbase commit 2e1de7f3c4ca). So in 5.5 the double slash got simplified to a
single slash, while in 5.6 it stays and breaks the test.
Not
dfaure added inline comments.
INLINE COMMENTS
kioslave/desktop/kio_desktop.cpp:161 Can the path really *not* start with a
'/' in this code ?
From a QUrl point of view, it can happen with relative URLs
("desktop:foo.txt"), but we very rarely use that in KDE code, if at all (it's
unusable
ch/032116.html
> [2] https://community.kde.org/Frameworks/Policies
> [3] https://community.kde.org/Frameworks/CreationGuidelines
> [4] I'll do those tasks if we get the green light for move to frameworks,
> otherwise it'll stay in Plasma
> [5] some code uses linux includes, to sup
https://bugs.kde.org/show_bug.cgi?id=360162
David Faure <fa...@kde.org> changed:
What|Removed |Added
Assignee|fa...@kde.org |plasma-devel@k
ou have libkonq installed, while the CI doesn't.
Thanks for the heads up.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing li
dfaure added a comment.
Yes, KAssistantDialog says
buttonBox->setStandardButtons(QDialogButtonBox::Cancel |
QDialogButtonBox::Help);
If you then call addButton(Help) you get another one.
I do wonder if KAssistantDialog should be doing this indeed. It means it
offers a button
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/#review92384
---
Ship it!
Ship It!
- David Faure
On Feb. 14, 2016, 11
/platformtheme/kdeplatformfiledialoghelper.cpp (line 268)
<https://git.reviewboard.kde.org/r/127024/#comment62971>
these 3 lines are duplicated in both branches -> move them out of the
if/else?
- David Faure
On Feb. 11, 2016, 4:41 p.m., Aleix Pol Gonza
> On Dec. 29, 2015, 6:07 p.m., Kai Uwe Broulik wrote:
> > I completely screwed up my Kate desktop files :( Would it help if I set
> > NoDisplay or Hidden on the desktop file copy so it's there for the icon
> > widget but not shown in the Open With dialogs and so on? Or, if I copied
> > the
On Friday 01 January 2016 18:07:59 Ivan Čukić wrote:
>
> So, applications that do link to activities will run and work
> uninterrupted even if the service is not present.
OK, sounds good to me.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Fra
tegration or solution, all
> OSs)
> - kactivitymanagerd (service, kcm settings module, dolphin plugin;
> officially linux-only)
Shouldn't the service be part of the framework?
How usable is the framework without the service?
Compiling is good, but running is even better :-)
--
David Faur
icon_p.cpp (line 239)
<https://git.reviewboard.kde.org/r/126149/#comment60951>
why commented out?
- David Faure
On Nov. 26, 2015, 8:15 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically
an eye on CI so I don't have to hunt for broken unittests when
making a release.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/li
ativetest
Is anyone looking into fixing that, before making more commits to
plasma-framework?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman
/r/125420/#comment59356>
or faster,
QString::compare(mimeName, name(), Qt::CaseInsensitive) != 0
- David Faure
On Sept. 27, 2015, 2:59 p.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically generated e-mail. To
, that this is for
shared-mime-info < 1.3
So that we can remove that code, in 10 years ;)
- David Faure
On Sept. 28, 2015, 8:41 p.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
l. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> ---
>
> (Updated Sept. 12, 2015, 9:38 a.m.)
>
>
> Review request for Plasma and David Faure.
>
>
> Repository: plasma-workspace
>
>
&
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85238
---
Ship it!
Ship It!
- David Faure
On Sept. 12, 2015, 9:38
into a separate line of code for
readability, but other than that, this looks good, thanks for having made and
tested the change.
- David Faure
On Sept. 8, 2015, 3:05 p.m., Martin Klapetek wrote:
>
> ---
> This is an automatically ge
> On Sept. 7, 2015, 7:25 a.m., David Faure wrote:
> > There's no need to call aliases() at all, trader queries (and in fact
> > ksycoca already) do resolve aliases.
And since you're calling this for one URL at a time, you don't need
KFileItemActions, just do
const KSer
(and in fact ksycoca
already) do resolve aliases.
- David Faure
On May 13, 2015, 5:05 p.m., Martin Klapetek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote:
I've got both Gentoo and Arch saying this causes a major problem [1]:
libdraganddropplugin.so changes to draganddropplugin.so
in /usr/lib/qt/qml/org/kde/draganddrop
and then they don't get loaded.
any ideas? Otherwise I'll
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124633/#review83697
---
Ship it!
- David Faure
On Aug. 5, 2015, 10:41 p.m
the CC list?
I'd like to split the responsibilities cleanly.
Anything in the CI view Frameworks kf5-qt5 (and stable) should come here,
anything else shouldn't ;)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Plasma
for instance, aren't you
missing an accessor in KService? OK, on the other hand, if this is the only
user, then property(...) would do too, but still, compile-time checking is
more robust.
About ksycocathreadtest: I just pushed many fixes for it, does it pass for you
now?
- David Faure
On Aug. 5
, could just be =
- David Faure
On Aug. 5, 2015, 8:57 p.m., Sebastian Kügler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124633
the directory (*it_dir)?
After all the current logic is to iterate over a list of languages, and see
which ones do exist. Might as well just look at what exists, without starting
from a possible list of languages?
- David Faure
On March 25, 2015, 9:17 p.m., Alex Richardson wrote
531e88b4257901e890f16c23761d2c0aa538d524
Diff: https://git.reviewboard.kde.org/r/124534/diff/
Testing
---
Logged out and back in many times :)
My autostart folder got copied correctly, including symlinks
Thanks,
David Faure
___
Plasma-devel
marked as submitted.
Review request for Plasma and Vishesh Handa.
Changes
---
Submitted with commit e33b582fda5588762aa50e3ad619283b97e7d758 by David Faure
to branch master.
Repository: plasma-workspace
Description
---
Commit f913e251fe6 removed this, due to a porting bug: both
ksmserver/startup.cpp 531e88b4257901e890f16c23761d2c0aa538d524
Diff: https://git.reviewboard.kde.org/r/124534/diff/
Testing
---
Logged out and back in many times :)
My autostart folder got copied correctly, including symlinks
Thanks,
David Faure
://commits.kde.org/kcoreaddons/bf48030d6fec4efbfa0f8ea5a379d2250dc9da1c
(just pushed now)
- David Faure
On July 30, 2015, 12:48 p.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org
---
Logged out and back in many times :)
My autostart folder got copied correctly, including symlinks
Thanks,
David Faure
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
On July 30, 2015, 12:48 p.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124534
doesn't have
operator for QString, and QString's implicit conversion to char * is disabled
by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a bug in the
first place).
I'm pretty sure that toLocal8Bit().constData() is the proper way to give a
QString to cout/cerr...
- David Faure
On July 20, 2015, 12:32 p.m., David Faure wrote:
This is rather surprising. How does it compile? std::cout doesn't have
operator for QString, and QString's implicit conversion to char * is
disabled by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a
bug in the first
On May 14, 2015, 7:17 p.m., David Faure wrote:
Right, this code should have been ported to
entry.insert(KIO::UDSEntry::UDS_TARGET_URL,
QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH)));
This would seem safer to me, because closer to the kde4 behaviour
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123781/#review80432
---
Ship it!
Ship It!
- David Faure
On May 13, 2015, 7:38 p.m
On May 14, 2015, 7:17 p.m., David Faure wrote:
Right, this code should have been ported to
entry.insert(KIO::UDSEntry::UDS_TARGET_URL,
QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH)));
This would seem safer to me, because closer to the kde4 behaviour
::UDSEntry::UDS_TARGET_URL,
QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH)));
This would seem safer to me, because closer to the kde4 behaviour.
I'm just not sure you caught all the cases where the target url was used (e.g.
properties dialog etc.)
- David Faure
On May 13
mid(0, ) above. The unittest will tell you if I'm wrong by one char, but I
don't think so :)
- David Faure
On April 30, 2015, 9:05 a.m., Ashish Bansal wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123544/#review79694
---
Ship it!
Ship It!
- David Faure
On April 28, 2015, 6:18
/global.cpp (line 417)
https://git.reviewboard.kde.org/r/123224/#comment54445
QString suggestedName =
(it's not used before this line, so it should be declared here; could even
be const QString suggestedName = ... since it's not modified later)
- David Faure
On April 26, 2015
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote:
autotests/globaltest.cpp, line 96
https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96
This should be (1).txt?
Ashish Bansal wrote:
imho if my any file starts with ., that's my dot file and I would
, it can return the mimetype and
even the known suffix without any iteration needed, see
QMimeDatabase::suffixForFileName.
- David Faure
On April 4, 2015, 1:15 p.m., Ashish Bansal wrote:
---
This is an automatically generated e-mail
::NoGlobals,
QStandardPaths::GenericDataLocation).groupList()` instead to
KLocale::languageList()?
David Faure wrote:
Sounds to me like it should be a method in ki18n, it's a bit too arcane
to be maintainable.
Alex Richardson wrote:
Seems like it's not the right replacement
On March 25, 2015, 9:54 p.m., Lukáš Tinkl wrote:
man/kio_man.cpp, line 242
https://git.reviewboard.kde.org/r/123131/diff/1/?file=356605#file356605line242
Not correct, this returns only user configured list of languages,
whereas it previously returned the full list.
Nick
.
Every bugfix (compared to the previous release, not for commits from the day
before) can matter to users of the frameworks. Having them in the changelog is
IMHO useful. So I agree, it's not every commit, but it's not major features
only either.
--
David Faure, fa...@kde.org, http
On Friday 13 March 2015 09:29:44 David Faure wrote:
Plasma framework
* Fix plasmapkg2 for translated systems
* Improve tooltip layout
* Make it possible to let plasmoids to load scripts outside the plasma
package
...
Plasma-framework developers: this ... means, please use CHANGELOG
Qt should be taking care
of
- David Faure
On Jan. 21, 2015, 4:57 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122184
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121882/#review73281
---
Ship it!
Ship It!
- David Faure
On Jan. 6, 2015, 3:05 p.m
-
CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974
drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67
Diff: https://git.reviewboard.kde.org/r/121718/diff/
Testing
---
Compiling without qt5 webkit.
Thanks,
David Faure
___
Plasma
)
REVIEW: 121718
Diffs (updated)
-
CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974
drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67
Diff: https://git.reviewboard.kde.org/r/121718/diff/
Testing
---
Compiling without qt5 webkit.
Thanks,
David Faure
://git.reviewboard.kde.org/r/121718/#review72659
---
On Dec. 28, 2014, 6:16 p.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121718
a362d7ec651c027d91d0912e84817cd3a2f94d67
Diff: https://git.reviewboard.kde.org/r/121718/diff/
Testing
---
Compiling without qt5 webkit.
Thanks,
David Faure
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Monday 22 December 2014 10:21:21 Marco Martin wrote:
On Saturday 20 December 2014, David Faure wrote:
in the branch mart/kpluginmetadata there is an experiment in porting
away
from kservice, tough if i go all the way it should have a complete own
copy of the plugin indexing
kservice it should be completely independent from it
Sounds like depending on kcoreaddons (if the plugin indexing can go there)
would be better than duplicating the whole thing.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
...
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Thursday 23 October 2014 13:20:06 David Edmundson wrote:
On Thu, Oct 23, 2014 at 9:33 AM, David Faure fa...@kde.org wrote:
On Monday 20 October 2014 02:52:58 David Edmundson wrote:
Give me the sha1 to cherry-pick and I'll make a 5.3.1
-pick and I'll make a 5.3.1 with it.
Sorry for the delay.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
(the EmailClient and the x-scheme-handler/mailto.
- David Faure
On Oct. 12, 2014, 8:43 p.m., Luc Menut wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120569
account? I don't have time to submit all your
patches :-)
https://techbase.kde.org/Contribute/Get_a_Contributor_Account
- David Faure
On Oct. 12, 2014, 5:48 p.m., Luc Menut wrote:
---
This is an automatically generated e-mail. To reply
On Oct. 12, 2014, 8:51 p.m., David Faure wrote:
kcms/componentchooser/componentchooserbrowser.cpp, line 102
https://git.reviewboard.kde.org/r/120568/diff/1/?file=318115#file318115line102
No, I am very much against this.
The whole point of use the right KDE app is to use
:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120568/
---
(Updated Oct. 12, 2014, 8:40 p.m.)
Review request for Plasma and David Faure
is obsoleted by this, I
guess you're keeping it for old implementations, that's fine.
Hmm, well, kservice/src/kbuildsycoca/kmimeassociations.cpp is such an old
implementation, it doesn't read Default Applications yet :-)
That's something else you might want to fix ;)
- David Faure
On Oct. 12
then use KRun directly in the kio
code that looks up x-scheme-handler stuff (grep says: KRun and
DesktopExecParser).
- David Faure
On Oct. 12, 2014, 8:40 p.m., Luc Menut wrote:
---
This is an automatically generated e-mail. To reply
-frameworks-de...@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Plasma-devel mailing list
Plasma-devel@kde.org
On Wednesday 20 August 2014 11:38:12 Jonathan Riddell wrote:
On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote:
On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote:
On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote:
On Tue, Jul 01, 2014 at 11:25:11PM
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote:
I'm a bit worried by the multitude of user and distro specific scripts that
rely on kdesu being present :/
Marco Martin wrote:
to me either way it gets fixed i'm ok.
the other option is to keep it called kdesu, so it wouldn't be
On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote:
On Tue, Jul 01, 2014 at 11:25:11PM +0200, David Faure wrote:
On Sunday 27 April 2014 19:35:37 I wrote:
* place that repo in kde/ or kde/something in the projects.kde.org
hierarchy, so that it gets released with the KDE
doesn't really need sed.
- David Faure
On July 6, 2014, 12:52 p.m., Luca Beltrame wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119145
, but indeed it's
missing in qtpaths, I'll fix that.
We should be using it, because ConfigLocation includes the appname on Windows
(big whoops).
- David Faure
On July 6, 2014, 1:19 p.m., Luca Beltrame wrote:
---
This is an automatically
On July 6, 2014, 1:25 p.m., David Faure wrote:
I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's
missing in qtpaths, I'll fix that.
We should be using it, because ConfigLocation includes the appname on
Windows (big whoops).
I mean we should be using
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119146/#review61706
---
Ship it!
Thanks.
- David Faure
On July 6, 2014, 1:28 p.m
On July 6, 2014, 1:25 p.m., David Faure wrote:
I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's
missing in qtpaths, I'll fix that.
We should be using it, because ConfigLocation includes the appname on
Windows (big whoops).
David Faure wrote:
I
/119145/#comment42946
comment needs to be updated
startkde/startkde.cmake
https://git.reviewboard.kde.org/r/119145/#comment42945
comment needs to be updated
- David Faure
On July 6, 2014, 1:35 p.m., Luca Beltrame wrote
/119145/#comment42950
s/Move to/Use/ - we don't have to move any files :-)
- David Faure
On July 6, 2014, 1:46 p.m., Luca Beltrame wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org
/119053/#comment42722
sounds like shortcutFromInList(keys) should be put in a local variable, for
use in this line and the next.
- David Faure
On July 1, 2014, 7:59 a.m., Martin Gräßlin wrote:
---
This is an automatically
301 - 400 of 481 matches
Mail list logo
