D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Instead of kuserfeedback which uploads data collected prior users consent, I believe this patch is good enough. @ngraham It appears that I should let you know that, I'm no longer going to work on it under these circumstances, so that you can use it if you want.

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. In D27199#629881 , @manueljlin wrote: > In D27199#627422 , @gvgeo wrote: > > > Differently sized icons are about to be restored in D28034

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

gvgeo added a comment. Are there objections for `Math.round(gridUnit * 2.33)` (42 with default settings) suggested by @filifp? So that it can have big icons. In D27845#622739 , @ndavis wrote: > I don't want to turn this into bikeshedding,

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. Differently sized icons are about to be restored in D28034 . > ...text indicator replaced with a 1px divider... Is it a good idea to tweak it or is it better to leave it like it is? The alternative is the first version

D28034: [WIP] [Applet] Port to ExpandableListItem

gvgeo added a comment. Labels need eliding. Full width has problems? Button need to expand also. Click always collapse? Listitem.qml can be deleted now. I didn't see itemExpanded use anywhere. In expandedView (main patch) there is height in Layout. Button right margin is

D28003: [WIP]Expose global switch to the user

gvgeo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY This is a rough patch and will be abandoned. See D28002 instead. REPOSITORY R120 Plasma

D27823: Use consistent highlight

gvgeo added a comment. Couple of notes, as I'm not sure what the aim was here. I have not test it, take them with a grain of salt. - Highlight area was changed, without changing the click area. - Connect button pop up area change, was not documented. - Highlight svg is not consistent

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Generally FormLayout is unfit for this, If I understand it correctly they cannot get `theme.smallestFont` height. Which will introduce big height, and big margins between lines. > IIRC the labels were reduced opacity before, and this was not a change introduced

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. > Do we need to reduce the opacity for the labels? Is this a visual design argument or a coding one? The opacity was reduced in the layout update. Are you saying that should not had be changed. IMO this is vital part of the new layout. > We don't really do

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

gvgeo added a comment. I believe that D26992 , moves the icons down. And this patch, by adding an extra smallSpacing/2 makes it more noticeable. Baking magic numbers is always questionable. Either the 1 smallspacing before, or the current 3/2, or 2

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. @ngraham If FormLayout does not support opacity/enabled for labels, then maybe, this patch is good enough. INLINE COMMENTS > DetailsText.qml:67 > font.pointSize: theme.smallestFont.pointSize > -text: details[(index*2)+1] > +

D27608: Fixes for applet configuration layout.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d6731530bb43: Fixes for applet configuration layout. (authored by gvgeo). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=77046=77050 REVISION

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

gvgeo added a comment. IMO better use Math.round(gridUnit*2.1) than fixed value that will not always look good with a scaled display. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: gvgeo, davidedmundson, ndavis,

D27870: [applets/systemtray] Right align popup heading when in RTL mode

gvgeo added a comment. It seems that QQC2 as long a horizontal value is set, will flip it around. Otherwise will use the default direction left. Agree, looks like a bug. Kirigami and frameworks are the places where this should be set. Already have corrected the other patch. REPOSITORY

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 77046. gvgeo added a comment. Remove title alingment for kirigami change. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=77017=77046 BRANCH configscollcat (branched from master) REVISION DETAIL

D27874: Disable the audio stream indicator for IOTM

gvgeo added a comment. Disable the mute function then. And maybe add as an option. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: gvgeo, ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27792: [Applet]Fix traffic monitor labels width

This revision was automatically updated to reflect the committed changes. Closed by commit R116:986341a3fae8: [Applet]Fix traffic monitor labels width (authored by gvgeo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 77017. gvgeo added a comment. Prevent vertical scrollbar from popping on/off internally. Fix title alignment for RTL. I tried splitting into two patches, to separate the height loop changes, but could not find a good point to cut the patch. All the

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. I don't plan to make more patches, for now. But if the problem would not exist with layouts, prefer to do it than make quick bugfixes. But can't see how the Layouts would help with that. Everything can be done without Layouts too AFAIK, just more messy. I want

D27608: Fixes for applet configuration layout.

gvgeo added a comment. There is a problem, I still try to fix... REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf, ngraham Cc: ngraham, filipf, plasma-devel, Orage,

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo abandoned this revision. gvgeo added a comment. Unfortunately I won't be able to continue with this patch about battery applet. Feel free to use/modify if you want. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg,

D27608: Fixes for applet configuration layout.

gvgeo added a comment. Strange, I don't get the resizing problem as it is now, or in master. Only managed to get this space by changing the theme, and was immediately fixed with resize. Thanks Filip for double checking. REPOSITORY R119 Plasma Desktop BRANCH configscollcat

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76910. gvgeo added a comment. Cancel button was touching the edge in RTL. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=76908=76910 BRANCH configscollcat (branched from master) REVISION DETAIL

D27645: [KCM]Align volume controls row

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ca15ec82c121: [KCM]Align volume controls row (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76884=76909 REVISION

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76908. gvgeo marked an inline comment as not done. gvgeo added a comment. Fixed margins. Unfortunatly the RTL layout has some issues, had to disable the use of available width for RTL layout, to stop the jumping from the scrollview. REPOSITORY R119

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. #VDG Does a better way exist, to measure the width of transfer speed text? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27792 To: gvgeo, #vdg, #plasma, jgrulich, ngraham Cc:

D26946: Changed leftMargins to smallSpacing to be consistent

gvgeo added inline comments. INLINE COMMENTS > PopupDialog.qml:120 > boundsBehavior: Flickable.StopAtBounds > -spacing: Math.round(units.gridUnit / 2) > +spacing: Math.round(units.smallSpacing / 2) > I don't see why decrease this spacing. Were you able to

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76884. gvgeo added a comment. Fix rebase. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76874=76884 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76874. gvgeo added a comment. Math round. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76873=76874 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76873. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76519=76873 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645

D27608: Fixes for applet configuration layout.

gvgeo marked an inline comment as done. gvgeo added a comment. I'll give a bit more time, so @filipf gets a chance to check again and accept if possible. REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608

D27422: [KCM]Update Device item layout based on applet

This revision was automatically updated to reflect the committed changes. Closed by commit R115:606c6499750a: [KCM]Update Device item layout based on applet (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76869. gvgeo edited the test plan for this revision. gvgeo added a comment. Restore code for vertical line. Cannot find a reason this happens or replicate. But realized that the change was unnecessary. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. In D27422#614236 , @ngraham wrote: > I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows: > > F8112849: Screenshot_20200219_075319.png > >

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76840. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=76475=76840 BRANCH kcmports3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27422

D27577: [KCM]Fix content below scrollbars

This revision was automatically updated to reflect the committed changes. Closed by commit R115:552b0384ffd2: [KCM]Fix content below scrollbars (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76467=76836

D27734: [Applet/TaskManager]Don't create extra PulseAudio component

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bfcc6df32396: [Applet/TaskManager]Dont create extra PulseAudio component (authored by gvgeo). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27608: Fixes for applet configuration layout.

gvgeo added a comment. > I'm starting to agree that this is the wrong place to add the titlebar separator. Can this go as is, for now? I don't believe there is an alternative in the near future. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To:

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. Is it? INLINE COMMENTS > TrafficMonitor.qml:107 > +// Measure 888.8 KiB/s > +text: KCoreAddons.Format.formatByteSize(910131) + i18n("/s") > +} Biggest number it can display? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. @ngraham Is there a better way to fix this? In D27199#620730 , @jgrulich wrote: > Looks this changed introduced an issue. The traffic monitor doesn't fit into the applet. > > See picture below: > F8145280:

D27792: [Applet]Fix traffic monitor labels width

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use text metrics to set a proper space for labels. And remove unused plotter

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

gvgeo added a comment. IMO this is the wrong way to do these changes. 1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be best to increase the size in one place. 2. For tablets already allow to use bigger

D27737: Fixed margin of digital clock

gvgeo added a comment. I was too late, it does change constantly now. But it depends on the font. The default font has the same width for all numbers, others don't. Wish I could at least help with git, but I struggle with it. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27737: Fixed margin of digital clock

gvgeo added a comment. By using paintedWidth size is going to change constantly and will move the rest of the widgets. REPOSITORY R120 Plasma Workspace BRANCH margin_digital_clock (branched from master) REVISION DETAIL https://phabricator.kde.org/D27737 To: niccolove, #vdg, #plasma,

D27645: [KCM]Align volume controls row

gvgeo added a comment. In my opinion this is better even without the workaround. Only when scale is 100% for playback devices, look worse (first photo in before-after). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma,

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. I don't see any objections, will push to stable. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ngraham, apol, plasma-devel,

D27734: [Applet/TaskManager]Don't create extra PulseAudio component

gvgeo created this revision. gvgeo added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use the component already created. TEST PLAN Functionality must stay the same. Test with

D27711: [Applet]Use gridLayout for details

gvgeo abandoned this revision. gvgeo added a comment. In favor of kirigami form. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Kirigami in applet? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Separate patch so can be easily reverted, if a grid+repeater problem exist R120:d12521b149fa . REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27711: [Applet]Use gridLayout for details

gvgeo created this revision. gvgeo added reviewers: Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use gridLayout for repeater in DetailsText. Now right mouse menu(copy) opens on

D27199: [Applet]Update layout based on T10470

This revision was automatically updated to reflect the committed changes. Closed by commit R116:24b737bc6d5c: [Applet]Update layout based on T10470 (authored by gvgeo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27669: WIP: [kstyle] Tools area

gvgeo added a comment. Filelight works fine here. Kmag has some buttons with wrong color, but the toolbar row takes correct color. With breeze light when changing active window, color changing is not in sync with the titlebar. The timing is a little off, can get dizzy. REPOSITORY R31

D27199: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 76526. gvgeo edited the summary of this revision. gvgeo added a comment. rebase REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=75906=76526 BRANCH arcpatch-D27199_2 REVISION DETAIL

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76519. gvgeo added a comment. Removed workaround. (It would be nice to mention breeze theme.) REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76353=76519 BRANCH scaleM (branched from

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

gvgeo added inline comments. INLINE COMMENTS > main.qml:46 > > +readonly property bool plasmaPaAvailable: > Qt.createComponent("PulseAudio.qml").status === Component.Ready > + I get a feeling there are 2 instances now. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27645: [KCM]Align volume controls row

gvgeo added a comment. Should I remove the slider workaround? And leave it with 2 pixel offset? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n,

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. ping REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo added a comment. @davidedmundson ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

gvgeo added inline comments. INLINE COMMENTS > Task.qml:230 > +onAudioIndicatorsEnabledChanged: { > +audioStreamIconLoader.active = audioIndicatorsEnabled; > } Better include hasAudioStream too, or will be active for all tasks, even if it is not visible. REPOSITORY R119

D27648: [KCM]Set implicitWidth for main page

This revision was automatically updated to reflect the committed changes. Closed by commit R115:8dea974eacf0: [KCM]Set implicitWidth for main page (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27648?vs=76358=76480

D27420: [Applet]Improvements for unavailable port.

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ada3385d04c3: [Applet]Improvements for unavailable port. (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76475. gvgeo added a comment. Hide portbox if window is too small. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=76093=76475 BRANCH kcmports2 REVISION DETAIL

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76467. gvgeo added a comment. Added item as a proxy for the devices and applications. This fixed the vertical binding loop. And made scrollbar touch the top and botoom edges. With this patch content is closer, by smallSpacing, to the frame. And

D27420: [Applet]Improvements for unavailable port.

gvgeo added a comment. Don't see anyone objecting, will commit later. REPOSITORY R115 Plasma Audio Volume Applet BRANCH FreeThePort3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27420 To: gvgeo, #plasma, drosca, ngraham Cc: pino, plasma-devel, Orage, LeGast00n,

D27651: Fixes for applet configuration layout.

gvgeo abandoned this revision. gvgeo added a comment. Accidental patch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27651 To: gvgeo, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27651: Fixes for applet configuration layout.

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Fix applet configuration overlap with top line. Change the margins to move scrollbar so that it

D27648: [KCM]Set implicitWidth for main page

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Set implicitWidth in the main page for the initial size when opening audio

D27608: Fixes for applet configuration layout.

gvgeo added a comment. Can't have everything. now will cat line again. F8130965: Screenshot_20200225_140134.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf Cc: ngraham,

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76356. gvgeo added a comment. Categories touch top and bottom. Removed 1 unnecessary line. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=76320=76356 BRANCH configscollcat (branched from master)

D27645: [KCM]Align volume controls row

gvgeo added inline comments. INLINE COMMENTS > VolumeSlider.qml:43 > +// Workaround: Slider has 2 extra pixels at the bottom, used for the > tickmarks, which move it off-center. > +Layout.bottomMargin: -Math.round(slider.implicitHeight / 11) > + I tried to change

D27645: [KCM]Align volume controls row

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Align mute button, slider and percent text. Set proper margin for mute. Cut

D27608: Fixes for applet configuration layout.

gvgeo added inline comments. INLINE COMMENTS > AppletConfiguration.qml:117 > Kirigami.Separator { > -visible: configDialog.configModel > -anchors.left: sidebar.right > -height: root.height > -} > - > -Kirigami.Separator { > +id: topSeparator >

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76320. gvgeo added a comment. style restore REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=76319=76320 BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76319. gvgeo retitled this revision from "Fix applet configuration ovelap with top line" to "Fixes for applet configuration layout.". gvgeo edited the summary of this revision. gvgeo edited the test plan for this revision. gvgeo added a comment. Added all

D27608: Fix applet configuration ovelap with top line

gvgeo planned changes to this revision. gvgeo added a comment. Will add more related changes here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. Today for 5.18.2 or can wait? Apol only looked the code for the first change. And I don't know why vertical margins create bind loop, or if Item as a proxy is good. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. I would not call them stylistic choice, the position didn't change. And there are included in description. Make Header always fit inside the scrollview area. They had 2 different problems, when the text is too big. As enabled they would cut text left and

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. In D27577#616579 , @ngraham wrote: > The changes to labels in `Header.qml` seem unrelated. They are as related as the other 4 changes are. Either will make 5 different patches or 1. But I'm not going to change

D27608: Fix applet configuration ovelap with top line

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY For plasmoids configuration add top line as topMargin. TEST PLAN Open desktop configuration.

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76202. gvgeo added a comment. typo REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76201=76202 BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76201. gvgeo added a comment. Make scrollbars touch the side of the frame. Fit speaker test grid inside the scrollview area. Fix advanced content layout. Make Header always fit inside the scrollview area. REPOSITORY R115 Plasma Audio Volume Applet

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76200. gvgeo edited the test plan for this revision. gvgeo added a comment. Changed comment. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76173=76200 BRANCH scrollbars (branched from

D27577: [KCM]Fix content below scrollbars

gvgeo added inline comments. INLINE COMMENTS > Advanced.qml:33 > +// TODO Fix contentview width, and Remove policy. > +ScrollBar.horizontal.policy: ScrollBar.AlwaysOff > > What if there's too many devices? No matter how many devices there are, column is always a column. > It doesn't

D27577: [KCM]Fix content below scrollbars

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Set content to use available space. BUG:416331 BUG:417447 TEST PLAN Open audio

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76093. gvgeo added a comment. Fix problem 3 REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75971=76093 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 AFFECTED FILES

D27261: [Folder view] Fix binding loop on width

gvgeo added a comment. I logged with my main account and I get lots of file:///code/kde/usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:306:17: QML Label: Binding loop detected for property "width" REPOSITORY R119 Plasma Desktop REVISION

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. > I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows: I cannot replicate this. And I cannot see how I could have created this. Or where to start. Here's my short list of problems. F8113183: problems.png

D27316: [Folder view]Make shadow scale aware

gvgeo added a comment. In D27316#613771 , @davidedmundson wrote: > I don't know > > You can find > > ./qml/QtGraphicalEffects/private/DropShadowBase.qml > > somewhere in /usr on your local system, > > add in some > console.log

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75971. gvgeo added a comment. Kirigami units. Remove unnecessary preferred width. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75935=75971 BRANCH kcmports2 REVISION DETAIL

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. Although this is a general problem, just to be clear. Without Plasma Components I don't get any scaling. F8111566: Screenshot_20200218_214017.png REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL

D27316: [Folder view]Make shadow scale aware

gvgeo added a comment. It was more of a general question... Anyway I tried, nothing happens. I Believe it uses the qmlc files. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson Cc:

D27316: [Folder view]Make shadow scale aware

gvgeo added a comment. I use arch's Qt 5.14.1 Any chance I only have this problem? My build is not exactly stable. Btw found some places that use radius spallSpacing or gridUnit, like knewstuff. I wonder how that look, with that commit. REPOSITORY R119 Plasma Desktop REVISION

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75935. gvgeo added a comment. More style fixes. (indentation restore) REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75820=75935 BRANCH kcmports2 REVISION DETAIL

D27316: [Folder view]Make shadow scale aware

gvgeo added inline comments. INLINE COMMENTS > FolderItemDelegate.qml:435 > +radius: Math.round(5 * units.devicePixelRatio) > +samples: radius * 2 + 1 > spread: 0.05 And I ate the "one" `Ideally, this value should be twice

D27316: [Folder view]Make shadow scale aware

gvgeo added inline comments. INLINE COMMENTS > FolderItemDelegate.qml:435 > +radius: Math.round(5 * units.devicePixelRatio) > +samples: radius * 2 + 1 > spread: 0.05

D27316: [Folder view]Make shadow scale aware

gvgeo added a comment. Can I close this patch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo added a comment. Is there any problem with this patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n,

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. Thanks Nate, both for explaining and taking care of the patches yesterday. REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma, drosca, ngraham, #vdg Cc: plasma-devel, Orage,

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. The worst problem I could found, by ignoring the margins. Theme "Underworld". F8110467: Screenshot_20200218_134914.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199

  1   2   3   >