/calendartable.h 8678593
libs/plasmaclock/calendartable.cpp d2b436e
libs/taskmanager/groupmanager.cpp 45c15a9
Diff: https://git.reviewboard.kde.org/r/105779/diff/
Testing
---
works for me
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma
Diff: https://git.reviewboard.kde.org/r/105924/diff/
Testing
---
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/
Testing
---
not too much, surely have to update this diff a couple of times. But you can
start dropping comments anyway.
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
://git.reviewboard.kde.org/r/111087/diff/
Testing
---
File Attachments
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/taskbar_nocut.png
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org
. 25, 2013, 6:20 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/
---
(Updated Feb. 25, 2013, 6:20 p.m
load an icon file from the svg theme and specify the element to
use, e.g.: source: svgname-elementname
- do you know how to read the size of the containment the widget is
contained?
no, and this should never be required.
Greg T wrote:
- - there is an annoyance in the task list
/package/contents/ui/Task.qml
PRE-CREATION
plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml
PRE-CREATION
plasma/netbook/applets/currentappcontrol/package/metadata.desktop
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109124/diff/
Testing
---
Thanks,
Greg
://git.reviewboard.kde.org/r/109124/diff/
Testing
---
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
the image looks
silly.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/#review27958
---
On Feb. 24, 2013, 11:10 a.m., Greg T
---
On Oct. 21, 2012, 10:23 a.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106448
On Feb. 8, 2013, 10:16 p.m., Albert Astals Cid wrote:
What is the status of this? Are you guys still working on it? Needs
improvements? Can be commited? Should be discarded? It's been 3 months
without activity!
Greg T wrote:
nope, there has been made some progress in the last
5c2e73f9d6b8207efd3a3de6464278d1bdbc9263
Diff: http://git.reviewboard.kde.org/r/107433/diff/
Testing
---
Screenshots
---
dropdown
http://git.reviewboard.kde.org/r/107433/s/850/
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel
/currentappcontrol/currentappcontrol.cpp
5c2e73f9d6b8207efd3a3de6464278d1bdbc9263
Diff: http://git.reviewboard.kde.org/r/107433/diff/
Testing
---
Screenshots
---
dropdown
http://git.reviewboard.kde.org/r/107433/s/850/
Thanks,
Greg T
___
Plasma
/diff/
Testing
---
works on my laptop when I set the screen brightness with the batterymonitor
plasmoid
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
3d0926fab8dac334d56d5cce430691e501b6f8c7
Diff: http://git.reviewboard.kde.org/r/107398/diff/
Testing
---
works on my laptop when I set the screen brightness with the batterymonitor
plasmoid
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org
3d0926fab8dac334d56d5cce430691e501b6f8c7
Diff: http://git.reviewboard.kde.org/r/107398/diff/
Testing
---
works on my laptop when I set the screen brightness with the batterymonitor
plasmoid
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
the dataengine.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107398/#review22339
---
On Nov. 21, 2012, 5:43 p.m., Greg T wrote
too
- Greg T
On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107026
---
not too much, surely have to update this diff a couple of times. But you can
start dropping comments anyway.
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
:
http://git.reviewboard.kde.org/r/106448/#review20586
---
On Oct. 21, 2012, 10:23 a.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
/diff/
Testing
---
not too much, surely have to update this diff a couple of times. But you can
start dropping comments anyway.
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
desktop files for the kickoff launcher:
- metadata.desktop and the old plasma-applet-launcher.desktop
- we don't need CMakeLists.txt in core/ anymore?
- also it conflicts with my last commit in kickoff-qml (just a minor in
kickoff.qml)
- Greg T
On Oct. 19, 2012, 1:04 p.m., Marco Martin wrote
---
not too much, surely have to update this diff a couple of times. But you can
start dropping comments anyway.
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106448/#review19954
---
On Sept. 20, 2012, 4:10 p.m., Greg T wrote
b62370e8a428087bb7671b60632e8fe458d1ee67
Diff: http://git.reviewboard.kde.org/r/106743/diff/
Testing
---
no issues noted
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote:
any updates on this?
what are the major blocker still remaining for a merge?
Greg T wrote:
well, to summarize it:
- classic menu broken
- some minor functionality missing
- martin didn't tested it?
I think we
970bf3c0e60915f49dc7318a9789bf9cd0830b59
plasma/netbook/containments/netpanel/panel.cpp
a53eb5f642b5102719bf11329b1a5c5be1c13c99
plasma/netbook/shell/plasmaapp.cpp 22c54b2ba9e746e85eb7c581ebee26e3ba63b459
Diff: http://git.reviewboard.kde.org/r/106723/diff/
Testing
---
Thanks,
Greg T
we handle this
case somewhere in the model?
- Greg T
On Sept. 29, 2012, 8:21 p.m., Alex Fiestas wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106637
-dataengine-packagekit.desktop
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/106448/diff/
Testing
---
not too much, surely have to update this diff a couple of times. But you can
start dropping comments anyway.
Thanks,
Greg T
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106448/#review18978
---
On Sept. 14, 2012, 7:04 p.m., Greg T wrote
-packagekit.desktop
PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/106448/diff/
Testing
---
not too much, surely have to update this diff a couple of times. But you can
start dropping comments anyway.
Thanks,
Greg T
___
Plasma-devel mailing list
/package/metadata.desktop PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/106448/diff/
Testing
---
not too much, surely have to update this diff a couple of times. But you can
start dropping comments anyway.
Thanks,
Greg T
___
Plasma-devel
---
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106365/#review18645
---
On Sept. 7, 2012, 9:20 a.m., Greg T wrote:
---
This is an automatically generated e-mail
/appletinterface.cpp 75dc2f0
Diff: http://git.reviewboard.kde.org/r/106365/diff/
Testing
---
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
version replacing the C++ version in master. we need to get this merged as
soon as possible so people can start using it and we can start improving
problems that crop up.
Greg T wrote:
Hi Aaron,
1. I really think as long as we support a context menu, we must also
provide those 2
On Aug. 31, 2012, 7:49 a.m., Albert Astals Cid wrote:
This has been commited late for 4.9.1 tagging (6 hours late) and without a
shipit from anyone in the reviewboard, so I'm not that eager to redo the
tarballs. Can anyone convince me otherwise? (You have 6 hours for that)
whoops, too
On Aug. 26, 2012, 7:50 a.m., Greg T wrote:
besides the points mentioned in review 106125, you have to remember that
KDE 4.8 is already EOL and there will be no more bugfix release (i.e.
4.8.6).
Richard Stockton wrote:
Yes, but I was asked to put it on the 4.8 tree in case
understand the
reporter correctly, he wants to move with Up/Down keys in the search view as
soon as he enters a search query. With your patch applied I still have to hit
the tab key first. Can you set the focus automatically on the view?
- Greg T
On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote
On Aug. 23, 2012, 2:53 p.m., Greg T wrote:
I think this time we can get kickoff-qml into kde 4.10. But this is no
reason to push this fix not into master :)
Richard Stockton wrote:
Thanks, Greg! I think we both plan this method for managing the two
modules, please advise if I am
to remember that KDE
4.8 is already EOL and there will be no more bugfix release (i.e. 4.8.6).
- Greg T
On Aug. 22, 2012, 9:06 p.m., Richard Stockton wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
://bugs.kde.org/show_bug.cgi?id=252291
Diffs
-
plasma/generic/applets/digital-clock/clock.h f4822ec
plasma/generic/applets/digital-clock/clock.cpp 1331776
Diff: http://git.reviewboard.kde.org/r/106223/diff/
Testing
---
issue fixed, using long date.
Thanks,
Greg T
. But this is no reason
to push this fix not into master :)
- Greg T
On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106125
-
plasma/generic/applets/digital-clock/clock.cpp 1331776
Diff: http://git.reviewboard.kde.org/r/105933/diff/
Testing
---
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
=281464
Diffs
-
libs/plasmaclock/calendar.cpp 75bfc31
libs/plasmaclock/calendartable.h 8678593
libs/plasmaclock/calendartable.cpp d2b436e
libs/taskmanager/groupmanager.cpp 45c15a9
Diff: http://git.reviewboard.kde.org/r/105924/diff/
Testing
---
Thanks,
Greg T
/groupmanager.cpp 45c15a9
Diff: http://git.reviewboard.kde.org/r/105924/diff/
Testing
---
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105924/#review17095
---
On Aug. 8, 2012, 7:35 a.m., Greg T wrote
45c15a9
Diff: http://git.reviewboard.kde.org/r/105779/diff/
Testing
---
works for me
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
://git.reviewboard.kde.org/r/105765/diff/
Testing
---
tested in a panel
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105769/#review16574
---
Ship it!
Ship It!
- Greg T
On July 28, 2012, 1:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105765/#review16571
---
On July 28, 2012, 11:24 a.m., Greg T wrote
On July 19, 2012, 9:04 a.m., Marco Martin wrote:
thanks, wouldn;t have remembered ;)
the changes seems good, but i'm not sure about giving kickoff a copy of the
tabbar.
any reason this is not proposed as a patch for the tabbar component itself?
Greg T wrote:
Of course I
e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105405/#review15332
---
On July 1, 2012, 8:42 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply
---
On July 1, 2012, 8:42 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105405
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/10/#review15869
---
Ship it!
Ship It!
- Greg T
On July 13, 2012, 2:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105550/#review15874
---
Ship it!
Ship It!
- Greg T
On July 13, 2012, 11:52 a.m
entrys?
- Greg T
On July 13, 2012, 2:49 p.m., Jekyll Wu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/10
or...?
Greg T wrote:
ah, I see.
Nope, I'm using plain master and that bug is definitely *not* fixed. The
preferred filemanager and browser icons keep reappaering on login. The
function GroupManagerPrivate::unsaveLauncher can't remove that config entrys
because the name of the launcher
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105473/#review15533
---
Ship it!
Ship It!
- Greg T
On July 7, 2012, 2:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105340/#review15316
---
Ship it!
Ship It!
- Greg T
On June 29, 2012, 11:38 a.m
/
Testing
---
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
afd1f2c
Diff: http://git.reviewboard.kde.org/r/105374/diff/
Testing
---
no regressions noted.
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
'browser'
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review15230
---
On June 28, 2012, 3:48 p.m., Greg T wrote
this review request.
This addresses bug 278724.
http://bugs.kde.org/show_bug.cgi?id=278724
Diffs (updated)
-
libs/taskmanager/groupmanager.cpp 5ca0159
Diff: http://git.reviewboard.kde.org/r/105374/diff/
Testing
---
no regressions noted.
Thanks,
Greg T
On June 28, 2012, 4:58 p.m., Aaron J. Seigo wrote:
Ship It!
Johannes Tröscher wrote:
i'm not that experienced with git.. i've pushed it to master, could you
backport it to 4.9? i don't know how to push single commits
I suggest you to use 'git cherry-pick' for that task.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105196/#review14571
---
On June 9, 2012, 12:32 p.m., Greg T wrote
/applets/kickoff/package/contents/ui/kickoff.qml 4a9a5e6
Diff: http://git.reviewboard.kde.org/r/105196/diff/
Testing
---
kinda works
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
bug fixed.
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
MarbleWidget.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105118/#review14296
---
On May 31, 2012, 12:52 p.m., Greg T wrote
!
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104959/#review14005
---
On May 21, 2012, 6:46 p.m., Greg T wrote
/activities.operations f9ce034
plasma/generic/dataengines/activities/activityjob.cpp 7fe8823
Diff: http://git.reviewboard.kde.org/r/104959/diff/
Testing
---
click: activity manager comes up
click again: manager vanishes!
Thanks,
Greg T
.
This addresses bug 266870.
http://bugs.kde.org/show_bug.cgi?id=266870
Diffs
-
plasma/generic/applets/icon/icon.cpp 4bdbae4
Diff: http://git.reviewboard.kde.org/r/104764/diff/
Testing
---
bug fixed
Thanks,
Greg T
___
Plasma-devel
---
seems to work
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
://bugs.kde.org/show_bug.cgi?id=199811
Diffs
-
plasma/generic/applets/icon/icon.cpp b25e5d6
Diff: http://git.reviewboard.kde.org/r/103435/diff/diff
Testing
---
looks good
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
: http://git.reviewboard.kde.org/r/103435/diff/diff
Testing
---
looks good
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
4ce4e73
applets/qalculate/qalculate_settings.cpp b62145b
Diff: http://git.reviewboard.kde.org/r/103052/diff/diff
Testing
---
seems to work
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo
/qalculate_applet.h aee14c0
applets/qalculate/qalculate_applet.cpp 4da9241
applets/qalculate/qalculate_history.h 59185ee
applets/qalculate/qalculate_history.cpp 35592a7
Diff: http://git.reviewboard.kde.org/r/103052/diff/diff
Testing
---
seems to work
Thanks,
Greg T
applets/qalculate/qalculate_applet.cpp 4da9241
applets/qalculate/qalculate_history.h 59185ee
applets/qalculate/qalculate_history.cpp 35592a7
Diff: http://git.reviewboard.kde.org/r/103052/diff/diff
Testing
---
seems to work
Thanks,
Greg T
---
On Dec. 8, 2011, 8:48 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103052/
---
(Updated
/#review8754
---
On Dec. 8, 2011, 8:48 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103052
generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103282/#review8689
---
On Nov. 28, 2011, 3:52 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply
a2acb35
Diff: http://git.reviewboard.kde.org/r/103159/diff/diff
Testing
---
works very nice
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
very nice
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
://git.reviewboard.kde.org/r/103052/diff/diff
Testing
---
seems to work
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
widget qalculate - PluginInfo-Website
Description (updated)
---
The old link was inaccurate.
Diffs (updated)
-
applets/qalculate/plasma-applet-qalculate.desktop 580c898
Diff: http://git.reviewboard.kde.org/r/103037/diff/diff
Testing
---
Thanks,
Greg T
., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103037/
---
(Updated Nov. 3, 2011, 12:24 p.m.)
Review request
applets/frame/picture.cpp 57d82ed
applets/frame/slideshow.cpp a461244
Diff: http://git.reviewboard.kde.org/r/103001/diff/diff
Testing
---
it compiles
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman
/slideshow.cpp 116c514
dataengines/potd/potd.cpp f1b9933
Diff: http://git.reviewboard.kde.org/r/102817/diff/diff
Testing
---
Bug fixed.
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo
---
On Oct. 28, 2011, 10:20 a.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102817
be add a URL item in the potd
DataEngine that is included with the source. this could be either a remote
or a local URL and wouldn't require the applet to be changed if/when the
DataEngine changes.
Greg T wrote:
Well, I get the basic idea but can you try to explain it a little bit
---
On Oct. 10, 2011, 10:41 a.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102817/
---
(Updated
Testing
---
Bug fixed.
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
On Sept. 1, 2011, 10:56 a.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102300
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102300/
---
(Updated Sept. 1, 2011, 10:56 a.m.)
Review request for KDE Base Apps and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102300/
---
(Updated Sept. 5, 2011, 9:33 a.m.)
Review request for KDE Base Apps and
97 matches
Mail list logo
