D26444: [RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This was present in the old `SourcesModel` but not ported to the new one. TEST PLAN 5.17

D26434: [Battery Monitor] Don't blink when battery is critical

This revision was automatically updated to reflect the committed changes. Closed by commit R120:222b407454f7: [Battery Monitor] Dont blink when battery is critical (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26434: [Battery Monitor] Don't blink when battery is critical

broulik added a comment. Works here. `notify-send foo bar -u critical` will show on top of everything. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26434 To: broulik, #plasma, anthonyfieroni Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26434: [Battery Monitor] Don't blink when battery is critical

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Especially when you're almost out of juice you don't want to be wasting it blinking an icon

D26086: Don't fetch pixmap if we have it already

This revision was automatically updated to reflect the committed changes. Closed by commit R120:08f02266c922: Dont fetch pixmap if we have it already (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26086?vs=71794=72785 REVISION

D26425: [Notifications KCM] Fixup current item syncing logic

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of relying on `currentIndex` and some massively complicated logic to track when the

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top

broulik added a comment. hmm, I wanted to have it more obvious than being the first "System Service" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26423 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it obvious that it's not an application or "service" but more of an overall category

D26422: [Notifications] Fix ListView attached property

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It is only attached to the delegate item itself. Broke when it got shuffled around when

D26378: [Download Plugin] Register downloaded files as recent documents

This revision was automatically updated to reflect the committed changes. Closed by commit R856:ddea25bf47f1: [Download Plugin] Register downloaded files as recent documents (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D26378: [Download Plugin] Register downloaded files as recent documents

broulik updated this revision to Diff 72737. broulik edited the test plan for this revision. broulik added a comment. - Make configurable REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26378?vs=72656=72737 REVISION DETAIL

D25991: [KFilePlacesModel] Fix supported scheme check for devices

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R241:3a6e3f927111: [KFilePlacesModel] Fix supported scheme check for devices (authored by broulik). Herald added a

D26403: [ToolTip] Round position

This revision was automatically updated to reflect the committed changes. Closed by commit R858:415683af956c: [ToolTip] Round position (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26403?vs=72705=72706

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25991 To: broulik, #frameworks, dfaure, ngraham, bruns Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26403: [ToolTip] Round position

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise screws up font rendering TEST PLAN Before F7858341: Screenshot_20200103_192446.png

D26077: [kcms/ksmserver] Swap shutdown options

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c4dc4bd45238: [kcms/ksmserver] Swap shutdown options (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26077?vs=71761=72681 REVISION

D26378: [Download Plugin] Register downloaded files as recent documents

broulik added a comment. Should it purge the entry from kactivities stats when you manually remove the download from the download list in the browser? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D26378 To: broulik, #plasma, hein, #vdg, fvogt

D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

broulik added a comment. > by disabling the display of critical notifications. It doesn't disable them. Merely keeps them behind full screen windows. I think the option is fine as it is. (You know, if we had some kuserfeedback data to prove that nobody disables this option... :p)

D26378: [Download Plugin] Register downloaded files as recent documents

broulik updated this revision to Diff 72656. broulik added a comment. - Ignore incognito downloads REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26378?vs=72655=72656 REVISION DETAIL https://phabricator.kde.org/D26378 AFFECTED FILES

D26378: [Download Plugin] Register downloaded files as recent documents

broulik created this revision. broulik added reviewers: Plasma, hein, VDG, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes them more easily accessible throughout the shell. TEST PLAN I'm a bit

D26183: Fix build with Qt 5.14

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. Please use `qmlRegisterAnonymousType` REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26183 To: tcanabrava, davidedmundson Cc: broulik, plasma-devel, LeGast00n,

D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The multiplexer is responsible for global media control shortcuts which won't work with a player

D23676: [Folder View] Only install watch on .directory file if actually used

broulik added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23676 To: broulik, #plasma, hein Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,

D26297: [Notifications] Don't show DrKonqi notifications in history

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e7e747b9bea1: [Notifications] Dont show DrKonqi notifications in history (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26297?vs=72401=72421#toc REPOSITORY R120

D26035: battery: Improve the brightness responsiveness

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Seems to work well, thanks REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26035 To: apol, #plasma, broulik Cc: plasma-devel,

D26297: [Notifications] Don't show DrKonqi notifications in history

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It creates a tray icon, so having a history entry is just annoying duplication. TEST PLAN

D26296: Add Opera Extension ID

broulik created this revision. broulik added reviewers: Plasma, leinir. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I submitted it to the Opera Add-ons store and despite having been signed with the same

D25851: [Notifications] Add quick reply feature

This revision was automatically updated to reflect the committed changes. Closed by commit R120:73a3222c6dd1: Merge branch broulik/quickreply (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25851?vs=71197=72391#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE

D25762: Only serialize window pixmap if we're using it

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b49d5cfde098: Only serialize window pixmap if were using it (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25762?vs=71789=72347

D26219: Check DPMS extension being present

This revision was automatically updated to reflect the committed changes. Closed by commit R122:18e53dbaaea2: Check for DPMS extension being present (authored by broulik). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26219?vs=72160=72234 REVISION DETAIL

D26219: Check DPMS extension being present

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It might be disabled. Don't die in this case. BUG: 414921 FIXED-IN: 5.17.5 TEST PLAN

D26160: [Notifications] For non-configurable applications use fake "@other" category

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4280515eebb0: [Notifications] For non-configurable applications use fake @other category (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26161: [Notifications KCM] Add "Other Applications" category

This revision was automatically updated to reflect the committed changes. Closed by commit R119:41e27fa56cd8: [Notifications KCM] Add Other Applications category (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26161?vs=72013=72062

D26162: [Notifications KCM] Force re-evaluation of position radio buttons

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The Settings object is kind of a write-only state and doesn't signal property changes unless

D26161: [Notifications KCM] Add "Other Applications" category

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Settings in there will influence all non-identifyable applications. TEST PLAN See aso

D26160: [Notifications] For non-configurable applications use fake "@other" category

broulik updated this revision to Diff 72012. broulik added a comment. - Ship `plasmanotifyrc` file with them disabled by default REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26160?vs=72011=72012 REVISION DETAIL

D26160: [Notifications] For non-configurable applications use fake "@other" category

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Allows to control the behavior of those applications rather than flat-out ignoring them. TEST

D26125: [Notifications] Release all cookies when service unregisters

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1967dc08e3db: [Notifications] Release all cookies when service unregisters (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26125?vs=71905=71906#toc REPOSITORY R120

D26125: [Notifications] Release all cookies when service unregisters

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY An application could have multiple inhibitions. Release all of them when the service unregisters

D26121: Kicker/RecentDocument display file path as decoration

broulik added inline comments. INLINE COMMENTS > recentusagemodel.cpp:269 > +QString desc = fileItem.localPath(); > +desc.truncate(desc.lastIndexOf(QChar('/'))); > +return desc; Can you use the "~" for HOME like the runners do please REPOSITORY R120 Plasma Workspace

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

broulik updated this revision to Diff 71887. broulik added a comment. - Use renamed hint REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26120?vs=71879=71887 REVISION DETAIL https://phabricator.kde.org/D26120 AFFECTED FILES src/bluedevil.notifyrc

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8dc1db04b9be: [Notifications] Add hint for a notification being response to explicit user… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25935?vs=71877=71882#toc

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

broulik added a comment. In D25935#580527 , @davidedmundson wrote: > I thought you were going to call it UserActionFeedback? You said "user-action works" REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

broulik created this revision. broulik added reviewers: VDG, drosca, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Saves the user from having to close the dialog when pairing succeeded. TEST PLAN -

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

broulik updated this revision to Diff 71877. broulik retitled this revision from "[Notifications] Add hint for showing a notification even in do not disturb mode" to "[Notifications] Add hint for a notification being response to explicit user interaction". broulik edited the summary of this

D25916: [Notifications] Provide better feedback when copying a single file

broulik abandoned this revision. broulik added a comment. I forgot why this was needed - KDE Connect works fine after I fixed the job... REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D25916 To: broulik, #plasma, #vdg Cc: plasma-devel, LeGast00n,

D25951: Show peripheral low battery notification for NoCharge

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R122:14212f78de5f: Show peripheral low battery notification for NoCharge (authored by broulik). REPOSITORY R122

D26091: [Notifications] Improve self-closing behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R120:90a69a7b508a: [Notifications] Improve self-closing behavior (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26091?vs=71821=71873#toc REPOSITORY R120 Plasma Workspace

D26093: Use a fixed icon size for the notification popup close button

broulik added a comment. F7826451: Screenshot_20191220_095532.png The icon looks pretty big here now - wouldn't it be `small` for normal `ToolButton` icon? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26093 To:

D26111: KRunner add a recentlyused runner accessing KActivityStats data

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Why not change the recentdocuments runner? We have various places where we whitelist recentdocuments as a runner and if a user disabled it, this would not be carried over

D25874: [Task Manager] Consider parent PID for audio stream

This revision was automatically updated to reflect the committed changes. Closed by commit R119:09a258a22ed4: [Task Manager] Consider parent PID for audio stream (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25874?vs=71251=71844

D25780: [Notifications] Set total amount to processed amount if no total and no error

broulik abandoned this revision. broulik added a comment. Given the trash issue and the fact that fixing KDE Connect was easy, let's abandon this: https://invent.kde.org/kde/kdeconnect-kde/merge_requests/188/diffs REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25851: [Notifications] Add quick reply feature

broulik added inline comments. INLINE COMMENTS > notification.cpp:637 > > +if (!d->hasReplyAction && name == QLatin1String("reply")) { > +d->hasReplyAction = true; I'll change that to "inline-reply" to avoid potential clashes > server_p.cpp:234 >

D26091: [Notifications] Improve self-closing behavior

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a plasmoid collapses in Active state, the popup is hidden. In Passive state, however, one

D26086: Don't fetch pixmap if we have it already

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `AppData` contains a `QIcon` with pixmap data gathered from `KWindowSystem::icon` which we

D25762: Only serialize window pixmap if we're using it

broulik updated this revision to Diff 71789. broulik retitled this revision from "Don't bother serializing window icon pixmap for known services" to "Only serialize window pixmap if we're using it". broulik edited the summary of this revision. broulik added a comment. - Use

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R119:35e8cb70c0c0: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26018?vs=71599=71787#toc REPOSITORY

D25782: [Notifications] Add draggable file icon when single file job finishes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:a22c44dafc6b: [Notifications] Add draggable file icon when single file job finishes (authored by broulik). CHANGED

D25992: [Wizard] Allow choosing device by double click

This revision was automatically updated to reflect the committed changes. Closed by commit R97:0fd34f0497cc: [Wizard] Allow choosing device by double click (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25992?vs=71525=71770 REVISION

D25634: Add kconf update script for ksmserver

broulik added a comment. -1 I'd prefer if the config value was kept REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25634 To: davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26077: [kcms/ksmserver] Swap shutdown options

broulik created this revision. broulik added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY With kcfg magic the order of the radio buttons determines the enum value. Just swap them

D26065: [KCM/Access] Port to use KConfigXT

broulik added a comment. I read kaccess.cpp and commented on where the defaults diverge, there could be more. There's also some keys that have typos and/or don't match. This shows quite impressively why having this stuff in a central place is useful :) Given kaccess.cpp is what does the

D25874: [Task Manager] Consider parent PID for audio stream

broulik added a comment. I have not. Given a browser window typically has dozens of children whereas you typically have few audio streams, I think if any it will be slower. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25874 To: broulik, #plasma, hein Cc:

D25762: Don't bother serializing window icon pixmap for known services

broulik planned changes to this revision. broulik added a comment. > That means you can limit serializing to cases where the window is in usingFallbackIcon. Good idea, I'll give it a try. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25762 To:

D25539: feat(kcm): add revert timer

broulik added a comment. > With direct-apply having a revert window/overlay/inline message only shown when certain critical options were changed could be a good compromise. It needs to be made absolute sure, though, that the keyboard focus is correct, so hitting e.g. Return will undo

D25762: Don't bother serializing window icon pixmap for known services

broulik added a comment. > why don't we just change the check to QIcon::isNull? We still want to serialize custom pixmap data icons which won't be null. What we want to do is tell between "icon on disk" and "icon from pixmap data" which we can't really at the moment. REPOSITORY R120

D26047: Expose KConfig settings to allow registration in KCM Notification

broulik added inline comments. INLINE COMMENTS > settings.h:343 > > +QList configSkeletons() const; > + Not a fan of this becoming public API REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26047 To: crossi, #plasma, #frameworks, ervin, bport,

D26045: Add immutability to KCM Icons

broulik added inline comments. INLINE COMMENTS > main.qml:38 > view.currentIndex: kcm.pluginIndex(kcm.iconsSettings.theme) > -enabled: !kcm.downloadingFile > Why this change? > main.qml:55 > > +enabled: !kcm.iconsSettings.isImmutable("Theme") // don't allow to > change

D26035: battery: Improve the brightness responsiveness

broulik added a comment. `PlasmaComponents` 3 `Slider` doesn't react to wheel events, which must be fixed before this can go in. INLINE COMMENTS > PopupDialog.qml:48 > - > -keyboardBrightnessSlider.valueChanged.connect(function() { > -batterymonitor.keyboardBrightness =

D25984: Load translations

broulik added a comment. I guess it builds the QML tree and evaluates the `qsTr` calls and then finds it needs an item from a plugin and loads the import and only then translates it. Subsequent controls are translated, only the ones on the initial item are not. Perhaps if we shoehorn a

D25984: Load translations

broulik added a comment. Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks,

D25984: Load translations

broulik added a comment. Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik,

D25984: Load translations

broulik added a comment. We don't link against Kirigami, so the startup routine stuff doesn't apply? And we're way after the QCoreApp constructor at this point. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau,

D25984: Load translations

broulik added a comment. Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To:

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Not a huge fan of the code duplication there.. Needs D26013

D26012: Restore circular progress bar in compact notification applet

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Lovely! REPOSITORY R120 Plasma Workspace BRANCH circular_progress REVISION DETAIL https://phabricator.kde.org/D26012 To: ahiemstra, #plasma, broulik Cc: broulik, plasma-devel,

D25950: Add specialized notification for Bluetooth battery

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R122:ef856e3598ec: Add specialized notification for Bluetooth battery (authored by broulik). REPOSITORY R122 Powerdevil

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:943ca2072a80: [Notifications] Show hint if notifications arent available or provided by… (authored by broulik).

D25983: Update size hint when font changes

This revision was automatically updated to reflect the committed changes. Closed by commit R858:51871406787d: Update size hint when font changes (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D26012: Restore circular progress bar in compact notification applet

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CompactRepresentation.qml:103 > running: visible > +opacity: compactRoot.jobsPercentage == 0 ? 1 : 0 > } You might want

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

broulik added a comment. I agree. The tooltips get in the way far too often as they are, so making them stay unnecessarily would be annoying. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D25952 To: ngraham, #plasma, #vdg, hein, ndavis Cc:

D25967: Emit panelTakesFocus for other plamsashell types

broulik added a comment. No! But it allows them to get it if they want to, e.g. when you hit inline reply REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D25967 To: davidedmundson, #plasma Cc: broulik, apol, plasma-devel,

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

broulik accepted this revision. broulik added a comment. Lovely REPOSITORY R120 Plasma Workspace BRANCH circular_timeout REVISION DETAIL https://phabricator.kde.org/D25993 To: ahiemstra, #plasma, broulik, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik added inline comments. INLINE COMMENTS > bruns wrote in kfileplacesmodel.cpp:758 > you have dropped the `allowedHere` check. Probably just `if (!allowedHere) > continue`. > > And for reasons unknown to me, `tags:` is not filtered per app - move the > allowedHere check to the very

D25992: [Wizard] Allow choosing device by double click

broulik added a comment. I think you can't. It is potentially a long list, so not sure if just clicking it should advance the list, since it is clearly a "wizard" pattern page. If it were a bunch of "command links" it would be obvious that clicking a single item would advance the wizard.

D25992: [Wizard] Allow choosing device by double click

broulik created this revision. broulik added reviewers: Plasma, drosca, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of having to select one and clicking "Next" TEST PLAN Clicked New device,

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A device doesn't usually have a URL so we need to actutally check the underlying

D25984: Load translations

broulik added a comment. Sounds good to me lol REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson,

D25984: Load translations

broulik created this revision. broulik added reviewers: Kirigami, Frameworks, kossebau, aacid. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The ECM QM Loader uses `Q_COREAPP_STARTUP_FUNCTION` which doesn't

D25983: Update size hint when font changes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures controls update their size when font changes. The Labels inside would but the control

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

broulik added a comment. It was suggested to make it more semantic, i.e. be about "this is feedback for user-initiated task" which will then imply showing in dnd mode. Suggestions on how to phrase that as a key name? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25970: [applet] Make details text fully opaque and normal style

broulik added a comment. Make sure that whatever you decide on is also applied to Bluetooth plasmoid REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D25970 To: ngraham, #vdg, jgrulich Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25936: [Desktop Containment] Hide tooltip while rotating the widget

This revision was automatically updated to reflect the committed changes. Closed by commit R119:115a3e1aeede: [Desktop Containment] Hide tooltip while rotating the widget (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25932: [Task Manager] Better align badge in tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:67d86068d7f2: [Task Manager] Better align badge in tooltip (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25932?vs=71384=71455#toc REPOSITORY R119 Plasma Desktop

D25951: Show peripheral low battery notification for NoCharge

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BlueZ doesn't report charge state, only percentage, so it is unfortunately always `NoCharge` for

D25950: Add specialized notification for Bluetooth battery

broulik updated this revision to Diff 71439. broulik added a comment. - Drop odd parentheses REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25950?vs=71437=71439 REVISION DETAIL https://phabricator.kde.org/D25950 AFFECTED FILES

D25950: Add specialized notification for Bluetooth battery

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since we have a type for generic Bluetooth devices now, add a specialized notification for

D25942: Instead of just delaying, compress calls to update

broulik added inline comments. INLINE COMMENTS > ActionToolBarLayoutDetails.qml:110 > + > +onWidthChanged: { delayUpdate.start = true } > +Component.onCompleted: { delayUpdate.start = true } How can this even work? `start` is a method. You probably meant `running = true`? or `start()`

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

broulik updated this revision to Diff 71413. broulik added a comment. - Restore condition REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25917?vs=71412=71413 REVISION DETAIL https://phabricator.kde.org/D25917 AFFECTED FILES

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

broulik updated this revision to Diff 71412. broulik added a comment. - Cleanup REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25917?vs=71350=71412 REVISION DETAIL https://phabricator.kde.org/D25917 AFFECTED FILES

<    2   3   4   5   6   7   8   9   10   11   >