Re: Plasma 5.12.9 LTS

On 9/11/19 9:39 PM, Christoph Feck wrote:> sizeInBytes() can be emulated with bytesPerLine() * height(). The issue is already fixed. Please roll out new tar. Would it be possible to adopt the convention "tars are announced a few days before the tag/release" used by Frameworks and Applications

D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display

zzag added a comment. FYI D20445 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D23831 To: guoyunhe, #plasma Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23783: [kcm] Fix i18n output file name and split texts

zzag added a comment. In D23783#527562 , @pino wrote: > Please do not split the messages just for sake of column width. > > What about just removing the `+` to concatenate the strings, and just use normal continuation, i.e.: > > text:

D23734: Remove the "fail_delay()" function

zzag added a comment. Thank you for looking further into this issue. Just abandon the revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23734 To: jfranklin, #plasma, #kwin, zzag Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23734: Remove the "fail_delay()" function

zzag added a comment. Um, pam_unix I suppose... REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23734 To: jfranklin, #plasma, #kwin, zzag Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D23734: Remove the "fail_delay()" function

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. Hmm, "Unlocking failed" doesn't show up immediately if I type wrong password. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23734 To: jfranklin,

D23734: Remove the "fail_delay()" function

zzag added a comment. > I'd be very curious to know if there is a reason for having a fail_delay() function that performs no action. Just let me know! We want to notify the user as soon as possible about authentication failure. REPOSITORY R133 KScreenLocker REVISION DETAIL

D23287: Create a plugin framework for processes

zzag added inline comments. INLINE COMMENTS > extended_process_list.cpp:31 > + > +class ExtendedProcesses::Private > +{ Symbol of the PIMPL is leaked. Use Q_DECL_HIDDEN. > process_data_provider.h:42-52 > +/** > + * Accessors for process information matching > + */ > +

D23228: Port away from deprecated KWindowSystem API

zzag added a comment. Thank you for doing God's work. ;-) REPOSITORY R133 KScreenLocker BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D23228 To: dfaure, zzag, graesslin, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23228: Port away from deprecated KWindowSystem API

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. > Builds, didn't test yet. Whitelisted shortcuts still work. REPOSITORY R133 KScreenLocker BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D23228 To: dfaure, zzag,

D23079: [GTK3] Fix Firefox's CSD colors, kinda

zzag added a comment. How does it look when Firefox has a server side-decoration? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23079 To: cblack, #vdg, #breeze Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22966: Wayland: backend code cleanup

zzag added inline comments. INLINE COMMENTS > waylandconfig.h:73 > > -QMap outputMap() const; > If libkscreen follows the Frameworks or the Kdelibs coding style, then `WaylandOutput` and `*` have to be separated by a space. See source code of Qt for more examples. Qt Coding Style and

D22924: [Night Color KCM] Don't show advanced controls for constant mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bf1009cf1973: [Night Color KCM] Dont show advanced controls for constant mode (authored by zzag). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22923: [Night Color KCM] Rename "Manual" mode to "Constant"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:68c51ae798da: [Night Color KCM] Rename Manual mode to Constant (authored by zzag). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22923?vs=63059=63165

D22923: [Night Color KCM] Rename "Manual" mode to "Constant"

zzag added a comment. I'll land this patch in 24h if there are no objections from #plasma . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22923 To: zzag, #plasma, #vdg, GB_2, ngraham Cc: plasma-devel, LeGast00n,

D22924: [Night Color KCM] Don't show advanced controls for constant mode

zzag added a comment. I'll land this patch in 24h if there are no objections from #plasma . REPOSITORY R119 Plasma Desktop BRANCH rename-manual-to-constant REVISION DETAIL https://phabricator.kde.org/D22924 To: zzag, #plasma, #vdg, GB_2,

D22924: [Night Color KCM] Don't show advanced controls for constant mode

zzag created this revision. zzag added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The user can only change the color temperature when the constant mode is selected. Therefore, it

D22923: [Night Color KCM] Rename "Manual" mode to "Constant"

zzag created this revision. zzag added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Both the Night Color (KDE Plasma) and the Night Light (GNOME Shell) have so called "Manual" mode. In

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

zzag added inline comments. INLINE COMMENTS > filipf wrote in main.qml:118 > I think using the technical term here is fine. IIRC f.lux tried to simplify > this by adding a bunch of descriptors which compared a particular temperature > value or even range to a lighting condition, e.g. one

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

zzag added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:118 > "Night Color" is the name of the feature itself; you can't truncate it to > save a few words. I think it also needs to keep its capitalization. > > If you're looking to change the string, I would focus on the word >

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

zzag added inline comments. INLINE COMMENTS > zzag wrote in main.qml:118 > Just my 2 cents: you can simplify this string to "Night temperature." Not > sure whether translators will like this change though. but it depends on how you look at it. "Night color temperature" might be a better

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

zzag added inline comments. INLINE COMMENTS > romangg wrote in main.qml:118 > I would leave it with the capital C since it's part of the name. Just my 2 cents: you can simplify this string to "Night temperature." Not sure whether translators will like this change though. REPOSITORY R119

D22623: Bind SQL parameters in firefox bookmarksrunner support

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. KRunners isn't my thing, but I had been working as a backend web developer for quite a while. INLINE COMMENTS > firefox.cpp:98 > } > -QList results = m_fetchsqlite->query(query, QMap

D21950: [Night Color KCM] Add "Constant" mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f254f9be8457: [Night Color KCM] Add Constant mode (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21950?vs=60189=62246#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE

D21949: [libcolorcorrect] Add "Constant" mode

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a6b1c0e543cc: [libcolorcorrect] Add Constant mode (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21949?vs=60188=62245 REVISION DETAIL

D22589: Embrace X-KDE-Wayland-Interfaces

zzag added subscribers: mvourlakos, zzag. zzag added a comment. @mvourlakos Perhaps Latte-Dock will need to set X-KDE-Wayland-Interfaces too (I assume that Latte-Dock uses libtaskmanager). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22589 To: apol,

D22452: Fix text color in non-selected tabs in Firefox

zzag added a comment. We should not style server-side decorated Firefox windows. They are fine. The problem you're trying to solve only affects client-side decorated Firefox windows F7022851: Screenshot_20190714_221415.png F7022853:

D22452: Fix text color in non-selected tabs in Firefox

zzag added a comment. I'm not a Breeze GTK maintainer or developer, but perhaps you need to create separate folder for application specific styles, e.g. src/XXX/apps and put Firefox styles in a corresponding file, e.g. src/XXX/apps/_firefox.scss INLINE COMMENTS >

Re: RFC: Running clang-format across all Plasma (and more?) repos

Hi, On 7/11/19 5:18 PM, David Edmundson wrote: One topic discussed at the recent Plasma sprint was that we should run a code formatting tool (clang-format) over all our repos to ease all future review comments about whitespace. This is a good idea! Reviewing such changes can become really

D10747: Implement zwp_linux_dmabuf_v1

zzag added a comment. > Update protocol xml to wayland-protocols master OT: there's a package called wayland-protocols. We could use it in order to avoid copying protocol specs. name=FindWaylandProtocols.cmake #.rst: # FindWaylandProtocols # --- # # Try to

D22084: Span wayland objects to lifespan of the QApplication

zzag added inline comments. INLINE COMMENTS > apol wrote in waylandintegration.cpp:125 > Yes, note it's a QPointer now. Is it okay to access waylandBlurManager() right after it's been deleted (or rather scheduled for removal)? REPOSITORY R130 Frameworks integration plugin using KWayland

D22084: Span wayland objects to lifespan of the QApplication

zzag added a comment. Hmm, okay, I see what the problem is. The proposed patch seems to be reasonable, but I don't like the new object tree. We could fix this bug by introducing m_isTerminating, e.g. // In setupKWaylandIntegration. connect(qApp, ::aboutToQuick, this, [] {

D22084: Span wayland objects to lifespan of the QApplication

zzag added a comment. Is there any reason for not making WaylandIntegration a child of qApp? (disclaimer: I don't have full insight into the problem) REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D22084 To: davidedmundson,

D10750: wayland: Add support for zwp_linux_dmabuf

zzag added inline comments. INLINE COMMENTS > abstract_egl_backend.cpp:438-439 > +EGL_DMA_BUF_PLANE0_PITCH_EXT, EGLint(planes[0].stride), > +EGL_DMA_BUF_PLANE0_MODIFIER_LO_EXT, EGLint(planes[0].modifier & > 0x), > +EGL_DMA_BUF_PLANE0_MODIFIER_HI_EXT,

D10750: wayland: Add support for zwp_linux_dmabuf

zzag added inline comments. INLINE COMMENTS > abstract_egl_backend.cpp:427 > + > +// FIXME: Add support for multi-planar images > +if (planes.count() != 1) What's holding us from doing that? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: romangg,

D22000: [colors/Breeze] Change selected text color to black

zzag added a comment. Can you attach before & after screenshots? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D22000 To: ndavis, #vdg, #breeze, #plasma Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21949: [libcolorcorrect] Add "Constant" mode

zzag created this revision. zzag added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH native-redshift REVISION DETAIL https://phabricator.kde.org/D21949

D21950: [Night Color KCM] Add "Constant" mode

zzag created this revision. zzag added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH native-redshift REVISION DETAIL https://phabricator.kde.org/D21950

D21869: Border for "separator_menu_item" should be 0

zzag added a comment. I don't like how this patch was reviewed. The underlying problem wasn't fully understood. If an application crashes, then the backtrace is required. I don't see it in the bug report. > (seq64:25899): WARNING **: 09:40:24.716: Invalid borders specified for theme

D21347: [Night Light KCM] Display the kcm on X11 platform

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b60fffd0b1df: [Night Light KCM] Display the kcm on X11 platform (authored by zzag). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21347?vs=58495=59980

D21346: [libcolorcorrect] Allow color correction on X

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e8ff23cfe81e: [libcolorcorrect] Allow color correction on X (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21346?vs=58494=59979

D21869: [RFC] Change border for "separator_menu_item" line-h.png

zzag added a comment. Can you add some meaningful commit message? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21869 To: vzapod Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D21779: Resolve X-Flatpak-RenamedFrom

zzag added inline comments. INLINE COMMENTS > notification_p.h:53 > > +static KService::Ptr serviceForDesktopEntry(const QString ); > + A bit off topic: is there any point for making this method static? You could get away with making serviceForDesktopEntry function static in the cpp

D21646: re-read color palettes when application color changes

zzag added a comment. A bit noob-ish question: can we listen to paletteChanged signal instead? e.g. connect(qApp, ::paletteChanged, this, ::configurationChanged); REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21646 To: sebas, #plasma Cc: zzag, plasma-devel,

D21433: [kdecoration] Unset resize borders for maximized clients

zzag abandoned this revision. zzag added a comment. Hugo will push a bit simpler solution. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D21433 To: zzag, #plasma Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21432: [kdecoration] Unset resize borders for maximized clients

zzag abandoned this revision. zzag added a comment. Hugo will push a bit simpler solution. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21432 To: zzag, #plasma Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D21433: [kdecoration] Unset resize borders for maximized clients

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY So far this decoration theme was setting resize borders unconditionally, without actually taking into

D21432: [kdecoration] Unset resize borders for maximized clients

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY So far this decoration theme was setting resize borders unconditionally, without actually taking into

D21347: [Night Light KCM] Display the kcm on X11 platform

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH native-redshift REVISION DETAIL https://phabricator.kde.org/D21347 AFFECTED

D21346: [libcolorcorrect] Allow color correction on X

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH native-redshift REVISION DETAIL https://phabricator.kde.org/D21346 AFFECTED

D21220: [Touchpad KCM] Fix libinput-less build and warnings

zzag added inline comments. INLINE COMMENTS > libinputcommon.h:28 > template > -T valueLoaderPart(QVariant const ) { Q_UNUSED(reply); return T(); } > +inline T valueLoaderPart(QVariant const ) { Q_UNUSED(reply); return > T(); } > Just a note for the future: you don't have to define this

D20804: RFC: Try getting the X keyboard grab multiple times

zzag added a comment. Arguably it won't help us with all cases because the clients would have to voluntarily participate in the protocol. I wonder whether it's worth fixing this bug on X11 at all. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20804 To:

D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets

zzag added a comment. > I would suggest making the ID much more generic. Maybe org.kde.plasma.windowmanagement From perspective of a former Windows user, "minimize all" is the same as "show desktop." REPOSITORY R119 Plasma Desktop BRANCH

D20804: RFC: Try getting the X keyboard grab multiple times

zzag added a comment. > Wrote relevant matching kwin patch to close effects Have you uploaded it? :-) REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20804 To: davidedmundson, #plasma, #kwin Cc: zzag, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D20576: Add new notifications KCM

zzag added inline comments. INLINE COMMENTS > sourcesmodel.cpp:243 > + > +KConfig *config = new KConfig(file, KConfig::NoGlobals); > + > config->addConfigSources(QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, A bit stupid question: how it gets deleted?

D20445: signalplotter: Add highdpi support

zzag added inline comments. INLINE COMMENTS > ksignalplotter.cpp:897-899 > +pen.setWidthF(1.0 / dpr); > else > +pen.setWidthF(2.0 / dpr); Could you please explain why we have to do this? REPOSITORY R111 KSysguard Library REVISION DETAIL

D19011: Thunderbolt KCM and KDED module

zzag added inline comments. INLINE COMMENTS > kded_bolt.h:34 > +class KNotification; > +namespace Bolt { > +class Device; Coding style nitpick: > Function implementations, class, struct and namespace declarations always > have the opening brace on the start of a line. > dbushelper.cpp:35 > +

D20569: RFC: Use more compact OSD

zzag added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20445: signalplotter: Add highdpi support

zzag added a comment. Yep, those issues are still present. :( F6764644: foo.png REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20445 To: volkov Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D20445: signalplotter: Add highdpi support

zzag added a comment. Oh, nice! FWIW, I made a patch to add HighDPI support some time ago as well. I haven't uploaded it for review because there were issues with beams not being smooth. INLINE COMMENTS > ksignalplotter.cpp:681-682 > +const auto dpr =

D20201: Fix build with Qt 4

This revision was automatically updated to reflect the committed changes. Closed by commit R31:386d3b8ed1e0: Fix build with Qt 4 (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20201?vs=55273=55276 REVISION DETAIL

D20201: Fix build with Qt 4

zzag updated this revision to Diff 55273. zzag added a comment. merghe paths REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20201?vs=55271=55273 BRANCH Plasma/5.15 REVISION DETAIL https://phabricator.kde.org/D20201 AFFECTED FILES

D20201: Fix build with Qt 4

zzag added inline comments. INLINE COMMENTS > fvogt wrote in breezewindowmanager.cpp:904 > Please add that to the already existing `#if` above. Well, for better readability I suggest to keep them both separate. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D20201 To:

D20201: Fix build with Qt 4

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH Plasma/5.15 REVISION DETAIL https://phabricator.kde.org/D20201 AFFECTED FILES

D20182: Compute correct position of drag button press on X11

This revision was automatically updated to reflect the committed changes. Closed by commit R31:1915c484dc9e: Compute correct position of drag button press on X11 (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20182?vs=55221=55236 REVISION

D20182: Compute correct move-resize position on X11

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY While dimensions of QScreen are in logical pixels, the origin is not. As result, computed native

D19971: Fix compilation error when SA_TRACE is 1

This revision was automatically updated to reflect the committed changes. Closed by commit R111:55aa93600b61: Fix compilation error when SA_TRACE is 1 (authored by zzag). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19971?vs=54550=54970 REVISION

D12055: Remove border around menubars

This revision was automatically updated to reflect the committed changes. Closed by commit R98:1c66db4f34c9: Remove border around menubars (authored by zzag). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12055?vs=54576=54969 REVISION DETAIL

D18579: Rework Sensor Browser

zzag added a comment. > Fix code style In general, the coding style situation in KSysGuard is a bit sad. I personally can't trace any distinct coding style, it's basically a mix of every potential coding style. We should probably run clang-format and clang-tidy over it some time

D12055: Remove border around menubars

zzag updated this revision to Diff 54576. zzag added a comment. rebase REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12055?vs=35206=54576 BRANCH remove-border REVISION DETAIL https://phabricator.kde.org/D12055 AFFECTED FILES

D19971: Fix compilation error when SA_TRACE is 1

zzag created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The error itself: /home/vlad/Workspace/KDE/src/kde/workspace/libksysguard/ksgrd/SensorAgent.cpp: In member function ‘void

D19909: Enable blurbehind for panels only if theme sets it

zzag added a comment. What about plasma::dialog? REPOSITORY R120 Plasma Workspace BRANCH supportblurBehindEnabled REVISION DETAIL https://phabricator.kde.org/D19909 To: kossebau, #plasma, davidedmundson Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag resigned from this revision. zzag added a comment. Just to be clear, I'm not against good defaults. I don't like that the defaults are adjusted in such way that icons look sharp only with one particular font size and one particular button size. After all, KDE Plasma is configurable. If

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag added a comment. > What's not worth what? Making some icons sharp only for particular button size and font size. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: ngraham, abetts, plasma-devel,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag added a comment. Not really, I still think it's not worth that. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19603: Fix colours of header bar for acitve and inactive windows

zzag added inline comments. INLINE COMMENTS > zzag wrote in _headerbar.scss:14 > This is probably redundant. Argh, please ignore this comment. It looks like background-image: none, background-color: ..., is used throughout the theme. REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D19603: Fix colours of header bar for acitve and inactive windows

zzag added a comment. > On X11, gtk isn't selecting the backdrop class. Probably because kwin doesn't support one of their new activation flags which would be a GTK bug for not following their fallback correctly. If this is the case, then it's a bit awkward because GTK doesn't follow

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag added a comment. This patch makes buttons sharp only for one particular button size and font size. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19603: Fix colours of header bar for acitve and inactive windows

zzag added a comment. (also, it would be enough just to add a group reviewer) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19603 To: davidedmundson, #breeze, zzag, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19603: Fix colours of header bar for acitve and inactive windows

zzag added a comment. What's the reason for removing the linear gradient? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19603 To: davidedmundson, #breeze, zzag, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

zzag added a comment. I'll backport it to Plasma/5.15. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16093 To: Zren, davidedmundson, ngraham Cc: zzag, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19148: Make shadow sizes linear

zzag added a comment. > I don't see a difference either > If the ambient shadow actually did anything, wouldn't the inner areas of the shadow be significantly different in the second screenshot? Again, I'll repeat, the ambient shadow matters. Decoration shadows are a bit

D19148: Make shadow sizes linear

zzag added a comment. In D19148#418083 , @ndavis wrote: > @zzag Is the only difference between the ambient and directional shadow the Y axis offset? If so, why do we have two shadows if they don't work differently? Well, no, that's not

D19148: Make shadow sizes linear

zzag added a comment. ... though if vdg is okay with the proposed shadows, feel free to push. REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraham, zzag, rooty,

D15907: Compare float values in DecorationButton contains check

zzag resigned from this revision. zzag added a comment. Alright, I'm done. I don't understand what's the point of review where comments are ignored. The fact that reviewer has to address review comments strikes me odd the most, like it's his/her/their responsibility. It's really sad

D19148: Make shadow sizes linear

zzag added a comment. In D19148#417272 , @ndavis wrote: > But then we run into a problem where small shadows aren't visible enough to serve their purpose. Just increase opacity of shadow from ambient light. :-) > How about we just

D15907: Compare float values in DecorationButton contains check

zzag added a comment. void DecorationButtonTest::testContains_data() { QTest::addColumn("geometry"); QTest::addColumn("pos"); QTest::addColumn("contains"); QTest::newRow("left edge (integer)") << QRectF(0, 0, 10, 10) << QPointF(0, 5) << true;

D19148: Make shadow sizes linear

zzag added a comment. Well, I guess that depends on the light. After all we don't try to model "physically correct" shadows. Anyway, I've asked that question about opacity because most folks do the same thing. Also, this is what I did in kstyle. Even though kstyle and kdecoration

D15907: Compare float values in DecorationButton contains check

zzag added a comment. Tests are not less important than the rest of the project. It's not good that we don't care about their readability. I'm not convinced by "current autotest fails without the change on current master and works with the patch". Please make the test simpler. I don't

D19148: Make shadow sizes linear

zzag added a comment. In D19148#416006 , @ndavis wrote: > kstyle uses entirely different shadows, even more so compared to the original values for kdecoration. Should it not be that way? Well, my concern was that now decoration shadows

D15907: Compare float values in DecorationButton contains check

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. See my comment above. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D15907 To: romangg, #kwin, zzag, davidedmundson Cc: plasma-devel,

D19148: Make shadow sizes linear

zzag added a comment. What about kstyle? Is it okay? REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D15907: Compare float values in DecorationButton contains check

zzag added a comment. Looks good to me. I think the test is too much complicated. Would it be simpler to have something like QTest::addColumn("geometry"); QTest::addColumn("pos"); QTest::addColumn("contains"); ? INLINE COMMENTS > decorationbutton.cpp:455 > +//

D15907: Compare float values in DecorationButton contains check

zzag added a comment. Sorry, I applied the change to the wrong repo REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D15907 To: romangg, #kwin, zzag, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15907: Compare float values in DecorationButton contains check

zzag added a comment. Could you please rebase it on master? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D15907 To: romangg, #kwin, zzag, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

zzag added a comment. I'm not convinced that we need yet another shadow size, we already have too many. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze Cc: zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

zzag added a comment. Please revert this change. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19134 To: ndavis, #breeze, ngraham Cc: zzag, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19125: Change shadow color to 0,0,0 for KStyle

zzag added a comment. Should we adjust opacity as well? REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19125 To: ndavis, #vdg, #breeze, ngraham, zzag Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19124: Change shadow color to 0,0,0

zzag added a comment. What about kstyle? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19124 To: ndavis, #vdg, ngraham, filipf Cc: zzag, filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D15512: [startplasmacompositor] Add Wayland socket argument

zzag added a comment. In D15512#359309 , @fvogt wrote: > kwin_wayland just needs to make use of `wl_display_add_socket_auto` (other compositors do as well). It looks like now it does that. REPOSITORY R120 Plasma Workspace REVISION

  1   2   3   4   5   6   >