This revision was automatically updated to reflect the committed changes.
Closed by commit R116:38b659465d86: Unbreak SSH agent support for SSH VPN
tunnels. (authored by jgrulich).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
jgrulich added a comment.
Thank you for your contribution.
REVISION DETAIL
https://phabricator.kde.org/D14035
To: catherinez, #plasma, jgrulich
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
catherinez updated this revision to Diff 39036.
catherinez added a comment.
Complete request when SSH_AUTH_SOCK is not present.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14035?vs=38850=39036
REVISION DETAIL
https://phabricator.kde.org/D14035
AFFECTED FILES
catherinez marked an inline comment as done.
catherinez added a comment.
Done.
REVISION DETAIL
https://phabricator.kde.org/D14035
To: catherinez, #plasma, jgrulich
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> secretagent.cpp:370
> + QLatin1String("SSH_AUTH_SOCK not present"),
> + request.message);
> +
catherinez updated this revision to Diff 38850.
catherinez added a comment.
Added QLatin1String() where requested, handled the case of empty
SSH_AUTH_SOCK.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14035?vs=37535=38850
REVISION DETAIL
https://phabricator.kde.org/D14035
catherinez marked 3 inline comments as done.
catherinez added a comment.
Done.
REVISION DETAIL
https://phabricator.kde.org/D14035
To: catherinez, #plasma, jgrulich
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
jgrulich added inline comments.
INLINE COMMENTS
> secretagent.cpp:363
> +NetworkManager::VpnSetting::Ptr vpnSetting =
> connectionSettings->setting(NetworkManager::Setting::Vpn).dynamicCast();
> +if (vpnSetting->serviceType() ==
> "org.freedesktop.NetworkManager.ssh" &&
catherinez created this revision.
catherinez added a reviewer: Plasma.
catherinez added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
catherinez requested review of this revision.
REVISION SUMMARY
Right now selecting SSH agent as authentication method for SSH VPNs
