D29603: Adds custom spacing between task manager icons

ngraham commandeered this revision. ngraham edited reviewers, added: martellini; removed: ngraham. ngraham added a comment. Cool, thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To: ngraham, #vdg, martellini Cc: ngraham, niccolove, plasma-devel,

D29603: Adds custom spacing between task manager icons

martellini added a comment. Done Adjustable spacing between icons REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To: martellini, #vdg, ngraham Cc: ngraham, niccolove, plasma-devel,

D29603: Adds custom spacing between task manager icons

ngraham added a comment. Thanks! Do you think you could maybe re-open this at https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/? We're transitioning patch review over to GitLab. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To:

D29603: Adds custom spacing between task manager icons

martellini updated this revision to Diff 83182. martellini added a comment. Changed the input field from SpinBox to ComboBox and the options are: - Narrow: 0 px - Medium: 8 px - Wide: 16 px - Extra wide: 24 px REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D29603: Adds custom spacing between task manager icons

martellini added a comment. In D29603#673942 , @ngraham wrote: > Thanks! And sorry for the long delay before reviewing. However this doesn't seem to be working for me; no matter what value I enter, my vertical icons-only-task manager's icon

D29603: Adds custom spacing between task manager icons

ngraham added a comment. Thanks! And sorry for the long delay before reviewing. However this doesn't seem to be working for me; no matter what value I enter, my vertical icons-only-task manager's icon spacing does not change. Also, instead of allowing the user to specify a pixel value,

D29603: Adds custom spacing between task manager icons

martellini added a comment. It should be a little better now, but I left out 2 of the things we said: - I didn't remove the icon size setting from the configuration of the vertical task manager because maybe someone likes small icons when the panel is by the side - I left the spacing

D29603: Adds custom spacing between task manager icons

martellini updated this revision to Diff 82986. martellini added a comment. - Separates the Spacing setting from the others REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29603?vs=82983=82986 BRANCH adjustable-spacing-between-icons (branched from

D29603: Adds custom spacing between task manager icons

martellini updated this revision to Diff 82983. martellini added a comment. - Makes icon scale linearly to the size of the taksbar - Improved the spacing configuration of the taskbar icons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29603: Adds custom spacing between task manager icons

martellini added a comment. In D29603#669457 , @ngraham wrote: > In D29603#669015 , @martellini wrote: > > > Sounds cool. I'll be working on it. > > I must that the iconSize setting is only

D29603: Adds custom spacing between task manager icons

ngraham added a comment. In D29603#669015 , @martellini wrote: > Sounds cool. I'll be working on it. > I must that the iconSize setting is only visibile if the panel is vertical, why do you think it is so? Not sure I fully

D29603: Adds custom spacing between task manager icons

martellini added a comment. Sounds cool. I'll be working on it. I must that the iconSize setting is only visibile if the panel is vertical, why do you think it is so? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To: martellini, #vdg, ngraham Cc:

D29603: Adds custom spacing between task manager icons

ngraham added a comment. In D29603#668422 , @martellini wrote: > > Also, it doesn't make sense IMO to expose separate horizontal and vertical controls; there should be just one control visible, and it should affect the task manager no matter

D29603: Adds custom spacing between task manager icons

martellini added a comment. In D29603#668283 , @niccolove wrote: > Are we really sure this is worth exposing to the user? Not sure at all. I just can't stand the default spacing, because it feels like the icons are crammed. At least if

D29603: Adds custom spacing between task manager icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I think it would make more sense to fix the default sizing behavior rather than adding these. We already have an "icon size" setting which roughly adjusts this already, just

D29603: Adds custom spacing between task manager icons

niccolove added a comment. Are we really sure this is worth exposing to the user? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To: martellini, #vdg Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29603: Adds custom spacing between task manager icons

martellini created this revision. martellini added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. martellini requested review of this revision. REVISION SUMMARY Adds the option to set a custom spacing between the icons of the icons-only task manager.