leinir closed this revision.
leinir added a comment.
Closed by commit 1db3b40cc4f979cc8c50dcfc1a41cddcce973ae7
INLINE COMMENTS
> apol wrote in KNSBackend.cpp:111
> Could be moved into a proper slot?
It /is/ starting to be more than trivial code in there, that'd make sense,
yeah. i'm sure th
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5147
To: leinir, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
apol added inline comments.
INLINE COMMENTS
> KNSBackend.cpp:111
> // Setting setFetching to false when we get an error ensures we don't
> end up in an eternally-fetching state
> -connect(m_engine, &KNSCore::Engine::signalError, this, [this](const
> QString &error) { this->setFetching(
leinir created this revision.
leinir added a project: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
KNS being, at times, a little twitchy means that we have to handle such
things a bit more grac
