Re: Review Request 128915: resize the view just after setting the containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128915/ --- (Updated Sept. 15, 2016, 7:05 a.m.) Status -- This change has been

Re: Review Request 128915: resize the view just after setting the containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128915/#review99202 --- Ship it! Ship It! - David Edmundson On Sept. 15, 2016,

Re: Review Request 128915: resize the view just after setting the containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128915/ --- (Updated Sept. 15, 2016, 10:57 a.m.) Review request for Plasma.

Re: Review Request 128915: resize the view just after setting the containment

> On Sept. 15, 2016, 10:01 a.m., Aleix Pol Gonzalez wrote: > > src/plasmaquick/containmentview.cpp, line 101 > > > > > > Wouldn't it be better to pass the size with the incubation properties? > > Marco Martin

Re: Review Request 128915: resize the view just after setting the containment

> On Sept. 15, 2016, 10:34 a.m., David Edmundson wrote: > > src/plasmaquick/containmentview.cpp, line 137 > > > > > > does it render this redundant? > > Aleix Pol Gonzalez wrote: > Otherwise it could make

Re: Review Request 128915: resize the view just after setting the containment

> On Sept. 15, 2016, 12:34 p.m., David Edmundson wrote: > > src/plasmaquick/containmentview.cpp, line 137 > > > > > > does it render this redundant? Otherwise it could make sense to statically have an

Re: Review Request 128915: resize the view just after setting the containment

> On Sept. 15, 2016, 12:01 p.m., Aleix Pol Gonzalez wrote: > > src/plasmaquick/containmentview.cpp, line 101 > > > > > > Wouldn't it be better to pass the size with the incubation properties? > > Marco Martin

Re: Review Request 128915: resize the view just after setting the containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128915/#review99195 --- Fix it, then Ship it!

Re: Review Request 128915: resize the view just after setting the containment

> On Sept. 15, 2016, 10:01 a.m., Aleix Pol Gonzalez wrote: > > src/plasmaquick/containmentview.cpp, line 101 > > > > > > Wouldn't it be better to pass the size with the incubation properties? hmm, you can't

Re: Review Request 128915: resize the view just after setting the containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128915/#review99192 --- src/plasmaquick/containmentview.cpp (line 101)