D18867: Remove redundant DNS field per bug 403546

[Bruce Anderson]

andersonbruce added a comment.


  Any connection created by the previous version or the basic NetworkManager 
plugin should continue to work even though the DNS server list will not be 
viewable in the new interface. 
  I did not provide an automatic conversion from a previously created 
connection to the new storage format. Neither did I create a warning (popup?) 
if an old style config is displayed by the editor. If there is a consensus to 
add either of these items, I can do that.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18867

To: andersonbruce, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18867: Remove redundant DNS field per bug 403546

[Bruce Anderson]

andersonbruce created this revision.
andersonbruce added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
andersonbruce requested review of this revision.

REVISION SUMMARY
  A DNS field was included on the VPN tab in the initial release to match the
  interface of the underlying NetworkManager plugin. This change removes this 
field and instead 
  requires the user to use the standard DNS field on the IPv4 and/or IPv6 tabs 
to enter DNS 
  servers.
  The import function was changed to insert any DNS servers specified in the 
incoming config 
  file into the new locations and the export function was changed to output DNS 
servers from 
  the IPv4 and IPv6 tabs if they are present but for compatibility with 
connections created 
  with the previous version or with the basic NetworkManager plugin, if the 
IPv4 and IPv6 tabs 
  do not contain DNS and an (undisplayed) entry on the VPN tab is present it 
will export from 
  there.  This allows a user to update a connection to the new format by simply 
exporting it, 
  deleting it, and re-importing it.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  RemoveDNSField

REVISION DETAIL
  https://phabricator.kde.org/D18867

AFFECTED FILES
  libs/editor/connectioneditorbase.cpp
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18716: Add a TextField component

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> TextField.qml:101
> +}
> +icon.name: root.leftAction != null ? root.rightAction.iconName : ""
> +visible: root.leftAction != null && root.leftAction.visible

@mart I'm not sure if it's the right way to convert the icon from the action to 
the one needed by the toolButton (don't support icon.source)

> kirigamiplugin.cpp:181
> +//2.7
> +qmlRegisterType(componentUrl(QStringLiteral("TextField.qml")), uri, 2, 
> 6, "TextField");
> +

@mart Should I use 2.6 or 2.7? I didn't find any information about that version 
I should use.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added a comment.


  Just tried again with a clean build directory, and there's no change. :(
  
  Maybe @davidedmundson can shed some light on this puzzle?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 5 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/5/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 Feb 2019 22:41:37 +
 Build duration:
6 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)16%
(4/25)16%
(4/25)19%
(493/2554)14%
(212/1483)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1247)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/1)0%
(0/1)0%
(0/232)0%
(0/118)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/218)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

D18861: Improve the Fonts KCM UI

[Nathaniel Graham]

ngraham added a comment.


  The other ordering is more English-like, but your suggestion would probably 
be fine too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/3/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 Feb 2019 22:41:36 +
 Build duration:
3 min 45 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/3999)0%
(0/2740)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1407)0%
(0/1116)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/806)0%
(0/470)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/221)0%
(0/114)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1018)0%
(0/759)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/7/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 08 Feb 2019 22:41:36 +
 Build duration:
3 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/23)0%
(0/23)0%
(0/1820)0%
(0/706)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/273)0%
(0/126)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/92)0%
(0/18)classic0%
(0/2)0%
(0/2)0%
(0/189)0%
(0/52)core0%
(0/9)0%
(0/9)0%
(0/505)0%
(0/238)icons0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/48)sidebar0%
(0/4)0%
(0/4)0%
(0/426)0%
(0/202)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/93)0%
(0/22)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/8/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 08 Feb 2019 22:41:38 +
 Build duration:
3 min 21 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D18861: Improve the Fonts KCM UI

[Björn Feber]

GB_2 added a comment.


  What about `Noto Sans 10pt`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre marked an inline comment as done.
davidre added a comment.


  In D18809#408175 , @ngraham wrote:
  
  > Could be. Since this is going to land on the master branch (because it's a 
new feature, not a bugfix), ideally should be developing on the master branch 
too.
  >
  > If your distro packages are too old to accommodate this, you can use 
`kdesrc-build` to build them yourself. See 
https://community.kde.org/Get_Involved/development
  
  
  I have now build it with kdesrc-build and applied the patch and build it 
again as described here: 
https://community.kde.org/Infrastructure/Phabricator#Apply_the_patch_and_compile_the_software
 and it still works for me

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  All right, let's do that. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Noah Davis]

ndavis added a comment.


  In D18861#408286 , @ngraham wrote:
  
  > Personally my preference would be for the strings to be like this: `10 pt 
Noto Sans`
  
  
  That would be fine too since it reads like English. The `|` character makes 
it seem like we're mixing TUI with GUI.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Nathaniel Graham]

ngraham added a comment.


  Personally my preference would be for the strings to be like this: `10 pt 
Noto Sans`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Noah Davis]

ndavis added a comment.


  I don't like the look of the `|` character between the font name and the font 
size. I think the existing "Noto Sans 10" format looked better, but I'm not 
going to formally request changes.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18859: msvc: First commit

[Nathaniel Graham]

ngraham added a comment.


  Then it should not have been submitted yet, or it should have [WIP] at the 
beginning of the title. :)

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: msvc: First commit

[patrick j pereira]

patrickelectric added a comment.


  thank you @ngraham, but this is not ready to review yet.
  But be free to review @D18801 and @D18802

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> davidre wrote in image.cpp:877
> Yes I also saw this method since the backgroundlist uses it but the Header 
> said to use KRun if you want to open a folder instead of it.

Well it just depends on what you want to do. If you want to open the folder, 
then yeah KRun is better. But if you want to highlight it in a file manager 
window, then `highlightInFileManager()` is the way to go.

> WallpaperDelegate.qml:40
>  
>  hoverEnabled: true
>  

I just realized: setting this to false when in slideshow mode is a quick way to 
make them non-selectable.

> config.qml:278
> +text: modelData
> +visible: folderDelegate.hovered
> +delay: 1000

This should also hide itself when either of the actions' tooltips is visible 
(otherwise they overlap each other)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre marked an inline comment as done.
davidre added inline comments.

INLINE COMMENTS

> ngraham wrote in image.cpp:877
> This generates a warning (variable `krun` is unused). I would suggest using 
> `KIO::highlightInFileManager()` instead. For example: 
> https://cgit.kde.org/spectacle.git/tree/src/Gui/KSMainWindow.cpp#n327

Yes I also saw this method since the backgroundlist uses it but the Header said 
to use KRun if you want to open a folder instead of it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre updated this revision to Diff 51218.
davidre added a comment.


  - Use highlightInFileManager instead of KRun

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=51206=51218

BRANCH
  arcpatch-D18809

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: msvc: First commit

[Nathaniel Graham]

ngraham added a comment.


  The title and summary sections need to describe what this patch does. See 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:82b904bce54b: [Kickoff] Return Kickoff to Favorites page 
after running a search (authored by rooty).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18848?vs=51197=51208

REVISION DETAIL
  https://phabricator.kde.org/D18848

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: rooty, #vdg, #plasma, ngraham, hein
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 51213.
GB_2 added a comment.


  Change "Force fonts DPI" checkbox text to "Force font DPI"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18861?vs=51211=51213

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: msvc: First commit

[patrick j pereira]

patrickelectric updated this revision to Diff 51209.
patrickelectric added a comment.


  - msvc: Add cdb configuration

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18859?vs=51207=51209

BRANCH
  msvc

REVISION DETAIL
  https://phabricator.kde.org/D18859

AFFECTED FILES
  src/data/debuggers/external/cdbrc
  src/data/debuggers/internal/cdbrc
  src/drkonqibackends.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsercdb.cpp
  src/parser/backtraceparsercdb.h

To: patrickelectric
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> image.cpp:877
> +{
> +   KRun* krun = new KRun(QUrl::fromLocalFile(path), nullptr);
> +}

This generates a warning (variable `krun` is unused). I would suggest using 
`KIO::highlightInFileManager()` instead. For example: 
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSMainWindow.cpp#n327

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added a comment.


  Could be. Since this is going to land on the master branch (because it's a 
new feature, not a bugfix), ideally should be developing on the master branch 
too.
  
  If your distro packages are too old to accommodate this, you can use 
`kdesrc-build` to build them yourself. See 
https://community.kde.org/Get_Involved/development

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18860: Add comment / description to the translations kcm

[Jonah Brüchert]

jbbgameich created this revision.
jbbgameich added reviewers: hein, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Fixes inconsistency with other kcms

TEST PLAN
  comment is displayed in plasma-settings

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18860

AFFECTED FILES
  kcms/translations/kcm_translations.desktop

To: jbbgameich, hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Krešimir Čohar]

rooty added a comment.


  nice!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg
Cc: rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added a comment.


  In D18809#408101 , @davidre wrote:
  
  > Are the images added immediately to the Gridview if you add a folder?
  
  
  Yep.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: msvc: First commit

[patrick j pereira]

patrickelectric created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
patrickelectric requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Patrick José Pereira 

REPOSITORY
  R871 DrKonqi

BRANCH
  msvc

REVISION DETAIL
  https://phabricator.kde.org/D18859

AFFECTED FILES
  src/drkonqibackends.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsercdb.cpp
  src/parser/backtraceparsercdb.h

To: patrickelectric
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18716: Add a SearchField component

[Carl Schwan]

ognarb updated this revision to Diff 51215.
ognarb added a comment.


  Create a generic TextField instead

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18716?vs=50813=51215

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18716

AFFECTED FILES
  examples/simpleexamples/Sidebar.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/TextField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  I don't know why the images aren't removed immediately on your side. I just 
did a clean build and removed everything from my installation prefix and it 
still works for me. Are you testing directly on the master branch? Maybe the 
difference is that I'm building on the 5.14 branch because of dependencies?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre updated this revision to Diff 51206.
davidre added a comment.


  - Show Tooltip with the full path

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=51202=51206

BRANCH
  arcpatch-D18809

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  No suggestions for improvement! I guess because this has already been 
discussed for weeks in the IRC channel. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18861: Improve the Fonts KCM UI

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Makes some improvements to the Fonts KCM UI, like applying the KDE HIG, 
adding icons and tooltips to buttons and improrving the buttons, updating 
strings and more.
  F6602139: Improved Fonts KCM UI.png 

TEST PLAN
  Open the Fonts KCM.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.


  yeah we've been discussing this for weeks you've got my vote :D

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  In D18809#408086 , @ngraham wrote:
  
  > In D18809#408015 , @davidre 
wrote:
  >
  > > In D18809#407355 , @ngraham 
wrote:
  > >
  > > > - After removing a folder, the wallpaper grid should update immediately 
to reflect that
  > >
  > >
  > > It doesn't work for you? Maybe I missed something in the diff, I will try 
to upload a video.
  >
  >
  > Hmm, it still doesn't work for me, even with the latest version.
  
  
  Are the images added immidiately to the Gridview if you add a folder?
  
  > Also now there's a regression: when I add a folder using the button and 
select a folder in the folder chooser, the name displayed is the name of its 
parent folder, not the actual folder.
  
  Yes that was me being lazy and just assumed that the paths end with a slash 
but that was only the case because I was typing them in rather then clicking.
  
  >>> - The individual elements in the wallpaper grid now can't be individually 
chosen as wallpapers, so there's no need for them to be selectable anymore
  >> 
  >> I think I need help with that.
  > 
  > You would probably need to add a new writable property 
(`delegatesSelectable` maybe?) in 
https://cgit.kde.org/kdeclarative.git/tree/src/qmlcontrols/kcmcontrols/qml/GridView.qml?id=c49f51c1985499b9210b29a3e31a1220f1063334
 and 
https://cgit.kde.org/kdeclarative.git/tree/src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml?id=c49f51c1985499b9210b29a3e31a1220f1063334
  > 
  > Could be material for another patch if you'd like.
  > 
  >> Done. Now the problem is, that if you add two folders with the same name 
you cannot know which is which, Maybe it would be possible to add a tooltip?
  > 
  > Yeah, putting the full path in a tooltip makes sense to me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre updated this revision to Diff 51202.
davidre added a comment.


  - Also handle paths not ending with /

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=51193=51202

BRANCH
  slideshow-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added a comment.


  In D18809#408015 , @davidre wrote:
  
  > In D18809#407355 , @ngraham 
wrote:
  >
  > > - After removing a folder, the wallpaper grid should update immediately 
to reflect that
  >
  >
  > It doesn't work for you? Maybe I missed something in the diff, I will try 
to upload a video.
  
  
  Hmm, it still doesn't work for me, even with the latest version.
  
  Also now there's a regression: when I add a folder using the button and 
select a folder in the folder chooser, the name displayed is the name of its 
parent folder, not the actual folder.
  
  >> - The individual elements in the wallpaper grid now can't be individually 
chosen as wallpapers, so there's no need for them to be selectable anymore
  > 
  > I think I need help with that.
  
  You would probably need to add a new writable property (`delegatesSelectable` 
maybe?) in 
https://cgit.kde.org/kdeclarative.git/tree/src/qmlcontrols/kcmcontrols/qml/GridView.qml?id=c49f51c1985499b9210b29a3e31a1220f1063334
 and 
https://cgit.kde.org/kdeclarative.git/tree/src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml?id=c49f51c1985499b9210b29a3e31a1220f1063334
  
  Could be material for another patch if you'd like.
  
  > Done. Now the problem is, that if you add two folders with the same name 
you cannot know which is which, Maybe it would be possible to add a tooltip?
  
  Yeah, putting the full path in a tooltip makes sense to me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Krešimir Čohar]

rooty updated this revision to Diff 51197.
rooty added a comment.


  Reorder code instead of adding property changes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18848?vs=51176=51197

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Krešimir Čohar]

rooty added a comment.


  > Doesn't that mean the code in switchToInitial just needs reordering to set 
the state (to Normal) first and then do the tab change? (Or alternatively the 
tab change could be cleaned away from the function.)
  
  You're right! That's a lot simpler than adding a property change, and it 
works.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Request for another 5.14 bugfix release

[Jonathan Riddell]

Yes as discussed on IRC right now we're planning on doing a 5.14.5.1
on Monday for the modules which need it.

Jonathan

On Fri, 8 Feb 2019 at 16:42, Nate Graham  wrote:
>
> Hello release team!
>
> I would like to request that we consider doing one more Plasma 5.14
> bugfix release. 5.14.5 shipped with Discover very badly broken, and
> we've fixed it with a commit on the 5.14 branch [1].
>
> In addition, Debian Stable is planning to freeze on Plasma 5.14, so with
> an eye towards making this release as stable as possible for them, we've
> landed and backported fixes for various high-profile issues onto their
> respective repos' Plasma/5.14 branches [2].
>
> It would be nice if we could get a new bugfix release sometime in the
> new few days or weeks, or at least a re-spin of the tars for discover,
> plasma-desktop, and plasma-workspace.
>
> Thanks everyone!
>
> Nate
>
>
> [1]
> https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=003fc9fc980003ec0a4d13a020a40c5cf903c411
>
> [2] https://bugs.kde.org/show_bug.cgi?id=395401
>  https://bugs.kde.org/show_bug.cgi?id=402574
>  https://bugs.kde.org/show_bug.cgi?id=354802
>  https://bugs.kde.org/show_bug.cgi?id=401023
>  https://bugs.kde.org/show_bug.cgi?id=393630
>
>

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  The video showing that the Gridview updates when I remove a Folder:
  F6601697: 2019-02-08 15-30-38.mp4 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre updated this revision to Diff 51193.
davidre added a comment.


  Show only folder name and show remove and  open actions on hover

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18809?vs=51120=51193

BRANCH
  slideshow-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18809

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  In D18809#407355 , @ngraham wrote:
  
  > This is a huge improvement over what we have right now. Very nice job!
  
  
  Thanks!
  
  > A few behavioral issues:
  > 
  > - After removing a folder, the wallpaper grid should update immediately to 
reflect that
  
  It doesn't work for you? Maybe I missed something in the diff, I will try to 
upload a video.
  
  > - The individual elements in the wallpaper grid now can't be individually 
chosen as wallpapers, so there's no need for them to be selectable anymore
  
  I think I need help with that.
  
  > And a design issue: now that it's not taking up the full width, the folder 
list manages to feel space-inefficient while also eliding the text most of the 
time. And there's not so much room left for the wallpaper grid so it feels a 
bit scrunched, especially in System Settings at the default window size:
  >  F6598236: A bit scrunched.png 
  > 
  > I would recommend showing just the folder name, not the full path. Then you 
can reduce its width a bit, so that it's say, a maximum of 25% of the total 
layout width. Right now it's more like 33-40% of the total width most of the 
time which feels too wide.
  
  Done. Now the problem is, that if you add two folders with the same name you 
cannot know which is which, Maybe it would be possible to add a tooltip?
  
  > Ideas for further improvement (not necessary in this patch, but nice to 
have)
  > 
  > - The Remove button should show up on hover rathet than being always 
visible. If you use a Kirigami `SwipeListItem` instead of a `BasicListItem`, 
this will happen automatically if you implement the remove button as an action. 
Here is an example: 
https://cgit.kde.org/discover.git/tree/discover/qml/SourcesPage.qml#n160
  
  Done.
  
  > - It might be nice to add an "Open Containing Folder" action to the folder 
list items, too
  
  Done.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17706: Fix lock screen focus

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:2fdf002b11cf: Fix lock screen focus (authored by 
andreyby, committed by ngraham).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17706?vs=50911=51194

REVISION DETAIL
  https://phabricator.kde.org/D17706

AFFECTED FILES
  greeter/greeterapp.cpp
  greeter/greeterapp.h

To: andreyby, davidedmundson
Cc: ngraham, graesslin, abetts, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Eike Hein]

hein added a comment.


  In D18848#407843 , @rooty wrote:
  
  > In D18848#407838 , @hein wrote:
  >
  > > This is a good change, but it's more worth finding out why it doesn't 
work already. Looking at the code, when `KickoffItem` is triggered it runs the 
`switchToInitial()` function in FullRepresentation.qml, which already switches 
tabs and is also what sets the state back to `Normal`. So setting the tab in 
the state shouldn't be necessary. Can you debug why setting `currentTab` in 
`switchToInitial()` apparently doesn't work?
  >
  >
  > I think it might be because of the switch from the state "Search" to the 
state "Normal", because this doesn't happen if the arrow keys are used to 
navigate to the right of Favorites, only when Search is invoked. There's a 
"currentTab: searchPage" (line 738) setting in the state "Search" that probably 
gets stuck. I didn't want to deal with changing "Search" because in my 
experience, Kickoff's search view can be pretty temperamental. This seemed like 
the safest course of action.
  
  
  Doesn't that mean the code in switchToInitial just needs reordering to set 
the state (to Normal) first and then do the tab change? (Or alternatively the 
tab change could be cleaned away from the function.)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Nathaniel Graham]

ngraham added a comment.


  The diff is automatically closed once Phab detects a commit associated with 
it, so you don't have to do that manually (most of the time at least; sometimes 
it's a tad buggy).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Krešimir Čohar]

rooty added a comment.


  In D18848#407999 , @ngraham wrote:
  
  > The diff is automatically closed once Phab detects a commit associated with 
it, so you don't have to do that manually (most of the time at least; sometimes 
it's a tad buggy).
  
  
  Excellent :D

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Krešimir Čohar]

rooty added a comment.


  In D18848#407997 , @ngraham wrote:
  
  > Nah, `arc land` is just a fancy way of saying "take the commits on this 
branch and commit them onto the parent branch and then push the parent branch 
and then delete this branch"
  >
  > You can always just do those things yourself if you'd like, which the above 
instructions show you how to do in a different way.
  
  
  I was just wondering about running arc land after the last push because it 
closes the diff? Or does git push do that too?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Nathaniel Graham]

ngraham added a comment.


  Nah, `arc land` is just a fancy way of saying "take the commits on this 
branch and commit them onto the parent branch and then push the parent branch 
and then delete this branch"
  
  You can always just do those things yourself if you'd like, which the above 
instructions show you how to do in a different way.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Krešimir Čohar]

rooty added a comment.


  Wow thanks!
  And after all is said and done, there's no need to run arc land?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Nathaniel Graham]

ngraham added a comment.


  Regardless, let's wait for Eike's approval before landing this.
  
  Here's how I would do it, if and when it's time to land this patch:
  
git checkout Plasma/5.12
git cherry-pick 2c3b1ee1995692aaa68e4d3c76e9bf37565741b2
git push
git checkout Plasma/5.14 (we're putting fixes on 5.14 too since we may ship 
another 5.14 bugfix release)
git merge Plasma/5.12
git push
git checkout Plasma/5.15
git merge Plasma/5.14
git push
git checkout master
git merge Plasma/5.15
git push

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Krešimir Čohar]

rooty added a comment.


  Can I use Kai's suggestion to git checkout Plasma/5.12 then commit then 
checkout Plasma/5.15 then merge Plasma/5.12, then checkout master then merge 
Plasma/5.15? Will this work if I cloned it off of anongit.kde.org (and not 
github.com)?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18805: Workaround for the bug 393630 - SystemTray part

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6fcf9a5e03ba: Fix System Tray popup interactivity after 
echanging item visiblity (authored by trmdi, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18805?vs=51146=51190

REVISION DETAIL
  https://phabricator.kde.org/D18805

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigEntries.qml

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15512: [startplasmacompositor] Add Wayland socket argument

[Roman Gilg]

romangg abandoned this revision.
romangg added a comment.


  Superseded by D17122 .

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15512

To: romangg, #kwin, #plasma
Cc: zzag, graesslin, fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Krešimir Čohar]

rooty added a comment.


  In D18848#407897 , @ngraham wrote:
  
  > BTW your `FIXED-IN` tag says 5.12.x, but this patch was branched off of 
master. So if and when this lands, if you don't do anything special, it's 
currently going to master only. To land it on 5.12.8, the easiest thing is to 
just cherry-pick the commit hash onto `Plasma/5.12` and merge forward into 5.15 
and master. I can help out with that.
  
  
  Please :D

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15512: [startplasmacompositor] Add Wayland socket argument

[Vlad Zagorodniy]

zzag added a comment.


  In D15512#359309 , @fvogt wrote:
  
  > kwin_wayland just needs to make use of `wl_display_add_socket_auto` (other 
compositors do as well).
  
  
  It looks like now it does that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15512

To: romangg, #kwin, #plasma
Cc: zzag, graesslin, fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Nathaniel Graham]

ngraham added a comment.


  BTW your `FIXED-IN` tag says 5.12.x, but this patch was branched off of 
master. So if and when this lands, if you don't do anything special, it's 
currently going to master only. To land it on 5.12.8, the easiest thing is to 
just cherry-pick the commit hash onto `Plasma/5.12` and merge forward into 5.15 
and master. I can help out with that.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice fix, seems sensible enough to be explicit. Confirmed the bug and that 
this fixes it.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Krešimir Čohar]

rooty added a comment.


  In D18848#407838 , @hein wrote:
  
  > This is a good change, but it's more worth finding out why it doesn't work 
already. Looking at the code, when `KickoffItem` is triggered it runs the 
`switchToInitial()` function in FullRepresentation.qml, which already switches 
tabs and is also what sets the state back to `Normal`. So setting the tab in 
the state shouldn't be necessary. Can you debug why setting `currentTab` in 
`switchToInitial()` apparently doesn't work?
  
  
  I think it might be because of the switch from the state "Search" to the 
state "Normal", because this doesn't happen if the arrow keys are used to 
navigate to the right of Favorites, only when Search is invoked. There's a 
"currentTab: searchPage" (line 738) setting in the state "Search" that probably 
gets stuck. I didn't want to deal with changing "Search" because in my 
experience, Kickoff's search view can be pretty temperamental. This seemed like 
the safest course of action.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma
Cc: hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Eike Hein]

hein added a comment.


  This is a good change, but it's more worth finding out why it doesn't work 
already. Looking at the code, when `KickoffItem` is triggered it runs the 
`switchToInitial()` function in FullRepresentation.qml, which already switches 
tabs and is also what sets the state back to `Normal`. So setting the tab in 
the state shouldn't be necessary. Can you debug why setting `currentTab` in 
`switchToInitial()` apparently doesn't work?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma
Cc: hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Filip Fila]

filipf added a comment.


  Fixes the bug for me. I also reproduced it in 5.12 so you should add: 
FIXED-IN: 5.12.8

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18848: [Kickoff] Return Kickoff to Favorites page after running a search

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch fixes the bug that would make Kickoff retain the contents of the 
tab that was selected when a search was run from a tab other than
  Favorites (but at the same time highlight Favorites in the Tab Bar, when it 
was in fact, stuck on another tab).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

[Dimitris Kardarakos]

dkardarakos updated this revision to Diff 51172.
dkardarakos edited the summary of this revision.
dkardarakos added a comment.


  Changed links that pointed to the kirigami repository, to kirigami-gallery 
which is more useful for the contributors.

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18839?vs=51153=51172

REVISION DETAIL
  https://phabricator.kde.org/D18839

AFFECTED FILES
  src/data/contents/ui/gallery/CardsGridViewGallery.qml
  src/data/contents/ui/gallery/CardsListViewGallery.qml
  src/data/contents/ui/gallery/InlineMessagesGallery.qml
  src/data/info-data.json

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D18806: bump to cmake requirement to 3.5

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:908501f116e7: bump to cmake requirement to 3.5 (authored 
by sitter).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18806?vs=51083=51166

REVISION DETAIL
  https://phabricator.kde.org/D18806

AFFECTED FILES
  CMakeLists.txt

To: sitter, #plasma, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18844: Fix opening toolbox button

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:67d8ac416ff6: Use Dialogs visibility directly 
rather than relying on the mainItems (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18844?vs=51160=51164

REVISION DETAIL
  https://phabricator.kde.org/D18844

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: broulik, #plasma, lbeltrame
Cc: davidedmundson, lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18785: Use different Font Management KCM "All Fonts" icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e5ef9c97e75e: Use different Font Management KCM All 
Fonts icon (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18785?vs=51115=51162

REVISION DETAIL
  https://phabricator.kde.org/D18785

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/GroupList.cpp

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18844: Fix opening toolbox button

[David Edmundson]

davidedmundson added a comment.


  That framework change is released tomorrow, right? Is it worth reverting?  
  Including this, that's at least the second regression it's caused, which 
makes me worry there's even more we haven't found.
  
  > It should have used Dialog's visiblity from the beginning anyway.
  
  It should, so still ship this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18844

To: broulik, #plasma, lbeltrame
Cc: davidedmundson, lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18844: Fix opening toolbox button

[Luca Beltrame]

lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  Works. No side effects.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18844

To: broulik, #plasma, lbeltrame
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18844: Fix opening toolbox button

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `Dialog` no longer alters the `mainItem`'s visiblity, so this codepath failed.
  It should have used `Dialog`'s visiblity from the beginning anyway.

TEST PLAN
  5.12?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18844

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18840: [Containment Actions Configuration] Fix changing plugin

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:42fb1de1b3fa: [Containment Actions Configuration] Fix 
changing plugin (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18840?vs=51155=51159

REVISION DETAIL
  https://phabricator.kde.org/D18840

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18840: [Containment Actions Configuration] Fix changing plugin

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ConfigurationContainmentActions.qml:98
> +// "index" argument of onActivated shadows the model index
> +readonly property int pluginIndex: index
>  Layout.fillWidth: true

would just explicitly using "pluginsCombo.index" also work?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18840

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18840: [Containment Actions Configuration] Fix changing plugin

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ConfigurationContainmentActions.qml:98
> would just explicitly using "pluginsCombo.index" also work?

No, because `index` is a "magic" context property set by the `Repeater`, there 
is no "physical" property you can access on an element.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18840

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17796: Show accurate checked state for system monitor configuration pages

[Kai Uwe Broulik]

broulik added a comment.


  > The call on line 141 looks superfluous - if there's any change to checked 
we modify cfg_sources which should trigger the reload.
  
  QML cannot detect changes within a JS structure, if you `push()` into an 
`Array` or modify members of an `Object` it doesn't see the change and the 
automatism for `onCfg_...Changed` doesn't trigger

REVISION DETAIL
  https://phabricator.kde.org/D17796

To: pavelmos, jriddell, #plasma, ngraham
Cc: broulik, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D17796: Show accurate checked state for system monitor configuration pages

[Pavel Mos]

pavelmos added a comment.


  I have no commit access.

REVISION DETAIL
  https://phabricator.kde.org/D17796

To: pavelmos, jriddell, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18840: [Containment Actions Configuration] Fix changing plugin

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The `index` argument of the `activated` signal shadows the `index` context 
property of the `Repeater`

TEST PLAN
  5.15
  Changed mouse action plugin in dropdown, Apply button got enabled, could 
apply setting fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18840

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  Info sheet is fed by a single json file that contains extra info and links to 
source and hig. Cards Grid, Cards List and Inline Messages should use this to 
provide extra info.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D18839

AFFECTED FILES
  src/data/contents/ui/gallery/CardsGridViewGallery.qml
  src/data/contents/ui/gallery/CardsListViewGallery.qml
  src/data/contents/ui/gallery/InlineMessagesGallery.qml
  src/data/info-data.json

To: dkardarakos, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D18805: Workaround for the bug 393630 - SystemTray part

[Tranter Madi]

trmdi added a comment.


  In D18805#407599 , @fvogt wrote:
  
  > You can select "Abandon revision" as action.
  
  
  Done. Thank you. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18805: Workaround for the bug 393630 - SystemTray part

[Fabian Vogt]

fvogt added a comment.


  In D18805#407542 , @trmdi wrote:
  
  > Use @davidedmundson 's approach.
  >
  > @ngraham Could you please help me to discard D18804 
 ? This patch does not require it anymore.
  
  
  You can select "Abandon revision" as action.
  
  > And land it.
  >  Thanks everyone !

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18805

To: trmdi, #plasma, ngraham, broulik, davidedmundson, anthonyfieroni, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart