D25280: [Baloo KCM] Purge index when disabling indexing

cfeck added a comment. Shouldn't there be a warning message "delete yes/no?" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25280 To: ngraham, tcanabrava, #plasma, davidedmundson Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25261: [sddm-theme] Fix initial focus after SDDM QQC2 Port

davidre added a comment. Seems to work REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25261 To: davidedmundson, #plasma Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D24893: [Lock Screen] Add option to hide clock when idle

broulik added a comment. > Does it make sense to have the option off by default, i.e. hiding the clock on idle by default? "Given that the setting will be off by default," is not true. By default the clock is shown, so nothing changes here, also given a static image is also our

D25212: Move the shortcut management in the settings object

davidedmundson added inline comments. INLINE COMMENTS > kcm.cpp:198 > -// the keys sequence > -if (!KGlobalAccel::promptStealShortcutSystemwide(this, > conflicting, sequence)) { > -return false; This part appears to have gone? >

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/9/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 12 Nov 2019 10:07:01 + Build duration: 1 hr 25 min and counting CONSOLE OUTPUT

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

ervin added inline comments. INLINE COMMENTS > kcmstyle.cpp:98 > > -connect(m_model, ::selectedStyleChanged, this, [this] { > -m_selectedStyleDirty = true; > -setNeedsSave(true); > +connect(m_model, ::selectedStyleChanged, this, [this](const > QString& style) { > +

KDE CI: Plasma » kdecoration » kf5-qt5 SUSEQt5.12 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kdecoration/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Nov 2019 11:28:58 + Build duration: 1 hr 14 min and counting BUILD ARTIFACTS

D25212: Move the shortcut management in the settings object

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:198 > This part appears to have gone? Yes, it was never triggered. It turns out KKeySequenceWidget does that already as soon as you pick a new shortcut, so it could never end up conflicting here since said conflict

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69651. tcanabrava added a comment. - Fix Layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24224?vs=69650=69651 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24224 AFFECTED FILES

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Otherwise users who know the term "Baloo" might not make the connection, and also in general it's

D24224: Start of the accessibility KCM

tcanabrava added a comment. F7759258: image.png INLINE COMMENTS > bport wrote in CMakeLists.txt:24 > Not sure why we have this change in this code review, seems unrelated completely unrelated, thanks for spotting. REPOSITORY R119 Plasma Desktop

D24224: Start of the accessibility KCM

ngraham added a comment. It doesn't compile: /home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal error: kns3/downloaddialog.h: No such file or directory 1 | #include "kns3/downloaddialog.h" | ^~~ Also we should

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

ngraham created this revision. ngraham added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY Right now Bluetooth is unconditionally

D25277: [Tabs Runner] Filter on the host side already

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. If we're going to do this, we may as well merge the existing DBus runner (which I had a patch on phabricator since forever) instead of completely duplicating it

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 69650. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. We got another bug report illustrating another reason why this might be desirable from a user perspective, aside from the Chromium bug: https://bugs.kde.org/show_bug.cgi?id=413111 I'll rescind my objection so we can review and get it in. Can you rebase the

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in main.qml:27 > Is this actually used? Also, because it's not installed by default it shows > an error. Fixed in https://commits.kde.org/plasma-desktop/659a46aac39789c40e8cd07060e3bacd5fe8d461 REPOSITORY R119 Plasma Desktop

KDE CI: Plasma » kdecoration » kf5-qt5 SUSEQt5.12 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kdecoration/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Nov 2019 10:04:49 + Build duration: 34 min and counting CONSOLE OUTPUT [...truncated 400

D24893: [Lock Screen] Add option to hide clock when idle

colomar added a comment. In D24893#558506 , @ngraham wrote: > In D24893#558451 , @mart wrote: > > > clock "always show" is fine too tough > > > Given that the setting will be off by default,

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi added inline comments. INLINE COMMENTS > ervin wrote in kcmstyle.cpp:98 > Space before &, not after. Will fix > ervin wrote in kcmstyle.cpp:245 > AFAICT this is the only place where m_effectsDirty is read. So I think you > can remove that flag altogether, which should bring further

D25275: Clean up config-X11.h

cgiboudeaux added a comment. Also tested with CMake 3.1 which is the version required by Qt 5.12. REPOSITORY R101 KHotKeys REVISION DETAIL https://phabricator.kde.org/D25275 To: cgiboudeaux Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25223: Avoid side effects during menu initialization

kmaterka added a comment. In D25223#561570 , @davidedmundson wrote: > I had this. I abandoned because we ended up forking some special wayland stuff in our DBus menu, so would always want our implementation. > > >

D25223: Avoid side effects during menu initialization

nicolasfella added a comment. My long-term goal is to get rid of the application side KStatusNotifierItem and amend the QSystemTrayIcon API REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks,

D25277: [Tabs Runner] Filter on the host side already

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids allowing to query for all tabs easily and also reduces DBus traffic somewhat. TEST

D25275: Clean up config-X11.h

cgiboudeaux closed this revision. REPOSITORY R101 KHotKeys REVISION DETAIL https://phabricator.kde.org/D25275 To: cgiboudeaux, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,

D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement

broulik updated this revision to Diff 69638. broulik added a comment. - Also apply the same thing to Firefox REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24870?vs=69622=69638 REVISION DETAIL https://phabricator.kde.org/D24870

D25274: KCM LookAndFeel : port to KConfig XT

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Just a recurring typo, otherwise LGTM INLINE COMMENTS > kcm.cpp:220 > + > +//Model has been cleared so pretend the selected look and fell changed > to force view update > +

D25274: KCM LookAndFeel : port to KConfig XT

crossi updated this revision to Diff 69643. crossi added a comment. misspelling REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25274?vs=69642=69643 REVISION DETAIL https://phabricator.kde.org/D25274 AFFECTED FILES

D25223: Avoid side effects during menu initialization

kmaterka marked an inline comment as done. kmaterka added a comment. Off-topic idea: This QPA integration uses KStatusNotifierItem, which then translates it to DBus. Wouldn't it be better to talk to DBus directly? From the other side, this may be a duplication of work... Was the idea

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre planned changes to this revision. davidre added a comment. I somehow broke it before uploading REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25273 To: davidre, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre updated this revision to Diff 69639. davidre added a comment. Was a typo REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25273?vs=69637=69639 BRANCH colorschemes (branched from master) REVISION DETAIL https://phabricator.kde.org/D25273

D25212: Move the shortcut management in the settings object

davidedmundson added inline comments. INLINE COMMENTS > ervin wrote in kcm.cpp:198 > Yes, it was never triggered. It turns out KKeySequenceWidget does that > already as soon as you pick a new shortcut, so it could never end up > conflicting here since said conflict would have been handled

D25275: Clean up config-X11.h

cgiboudeaux created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY Khotkeys only requires libX11 and the optional Xtst component. Report whether the optional Xtst component was found.

D25275: Clean up config-X11.h

cgiboudeaux added a comment. Note: this is 2 different commits. REPOSITORY R101 KHotKeys REVISION DETAIL https://phabricator.kde.org/D25275 To: cgiboudeaux Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

Plasma 5.17.3

Plasma 5.17.3 is now released https://www.kde.org/announcements/plasma-5.17.3.php

D25223: Avoid side effects during menu initialization

kmaterka marked an inline comment as done. kmaterka added a comment. I will send fixes in 5 minutes INLINE COMMENTS > broulik wrote in kdeplatformsystemtrayicon.cpp:33 > Is this explicit initialization neccessary? Not mandatory, works without this. I just wanted to be... explicit.

D25223: Avoid side effects during menu initialization

davidedmundson added a comment. I had this. I abandoned because we ended up forking some special wayland stuff in our DBus menu, so would always want our implementation. > ?https://codereview.qt-project.org/c/qt/qtbase/+/168458 REPOSITORY R135 Integration for Qt applications in Plasma

D25274: KCM LookAndFeel : port to KConfig XT

crossi updated this revision to Diff 69642. crossi added a comment. Add kcfg files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25274?vs=69641=69642 REVISION DETAIL https://phabricator.kde.org/D25274 AFFECTED FILES

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre added inline comments. INLINE COMMENTS > main.cpp:130 > +engine.rootContext()->setContextProperty("colorSchemes", colorSchemes); > +engine.load(QUrl::fromLocalFile(package.filePath("mainscript"))); > + Moving the setting of the context properties before loading of the file fixes

D25274: KCM LookAndFeel : port to KConfig XT

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25274 AFFECTED

D25223: Avoid side effects during menu initialization

kmaterka updated this revision to Diff 69634. kmaterka marked an inline comment as done. kmaterka added a comment. QVariant related changes suggested in comments REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi updated this revision to Diff 69635. crossi added a comment. style + consistency REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25220?vs=69468=69635 REVISION DETAIL https://phabricator.kde.org/D25220 AFFECTED FILES

D23079: [GTK3] Fix Firefox's CSD colors, kinda

ngraham added a comment. Can you rebase this? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23079 To: cblack, #vdg, #breeze, ngraham Cc: mthw, ngraham, zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

ervin added inline comments. INLINE COMMENTS > crossi wrote in kcmstyle.cpp:248 > m_model->selectedStyle() is bound to m_settings->widgetStyle() and vice > versa, so I need to save previous state to allow a rollback. > I should have used m_settings->widgetStyle() here and after for consistency.

D25223: Avoid side effects during menu initialization

nicolasfella added subscribers: davidedmundson, nicolasfella. nicolasfella added a comment. In D25223#561561 , @kmaterka wrote: > Off-topic idea: This QPA integration uses KStatusNotifierItem, which then translates it to DBus. Wouldn't it be

D25261: [sddm-theme] Fix initial focus after SDDM QQC2 Port

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2d066f00e884: [sddm-theme] Fix initial focus after SDDM QQC2 Port (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/10/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 12 Nov 2019 12:10:20 + Build duration: 2 hr 13 min and counting CONSOLE

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY By using KColorSchemeManager we can enable viewing icons with all installed color schemes. REPOSITORY R118 Plasma SDK BRANCH

D25223: Avoid side effects during menu initialization

broulik added inline comments. INLINE COMMENTS > kdeplatformsystemtrayicon.cpp:27 > #include > +#include > Already included in the header file > kdeplatformsystemtrayicon.cpp:33 > : QPlatformMenu() > -, m_enabled(true) > -, m_visible(true) > -,

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. > How can you interpret these weird charge_now values correctly? If the range is [1/1000, 901] Wh, while the real range is [0, 45] Wh, how does the charge curve look like while charging or discharging? Are there (continues) values in [46, 901] Wh? Do you assume all

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

davidedmundson added a comment. > Otherwise users who know the term "Baloo" might not make the connection, and also in > general it's good to expose our brand names to users rather than hiding them. Previously we've deliberately made a very conscious decision to not throw random

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

ngraham added a comment. This isn't random; Baloo is a brand name with a logo in progress (D24957 ). We have a HIG page about this: https://hig.kde.org/style/writing/brandnames.html. Baloo is even mentioned there as an example of a brand name. :) the

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. I thought this patch results in a "Breeze light" theme becoming visible in the KCM. If so, that would seem to fulfill the request, unless I'm misunderstanding how the Breeze Dark and proposed Breeze Light themes work. If these themes don't have hardcoded colors (as

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Could we repurpose the Breeze Light and Breeze Dark GTK themes to simply hardcode everything to be dark or light rather than following the color scheme? That mirrors what we do for the Plasma theme. REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#561761 , @ngraham wrote: > Could we repurpose the Breeze Light and Breeze Dark GTK themes to simply hardcode everything to be dark or light rather than following the color scheme? That mirrors what we do for

D25280: [Baloo KCM] Purge index when disabling indexing

ngraham added a comment. I thought tags were stored in extended attributes on the tagged files, not in the database. And can you clarify regarding what's stored in the database for activities? I do see code calling `baloo_file_cleaner` but that executable does not seem to exist

D25280: [Baloo KCM] Purge index when disabling indexing

davidedmundson added a comment. Tags are stored as xattr, but indexed and cached in the baloo DB. The tags IO slave only searches the cache. I had a recollection that adding a tag in dolphin/whatever forced a basic index of that file. However, I can't find any reference to that anymore.

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Conceptually it seems like there are two ways to go: - Have a single Breeze theme that always follows the color scheme - Expose the ability to force the use of a particular color scheme via some UI (for example adding "Breeze Dark" and "Breeze Light" themes

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#561773 , @ngraham wrote: > Conceptually it seems like there are two ways to go: > > - Have a single Breeze theme that always follows the color scheme > - Expose the ability to force the use of a particular

Re: KScreen/libkscreen commit message policies

Roman Gilg ha scritto: > On Mon, Nov 11, 2019 at 10:58 PM Luigi Toscano > wrote: >> >> Roman Gilg ha scritto: >>> Hi, >>> >>> I just pushed commit message policies to KScreen [1] and libkscreen >>> [2] (linked below from GitHub so they can be read with Markdown >>> formatted). >>> >>> I intend

D25280: [Baloo KCM] Purge index when disabling indexing

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Baloo covers tags and activities, regardless of indexer. Wiping the index does not make sense. What you want to achieve is what baloo_file_cleaner does.

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#561710 , @ngraham wrote: > We got another bug report illustrating another reason why this might be desirable from a user perspective, aside from the Chromium bug: https://bugs.kde.org/show_bug.cgi?id=413111 >

D23079: [GTK3] Fix Firefox's CSD colors, kinda

cblack abandoned this revision. cblack added a comment. See D25281 . REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23079 To: cblack, #vdg, #breeze, ngraham Cc: mthw, ngraham, zzag, plasma-devel, LeGast00n,

D25273: Enable selecting all installed color schemes in Cuttlefish

ngraham added a comment. Nice, it's good to get rid of so much boilerplate. However when I change the system's own color scheme from Breeze to anything else and start Cuttlefish, the app itself uses that color scheme as expected, but the combobox's text is blank: F7760159:

D25273: Enable selecting all installed color schemes in Cuttlefish

ngraham added a comment. Also, the combobox's model appears to have duplicates for Breeze, Breeze Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for me: F7760168: Screenshot_20191112_221936.png REPOSITORY R118 Plasma SDK

D25280: [Baloo KCM] Purge index when disabling indexing

ngraham created this revision. ngraham added reviewers: tcanabrava, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The only reason why a user would want to entirely disable file indexing is because

D25281: [GTK3] Improve legibility of Firefox CSD colours

cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This fixes the CSD colors of Firefox to be more legible, but not without some caveats due to upstream issues. - The inactive

D25281: [GTK3] Improve legibility of Firefox CSD colours

ngraham added a comment. This suffers from the same problem as the earlier version in that the SSD versions of the apps look like this: F7759573: Screenshot_20191112_153033.png This is a problem with the current state of the Breeze color scheme

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#561739 , @ngraham wrote: > I thought this patch results in a "Breeze light" theme becoming visible in the KCM. If so, that would seem to fulfill the request, unless I'm misunderstanding how the Breeze Dark and

D24070: Don't use toolTipMainText to show info, rather use the second line

ndavis added a comment. @broulik @mthw ping :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D22684: [Klipper] Fix clipboard history management

pdabrowski added a comment. Bump. This privacy issue (#409366) is still unresolved in latest Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: davidre, plasma-devel,

D25263: [ComboBox] Don't dim Popup

This revision was automatically updated to reflect the committed changes. Closed by commit R858:d11ba447fa78: [ComboBox] Dont dim Popup (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25263?vs=69601=69623

D25264: [Cursor Theme KCM] Elide size ComboBox text

This revision was automatically updated to reflect the committed changes. Closed by commit R119:582bd8e04af0: [Cursor Theme KCM] Elide size ComboBox text (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25264?vs=69602=69624