D27944: KCM Colors fix apply button always disabled

davidedmundson added a comment. Please see D27724 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27944 To: crossi, #plasma, ervin, bport, meven, broulik Cc: davidedmundson, plasma-devel, Orage, LeGast00n,

D27956: [Various KCMs] Notify about changes in GTK related settings

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Also save colors before saving colorScheme name, so that we can correctly use heuristic in GTK Config, after the moment we know,

D27669: [kstyle] Tools area

ngraham added inline comments. INLINE COMMENTS > cblack wrote in breezetoolsareamanager.cpp:108 > Eh? What application do you see this behaviour in? All of them with anything besides a titlebar in their Tools area: Dolphin, Gwenview, Okular, Kate, Konsole... REPOSITORY R31 Breeze REVISION

D27669: [kstyle] Tools area

ngraham added a comment. Fascinating. I've been testing different color schemes to find one that I like best and the current one happens to have the same color for the window bg and inactive toolbar bg, yes. Fixed, now, thanks! REPOSITORY R31 Breeze REVISION DETAIL

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added a comment. Porting with such feature regression is hard to justify. Perhaps we should port KFontDialog (it is ~150 lines of cpp) to kwidgetsaddons instead, `KFontChooser` is already there. Or better perhaps implement here a simple QDialog embedding `KFontChooser` and

D27669: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > cblack wrote in breezetoolsareamanager.cpp:108 > That's odd—the margin shouldn't be shifting based off of window status. Will > investigate. I believe this is due to how it determines "should draw tools area" conflicting with your colourscheme.

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 77314. cblack added a comment. Address more feedback REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77312=77314 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27957: [GTK Config] Port all settings to KConfigWatcher

gikari updated this revision to Diff 77320. gikari added a comment. - Add forgotten toolbar style REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27957?vs=77317=77320 BRANCH port-all-to-kconfigwatcher (branched from master) REVISION

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. For X check out the appmenu applet: https://cgit.kde.org/plasma-workspace.git/tree/applets/appmenu/plugin/appmenumodel.cpp#n164 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel,

D27960: Make it possible to scroll through the padding

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Forwards wheel events happening on the padding to the WheelHandler that manages the Flickable.

D27669: [kstyle] Tools area

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in breezetoolsareamanager.cpp:108 > All of them with anything besides a titlebar in their Tools area: Dolphin, > Gwenview, Okular, Kate, Konsole... F8168127: vokoscreenNG-2020-03-09_18-36-02.webm

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. > Do we need to reduce the opacity for the labels? Is this a visual design argument or a coding one? The opacity was reduced in the layout update. Are you saying that should not had be changed. IMO this is vital part of the new layout. > We don't really do

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Generally FormLayout is unfit for this, If I understand it correctly they cannot get `theme.smallestFont` height. Which will introduce big height, and big margins between lines. > IIRC the labels were reduced opacity before, and this was not a change introduced

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 77316. cblack added a comment. Remove chunk that wasn't staged REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77315=77316 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 77315. cblack added a comment. Remove extraneous comma REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77314=77315 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. Can we make the dbus service role name more generic? GTK has a generic DBus prop on the window, too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n,

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

ahmadsamir planned changes to this revision. ahmadsamir added a comment. It seems I messed up the branches stuff (or phabricator works in a way I don't understand), so I think it's best to work at one diff at a time, instead of wasting time trying to make sense of this situation :/ (I

D27107: [GTK Config] Remove redundant reparse configuration call

gikari abandoned this revision. gikari added a comment. In favor of D27957 REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27107 To: gikari, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n,

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The tasks model now exposes a window's application menu object path and service name. Model only

D27957: [GTK Config] Port all settings to KConfigWatcher

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Also remove redundant reparse configuration calls and change the ways of reading some settings accordingly. Depend on: D27956

D27669: [kstyle] Tools area

davidre added inline comments. INLINE COMMENTS > breezetoolsareamanager.cpp:102 > +{ > +if (QApplication::desktopFileName() == > QStringLiteral("telegram-desktop.desktop")) return; > +auto window = qobject_cast (widget); This needs at least a comment why we have this hack

D27669: [kstyle] Tools area

ngraham added inline comments. INLINE COMMENTS > breezetoolsareamanager.cpp:108 > +} else { > +window->setContentsMargins(0,1,0,0); > +} This seems to make the window content move vertically when the window loses focus

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. Fix for narrow panel in D27958 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage,

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack added a comment. In D27959#625053 , @broulik wrote: > Can we make the dbus service role name more generic? GTK has a generic DBus prop on the window, too. Both the `org.gtk.Actions` and the `org.gtk.Menus` dbus interfaces exposed

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka added a comment. I don't like how icon size and item size (container = icon + padding) are calculated and used... Firstly best icons size is calculated, but then padding are added. This combined size is used as item size (container size): - SNI icons are rounded to nearest icon

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack added a comment. In D27959#625055 , @broulik wrote: > For X check out the appmenu applet: https://cgit.kde.org/plasma-workspace.git/tree/applets/appmenu/plugin/appmenumodel.cpp#n164 > > I was wondering if we should maybe add that to

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

ahmadsamir added a comment. In D27808#625052 , @meven wrote: > Porting with such feature regression is hard to justify. I honestly don't know how many users actually use that feature; if it's still widely used, then yeah, that would

D27669: [kstyle] Tools area

cblack updated this revision to Diff 77326. cblack added a comment. Always compare active titlebar against active window for determining if tools area should be drawn REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77316=77326 BRANCH

D27711: [Applet]Use gridLayout for details

ngraham added a subscriber: manueljlin. ngraham added a comment. FormLayouts are used all over the place. But typically, we don't reduce the opacity of the labels. I'm not categorically against it, I'm just wondering. IIRC the labels were reduced opacity before, and this was not a change

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 77312. cblack added a comment. Address some feedback REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77057=77312 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY For very narrow panel item size is too big (item + paddings exceed panel size). This adds a

D27345: Don't emit palette changes if the palette didn't change

This revision was automatically updated to reflect the committed changes. Closed by commit R169:cad71c6f968f: Dont emit palette changes if the palette didnt change (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27345?vs=77324=77325

D27345: Don't emit palette changes if the palette didn't change

apol updated this revision to Diff 77324. apol added a comment. Simplify the process REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27345?vs=76036=77324 BRANCH arcpatch-D27345_1 REVISION DETAIL https://phabricator.kde.org/D27345 AFFECTED FILES

D27669: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > ngraham wrote in breezetoolsareamanager.cpp:108 > This seems to make the window content move vertically when the window loses > focus Eh? What application do you see this behaviour in? REPOSITORY R31 Breeze REVISION DETAIL

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added inline comments. INLINE COMMENTS > fonts.cpp:678 > > -QFont KFonts::applyFontDiff(const QFont , const QFont , int > fontDiffFlags) > -{ > -QFont font(fnt); > - > -if (fontDiffFlags & KFontChooser::FontDiffSize) { > -font.setPointSizeF(newFont.pointSizeF()); > -

D27915: Use breeze icons for categories

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Don't land before D27913 . REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27915 To: guoyunhe, #plasma,

D27669: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > ngraham wrote in breezetoolsareamanager.cpp:108 > F8168127: vokoscreenNG-2020-03-09_18-36-02.webm > That's odd—the margin shouldn't be shifting based off of window status. Will investigate. REPOSITORY

D27669: [kstyle] Tools area

ngraham added a comment. This is looking pretty polished. There are just a few visual issues left: #1: The titlebar and toolbar/menubar change color at slightly different rates, rather than all together. I guess the titlebar should animate its transition too: F8168180:

D27669: [kstyle] Tools area

hpereiradacosta added a comment. The toolbar background seems to be broken when there are multiple toolbars in the same row. See, e.g. ktorrent: F8168244: Screenshot_20200309_213717.png Does not happen for applications that have a single toolbar

D27669: [kstyle] Tools area

cblack updated this revision to Diff 77333. cblack added a comment. Draw border on QDialogs REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77332=77333 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27669: [kstyle] Tools area

cblack updated this revision to Diff 77334. cblack marked 10 inline comments as done. cblack added a comment. Address feedback and compiler warnings REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77333=77334 BRANCH cblack/toolsarea REVISION

D27669: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:367 > Just for my understanding: why is it necessary ? > Here at least, nothing changes if I take this out. This causes Qt to request a background be drawn on these widgets, which is used for painting the

D27669: [kstyle] Tools area

hpereiradacosta added a comment. Some more comments, mostly code related. Thanks for addressing all the comments so far ! INLINE COMMENTS > breezehelper.cpp:33 > +#include > +#include > This include is not needed any more as far as I can tell > breezehelper.cpp:1723 > + > +

D27669: [kstyle] Tools area

cblack updated this revision to Diff 77332. cblack added a comment. Render consistent tools area border colour REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77326=77332 BRANCH cblack/toolsarea REVISION DETAIL

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mvourlakos added a comment. I think it is better to have an option for this in order to not be applied always when the user reverses the indicator.. And also are you sure that this way the growing circle animation of the indicator is still working correctly? REPOSITORY R878 Latte

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

ahmadsamir added a comment. In D27808#624506 , @bport wrote: > With your change, we are not allowed anymore to change for example only font and keeping different size, style for each kind of font (window, menu, toolbar...), right ?

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

davidre added a comment. I want to echo the sentiment that Breeze should not gain more options and this instead be a new decoration. I see the issue with mdi windows having different titlebars because they are drawn by the QStyle but you add these options here you are only solving this

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

ahmadsamir updated this revision to Diff 77258. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir removed a reviewer: bport. ahmadsamir added a comment. More detailed commit message REPOSITORY R119 Plasma Desktop CHANGES SINCE

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

ahmadsamir marked 3 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > bport wrote in fonts.cpp:115 > You can use && to have only one if there OK. > bport wrote in fonts.cpp:552 > Those change will compare font twice, here and on setters so I will keep old > code

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

bport added a comment. With your change, we are not allowed anymore to change for example only font and keeping different size, style for each kind of font (window, menu, toolbar...), right ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To:

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. @ngraham If FormLayout does not support opacity/enabled for labels, then maybe, this patch is good enough. INLINE COMMENTS > DetailsText.qml:67 > font.pointSize: theme.smallestFont.pointSize > -text: details[(index*2)+1] > +

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

broulik added a comment. This causes layouting issues in narrow panels: F8167100: Screenshot_20200309_085328.PNG REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham

Plasma Sprint in Augsburg cancelled

Hi everyone, I regret to inform you that with Covid-19 spreading, large events and flights increasingly being cancelled on short notice, the situation in Italy worsening etc, we decided to call off the Plasma Sprint in Augsburg next month. If you have made travel arrangements, please see if

D27886: Demote jump list actions to PossibleMatches

This revision was automatically updated to reflect the committed changes. Closed by commit R120:18422ededcc9: Demote jump list actions to PossibleMatches (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27886?vs=77079=77247

D27884: [gmenu-dbusmenu-proxy] Pass action "target" in invocation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:503bf4f3a542: [gmenu-dbusmenu-proxy] Pass action target in invocation (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27879: Degrade qCInfo to qCDebug

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9a4f259c4820: Degrade qCInfo to qCDebug (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27879?vs=77063=77248 REVISION DETAIL

D27885: [gmenu-dbusmenu-proxy] Fix radio button state detection

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea358c896668: [gmenu-dbusmenu-proxy] Fix radio button state detection (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27823: Use consistent highlight

niccolove updated this revision to Diff 77254. niccolove added a comment. ops REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77253=77254 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

niccolove updated this revision to Diff 77253. niccolove added a comment. fixed name of list REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77219=77253 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

niccolove added a comment. Sorry, I had different files with different versions. Now it shows correctly for me, with all files up to date. That said, is it normal that: F8167163: image.png - the top elements has a top separator - icon size of

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fonts.cpp:115 > +if (!sameFont) { > +if (font.weight() == QFont::Normal && font.styleName().isEmpty() > +&& result.weight() ==

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. In D27466#624447 , @broulik wrote: > This causes layouting issues in narrow panels: > F8167100: Screenshot_20200309_085328.PNG > The icons are also too far apart For

D27711: [Applet]Use gridLayout for details

ngraham added a comment. Do we need to reduce the opacity for the labels? We don't really do this anywhere else. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n,

D27436: Use task rather than tabs

niccolove added a comment. Actually, after some use, I don't think this is the best effect to use. I will investigate more. REPOSITORY R119 Plasma Desktop BRANCH avoid_tabs_for_applets (branched from master) REVISION DETAIL https://phabricator.kde.org/D27436 To: niccolove, #vdg,

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham added a comment. In D27466#624639 , @kmaterka wrote: > I guess it needs to be reworked... I can do that, just need few days for investigation. Thanks, much appreciated! REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

ngraham added inline comments. INLINE COMMENTS > gtkconfig.h:89 > void onKWinSettingsChange(const KConfigGroup , const > QByteArrayList ) const; > +void onKcminputSettingsChange(const KConfigGroup , const > QByteArrayList ) const; > `onKcmInputSettingsChange` (capitalize the I in

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I have to agree with Hugo and David. "Styles within styles" screams "this should just be another window decoration theme" to me as well. Especially since the proposed new

D27436: Use task rather than tabs

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. This will utterly break with every third party theme. If we were to do this we would need to introduce a dedicated "applet is open" highlight item or some property to tell it

D27944: KCM Colors fix apply button always disabled

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG: 418604 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27823: Use consistent highlight

ngraham accepted this revision. ngraham added a comment. Thanks, everything works now. :) I don't see that extra line in mine. But yeah, if it's reproducible, it's a bug that should be fixed. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

broulik added a comment. > I believe that D26992 , moves the icons down. It looks like with that patch the icon sizes differ between plasmoids and SNIs REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27466 To:

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. In D27466#624574 , @broulik wrote: > > I believe that D26992 , moves the icons down. > > It looks like with that patch the icon sizes differ between plasmoids and SNIs

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

gvgeo added a comment. I believe that D26992 , moves the icons down. And this patch, by adding an extra smallSpacing/2 makes it more noticeable. Baking magic numbers is always questionable. Either the 1 smallspacing before, or the current 3/2, or 2

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

ahmadsamir updated this revision to Diff 77264. ahmadsamir marked 3 inline comments as done. ahmadsamir retitled this revision from "[Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary" to "[Fonts KCM] Change how nearestExistingFonts() finds a matching font".

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

ahmadsamir updated this revision to Diff 77265. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Tweak commit message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27785?vs=77264=77265 BRANCH arcpatch-D27785 (branched

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 77261. meven added a comment. Reversed resizing the window REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=76470=77261 BRANCH arcpatch-D26934 REVISION DETAIL https://phabricator.kde.org/D26934

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

ahmadsamir updated this revision to Diff 77268. ahmadsamir retitled this revision from "[Fonts KCM] Change how nearestExistingFonts() finds a matching font" to "[Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary". ahmadsamir edited the summary of this revision.

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport updated this revision to Diff 77267. bport added a comment. fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27503?vs=76516=77267 REVISION DETAIL https://phabricator.kde.org/D27503 AFFECTED FILES kcms/spellchecking/CMakeLists.txt

D27942: [Cursors KCM] Notify about cursor change

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Notify all users of `KConfigWatcher` about cursor theme change. REPOSITORY R119 Plasma Desktop BRANCH

D27166: Refactor converter runner

sitter added a comment. Neat. I am Mostly just waiting for a test at this point. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma, sitter Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

Monday meeting notes for 9/3/2020

Kai Uwe: * not much from me, been on vacation last week. other than * PSA: Plasma Sprint in Augsburg next month has been cancelled (delayed due covid precautions) Arjen: * So I started last week by making my own implementation of a screenshot capture tool: Diff 27805 Add a screenshot capture

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Port from deprecated dbus signal to KConfigWatcher. Depends on: D27942 TEST PLAN 1.

D26934: KCM/Autostart Add a model to separate logic from UI

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > meven wrote in autostart.cpp:87 > The current default size was not very appropriate. > I took the liberty of changing this as well. > Before: > F8133214: Screenshot_20200226_140516.png >

D27096: Refactoring, improve validation in kcm, optimize

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM. Does anyone have final comments? REPOSITORY R114 Plasma Addons BRANCH charrunner_improvements (branched from master) REVISION DETAIL https://phabricator.kde.org/D27096 To:

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d28337b6d379: KCM Fonts port anti aliasing part to KPropertySkeletonItem (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mbehrendt added a comment. In D27939#624440 , @mvourlakos wrote: > I think it is better to have an option for this in order to not be applied always when the user reverses the indicator.. > > And also are you sure that this way the growing

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

gikari added inline comments. INLINE COMMENTS > ngraham wrote in gtkconfig.h:89 > `onKcmInputSettingsChange` (capitalize the I in Input) > > Maybe also capitalize KCM? > > Or maybe call it `onCursorSettingsChange` This name comes from configuration file name and this function (theoretically)

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

gikari updated this revision to Diff 77293. gikari marked an inline comment as done. gikari added a comment. Update function name REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27943?vs=77276=77293 BRANCH cursors-to-config-watcher

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mvourlakos added a comment. no prob, take your time... REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D27939 To: mbehrendt, mvourlakos Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, jraleigh, zachus, mbehrendt, fbampaloukas, GB_2,

D27823: Use consistent highlight

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b7291760dce1: Use consistent highlight (authored by niccolove). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77254=77310

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mvourlakos added a comment. The gap you see comes from the specific plasma theme, so this is plasma theme responsibility. That specific theme probably has that gap in its tasks svg. Having an option means that the user can always disable/enable that specific functionality if a plasma

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mbehrendt added a comment. Okay. I just tested with other themes. Was so used to Materia that I forgot about them. Yeah an option would make sense then. I'd like to look into this but that will probably take some time. REPOSITORY R878 Latte Dock REVISION DETAIL

D27942: [Cursors KCM] Notify about cursor change

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1fb3c36496cf: [Cursors KCM] Notify about cursor change (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27942?vs=77275=77303 REVISION

D27943: [Gtk Config] Port cursor theme sync to KConfigWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit R99:715e497d94b9: [Gtk Config] Port cursor theme sync to KConfigWatcher (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D27697: WIP: Added top area to notification header

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Looks sexy as hell. I think the icon inside the notification needs to be moved or resized though. Right now it has no top padding, so it touches the header. INLINE COMMENTS >

D27954: appstreamrunner: Port to KApplicationTrader

apol created this revision. apol added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Port away from the query language to lambda using the new KApplicationTrader API. Depends on