graesslin added a comment.
My notebook also only reports one more. I tested this on "real" hardware.
INLINE COMMENTS
> subdiff wrote in drm_output.h:152
> Nowhere (yet?) used.
Yes, it is for the case that modesettings fails, so that we can go back.
REPOSITORY
R108 KWin
BRANCH
davidedmundson updated this revision to Diff 21097.
davidedmundson added a comment.
yes, I meant that. It's what I had in my working dir..apparently I can't git
properly.
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8399?vs=21056=21097
BRANCH
subdiff accepted this revision.
subdiff added a comment.
This revision is now accepted and ready to land.
Looks good to me. I couldn't test it though, because KScreen KCM only showed
me one mode to select from.
INLINE COMMENTS
> drm_output.h:152
> drmModeModeInfo m_mode;
> +
graesslin requested changes to this revision.
graesslin added a subscriber: jriddell.
graesslin added a comment.
This revision now requires changes to proceed.
The general concept looks good to me.
INLINE COMMENTS
> constants.h:34-39
> +/* Whitepoint values for temperatures at 100K
Martchus retitled this revision from "Depends on D8402 Allow to set
"domain-suffix-match" in Wi-Fi settings" to "Allow to set "domain-suffix-match"
in Wi-Fi settings".
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D8405
To: Martchus, #plasma
Martchus retitled this revision from "Allow to set "domain-suffix-match" in
Wi-Fi settings" to "Depends on D8402 Allow to set "domain-suffix-match" in
Wi-Fi settings".
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D8405
To: Martchus, #plasma
ngraham added a comment.
There's special syntax you can use to indicate the dependency in the Summary
section:
"Depends on https://phabricator.kde.org/D8402;
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D8405
To: Martchus, #plasma
Martchus edited the test plan for this revision.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D8402
To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
Martchus added a dependent revision: D8402: Support "domain-suffix-match" in
Security8021xSetting.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D8405
To: Martchus, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
Martchus added a dependency: D8405: Allow to set "domain-suffix-match" in Wi-Fi
settings.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D8402
To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
Martchus edited the test plan for this revision.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D8405
To: Martchus, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
Martchus created this revision.
Martchus added a reviewer: Plasma.
Martchus added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This concerns Wi-Fi settings of enterprise WPA/WPA2:
- TLS
- tunneled TLS
- PEAP
Requires commit `Support
Martchus created this revision.
Martchus added a reviewer: Plasma.
Martchus added a project: Plasma.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Required for 'Allow setting "domain-suffix-match" in
graesslin updated this revision to Diff 21065.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Rename method to resetOutput and move the complete recreate logic there.
Hope I didn't break anything with it.
REPOSITORY
R108 KWin
CHANGES
graesslin marked an inline comment as done.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8398
To: graesslin, #kwin, #plasma, subdiff, sebas
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
In https://phabricator.kde.org/D8398#157766, @subdiff wrote:
> Nice!
>
> You are using AMS on your testing machine I assume?
Yes. I'm using defaults :-)
> The mode change should currently not work in legacy mode, because
`m_modesetRequested`
ngraham added inline comments.
INLINE COMMENTS
> main.cpp:34
> +//which is before KAboutData::setApplicationData
> +QCoreApplication::setApplicicationName("systemsettings");
> SystemSettingsApp application(argc, argv);
"setApplicicationName"? :-)
REPOSITORY
R124 System Settings
subdiff added inline comments.
INLINE COMMENTS
> egl_gbm_backend.cpp:153
>
> -void EglGbmBackend::createOutput(DrmOutput *drmOutput)
> +bool EglGbmBackend::initOutput(Output , DrmOutput *drmOutput)
> {
Rename this function `resetOutput` and put the destroy surface logic from the
lambda
subdiff added a comment.
Nice!
You are using AMS on your testing machine I assume? The mode change should
currently not work in legacy mode, because `m_modesetRequested` gets only used
by AMS. Without AMS you need to call directly `setModeLegacy` with a black
buffer. Or maybe just test
davidedmundson edited the summary of this revision.
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D8399
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
davidedmundson updated this revision to Diff 21056.
davidedmundson added a comment.
fix typo in summary
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8399?vs=21055=21056
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8399
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
(after a log of looking, it turns it's out not a bug in the QQC desktop
style)
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, subdiff, sebas.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This change hooks up the bits for changing the mode when a request to
change
aleksejshilin created this revision.
aleksejshilin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
With default vertical alignment to the center, the buttons became
misaligned when their text
graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
This protocol allows to indicate that a wl_surface
valeriymalov updated this revision to Diff 21043.
valeriymalov edited the summary of this revision.
valeriymalov added a comment.
I've just realized that config save/load that I've deleted is pretty
important since it also configures the KSysGuardProcessList widget (including
update interval
rkflx added a subscriber: sebas.
rkflx added a comment.
Let's put is this way: Ideally the shadows of the Plasma widgets would follow
whatever the window decoration is doing. Especially the Plasma popup widgets
are very similar to a normal widget menu popup, from the user's point of view –
hpereiradacosta added a comment.
In https://phabricator.kde.org/D8232#156981, @rkflx wrote:
> Thanks for summarizing the discussion and doing the prototyping, that's
appreciated.
>
> Just noticed a point which has not been mentioned yet: There are also the
shadows of the Plasma
dvratil created this revision.
dvratil added a reviewer: sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When the size of the unified QMLOutput changes (due to resolution change
for example), reposition it into
dvratil created this revision.
dvratil added a reviewer: sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Changing resolution of the 'Unified output' makes it move around which
then triggers
https://bugs.kde.org/show_bug.cgi?id=376128
Sebastian Kügler changed:
What|Removed |Added
CC||se...@kde.org
31 matches
Mail list logo