D14147: Port from GConf to GSettings

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. It still needs to keep GConf code for systems without gsettings pulseaudio module (eg. pulseaudio < 12.0). Also make the Qt keywords changes in separate commit or include

D14026: [Pager] Don't show a window list on hover if there is only one window

hein accepted this revision. hein added a comment. Sorry, was traveling. REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 To: nicolasfella, hein, broulik, ngraham Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14147: Port from GConf to GSettings

nicolasfella created this revision. nicolasfella added reviewers: drosca, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY CCBUG: 386665 As discussed in

D7087: Add "Copy Info" button to the About System KCM

rkflx accepted this revision. rkflx added a comment. @gregormi It's been a long time coming, but now the patch LGTM  (BTW, the patch does not apply cleanly after recent changes in master, so make sure to rebase properly…) @dhaumann As you "requested changes", could you check whether

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. Awesome, thanks for your patience over the last months. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma, colomar, broulik, mart, hein, rkflx Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham,

D14145: Show a vertical menu for the panel widget options pop-up

ngraham created this revision. ngraham added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch replaces the UI for the panel widget options pop-up

D14143: Make the action selector OSD independent of the other OSDs

zzag added inline comments. INLINE COMMENTS > zzag wrote in osd.cpp:120 > Please delete reference. Compilers can eliminate unnecessary copying, so > there is no need to do the lifetime expansion. s/expansion/extension/ REPOSITORY R104 KScreen REVISION DETAIL

D14138: Use a trash icon for anything that will remove a widget or a panel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1f87cec54e1d: Use a trash icon for anything that will remove a widget or a panel (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14143: Make the action selector OSD independent of the other OSDs

zzag added inline comments. INLINE COMMENTS > osd.cpp:120 > +if (!m_osdActionSelector) { > +const QString = > QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation, > QStringLiteral("kded_kscreen/qml/OsdSelector.qml")); > +if (osdPath.isEmpty()) {

D14081: Fix types, improve readability

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:20c88fd906dd: Fix types, improve readability (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE

D14144: Make the action selector OSD independent of the other OSDs

gladhorn added a comment. arc squashed https://phabricator.kde.org/D14143 into this :( Tool failure. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14144 To: gladhorn, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D14144: Make the action selector OSD independent of the other OSDs

gladhorn created this revision. gladhorn added a reviewer: Plasma. gladhorn added a project: Plasma. gladhorn requested review of this revision. REVISION SUMMARY This OSD should handle keyboard input and behave different, so make it work on its own. In follow up changes, the keyboard

D14143: Make the action selector OSD independent of the other OSDs

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This OSD should handle keyboard input and behave different, so

D14090: [libbreezecommon] Fix build when qreal is float

zzag added a comment. Ping? I'll land it tomorrow if no one has objections. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14090 To: zzag, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14133: [kdecoration] Make shadows lighter

This revision was automatically updated to reflect the committed changes. Closed by commit R31:02519ad921d3: [kdecoration] Make shadows lighter (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14133?vs=37810=37820 REVISION DETAIL

D14116: Use a better icon for "Remove" on the widget handle

ngraham added a comment. Found it. Here's the patch: D14138: Use a trash icon for anything that will remove a widget or a panel REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14116 To: ngraham, #plasma, #vdg,

D14138: Use a trash icon for anything that will remove a widget or a panel

ngraham created this revision. ngraham added reviewers: broulik, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Like D14116 , but for

D14116: Use a better icon for "Remove" on the widget handle

ngraham added a comment. Hmm actually that's for the toolbar above the panel, not the little menus that appear when you hover the mouse over a panel widget. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14116 To: ngraham, #plasma, #vdg, davidedmundson Cc:

D14133: WIP: [kdecoration] Make shadows lighter

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. An excellent tweak. I think this looks better--more subtle and more professional, but still retains the original goal. Good for you for listening to user feedback, too. :) REPOSITORY

D14105: Use a broom-style icon for clearing clipboard and notification history

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma, davidedmundson Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14133: WIP: [kdecoration] Make shadows lighter

zzag updated this revision to Diff 37810. zzag added a comment. Tweak small and medium shadows REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14133?vs=37805=37810 BRANCH refine-decoration-shadows REVISION DETAIL https://phabricator.kde.org/D14133

D14116: Use a better icon for "Remove" on the widget handle

ngraham added a comment. In D14116#292301 , @broulik wrote: > Can you make the same change also for the panel? There it's even more confusing as the "X" looks like it would close the popup but it's actually for deleting the widget. > Code is

D14105: Use a broom-style icon for clearing clipboard and notification history

Fuchs accepted this revision. Fuchs added a comment. if it falls back then all is perfect :) REPOSITORY R120 Plasma Workspace BRANCH broom-style-clear-history-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma,

D14133: WIP: [kdecoration] Make shadows lighter

ngraham added a comment. +1, I definitely prefer the version with the shadow box moved up a bit with a little bit of lightening. I think that looks fantastic! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14133 To: zzag, #vdg, ngraham Cc: plasma-devel, ragreen,

D14133: WIP: [kdecoration] Make shadows lighter

zzag added a comment. F6107977: Screenshot_20180715_175013.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14133 To: zzag, #vdg, ngraham Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D14133: WIP: [kdecoration] Make shadows lighter

zzag updated this revision to Diff 37805. zzag added a comment. Make key shadow lighter for Large and Very large shadows REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14133?vs=37803=37805 BRANCH refine-decoration-shadows REVISION DETAIL

D14133: WIP: [kdecoration] Make shadows lighter

zzag added a comment. F6107872: Screenshot_20180715_174127.png Maybe, we should make contrast/ambiance shadows lighter... REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14133 To: zzag, #vdg, ngraham Cc: plasma-devel,

D14133: WIP: [kdecoration] Make shadows lighter

zzag added a comment. Slightly moved box shadows -- Small: F6107843: 05-after-small.png Medium: F6107845: 06-after-medium.png Large: F6107848: 07-after-large.png

D14133: WIP: [kdecoration] Make shadows lighter

zzag updated this revision to Diff 37803. zzag added a comment. Move box shadows up REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14133?vs=37801=37803 BRANCH refine-decoration-shadows REVISION DETAIL https://phabricator.kde.org/D14133 AFFECTED FILES

D14105: Use a broom-style icon for clearing clipboard and notification history

ngraham added a comment. Right, it's not a problem: 1. Either the theme has its own version of that icon (as Oxygen does) 2. ...Or else the theme symlinks that icon to something else (as Papirus does; it's symlinked to `edit-clear` which looks like the backspace symbol)... 3. ...Or

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

colomar added a comment. So, first (and perhaps for me only one this time) guerilla test: Participant: - Plasma user for several years (because I recommended it to her) - Frequent but generally mostly "non-technical" computer user - Uses Plasma in English but isn't a native English

D14133: WIP: [kdecoration] Make shadows lighter

ngraham added a comment. IMHO the problem here is not the darkness, but how much darker the bottom edge is than the sides. My recommendation would be to move the shadow boxes up a few pixels instead of lightning everything. REPOSITORY R31 Breeze REVISION DETAIL

D14133: [kdecoration] Make shadows lighter

zzag created this revision. zzag added reviewers: VDG, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH refine-decoration-shadows REVISION DETAIL

Re: Discussion for Virtual Desktops and Activities future

Hi all, just chiming in to give some KWin perspective. Activities are weird and we (Thomas and I) never knew what they are and how we should integrate them in KWin. The existing code is just a bad copy of virtual desktops (bad because it copied the code 1:1 without understanding what it does

D14105: Use a broom-style icon for clearing clipboard and notification history

ngraham added a comment. It't not a problem: either theme theme has its own version of that icon, or else it falls back to the Breeze icon, which in 5.48 is a broom, and prior to 5.48 looks like the backspace symbol. REPOSITORY R120 Plasma Workspace BRANCH

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

https://bugs.kde.org/show_bug.cgi?id=345618 Christoph Feck changed: What|Removed |Added CC||ubunte...@gmail.com --- Comment #16 from

D14105: Use a broom-style icon for clearing clipboard and notification history

Fuchs added a comment. In D14105#292183 , @ngraham wrote: > Thanks! @fuchs and/or @broulik? Can't test it currently, looks fine, just one question: did you test what happens on other icon sets than breeze? If that doesn't work, I'd

D14130: Parse protocol in port option

martinschulze created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. martinschulze requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH feature/parse_protocol_flag REVISION DETAIL

D14129: Port away from string-based connects

vkrause created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Due to the large amount of connections here, multiplied by the not exactly small amount of

D14116: Use a better icon for "Remove" on the widget handle

broulik added a comment. Can you make the same change also for the panel? There it's even more confusing as the "X" looks like it would close the popup but it's actually for deleting the widget. Code is in

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 37787. gregormi added a comment. - Module.ui: add horizontal spacers REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=37786=37787 BRANCH arcpatch-D7087_1 REVISION DETAIL

D7087: Add "Copy Info" button to the About System KCM

gregormi added a comment. What do you think about this minor layout change? It is noticeable when the window is resized horizontally. Instead of centering the grid's middle line, it makes the left and right padding space to the window border equal which looks more pleasing at least to my

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 37786. gregormi marked 4 inline comments as done. gregormi added a comment. - Module.ui: Fix glitch near KernelName - Avoid double connection of copyToClipboard - Hide dummy label - Better naming of loop variable and optimize loop code REPOSITORY

D7087: Add "Copy Info" button to the About System KCM

gregormi added inline comments. INLINE COMMENTS > rkflx wrote in Module.cpp:263 > Coming back to this after a month, I now wonder what `p` stands for, which > might indicate that variable could get a better name… p stands for labelPair: renaming is a good idea. Done. > rkflx wrote in

D10297: Add new "Tools" button above System Monitor's process list

This revision was automatically updated to reflect the committed changes. Closed by commit R111:d039c8c74dcb: Add new Tools button above System Monitors process list (authored by gregormi). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D10297: Add new "Tools" button above System Monitor's process list

gregormi updated this revision to Diff 37783. gregormi added a comment. - Use setShortcuts to simplify code REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10297?vs=37782=37783 BRANCH arcpatch-D10297_2 REVISION DETAIL

D10297: Add new "Tools" button above System Monitor's process list

gregormi updated this revision to Diff 37782. gregormi marked an inline comment as done. gregormi added a comment. - Use setShortcuts to simplify code REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10297?vs=36895=37782 BRANCH arcpatch-D10297_2