rkflx accepted this revision. rkflx added a comment.
@gregormi It's been a long time coming, but now the patch LGTM 👍 (BTW, the patch does not apply cleanly after recent changes in master, so make sure to rebase properly…) @dhaumann As you "requested changes", could you check whether the patch is good to go now? (Currently Phabricator blocks landing the patch because of that.) In D7087#292261 <https://phabricator.kde.org/D7087#292261>, @gregormi wrote: > What do you think about this minor layout change? It is noticeable when the window is resized horizontally. Instead of centering the grid's middle line, it makes the left and right padding space to the window border equal which looks more pleasing at least to my eye. Yeah, I noticed this too. Much better after your update! It's slightly off-topic for the patch, but now that you added it, just keep it… > For reference: the layout in master: Yup, your patch will be improving it quite a lot. You could add a small note to the summary to indicate you had to redo the layout a bit. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, dhaumann, rkflx Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
