gregormi added inline comments.

INLINE COMMENTS

> rkflx wrote in Module.cpp:263
> Coming back to this after a month, I now wonder what `p` stands for, which 
> might indicate that variable could get a better nameā€¦

p stands for labelPair: renaming is a good idea. Done.

> rkflx wrote in Module.cpp:260
> I'm afraid you missed the "hidden" part, so it shows up right in front of the 
> distro logo ;)
> 
> Adding
> 
>   dummyDistroDescriptionLabel->hide();
> 
> where you are creating the label solves the issue for me.

dummy hide: Oh sorry, I should have seen that myself. Fixed it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

Reply via email to