D18892: Move Look and Feel KCM to top level

2019-02-13 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0af980f5cab8: Move Look and Feel KCM to top level 
(authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18892?vs=51301=51642

REVISION DETAIL
  https://phabricator.kde.org/D18892

AFFECTED FILES
  kcms/lookandfeel/kcm_lookandfeel.desktop

To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson
Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15304: [KCM] Port to QQC2

2019-02-13 Thread Victor Ryzhykh 
victorr added a comment.


  I put this patch on plasma-pa-5.15.80
  
https://cgit.kde.org/plasma-pa.git/patch/?id=00026cee9ec8c5d04067cf892b46e5a5507b7f6d
  As a result, the translation disappeared.
  I have installed a framework-5.55, Plasma-5.15.80.
  And there was a 100% translation.
  Where there was a lack of translation, I myself did.
  And now it is missing in plasma-pa-5.15.80.
  I tried to change the parameters of the lines, but the translation did not 
appear.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: victorr, apol, huftis, nicolasfella, davidedmundson, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D15304: [KCM] Port to QQC2

2019-02-13 Thread Nathaniel Graham 
ngraham added a comment.


  What you're looking at was not touched in this patch. This patch only changed 
the category below it.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: victorr, apol, huftis, nicolasfella, davidedmundson, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D15304: [KCM] Port to QQC2

2019-02-13 Thread Victor Ryzhykh 
victorr added a comment.


  Now the translation does not work.
  The current untranslatable (Russian locale):
  
  F6614010: plasma-pa.jpeg 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: victorr, apol, huftis, nicolasfella, davidedmundson, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Krešimir Čohar 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:089612d232fd: Make Appearance KCMs labels 
consistent (authored by filipf, committed by rooty).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18903?vs=51616=51629

REVISION DETAIL
  https://phabricator.kde.org/D18903

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/metadata.desktop
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/package/metadata.desktop
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/metadata.desktop
  kcms/emoticons/emoticons.desktop
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/metadata.desktop
  kcms/icons/kcm_icons.desktop
  kcms/icons/package/metadata.desktop
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/fontinst.desktop
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm_splashscreen.desktop
  kcms/ksplash/package/metadata.desktop
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/metadata.desktop
  kcms/style/kcmstyle.cpp
  kcms/style/style.desktop

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: davidedmundson, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18991: [containment] Show an inline message when the Desktop Toolbox is hidden

2019-02-13 Thread Nathaniel Graham 
ngraham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, when the Desktop Toolbox is hidden, the only way to return to the
  containment configuration window is by right-clicking on the desktop. This may
  not be obvious or may be difficult for some people sue to age, disability,
  hardware, etc.
  
  This patch makes an informational message appear when the user goes to hide 
the
  Desktop Toolbox that explains how to return to the configuration window in the
  future. It only appears when the checkbox is currently checked and it is 
unchecked;
  it does not appear when the user visits the Tweaks page when the checkbox is
  already unchecked (by then they already know because they've already seen the
  message at least once)

TEST PLAN
  F6613733: Inline message 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-info-when-toolbox-is-hidden (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18991

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigTweaks.qml

To: ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18990: [containment] Modernize tweaks page layout and port to QQC2

2019-02-13 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: VDG, Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Port the page to QQC2 and modernize the layout, using modern Kirigami APIs
  
  This patch removes the invisible group boxes and headers since it seems
  unnecessary to give each checkbox in a two-checkbox layout its own private
  title. The labels are clear enough already.

TEST PLAN
  F6613694: Modernized layout 
  
  Everything still works

REPOSITORY
  R119 Plasma Desktop

BRANCH
  modernize-tweaks-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18990

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigTweaks.qml

To: ngraham, #vdg, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread David Edmundson 
davidedmundson added a comment.


  +1 from my side.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: davidedmundson, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18892: Move Look and Feel KCM to top level

2019-02-13 Thread David Edmundson 
davidedmundson added a comment.


  Go for it

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18892

To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson, abetts
Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18892: Move Look and Feel KCM to top level

2019-02-13 Thread Björn Feber 
GB_2 added a comment.


  Ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18892

To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson, abetts
Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila 
filipf added a comment.


  In D18903#411590 , @ngraham wrote:
  
  > BTW could you explain the changes in more detail in the Summary section?
  
  
  Sure, just did that now. Sounds pretty technical but I think it summarizes 
everything done here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Nathaniel Graham 
ngraham added a comment.


  BTW could you explain the changes in more detail in the Summary section?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Looking good to me now!
  
  I notice that the font installation and Emoticons KCMs display the comment 
rather than the KAboutData string in their headers, but this is a bug unrelated 
to your patch. Still, we should figure out what's going on and fix it in 
another patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila 
filipf updated this revision to Diff 51616.
filipf added a comment.


  get rid of articles, better wording

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18903?vs=51602=51616

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18903

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/metadata.desktop
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/package/metadata.desktop
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/metadata.desktop
  kcms/emoticons/emoticons.desktop
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/metadata.desktop
  kcms/icons/kcm_icons.desktop
  kcms/icons/package/metadata.desktop
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/fontinst.desktop
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm_splashscreen.desktop
  kcms/ksplash/package/metadata.desktop
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/metadata.desktop
  kcms/style/kcmstyle.cpp
  kcms/style/style.desktop

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

2019-02-13 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Weird. Well, this look good to me from a UX and basic code sanity check 
perspective, so I'll hand it over to other folks to do the more in-depth code 
review now.
  
  Thanks for the patch! Should be a nice improvement. And you may end up 
becoming the person who's fixed the oldest bug ever. :)

REPOSITORY
  R103 KMenu Editor

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: mlaurent, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

2019-02-13 Thread Aidan Sojourner 
tuxxi added a comment.


  In D18939#411450 , @ngraham wrote:
  
  > If you use a blank QWidget, you won't have to do that `setContentsMargin()` 
workaround, right?
  
  
  I actually tried this first, I was surprised when the plain `QWidget` still 
had margins; I realized the margins were part of the `QVBoxLayout` rather than 
in the widget containing it. I switched back to a `QFrame` since I've used it 
for this use in the past -- but it really makes no difference in this case, so 
I can switch it to a QWidget if you think that's better style :)

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: mlaurent, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18976: Improve Contextmenu

2019-02-13 Thread Michail Vourlakos 
This revision was automatically updated to reflect the committed changes.
Closed by commit R878:c893ab3d2281: Improve Contextmenu (authored by trmdi, 
committed by mvourlakos).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18976?vs=51613=51615

REVISION DETAIL
  https://phabricator.kde.org/D18976

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18976: Improve Contextmenu

2019-02-13 Thread Tranter Madi 
trmdi updated this revision to Diff 51613.

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18976?vs=51573=51613

REVISION DETAIL
  https://phabricator.kde.org/D18976

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Björn Feber 
GB_2 added a comment.


  Oops

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 5.16 Kickoff Meeting poll

2019-02-13 Thread Jonathan Riddell 
New poll
https://doodle.com/poll/tx5e78cqqcgnqtzd
the old one had mistakes in the times with 12 am vs pm
no need to fill it out if you correctly worked around that before

Jonathan

On Mon, 11 Feb 2019 at 22:57, Jonathan Riddell  wrote:
>
> Plasma 5.16 Kickoff Meeting poll
> https://doodle.com/poll/p54673rpqsinctp8
> Please indicate times you are available for a meeting to discuss plans
> for Plasma 5.16 cycle
>
> Meeting time is usually 1 to 2 hours long
>
> Remember to set your local timezone first to adjust
>
> Meeting will be on #plasma IRC channel on Freenode
>
> Jonathan

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Björn Feber 
GB_2 accepted this revision.
GB_2 added a comment.


  In D18903#411538 , @ngraham wrote:
  
  > In D18903#411529 , @filipf wrote:
  >
  > > For this patch (and moving forward) we still have 2 dilemmas left then:
  > >
  > > - remove the article -> "Configure system fonts" instead of "Configure 
the system fonts"?
  >
  >
  > My recommendation:
  >
  > - For the UI-related font KCM: "Choose user interface fonts" or something 
like that
  > - For the font installer KCM, we could expose some more of its power via 
the tooltip and make the comment something more like "Install, manage, and 
organize system fonts"
  >
  > > - capitalize Look and Feel? Or just do "Choose (the) look and feel theme"?
  >
  > For the title, "Look And Feel" is good. For the tooltip, my recommendation 
is "Choose the Look and Feel theme".
  
  
  In the tooltip Look and Feel should be lowercase, then it's correct.
  Other theme types are lowercase too and it's not a brand.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18976: Improve Contextmenu

2019-02-13 Thread Michail Vourlakos 
mvourlakos added a comment.


  In D18976#411537 , @trmdi wrote:
  
  > Oh, wait...
  >  I've just seen it is disabled unexpectedly. Do you know why ?
  
  
  yes, it comes from the setVisible(false) I dont know why,
  this is why I wanted to add in there:
  
setEnabled(true);

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18976

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Nathaniel Graham 
ngraham added a comment.


  In D18903#411529 , @filipf wrote:
  
  > For this patch (and moving forward) we still have 2 dilemmas left then:
  >
  > - remove the article -> "Configure system fonts" instead of "Configure the 
system fonts"?
  
  
  My recommendation:
  
  - For the UI-related font KCM: "Choose user interface fonts" or something 
like that
  - For the font installer KCM, we could expose some more of its power via the 
tooltip and make the comment something more like "Install, manage, and organize 
system fonts"
  
  > - capitalize Look and Feel? Or just do "Choose (the) look and feel theme"?
  
  For the title, "Look And Feel" is good. For the tooltip, my recommendation is 
"Choose the Look and Feel theme".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18976: Improve Contextmenu

2019-02-13 Thread Tranter Madi 
trmdi added a comment.


  Oh, wait...
  I've just seen it is disabled unexpectedly. Do you know why ?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18976

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila 
filipf added a comment.


  In D18903#411528 , @ngraham wrote:
  
  > Perfect. This strikes me as the exactly correct way to do it: The 
`KAboutData` string shows a real title, and the `Comment` provides the tooltip 
text. Can we do this for the few remaining KCMs in the appearance section too?
  >
  > Looks like there's a bug in the font management KCM: it ignores the 
KAboutData string and always displays the comment.
  
  
  Yes, we need 2 new patches though because Window Decorations and GTK Style 
are in different repos.
  
  For this patch (and moving forward) we still have 2 dilemmas left then:
  
  - remove the article -> "Configure system fonts" instead of "Configure the 
system fonts"?
  - capitalize Look and Feel? Or just do "Choose (the) look and feel theme"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Nathaniel Graham 
ngraham added a comment.


  Perfect. This strikes me as the exactly correct way to do it: The 
`KAboutData` string shows a real title, and the `Comment` provides the tooltip 
text. Can we do this for the few remaining KCMs in the appearance section too?
  
  Looks like there's a bug in the font management KCM: it ignores the 
KAboutData string and always displays the comment.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: cdb: First working version

2019-02-13 Thread Tomaz Canabrava 
tcanabrava added inline comments.

INLINE COMMENTS

> tcanabrava wrote in backtraceparsercdb.h:31
> remove virtual, override.

still missing the override.

> tcanabrava wrote in backtraceparsercdb.h:34
> remove virtual, override.

still missing the override.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18983: Use the python version found by cmake in build_theme.sh

2019-02-13 Thread Heiko Becker 
heikobecker created this revision.
heikobecker added a reviewer: Build System.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  Helpful if one has multiple python3 versions around.

TEST PLAN
  builds fine with the passed python executable, same files
  are installed.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D18983

AFFECTED FILES
  src/CMakeLists.txt
  src/build_theme.sh
  src/build_theme.sh.cmake

To: heikobecker, #build_system
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila 
filipf updated this revision to Diff 51602.
filipf added a comment.


  KAboutData i18n is the same as Name

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18903?vs=51601=51602

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18903

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/desktoptheme/kcm.cpp
  kcms/emoticons/emoticons.desktop
  kcms/fonts/fonts.cpp
  kcms/icons/kcm_icons.desktop
  kcms/icons/package/metadata.desktop
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/fontinst.desktop
  kcms/ksplash/kcm.cpp
  kcms/lookandfeel/kcm.cpp
  kcms/style/kcmstyle.cpp
  kcms/style/style.desktop

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila 
filipf updated this revision to Diff 51601.
filipf added a comment.


  .

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18903?vs=51600=51601

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18903

AFFECTED FILES
  kcms/emoticons/emoticons.desktop
  kcms/emoticons/emoticonslist.cpp
  kcms/icons/kcm_icons.desktop
  kcms/icons/main.cpp
  kcms/icons/package/metadata.desktop
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/fontinst.desktop
  kcms/style/kcmstyle.cpp
  kcms/style/style.desktop

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila 
filipf updated this revision to Diff 51600.
filipf added a comment.


  .

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18903?vs=51598=51600

BRANCH
  516-appearance-header-labels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18903

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/metadata.desktop
  kcms/emoticons/emoticons.desktop
  kcms/emoticons/emoticonslist.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/metadata.desktop
  kcms/icons/kcm_icons.desktop
  kcms/icons/main.cpp
  kcms/icons/package/metadata.desktop
  kcms/kfontinst/kcmfontinst/FontFilter.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/fontinst.desktop
  kcms/style/kcmstyle.cpp
  kcms/style/style.desktop

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila 
filipf updated this revision to Diff 51598.
filipf added a comment.


  try to fix it?

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18903?vs=51597=51598

BRANCH
  516-appearance-header-labels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18903

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/metadata.desktop
  kcms/emoticons/emoticons.desktop
  kcms/emoticons/emoticonslist.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/metadata.desktop
  kcms/icons/kcm_icons.desktop
  kcms/icons/main.cpp
  kcms/icons/package/metadata.desktop
  kcms/kfontinst/kcmfontinst/FontFilter.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/fontinst.desktop
  kcms/style/kcmstyle.cpp
  kcms/style/style.desktop

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila 
filipf added a comment.


  Bah sorry, it pulled in some other non-related changes as well. Will fix if I 
figure out how or open up a new diff.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila 
filipf updated this revision to Diff 51597.
filipf added a comment.


  use verb style headers

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18903?vs=51329=51597

BRANCH
  516-appearance-header-labels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18903

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/metadata.desktop
  kcms/emoticons/emoticons.desktop
  kcms/emoticons/emoticonslist.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/metadata.desktop
  kcms/icons/kcm_icons.desktop
  kcms/icons/main.cpp
  kcms/icons/package/metadata.desktop
  kcms/kfontinst/kcmfontinst/FontFilter.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/fontinst.desktop
  kcms/style/kcmstyle.cpp
  kcms/style/style.desktop

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

2019-02-13 Thread Nathaniel Graham 
ngraham added a comment.


  If you use a blank QWidget, you won't have to do that `setContentsMargin()` 
workaround, right?

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: mlaurent, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port to QQC2

2019-02-13 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:00026cee9ec8: [KCM] Port to QQC2 (authored by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=51557=51595

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DeviceComboBox.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

Plasma 5.14.5.1 updates

2019-02-13 Thread Jonathan Riddell 
Plasma team have released some updates to 5.14.  5.14 has reached the
end of its release cycle but some distros are still planning to ship
it and may want to use these updated tars.

discover-5.14.5.1.tar.xz
tag baac08a40851699585e80b0a226c4fd683579a7b
sha256 3b201f9e56b89284092087d05171cefeb495a3002982a0dc7e7def407fd5debf
http://embra.edinburghlinux.co.uk/~jr/tmp/5.14.5.1/discover/discover.changelog.txt

kdeplasma-addons-5.14.5.1.tar.xz
tag fba8a13fee6b3480f0191ea9bd57e0cb3f66d73a
sha256 9beda8d4eb60d0ca1df3d4c4d4146efe6a55071c912cc58c04549da755ab992e
http://embra.edinburghlinux.co.uk/~jr/tmp/5.14.5.1/kdeplasma-addons/kdeplasma-addons.changelog.txt

plasma-desktop-5.14.5.1.tar.xz
tag cc33c78ff5f773b9a0549fdb98dbb3c2aa6cd79b
sha256 78997ec7436cf426b539bc69569f608f10c42b4c021990a691eb13d85f9d8344
http://embra.edinburghlinux.co.uk/~jr/tmp/5.14.5.1/plasma-desktop/plasma-desktop.changelog.txt

plasma-workspace-5.14.5.1.tar.xz
tag dfe283bae534e68ea66b419cbdd2824e2663673e
sha256 b0019036fd17fa17534f8fd73b00d520a110bfccbfbb8112cbba69e45d8686be
http://embra.edinburghlinux.co.uk/~jr/tmp/5.14.5.1/plasma-workspace/plasma-workspace.changelog.txt

This info is also at
https://community.kde.org/Plasma/5.14_Errata

D18979: foldermodel: store information about screen used

2019-02-13 Thread Oleg Solovyov 
McPain requested review of this revision.
McPain added a comment.


  Seems like I can't use distinct screen mapping for each activity yet

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

To: McPain, broulik, sebas
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18979: foldermodel: store information about screen used

2019-02-13 Thread Oleg Solovyov 
McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 401464
  
  According to FolderModel::filterAcceptsRow code, it is possible that 
folderview is used by containment but not associated with a screen.
  In case of m_screen == -1 there was no information about which items we 
should filter out.
  
  Instead, we do not change m_screen to -1 and we can filter out items that 
does not belong to our screen.
  m_screenUsed shows whether folderview is associated with a screen or not

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: McPain
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

plasma-pa 5.12.7.1 update

2019-02-13 Thread Jonathan Riddell 
plasma-pa 5.12.7.1 is a minor bugfix update tar to Plasma 5.12.7 LTS
to fix an issue with Qt 5.12

https://www.kde.org/info/plasma-5.12.7.php

plasma-pa;Plasma/5.12;3b3b8c3d60e48db47d7b86e61f351bac03fd57b7;plasma-pa-5.12.7.1.tar.xz;ba444690f1999b9867905087a0f1779e5b299de24d9fea3a85ac0d16eaa82f7e

https://phabricator.kde.org/D16443

D18976: Improve Contextmenu

2019-02-13 Thread Tranter Madi 
trmdi updated this revision to Diff 51573.

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18976?vs=51563=51573

REVISION DETAIL
  https://phabricator.kde.org/D18976

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: trmdi, #latte_dock
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart