D10750: wayland: Add support for zwp_linux_dmabuf

romangg updated this revision to Diff 60898. romangg added a comment. - Import dma-bufs with multi-plane via modifier REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=60655=60898 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10750

D10750: wayland: Add support for zwp_linux_dmabuf

romangg added a comment. In D10750#486570 , @romangg wrote: > Multi-plane support is needed. See @fredrik's inline comment on how to do that: > > > We would need to create a separate EGL image and a separate texture for each plane. > >

D22179: [mobile/wifi] Move network en/disable into main action

ngraham added a comment. I kind of feel like on mobile, the toolbar itself should just move to the bottom. No need to use a whole new paradigm of floating text-less buttons that obscure the content and don't have labels. I know this is basically copied from Android, but I don't really like

D22179: [mobile/wifi] Move network en/disable into main action

nicolasfella added a comment. In D22179#488748 , @ngraham wrote: > +1 for porting to use the correct Kirigami paradigm. > > I feel like trying to do this exposes problems with our general general style (toggle-able toolbar button don't have

D22179: [mobile/wifi] Move network en/disable into main action

ngraham added a comment. +1 for porting to use the correct Kirigami paradigm. I feel like trying to do this exposes problems with our general general style (toggle-able toolbar button don't have a special appearance to indicate this) as well as the "floating text-less button" paradigm

D22181: Fix typo in documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e508c78fbdb9: Fix typo in documentation (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22181?vs=60895=60897 REVISION DETAIL

D22181: Fix typo in documentation

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22181

D22180: [mobile/wifi] Use default height for ConnectionItemDelegate

nicolasfella created this revision. nicolasfella added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Using the default height of SwipeListItem

D22106: [Separator] Match Breeze borders' color

filipf added a comment. In D22106#487287 , @mglb wrote: > Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76 > > Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha and either color mixing

Tipping the apple cart?

Hello folks, as you know, I'm not a coder. However, I'm interested in our code quality, and there has been some observation that "lots of patches get missed, and submitters get confused due to a lack of auto-populated reviewers" on Phabricator. Nate Graham has been adding groups to the reviewers

D22179: [mobile/wifi] Move network en/disable into main action

nicolasfella created this revision. nicolasfella added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY The current switch at the top is both not

D22178: [mobile/wifi] Fix some qml warnings in ConnectionItemDelegate

nicolasfella created this revision. nicolasfella added reviewers: Plasma, bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Using anchors on items managed by layouts

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, seems to work and makes sense. Let's get this in so we can start tagging things. REPOSITORY R119 Plasma Desktop BRANCH filter-themes-by-download-tags (branched from master)

D22128: [Kickoff] Redo tab bar separator's geometry

ngraham accepted this revision. ngraham added a comment. In D22128#487965 , @ndavis wrote: > Sorry, my bad once again. I hadn't actually applied D22108 . It works for me now. The tab highlight width problem

D22176: Rework system tray settings

ngraham added a comment. Nice!!! Let's give the scrollview that holds this list a visible frame, like we did in the Purpose job dialog. Also maybe rename the "General" tab to say "Entries" since that's all there is there. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22176: Rework system tray settings

nicolasfella created this revision. nicolasfella added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The current system tray settings has two pages with two slightly different

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre added a comment. Ah I forgot a word there. I wanted to say don't change the current order if the sort order is switched to random. And when opened and the current mode is random whatever. Displaying the order for the other modes is quite good I think. REPOSITORY R120 Plasma

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

ngraham added a comment. Yeah maybe we should always show them in alphabetical order, or maybe we should show them in alphabetical order just for the alphabetical and random modes? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma

D10362: Change reveal password button logic

ngraham added a comment. In D10362#488571 , @ndavis wrote: > In D10362#488389 , @ngraham wrote: > > > I think the idea is that you're not supposed to be typing with the characters visible as you

D10362: Change reveal password button logic

ndavis added a comment. In D10362#488389 , @ngraham wrote: > I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password. I

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre added a comment. In D22121#488479 , @ngraham wrote: > That fixed my crash, yay! > > I see a UX issues with the Random mode though: since the list re-sorts itself randomly, it becomes harder to locale any given wallpaper in there

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

ngraham added a comment. That fixed my crash, yay! I see a UX issues with the Random mode though: since the list re-sorts itself randomly, it becomes harder to locale any given wallpaper in there (say, for the purposes of unchecking it). Also, when you scroll all the way to the bottom

D22170: [latte-dock] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 . F6948355: latte-dock

D22169: [plasma-active-window-control] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 and use an alternative icon for

D22168: [plasma-desktop] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 . F6948267: plasma-desktop

D22167: [plasma-workspace] Use new activities icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the new icon added in D22155 . F6948276: plasma-workspace

D10362: Change reveal password button logic

ngraham added a comment. I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password. If you're in an environment where security concerns are sufficiently low as to permit this,

D10362: Change reveal password button logic

ndavis added a comment. In D10362#202435 , @starbuck wrote: > Would further be also likely more consistent with other toggles in the future, like imagined on mobile "wifi crossed out=disabled", etc. The difference between the WiFi toggle

D10362: Change reveal password button logic

ndavis added a comment. -1 for the current version How am I supposed to type with 2 hands and see the password at the same time if I have to hold down the left mouse button? -0.75 for the previous version of the patch We normally show the action that will happen when a button

D22162: taskmanager: performance

ngraham added a comment. Not sure if it's related, but while you're at it, would you be able to also fix these errors when hovering over a pinned item: file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:347: Unable to assign [undefined]

D10362: Change reveal password button logic

GB_2 added a comment. Ping REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisangelaccio,

D22162: taskmanager: performance

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Don't do queries on unknown values. Don't create a KDesktopFile until we know we're going to need it