D22316: Avoid garbling the sound if the volume slider is moved fast

ngraham added a comment. In D22316#492059 , @kezik wrote: > I don't know why it is not showing the context of the patch 路‍♂️ > I selected the plasma-pa project Because you didn't use `arc` to submit the patch and Phabricator is kinda

D22333: Move Solid::Device::listFromQuery calls to a separate thread

apol updated this revision to Diff 61379. apol added a comment. Call setFuture after connecting to finished REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22333?vs=61372=61379 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22333

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick marked 2 inline comments as done. croick added a comment. In D11234#492200 , @sitter wrote: > Could you explain your thinking behind the adjustSize call please? The way I see it the window should scale up as necessary if the size hints

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick updated this revision to Diff 61377. croick added a comment. - more style fixes - do not adjustSize after adding the button, since that is redundant now REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11234?vs=59627=61377 BRANCH nicebutton

D22333: Move Solid::Device::listFromQuery calls to a separate thread

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY They block the startup notably but the API doesn't require it to be blocking. TEST PLAN Ran plasmashell

D22322: Store crash report automatically if shutting down

tcanabrava updated this revision to Diff 61371. tcanabrava added a comment. - Add pid information to the log files - rebase REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22322?vs=61360=61371 BRANCH storeGuiless REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 54 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/54/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 08 Jul 2019 19:02:02 + Build duration: 2 min 12 sec and counting CONSOLE OUTPUT

D22242: Fix some tests in release mode

This revision was automatically updated to reflect the committed changes. Closed by commit R871:2f828efa74b3: Fix some tests in release mode (authored by tcanabrava). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22242?vs=61086=61369 REVISION DETAIL

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in logout.cpp:399-400 > Make job autodelete if not. This is no KJob REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22296 To: bruns, #plasma, broulik,

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

broulik added a comment. PowerDevil checks `if (KWorkSpace::isShuttingDown()) {` before suspending, so I think the ksmserver stuff is obsolete REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22296 To: bruns, #plasma, broulik, davidedmundson Cc:

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

davidedmundson added a comment. Given it's already broken, I would say just kill it. I've not had any related bug reports. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22296 To: bruns, #plasma, broulik, davidedmundson Cc: anthonyfieroni, sitter,

D22322: Store crash report automatically if shutting down

tcanabrava updated this revision to Diff 61360. tcanabrava added a comment. - Add pid information to the log files REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22322?vs=61338=61360 BRANCH storeGuiless REVISION DETAIL

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

anthonyfieroni added inline comments. INLINE COMMENTS > logout.cpp:399-400 > } else { > -Solid::PowerManagement::stopSuppressingSleep(inhibitCookie); > +delete inhibitionJob; > +inhibitionJob = nullptr; > qCDebug(KSMSERVER) << "Client " << c->program() << "

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns added a comment. In D22296#492147 , @sitter wrote: > > So, in order to port to the API, it'd first need finishing up really. The question is - do we really want this call here, or not. As is, it is just an expensive

D22326: fix API availability/version detection to not be terribly racey

sitter added a comment. That is rather disgusting snark there. Thanks for that REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D22326 To: sitter, #plasma Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22322: Store crash report automatically if shutting down

tcanabrava marked an inline comment as done. tcanabrava added a comment. > And perhaps more ideally, albeit not blocking this diff, we should look at reshuffling the architecture so on next login drkonqi auto starts with a list of crashes and the ability to file reports for them.

D22326: fix API availability/version detection to not be terribly racey

broulik added a comment. I wasn't serious when I said you should use a QML view with a `BusyIndicator`. I don't think that's appropriate. You don't want DrKonqi crashing when you want to report a crash caused by the nvidia driver. Or maybe that's the plan. Clever. REPOSITORY R871 DrKonqi

D22326: fix API availability/version detection to not be terribly racey

sitter added a comment. Looks comme ca when the page actually is necessary: F6991301: Screenshot_20190708_171225.png F6991303: Screenshot_20190708_171054.png REPOSITORY R871 DrKonqi REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 53 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/53/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 08 Jul 2019 15:07:02 + Build duration: 1 min 58 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 15 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/15/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 08 Jul 2019 15:07:02 + Build duration: 1 min 43 sec and counting CONSOLE

D22328: refactor basic OS info to be set via config and fixate it for testing

This revision was automatically updated to reflect the committed changes. Closed by commit R871:a2adbe4a0e0b: refactor basic OS info to be set via config and fixate it for testing (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D22329: hide save-login-info checkbox when kwallet is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R871:46a72cdc5e9d: hide save-login-info checkbox when kwallet is disabled (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22329?vs=61347=61349

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre planned changes to this revision. davidre added a comment. I may have introduced a similar crash or made it easier to trigger Nate's crash. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma, davidedmundson Cc:

D22329: hide save-login-info checkbox when kwallet is disabled

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY we can't save the info if kwalletd is disabled so let's hide the checkbox BUG: 363570

D22328: refactor basic OS info to be set via config and fixate it for testing

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the basic OS info is decided at compile time, on top of that influences whether lsbrelease and

D22327: [libnotificationmanager] Port to lighter KProcessList

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. This now returns the entire command line, not just the process name REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22327 To: davidedmundson,

D22327: [libnotificationmanager] Port to lighter KProcessList

davidedmundson updated this revision to Diff 61345. davidedmundson added a comment. remove from cmake REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22327?vs=61344=61345 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22327

D22327: [libnotificationmanager] Port to lighter KProcessList

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KSysGuard fetches everything you could possibly need from a process. If

D22326: fix API availability/version detection to not be terribly racey

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously at a random point in time there'd be a call to get the bugzilla version, that call

D22322: Store crash report automatically if shutting down

sitter added a comment. In D22322#492240 , @davidedmundson wrote: > > What's the rationale behind this change? Isn't this use case covered by coredumpd and the like? > > Well, by that logic we wouldn't have any drkonqi... I don't

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik updated this revision to Diff 61337. kezik added a comment. Thanks @davidedmundson for the feedback, I fixed what you suggested, but thinking about this again, the 50ms timer fixed the audio garbling but the sounds felt "too frequent", increasing the timer gave the same exact result

D22322: Store crash report automatically if shutting down

tcanabrava updated this revision to Diff 61338. tcanabrava added a comment. Store in the cache folder REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22322?vs=61324=61338 BRANCH storeGuiless REVISION DETAIL https://phabricator.kde.org/D22322 AFFECTED

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre updated this revision to Diff 61335. davidre added a comment. - Remember current slide between starts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=61318=61335 BRANCH slideshow (branched from master) REVISION DETAIL

D22316: Avoid garbling the sound if the volume slider is moved fast

davidedmundson added inline comments. INLINE COMMENTS > volumefeedback.cpp:33 > + > +timer = new QTime(); > +timer->start(); This object leaks. You're better off just making it a member var directly. Also, see QElapsedTimer > volumefeedback.cpp:34 > +timer = new QTime(); > +

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 52 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/52/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 08 Jul 2019 11:19:26 + Build duration: 22 min and counting CONSOLE OUTPUT

D22323: Code cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit R871:1af8e1cc37e9: Const-correctness (authored by tcanabrava). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22323?vs=61325=61330#toc REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D22323: Code cleanups

tcanabrava added a comment. In D22323#492220 , @sitter wrote: > I do wonder if it wouldn't make sense to make the two helpers into a new class DrKonqiLauncher or some such and then delegate this entire decision to the class. The way this was

D22322: Store crash report automatically if shutting down

davidedmundson added a comment. > What's the rationale behind this change? Isn't this use case covered by coredumpd and the like? Well, by that logic we wouldn't have any drkonqi... 1. crashes on shutdown are currently weird. A dialog appears and blocks on logout, on shutdown

notes for meeting of 8/07/2019

Roman: * I am at the moment refactoring the Compositor class: https://phabricator.kde.org/T11071 Already multiple patches landed last week. Thx zzag for reviews. Two more are currently in review including the split of the class into X11 and Wayland subclasses. I want to merge these today. I could

D22322: Store crash report automatically if shutting down

sitter added a comment. As mentioned in D22323 the stuff in main.cpp needs putting in a class. What's the rationale behind this change? Isn't this use case covered by coredumpd and the like? REPOSITORY R871 DrKonqi REVISION DETAIL

D22322: Store crash report automatically if shutting down

davidedmundson added a comment. Concept: +1 One question, when do we create a DBusInterfaceLauncher instance. Is it in time here? Without this startkde won't know there's a drkonqi it should be waiting for and then whether you finish saving or not becomes racey. INLINE COMMENTS

D22323: Code cleanups

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I do wonder if it wouldn't make sense to make the two helpers into a new class DrKonqiLauncher or some such and then delegate this entire decision to the class. The way this was before the

D22323: Code cleanups

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Send options as an Array *should* be faster as potentially there will be just one allocation Rename variable:

D22322: Store crash report automatically if shutting down

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Still need to program the shutdown detection REPOSITORY R871 DrKonqi BRANCH storeGuiless REVISION DETAIL

D22320: Hide "Dummy Output" from output list and improve user-visible labels

This revision was automatically updated to reflect the committed changes. Closed by commit R115:86d3fb911f0c: Hide Dummy Output from output list and improve user-visible labels (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D11234: [DrKonqi] Show debug button when KDevelop session is running

sitter added a comment. Could you explain your thinking behind the adjustSize call please? The way I see it the window should scale up as necessary if the size hints are properly set (which they should be on master). INLINE COMMENTS > drkonqidialog.cpp:203 > +//Report bug button: User1

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre added a comment. In D22121#492179 , @msdobrescu wrote: > Thanks, selecting from any image is useful, to avoid starting always from the top one. But should not enable the button until a check is done. Ideally if you want a

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

msdobrescu added a comment. Thanks, selecting from any image is useful, to avoid starting always from the top one. But should not enable the button until a check is done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre added a comment. In D22121#492173 , @msdobrescu wrote: > I'd say it is some half-implemented feature, probably. Could it be useful to navigate by keyboard and check/uncheck images, by using space, for example? You can still

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

msdobrescu added a comment. I'd say it is some half-implemented feature, probably. Could it be useful to navigate by keyboard and check/uncheck images, by using space, for example? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre updated this revision to Diff 61318. davidre added a comment. Don't start if we are in config mode I had another crash here via reload -> processPaths -> endInsertRows. Triggered by repeatetly checking and unchecking a checkbox. My guess is that because of multiple calls to

D22320: Hide "Dummy Output" from output list and improve user-visible labels

broulik created this revision. broulik added reviewers: Plasma, VDG, drosca, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We already show a "muted" icon and disallow adjusting the "Dummy

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre updated this revision to Diff 61314. davidre marked 2 inline comments as done. davidre added a comment. Disable selecting the wallpaper in slideshow configuration This was introduced when the gridview from the single image dialog was added to the slideshow one. In my mind it

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

sitter added a comment. FTR: The async solid power API is not built by default as it is unfinished, it's also not API stable. I recently poked Alex Fiestas about it and he said that the parts of the new async API that actually were implemented when he handed over maintainer ship of solid

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

msdobrescu added a comment. In D22256#492127 , @davidre wrote: > I guess one drawback is that you have to reindex all the files when the sort mode is changed. I expect to simply reload the list, from the filesystem. That should be done

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

davidre added a comment. I guess one drawback is that you have to reindex all the files when the sort mode is changed. REVISION DETAIL https://phabricator.kde.org/D22256 To: msdobrescu, ngraham, davidre, #plasma Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh,

D22283: Change validator for Endpoint Address entry field

This revision was automatically updated to reflect the committed changes. Closed by commit R116:12a7ea055197: Change validator for Endpoint Address entry field (authored by andersonbruce, committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE