D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Much better, thanks.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28859: Detect QQC2 version at build time with actual detection.

[Xuetian Weng]

xuetianweng added a comment.


  ping? :)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28859

To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 80594.
cblack added a comment.


  Rebase on master

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=79010=80594

BRANCH
  arcpatch-D27669_1

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham updated this revision to Diff 80598.
ngraham added a comment.


  Rebase

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28317?vs=79070=80598

BRANCH
  tools-area-color-changes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeLight.colors
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham updated this revision to Diff 80593.
ngraham added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26695?vs=74052=80593

BRANCH
  standardshortcuts-minimum-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26695

AFFECTED FILES
  kcms/standard_actions/standard_actions_module.cpp

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham updated this revision to Diff 80595.
ngraham added a comment.


  700 -> 600 to accommodate people who still have netbooks or run Plasma in a 
VM with a
  tiny window because guest tools aren't installed

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26695?vs=80593=80595

BRANCH
  standardshortcuts-minimum-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26695

AFFECTED FILES
  kcms/standard_actions/standard_actions_module.cpp

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 80597.
cblack added a comment.


  Properly rebase

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=80594=80597

BRANCH
  arcpatch-D27669_1

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8e0f525a9633: [KCMs/Standard Actions] Give KCMShell 
window a sane default size (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26695?vs=80595=80596

REVISION DETAIL
  https://phabricator.kde.org/D26695

AFFECTED FILES
  kcms/standard_actions/standard_actions_module.cpp

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 80603.
cblack added a comment.


  Fix menubar quirks

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=80597=80603

BRANCH
  arcpatch-D27669_1

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

[Friedrich W. H. Kossebau]

Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley:
> Hi all,
> 
> Another breakage in Qt?

Should be fixed now (restarted build now completed), with similar traps also 
removed for the future, thanks to David Faure for the work done and Ade for 
the root detecting investigations.

Seems Qt changed for Qt 5.14.1 -> 5.14.2 some wrappers around QSet-related API 
from
#if QT_VERSION < QT_VERSION_CHECK(6,0,0)
to
#if QT_DEPRECATED_SINCE(5, 14) && QT_VERSION < QT_VERSION_CHECK(6,0,0)
and by that stronger rules some projects no longer saw code they saw before, 
thus had started to fail.

Cheers
Friedrich

Re: Kickoff menu with empty history tab

[Thomas Nemeth]

Thank you David.

I'm sorry for my late reply : I only noticed that I sent my mail to
a mailing list after seeing the notification telling me a moderator
had to approve my post.

After a few research, I found out that kactivitymanagerd is
(hopefully) correctly started with my session.

$ ps aux | grep activityman
thomas  6031  0.0  0.1 553320 36956 ?Sl   10:56   0:01 /usr/
lib/x86_64-linux-gnu/libexec/kactivitymanager

However, I found where to configure history in the System Settings
application and discovered that the "Remember opened documents"
radio-button in the "Privacy" tab was set to "do not remember".

I have certainly been mislead by the word "documents".

Sorry for the bother.
Thanks.


Thomas.

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

[Friedrich W. H. Kossebau]

Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure:
> On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote:
> > Hi all,
> > 
> > Please see below - any ideas as to why KHelpCenter no longer successfully
> > builds?
> > 
> > It doesn't look like KHelpCenter has changed...
> 
> No, Qt has.

My question though is why. This would be a ABI-breaking change, no?
And khelpcenter nowhere disables deprecated Qt API, from what I can tell.

Does something smuggle in e.g. via CMake config file compile flags a 
QT_DISABLE_DEPRECATED_BEFORE=0x050e00 perhaps? Or is something flawed with the 
Qt packages on FreeBSD side?

Cheers
Friedrich

D28997: [applet] Improve tooltip text for single connected device use case

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:c810d1f3c8f2: [applet] Improve tooltip text for single 
connected device use case (authored by ngraham).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28997?vs=80590=80591

REVISION DETAIL
  https://phabricator.kde.org/D28997

AFFECTED FILES
  src/applet/package/contents/ui/logic.js

To: ngraham, #vdg, #plasma, drosca, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28997: [applet] Improve tooltip text for single connected device use case

[Nathaniel Graham]

ngraham added a comment.


  Or would "connected to [device]" be better? I'm not a heavy user of bluetooth 
and don't have a strong opinion on the matter.

REPOSITORY
  R97 Bluedevil

BRANCH
  better-single-device-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28997

To: ngraham, #vdg, #plasma, drosca, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28997: [applet] Improve tooltip text for single connected device use case

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Also fixes the bug that was making the popup be too wide in this case because 
we're no
  longer using a newline in the text (will fix that for the multi-device case 
in another
  patch later).

TEST PLAN
  Before: F8247608: Before.png 
  After: F8247607: After.png 

REPOSITORY
  R97 Bluedevil

BRANCH
  better-single-device-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28997

AFFECTED FILES
  src/applet/package/contents/ui/logic.js

To: ngraham, #vdg, #plasma, drosca
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28996: Converted to page and added heading

[Nathaniel Graham]

ngraham added a comment.


  Great! However the footer looks a bit weird since it doesn't touch the edges: 
F8247573: Screenshot_20200419_154306.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28996

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[David Edmundson]

davidedmundson resigned from this revision.
davidedmundson added a comment.


  Ah, I see.
  
name: "Search"
  PropertyChanges {
  target: tabBar
  opacity: 0
  }
  
  It's opacity zero, but technically still visible,  still enabled and with the 
same valid size. That sounds super weird :/
  But it means our mousearea is active and now I understand why you're saying 
it shouldn't be. Gotcha (in future longer commit messages can help make 
reviewing a bit faster)
  
  Surely then it'd still be active in the tabfocus chain too? And our property 
change should update enabled on tabbar too?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein, ngraham
Cc: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

KDE CI: Plasma » kactivitymanagerd » stable-kf5-qt5 FreeBSDQt5.14 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/stable-kf5-qt5%20FreeBSDQt5.14/3/
 Project:
stable-kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 19 Apr 2020 21:20:01 +
 Build duration:
1 min 44 sec and counting

D28996: Converted to page and added heading

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  screenshots coming

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28996

AFFECTED FILES
  applet/contents/ui/main.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I don't understand.
  
  Why is the search page a special case that should affect the tab bar 
behaviour?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein, ngraham, davidedmundson
Cc: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28988: Port hotplug from KRun::runCommand to CommandLauncherJob.

[David Faure]

dfaure added a comment.


  As it is currently implemented, CommandLauncherJob is very unlikely to ever 
fail. It doesn't even fail on non-existing executable in the command (because 
it delegates to bash) so apart from QProcess cannot fork, it never fails. 
Probably not worth doing something complicated here then. I'll just use 
KNotificationJobUiDelegate?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28988

To: dfaure, davidedmundson, sitter
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

[David Faure]

dfaure updated this revision to Diff 80586.
dfaure added a comment.


  Use KNotificationJobUiDelegate

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28990?vs=80568=80586

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28990

AFFECTED FILES
  CMakeLists.txt
  applets/quicklaunch/plugin/CMakeLists.txt
  applets/quicklaunch/plugin/quicklaunch_p.cpp

To: dfaure, drosca, davidedmundson, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

[David Faure]

dfaure added a comment.


  Agreed about notification delegate, will do.
  
  Does this really use KServiceAction anywhere? I don't see that. Confusing 
this one and D28988 ? [which however can't 
use the KServiceAction because of special support for %D and stuff]

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28990

To: dfaure, drosca, davidedmundson, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28988: Port hotplug from KRun::runCommand to CommandLauncherJob.

[Kai Uwe Broulik]

broulik added a comment.


  In principle dataengine actions are jobs, so they could communicate a result 
back

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28988

To: dfaure, davidedmundson, sitter
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

[Kai Uwe Broulik]

broulik added a comment.


  Also actually this should probably be refactored completely to use 
`KServiceAction` rather passing the exec to QML and then back here :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28990

To: dfaure, drosca, davidedmundson, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

[Kai Uwe Broulik]

broulik added a comment.


  Since it's an applet and thus run inside Plasma, do we not rather want the 
`KNotificationJobUiDelegate`?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28990

To: dfaure, drosca, davidedmundson, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kactivitymanagerd » stable-kf5-qt5 FreeBSDQt5.14 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/stable-kf5-qt5%20FreeBSDQt5.14/2/
 Project:
stable-kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 19 Apr 2020 20:17:53 +
 Build duration:
1 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 862 lines...][2020-04-19T20:19:16.786Z]   ^[2020-04-19T20:19:16.786Z] In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/stable-kf5-qt5 FreeBSDQt5.14/build/src/service/plugins/sqlite/resourcescoringadaptor.cpp:11:[2020-04-19T20:19:16.786Z] In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/stable-kf5-qt5 FreeBSDQt5.14/build/src/service/plugins/sqlite/resourcescoringadaptor.h:17:[2020-04-19T20:19:16.786Z] In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/stable-kf5-qt5 FreeBSDQt5.14/src/service/plugins/sqlite/StatsPlugin.h:27:[2020-04-19T20:19:16.786Z] In file included from /usr/local/include/boost/container/flat_set.hpp:27:[2020-04-19T20:19:16.786Z] In file included from /usr/local/include/boost/container/new_allocator.hpp:24:[2020-04-19T20:19:16.786Z] /usr/local/include/boost/container/throw_exception.hpp:88:25: warning: address of array 'msg' will always evaluate to 'true' [-Wpointer-bool-conversion][2020-04-19T20:19:16.786Z]   BOOST_ASSERT_MSG(!msg, str);[2020-04-19T20:19:16.786Z]~^~~[2020-04-19T20:19:16.786Z] /usr/local/include/boost/assert.hpp:61:46: note: expanded from macro 'BOOST_ASSERT_MSG'[2020-04-19T20:19:16.787Z] # define BOOST_ASSERT_MSG(expr, msg) assert((expr)&&(msg))[2020-04-19T20:19:16.787Z]  ^~~~[2020-04-19T20:19:16.787Z] /usr/include/assert.h:56:21: note: expanded from macro 'assert'[2020-04-19T20:19:16.787Z] #define assert(e)   ((e) ? (void)0 : __assert(__func__, __FILE__, \[2020-04-19T20:19:16.787Z]   ^[2020-04-19T20:19:16.787Z] 6 warnings generated.[2020-04-19T20:19:16.787Z] In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/stable-kf5-qt5 FreeBSDQt5.14/build/src/service/plugins/sqlite/resourcelinkingadaptor.cpp:11:[2020-04-19T20:19:16.787Z] In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/stable-kf5-qt5 FreeBSDQt5.14/build/src/service/plugins/sqlite/resourcelinkingadaptor.h:17:[2020-04-19T20:19:16.787Z] In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/stable-kf5-qt5 FreeBSDQt5.14/src/service/plugins/sqlite/ResourceLinking.h:26:[2020-04-19T20:19:16.787Z] In file included from /usr/local/include/boost/container/flat_set.hpp:27:[2020-04-19T20:19:16.787Z] In file included from /usr/local/include/boost/container/new_allocator.hpp:24:[2020-04-19T20:19:16.787Z] /usr/local/include/boost/container/throw_exception.hpp:56:21: warning: address of array 'msg' will always evaluate to 'true' [-Wpointer-bool-conversion][2020-04-19T20:19:16.787Z]   BOOST_ASSERT(!msg);[2020-04-19T20:19:16.787Z]~^~~[2020-04-19T20:19:16.787Z] /usr/local/include/boost/assert.hpp:60:36: note: expanded from macro 'BOOST_ASSERT'[2020-04-19T20:19:16.787Z] # define BOOST_ASSERT(expr) assert(expr)[2020-04-19T20:19:16.787Z]^~~~[2020-04-19T20:19:16.787Z] /usr/include/assert.h:56:21: note: expanded from macro 'assert'[2020-04-19T20:19:16.787Z] #define assert(e)   ((e) ? (void)0 : __assert(__func__, __FILE__, \[2020-04-19T20:19:16.787Z]   ^[2020-04-19T20:19:16.787Z] In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/stable-kf5-qt5 FreeBSDQt5.14/build/src/service/plugins/sqlite/resourcelinkingadaptor.cpp:11:[2020-04-19T20:19:16.787Z] In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/stable-kf5-qt5 FreeBSDQt5.14/build/src/service/plugins/sqlite/resourcelinkingadaptor.h:17:[2020-04-19T20:19:16.787Z] In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/stable-kf5-qt5 FreeBSDQt5.14/src/service/plugins/sqlite/ResourceLinking.h:26:[2020-04-19T20:19:16.787Z] In file included from /usr/local/include/boost/container/flat_set.hpp:27:[2020-04-19T20:19:16.787Z] In file included from /usr/local/include/boost/container/new_allocator.hpp:24:[2020-04-19T20:19:16.787Z] /usr/local/include/boost/container/throw_exception.hpp:64:25: warning: address of array 'msg' will always evaluate to 'true' [-Wpointer-bool-conversion][2020-04-19T20:19:16.787Z]   BOOST_ASSERT_MSG(!msg, str);[2020-04-19T20:19:16.787Z]~^~~[2020-04-19T20:19:16.787Z] /usr/local/include/boost/assert.hpp:61:46: note: expanded from macro 'BOOST_ASSERT_MSG'[2020-04-19T20:19:16.787Z] # define BOOST_ASSERT_MSG(expr, msg) assert((expr)&&(msg))[2020-04-19T20:19:16.787Z]  ^~~~[2020-04-19T20:19:16.787Z] /usr/include/assert.h:56:21: note: expanded from macro 

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Excellent!
  
  Please land on the `Plasma/5.18` branch and then merge to master. Let me know 
if you need a hand with that.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein, ngraham
Cc: ngraham, bugseforuns, dginovker, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28576: Converted to page and added Heading

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7d0a74721c5f: Converted to page and added Heading 
(authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28576?vs=79484=80583

REVISION DETAIL
  https://phabricator.kde.org/D28576

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> shortcutsmodel.cpp:440
> +}
> +const QString  = m_components[index.row()].uniqueName);
> +auto watcher = new 
> QDBusPendingCallWatcher(m_globalAccelInterface->getComponent(uniqueName));

compile error

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Found an interesting issue today: When you hide and show the menubar in 
Dolphin, this happens: F8247334: Screenshot_20200419_134038.png 
. It goes away if you interact with 
anything in the toolbar.
  
  Can reproduce in Kate too, and it goes away after interacting with the 
toolbar or switching tabs. Cannot reproduce in Konsole.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Nathaniel Graham]

ngraham added a comment.


  Well, they don't extend so far into the center of the screen as they used to.
  
  There's no way to make a notification pop-up not block anything. This patch 
is what feels best for me, as most of the tools and tabs I'm going to be using 
are more towards the edges of the screen, not the center. Could be different 
for others. However this is a non-default setting so hopefully it won't annoy 
many people. :) But I do think it's a genuine improvement for the "centered 
notifications" case. Give it a try and see if you like it!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  wider-notification-popu-when-on-top-or-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28989

To: ngraham, #vdg, #plasma, broulik, ndavis, cblack
Cc: IlyaBizyaev, ndavis, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  On the screenshots, the notifications block tab bars and toolbars in 3 apps :)
  Are you sure it's more convenient?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  wider-notification-popu-when-on-top-or-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28989

To: ngraham, #vdg, #plasma, broulik, ndavis, cblack
Cc: IlyaBizyaev, ndavis, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

[Ben Cooksley]

Hi all,

Another breakage in Qt?

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Sun, Apr 19, 2020 at 11:44 PM
Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5
FreeBSDQt5.14 - Build # 8 - Still Failing!
To: 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20stable-kf5-qt5%20FreeBSDQt5.14/8/
Project: Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14
Date of build: Sun, 19 Apr 2020 11:17:06 +
Build duration: 27 min and counting
* CONSOLE OUTPUT *
[...truncated 114019 lines...]
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/src/service/plugins/sqlite/ResourceLinking.h:26:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/flat_set.hpp:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/new_allocator.hpp:24:
[2020-04-19T11:44:31.964Z]
/usr/local/include/boost/container/throw_exception.hpp:88:25: warning:
address of array 'msg' will always evaluate to 'true'
[-Wpointer-bool-conversion]
[2020-04-19T11:44:31.964Z] BOOST_ASSERT_MSG(!msg, str);
[2020-04-19T11:44:31.964Z] ~^~~
[2020-04-19T11:44:31.964Z] /usr/local/include/boost/assert.hpp:61:46: note:
expanded from macro 'BOOST_ASSERT_MSG'
[2020-04-19T11:44:31.964Z] # define BOOST_ASSERT_MSG(expr, msg)
assert((expr)&&(msg))
[2020-04-19T11:44:31.964Z] ^~~~
[2020-04-19T11:44:31.964Z] /usr/include/assert.h:56:21: note: expanded from
macro 'assert'
[2020-04-19T11:44:31.964Z] #define assert(e) ((e) ? (void)0 :
__assert(__func__, __FILE__, \
[2020-04-19T11:44:31.964Z] ^
[2020-04-19T11:44:31.964Z] 6 warnings generated.
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/build/src/service/plugins/sqlite/resourcescoringadaptor.cpp:11:
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/build/src/service/plugins/sqlite/resourcescoringadaptor.h:17:
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/src/service/plugins/sqlite/StatsPlugin.h:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/flat_set.hpp:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/new_allocator.hpp:24:
[2020-04-19T11:44:31.964Z]
/usr/local/include/boost/container/throw_exception.hpp:56:21: warning:
address of array 'msg' will always evaluate to 'true'
[-Wpointer-bool-conversion]
[2020-04-19T11:44:31.964Z] BOOST_ASSERT(!msg);
[2020-04-19T11:44:31.964Z] ~^~~
[2020-04-19T11:44:31.964Z] /usr/local/include/boost/assert.hpp:60:36: note:
expanded from macro 'BOOST_ASSERT'
[2020-04-19T11:44:31.964Z] # define BOOST_ASSERT(expr) assert(expr)
[2020-04-19T11:44:31.964Z] ^~~~
[2020-04-19T11:44:31.964Z] /usr/include/assert.h:56:21: note: expanded from
macro 'assert'
[2020-04-19T11:44:31.964Z] #define assert(e) ((e) ? (void)0 :
__assert(__func__, __FILE__, \
[2020-04-19T11:44:31.964Z] ^
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/build/src/service/plugins/sqlite/resourcescoringadaptor.cpp:11:
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/build/src/service/plugins/sqlite/resourcescoringadaptor.h:17:
[2020-04-19T11:44:31.964Z] In file included from
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/kactivitymanagerd/src/service/plugins/sqlite/StatsPlugin.h:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/flat_set.hpp:27:
[2020-04-19T11:44:31.964Z] In file included from
/usr/local/include/boost/container/new_allocator.hpp:24:
[2020-04-19T11:44:31.964Z]
/usr/local/include/boost/container/throw_exception.hpp:64:25: warning:
address of array 'msg' will always evaluate to 'true'
[-Wpointer-bool-conversion]
[2020-04-19T11:44:31.964Z] BOOST_ASSERT_MSG(!msg, str);
[2020-04-19T11:44:31.964Z] ~^~~
[2020-04-19T11:44:31.964Z] /usr/local/include/boost/assert.hpp:61:46: note:
expanded from macro 'BOOST_ASSERT_MSG'
[2020-04-19T11:44:31.964Z] # define BOOST_ASSERT_MSG(expr, msg)
assert((expr)&&(msg))
[2020-04-19T11:44:31.964Z] ^~~~
[2020-04-19T11:44:31.964Z] /usr/include/assert.h:56:21: note: expanded from
macro 'assert'
[2020-04-19T11:44:31.964Z] #define assert(e) ((e) ? (void)0 :
__assert(__func__, __FILE__, \
[2020-04-19T11:44:31.964Z] ^
[2020-04-19T11:44:31.965Z] In file included from

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Needs a rebase

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

[Filip Fila]

filipf updated this revision to Diff 80582.
filipf added a comment.


  remove the separator instead of just shortening it

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25728?vs=70873=80582

BRANCH
  no-unwanted-titlebar-separator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25728

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #plasma, #vdg
Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[Patrick Silva]

bugseforuns added a comment.


  Patch also working on Neon unstable edition. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein
Cc: bugseforuns, dginovker, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  The lack of spacing looks bad but whatever

REPOSITORY
  R120 Plasma Workspace

BRANCH
  wider-notification-popu-when-on-top-or-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28989

To: ngraham, #vdg, #plasma, broulik, ndavis, cblack
Cc: ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Alexander Lohnau]

alex updated this revision to Diff 80580.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28619?vs=80578=80580

REVISION DETAIL
  https://phabricator.kde.org/D28619

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Alexander Lohnau]

alex updated this revision to Diff 80578.
alex added a comment.


  Implement requested changes
  
  Thanks, I will do that after the bugfix is done :-)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28619?vs=79466=80578

BRANCH
  arcpatch-D28619

REVISION DETAIL
  https://phabricator.kde.org/D28619

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Nathaniel Graham]

ngraham added a comment.


  Heh, sorry!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  wider-notification-popu-when-on-top-or-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28989

To: ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Please just remove the `writeEntry`.
  
  You can then propose "But what about renaming the dbfile entry, maybe to 
alternate_dbfile?" as another review.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28619

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Alexander Lohnau]

alex added a comment.


  Friendly ping :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28619

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Noah Davis]

ndavis added a comment.


  Oof, what a sad set of example notifications 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28989

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Konsole Runner: optimize and simplify

[Alexander Lohnau]

alex added a comment.


  @ngraham and others, may I ship this?

REPOSITORY
  R114 Plasma Addons

BRANCH
  arcpatch-D27098

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, 
broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

[David Faure]

dfaure created this revision.
dfaure added reviewers: drosca, davidedmundson, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

TEST PLAN
  Builds, but untested.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28990

AFFECTED FILES
  CMakeLists.txt
  applets/quicklaunch/plugin/quicklaunch_p.cpp

To: dfaure, drosca, davidedmundson, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Somehow the notification pop-up's positioning has never felt quite right to 
me. When it's
  in a bottom corner, it blocks the view of the latest messages in chat apps, 
or the text
  I'm searching for in Kate. When it's in a top corner, it blocks part of the 
open app's
  toolbar or tab bar that I often use. The best place I've found for is in the 
top-middle, which doesn't block very many of the thing I'm active using, and 
its centered position
  feels aesthetically pleasing. I've been using this for a bit and quite like 
it.
  
  However there is ony deficiency: the pop-up is not very wide, so it becomes 
quite tall
  when displaying multi-line messages from chat apps in particular, which makes 
the notification stack intrude into the middle of the screen where it 
definitely blocks things you
  want to be looking at. This is annoying.
  
  This patch resolves that issue by making the pop-up's size wider and the 
spacing between
  pop-ups smaller when the pop-ups are positioned in the top or bottom middle.
  
  There is no visual change when the notification pop-up is in one of the 
corners.

TEST PLAN
  Centered pop-ups now look like this:
  Single pop-up: F8247020: Screenshot_20200419_110522.png 

  Stack of pop-ups: F8247025: Screenshot_20200419_112511.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  wider-notification-popu-when-on-top-or-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28989

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28988: Port hotplug from KRun::runCommand to CommandLauncherJob.

[David Faure]

dfaure created this revision.
dfaure added reviewers: davidedmundson, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Is there a better way to report error from this code than the dialog box
  that KRun used to pop up (and KDialogJobUiDelegate does too)?

TEST PLAN
  Untested.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28988

AFFECTED FILES
  CMakeLists.txt
  dataengines/hotplug/deviceserviceaction.cpp

To: dfaure, davidedmundson, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

ngraham added a comment.


  Landed on master since adding or changing strings in the stable branch isn't 
allowed.
  
  Thanks for the contribution!

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R845:6944aab19e86: Include the Plasma Vault name in the mount 
dialog title (authored by ksmanis, committed by ngraham).

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28914?vs=80455=80560

REVISION DETAIL
  https://phabricator.kde.org/D28914

AFFECTED FILES
  kded/ui/mountdialog.cpp
  kded/ui/mountdialog.ui

To: ksmanis, #plasma, davidedmundson, ivan, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[Daniel Ginovker]

dginovker added a comment.


  Hi - I'm the original bug reporter, hopefully I'm allowed to comment here. 
The patch provided works, tested on 2 machines running Manjaro KDE :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein
Cc: dginovker, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28970: [applets/digital clock] Make tooltip spacing and text nicer and more consistent

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:44d338fcb105: [applets/digital clock] Make tooltip 
spacing and text nicer and more consistent (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28970?vs=80514=80559#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28970?vs=80514=80559

REVISION DETAIL
  https://phabricator.kde.org/D28970

AFFECTED FILES
  applets/digital-clock/package/contents/ui/Tooltip.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28971: Persist state between launches

[Nathaniel Graham]

ngraham added a comment.


  Window geometry and position is supposed to be saved automatically by 
KXMLGui, at least for widgets apps. If that's not possible to do here, perhaps 
we should have Kirigami do this at the frameworks level so it doesn't need to 
be done by every single app.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D28971

To: cblack, #kirigami
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Alexandre Pereira]

pereira.alex updated this revision to Diff 80557.
pereira.alex added a comment.


  Trying to fix the bug:
  
  So reverted the changed did and focused on fixing the bug.
  It was missing a connection to list view mode change.
  
  So now one can change view mode, change icon size in icon view mode and 
revert back to list view mode and the icon size will be the correct one.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28057?vs=78758=80557

BRANCH
  fix-folderview-popup-icon-list-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28057

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  When the root is in the "Search" state, we can safely disable it.
  
  BUG: 420282

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff

REVISION DETAIL
  https://phabricator.kde.org/D28985

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: trmdi, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Ahmad Samir]

ahmadsamir added a reviewer: broulik.
ahmadsamir added a comment.


  I had trouble finding what urlPatterns would look like, and only found 
trash:/ and run:/, also couldn't find any documentation about 
X-Plasma-DropUrlPatterns.
  
  Porting regex, especially with the pesky QRegExp::Wildcard, seeing what the 
pattern should look like always helps (and then adding a comment in the code 
with examples, that helps future changes, some docs say that the best 
regex-handling-code is one that has comments with examples of what the regex is 
supposed to match).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol, broulik
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80553.
davidre added a comment.


  - Make loading async
  - Make everything async

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80405=80553

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Aleix Pol Gonzalez]

apol added a comment.


  I wonder, while this will work with all our uses of DropUrlPatterns, this 
would have been able to work with something like `scheme:/*potato*` which after 
this patch won't work.
  
  In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate 
feedback from someone else. Code-wise, looks better for sure.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28651: Load and use global animation settings

[Martin Tobias Holmedahl Sandsmark]

sandsmark updated this revision to Diff 80551.
sandsmark added a comment.


  Remove the duplication of animation control, and don't override the animation 
settings if people haven't adjusted it globally.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28651?vs=79916=80551

REVISION DETAIL
  https://phabricator.kde.org/D28651

AFFECTED FILES
  kdecoration/config/breezeconfigwidget.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: sandsmark, #breeze
Cc: davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, trickyricky26, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  AFAICS, from grep'ing for "DropUrlPatterns" in 
/usr/share/{kservices5,plasma/plasmoids/}
  "urlPatterns" is either run:/ or trash:/, hence startsWith() should suffice.

TEST PLAN
  make && ctest

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28978

AFFECTED FILES
  src/plasma/pluginloader.cpp

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

[Kai Uwe Broulik]

broulik added a comment.


  It's just a `QAbstractListModel`, if any, it does some `columnCount` 
behavior. I emit `dataChanged`, yes. Will check the actual column count later.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28649

To: broulik, #plasma
Cc: davidre, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

[David Faure]

dfaure added a comment.


  Wait, even if the jobs model is empty (no rows), what's its columnCount()?
  If that's fixed, then it should all be fine. Maybe my analysis (and testcase) 
is incorrect.
  
  Can you check the columnCount() of the Concat model?
  
  I assume the notifications model emits dataChanged correctly when the 
ExpiredRole is set to true?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28649

To: broulik, #plasma
Cc: davidre, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

[Kai Uwe Broulik]

broulik added a comment.


  :( I see. Thanks! 
  At least by then I'll be able to use `sourceModels()` so I could make the 
mapping up the chain generic

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28649

To: broulik, #plasma
Cc: davidre, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

[David Faure]

dfaure added a comment.


  OK I see why this is happening.
  
  KConcatenateProxyModel's columnCount is the number of columns of the first 
source model. Which leads to strange things if other models have less columns.
  QConcatenateProxyModel takes the smallest number of columns of all source 
models, to solve that.
  But here the jobs model is empty. And empty model shouldn't be taken into 
account when calculating the number of columns.
  I'll fix that in QConcatenateProxyModel, but that means you can't use it for 
another 2 years or so... oh well ;)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28649

To: broulik, #plasma
Cc: davidre, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28958: [kcm_nightcolor] Set 2 decimal places precision for coordinates

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:35e18420a76a: [kcm_nightcolor] Set 2 decimal places 
precision for coordinates (authored by shubham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28958?vs=80495=80517

REVISION DETAIL
  https://phabricator.kde.org/D28958

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: shubham, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart