Review Request 128682: Fix typo in icon name

--- Introduced in commit 9e236ec5d4d28d7498dfcc830a95590dececcf02 Diffs - src/declarative/pkupdates.cpp 324387f Diff: https://git.reviewboard.kde.org/r/128682/diff/ Testing --- Built and run, icon appears fine. Thanks, Fabian Vogt

Re: Review Request 128682: Fix typo in icon name

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 9662b9c5d83ad0188803830d7cf9a96a2db0d114 by David Edmundson on behalf of Fabian Vogt to branch master. Repository: plasma-pk-updates Description --- Introduced in commit

[Differential] [Request, 3 lines] D4464: Add missing include in sortedactivitiesmodel to fix build with GCC 7I did not build-test this, but it's fairly obvious.

fvogt created this revision. fvogt added a reviewer: Plasma. fvogt added a subscriber: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes "error: 'placeholders' is not a namespace-name" REPOSITORY R119

[Differential] [Closed] D4464: Add missing include in sortedactivitiesmodel to fix build with GCC 7I did not build-test this, but it's fairly obvious.

fvogt closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4464 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, #plasma, davidedmundson Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed,

[Differential] [Accepted] D4654: Port to QMultiHash.

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. If all cases of insert(key,value) are validated to behave correctly (same as insertMulti now!), this looks good to me. Easier to understand and fewer code lines! REPOSITORY R120

[Differential] [Request, 4 lines] D4794: Fix default fixed font in fonts kcm

fvogt created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Now it is the same as used by plasma-integration. Also adjust the file name in the comment, which was apparently forgotten. TEST PLAN I

[Differential] [Updated] D4794: Fix default fixed font in fonts kcm

fvogt added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4794 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Differential] [Updated] D4794: Fix default fixed font in fonts kcm

fvogt edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4794 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

[Differential] [Request, 2 lines] D4579: Do not treat filename in selection as URL

fvogt created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KFileWidget::setSelection(QString &) accepts either absolute URLs or relative paths. If the filename contains a :, it gets treated as a URL

[Differential] [Updated] D4579: Do not treat filename in selection as URL

fvogt added a reviewer: Plasma. fvogt added a comment. https://bugs.kde.org/show_bug.cgi?id=376365 contains reproducer, with this change it works. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4579 EMAIL PREFERENCES

[Differential] [Closed] D4579: Do not treat filename in selection as URL

This revision was automatically updated to reflect the committed changes. Closed by commit R135:e70f8134a2bc: Do not treat filename in selection as URL (authored by fvogt). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. I finally figured the issue out. Newly appearing windows try to steal focus, which makes m_focusedLockWindow actually wrong. That explains why it works only for some and only for some setups... I'll try to fix that by adding

[Differential] [Closed] D4794: Fix default fixed font in fonts kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d02de0db36a3: Fix default fixed font in fonts kcm (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4794?vs=11826=11841 REVISION DETAIL

[Differential] [Updated, 29 lines] D4821: Implement manual focus on click

fvogt updated this revision to Diff 11941. fvogt added a comment. Newly created windows do not steal focus anymore Needs a quick test that it does not break wayland (e.g. no focus at all) REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

[Differential] [Requested Review] D4821: Implement manual focus on click

fvogt requested review of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, broulik, #plasma, graesslin Cc: plasma-devel, progwolff, lesliezhai,

[Differential] [Request, 24 lines] D4821: Implement manual focus on click

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Currently only the first created screenlock window gets focus. On clicks, no focus events are sent, which makes it impossible to input passwords. This patch now makes it possible to focus to a

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. This is weird: While the fix works absolutely fine (and reliably) for me on my primary user account, it does not have any effect for a different user around and @broulik Even weirder: I cannot reproduce the original bug in any of my VMs using multihead QXL...

[Differential] [Updated, 28 lines] D4821: Implement manual focus on click

fvogt updated this revision to Diff 11916. fvogt added a comment. Handle the case better when the currently focused window vanishes REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4821?vs=11898=11916 BRANCH Plasma/5.8 REVISION DETAIL

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. In https://phabricator.kde.org/D4821#90657, @graesslin wrote: > Just as an fyi: in the build tree there is a test app which does the complete locking without the need for restart the session. Would that really work for changes in x11locker.cpp as well? it's

Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/#review100841 --- Ship it! Tested, works fine! - Fabian Vogt On Nov. 14

D5227: Add a configuration option to hide the show password button

fvogt planned changes to this revision. fvogt added a comment. I would fix the clipboard content issue with klipper (although I find that approach wrong as it's too complicated as a seemingly unrelated component needs to support the screenlocker), but I do not have enough experience in that

D5227: Add a configuration option to hide the show password button

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The show password button only makes sense with a virtual keyboard on touchscreens. On desktop PCs it's not only not useful, but it can also be used to show (partially) typed in passwords. It also

D5227: Add a configuration option to hide the show password button

fvogt updated this revision to Diff 12933. fvogt added a comment. Add a comment in greeterapp.cpp and also add a tooltip to the configuration option label. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5227?vs=12932=12933 BRANCH master REVISION

D5227: Add a configuration option to hide the show password button

fvogt added a comment. In https://phabricator.kde.org/D5227#98542, @broulik wrote: > For show password button there's a kiosk restriction available: **lineedit_reveal_password** (see https://userbase.kde.org/KDE_System_Administration/Kiosk/Keys) Indeed, that works! Now if just

D5227: Add a configuration option to hide the show password button

fvogt added a comment. In https://phabricator.kde.org/D5227#98555, @graesslin wrote: > I'm against adding this option as the greeter does not have any influence over the lnf package. It works with our default but as soon as users change the theme we do not know. I'm against adding new

D5025: Do not use fixed steps when scrolling on battery icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:82a44a3f264c: Do not use fixed steps when scrolling on battery icon (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D5351: kcm_baloofile: Add option to disable file content indexing

fvogt updated this revision to Diff 13325. fvogt added a comment. Fixed label capitalization REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5351?vs=13233=13325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5351 AFFECTED FILES

D5351: kcm_baloofile: Add option to disable file content indexing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a818d2f0ad30: kcm_baloofile: Add option to disable file content indexing (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D5445: update baloo kcm docbook

fvogt added inline comments. INLINE COMMENTS > ltoscano wrote in index.docbook:62 > Uh, how is it different from the current text? Which current text? This got added. I'd phrase it like "Use 'Also index file content' to also index the file contents additional to the file names". REPOSITORY

D5445: update baloo kcm docbook

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > index.docbook:62 > > +Use Also index file content to only index the > filename or additionally > +the file contents. That is a bit misleading IMO, "Use

D5445: update baloo kcm docbook

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5445 To: lueck, #plasma, #documentation, mart, fvogt Cc: ltoscano, plasma-devel,

D5471: Prefer `plasmashell --version` to get Plasma version

fvogt added a comment. I don't know why openSUSE started replacing the upstream plasma5 session file with something that is basically an exact copy, I was not involved in the process. However, I also think that it is wrong and needs to be cleaned up. I can only think of a single valid

D5025: Do not use fixed steps when scrolling on battery icon

fvogt added a comment. Arc seems to have selected my local branch as target branch for some reason, it should be "master" instead, obviously REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5025 To: fvogt, #plasma Cc: plasma-devel, progwolff, lesliezhai,

D5025: Do not use fixed steps when scrolling on battery icon

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This makes it possible to have some more fine-grained control over the screen brightness with scroll devices that support it, like touchpads or trackpoints. TEST PLAN Tested with touchpad,

D4955: [QDBusMenuBar] Connect to popupRequested signal

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested this with Qt 5.6.2 + backports, the signal gets triggered fine. So far it only seems to work with a few select apps (dolphin), some (e.g. konsole) do not assign shortcuts at all and

D4955: [QDBusMenuBar] Connect to popupRequested signal

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Can't apply to Plasma/5.9 with arc patch as your diff is missing the workaround code for Qt 5.7.0. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

[Differential] [Closed] D4821: Implement manual focus on click

This revision was automatically updated to reflect the committed changes. Closed by commit R133:f8043de10b5d: Implement manual focus on click (authored by fvogt). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4821?vs=11941=12030 REVISION DETAIL

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. In https://phabricator.kde.org/D4821#91393, @hein wrote: > > On Wayland screen locker is initially focused but clicking on different screens doesn't focus them. > > If this is outstanding, maybe add a FIXME TODO so we don't forget ...? Yes, but that can

D5351: kcm_baloofile: Add option to disable file content indexing

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Baloo supports "only basic indexing" since version 5.15, which causes it to only store file names into the database: https://community.kde.org/Baloo/Configuration TEST PLAN Ran "balooctl config

D5351: kcm_baloofile: Add option to disable file content indexing

fvogt updated this revision to Diff 13233. fvogt added a comment. Obviously for master only. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5351?vs=13232=13233 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5351 AFFECTED FILES

D5499: Fix new checkbox for file content indexing in kcm_baloofile

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Needs a new connection to enable the "Apply" button. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D5499 AFFECTED FILES kcms/baloo/kcm.cpp To:

D5499: Fix new checkbox for file content indexing in kcm_baloofile

This revision was automatically updated to reflect the committed changes. Closed by commit R119:df9cee28e120: Fix new checkbox for file content indexing in kcm_baloofile (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D6718: Fix occasional abort in the krunner plugin

fvogt updated this revision to Diff 17480. fvogt added a comment. != 1 REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6718?vs=16746=17480 BRANCH crashfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D6718

D6718: Fix occasional abort in the krunner plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R856:a56dd8a1760c: Fix occasional abort in the krunner plugin (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6718?vs=17480=17481

D7046: Use xcb-icccm to read the name property

fvogt added inline comments. INLINE COMMENTS > anthonyfieroni wrote in client.cpp:1428 > QByteArray has a move constructor, it's not copy. That does not matter in this instance. `QString::fromUtf8(QByteArray(reply.name, reply.name_len));` does two copies: - QByteArray copies name_len bytes

D7046: Use xcb-icccm to read the name property

fvogt added inline comments. INLINE COMMENTS > graesslin wrote in client.cpp:1428 > fromRawData is dangerous as we delete the data with the wipe call again. > That's why I didn't use it. QString::fromUtf8 is something I didn't use as > QString from ascii is discouraged and can result in

D7046: Use xcb-icccm to read the name property

fvogt added a comment. Built and tested - works fine! I only added two rather nitpicky comments. INLINE COMMENTS > client.cpp:1428 > +if (reply.encoding == atoms->utf8_string) { > +retVal = QString::fromUtf8(QByteArray(reply.name, > reply.name_len)); > +

D7123: Several cleanups

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY - No cppcheck warnings anymore - Use snprintf everywhere - Avoid pointless multiplication with sizeof(char) - Avoid memory leaks TEST PLAN Still builds, works the same as before. REPOSITORY

D7125: Check for a graphical session

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Avoid running if it detects a text session. This can be overridden by adding "force_run" as argument. TEST PLAN Put pam_kwallet5.so as optional in a global common-session pam file that is

D7124: Avoid dropping privileges by initializing gcrypt secmem

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY It's a documented side effect that initialization of secure memory in gcrypt drops privileges if getuid() != geteuid(). This results in breaking setuid callers, like sudo or su. TEST PLAN Can

D7257: Set the QtQuick Controls 1 style name explicitly

fvogt added a comment. openQA found something that looks related as well, but unsetting does not help: https://openqa.opensuse.org/tests/467477#step/systemsettings5/5 I cannot reproduce the issue you have either. Maybe some kind of cache or leftovers from other styles? This change

D7257: Set the QtQuick Controls 1 style name explicitly

fvogt added a comment. Does it work with `export QT_QUICK_CONTROLS_1_STYLE=Breeze`? I don't know how the style selection of Quick Controls work, maybe someone more knowledgeable in that area could chime in here. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D7255: Remove application directory from QCoreApplication::libraryPaths()

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The directory containing the main application (read through argv[0]) is by default added to the list of paths containing libraries. This causes various methods to iterate through all entries of the

D7255: Remove application directory from QCoreApplication::libraryPaths()

fvogt added a comment. In https://phabricator.kde.org/D7255#134678, @graesslin wrote: > Reading through your description I think that KWin must also be affected and many, many more applications. Actually probably everything distributed in the classic "sysadmin style" (to reference a

D7160: Also specify a default StyleName for fonts

fvogt closed this revision. fvogt added a comment. Didn't get closed automatically again... https://commits.kde.org/plasma-integration/1b21b5977c2068c5bd30c9f9f641f60bdba9ea8e REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D7255: Remove application directory from QCoreApplication::libraryPaths()

fvogt added a comment. In https://phabricator.kde.org/D7255#134745, @broulik wrote: > > I'll look whether it's possible to override that in a sane place as well. > > KDeclarative QmlObject, maybe? I think the single QuickViewSharedEngine used in most of Plasma should already give a

D7257: Set the QtQuick Controls 1 style name explicitly

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY It does explicitly what the comment above the export implies. That way this warning on every use of Quick Controls 1 is gone: WARNING: Cannot find style "org.kde.desktop" - fallback:

D7257: Set the QtQuick Controls 1 style name explicitly

This revision was automatically updated to reflect the committed changes. Closed by commit R120:053d54488cdd: Set the QtQuick Controls 1 style name explicitly (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7257?vs=18020=18130

D7255: Remove application directory from QCoreApplication::libraryPaths()

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cf572c3b5224: Remove application directory from QCoreApplication::libraryPaths() (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D6679: Treat Button/ToolButton labels as plaintext

fvogt marked an inline comment as done. fvogt added inline comments. INLINE COMMENTS > broulik wrote in ToolButtonStyle.qml:100 > `Text.StyledText` I think the priority queue in my brain is somehow backwards REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D6679: Treat Button/ToolButton labels as plaintext

fvogt created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The label text gets treated as RichText/StyledText, which is required to display mnemonics underlined. Therefore it is necessary to

D6679: Treat Button/ToolButton labels as plaintext

fvogt updated this revision to Diff 16649. fvogt added a comment. Fix typo in ToolButtonStyle REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6679?vs=16648=16649 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6679

D6634: Require C++14

fvogt added a comment. In https://phabricator.kde.org/D6634#125102, @graesslin wrote: > In https://phabricator.kde.org/D6634#124880, @lbeltrame wrote: > > > openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available as well. > > > @lbeltrame does it mean it

D6673: [Notifications] Manually remove remote images

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > textsanitizer.cpp:45 > +for (int i = 0; i < newDocument->blockCount(); ++i) { > +QTextBlock block = newDocument->findBlock(i); > + (Already noted

D5227: Add a configuration option to hide the show password button

fvogt abandoned this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5227 To: fvogt, #plasma, graesslin Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6626: Session file parser: Support sections and respect the Hidden property

This revision was automatically updated to reflect the committed changes. Closed by commit R123:992143c4bf5a: Session file parser: Support sections and respect the Hidden property (authored by fvogt). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D6626: Session file parser: Support sections and respect the Hidden property

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Some desktop files have multiple sections, but for now we're only interested in [Desktop Entry]. Without this patch, every entry was seen as part of the [Desktop Entry] session, resulting in values

D6612: Honour the NoDisplay attribute of KServices

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY kcmshell5 refuses to load modules that have this set and when clicking on them in systemsettings, an empty page with no button to go back to the overview is shown. So just don't show them to the

D6612: Honour the NoDisplay attribute of KServices

This revision was automatically updated to reflect the committed changes. Closed by commit R124:85ed16cd4228: Honour the NoDisplay attribute of KServices (authored by fvogt). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6612?vs=16457=16487 REVISION

D6704: Fix tabsrunner DBus reply parsing

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The TODO comment in the code turned out to have fixed itself, so the code needed adjustment. As QList (which is actually a QList>) is apparently not a demarshall target,

D6707: Move browser detection to the extension

fvogt added a comment. I noticed that the correct dir for the firefox native messaging host is not `/usr/lib/mozilla/native-messaging-hosts/org.kde.plasma.browser_integration.json`, but rather `/usr/lib64/mozilla/native-messaging-hosts/org.kde.plasma.browser_integration.json`. I'm not 100%

D6707: Move browser detection to the extension

This revision was automatically updated to reflect the committed changes. Closed by commit R856:f01e3f0b98c0: Move browser detection to the extension (authored by fvogt). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6707?vs=16724=16726#toc REPOSITORY R856 Plasma Browser Integration

D6707: Move browser detection to the extension

fvogt marked an inline comment as done. REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D6707 To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D6707: Move browser detection to the extension

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY It's much easier to detect the browser there, so let the extension write a message with the browser name (mapped to Settings::Environment) to the native host. Also add support for Vivaldi. TEST

D6705: Actually filter the tab properties sent to the host

fvogt added a comment. In https://phabricator.kde.org/D6705#125503, @broulik wrote: > Where did you see a JPEG-encoded screenshot? Could perhaps be the favicon. In extData["thumbnail"], much larger than a favicon should ever be. Didn't get sent by opera 40, vivaldi 1.10 added

D6704: Fix tabsrunner DBus reply parsing

This revision was automatically updated to reflect the committed changes. Closed by commit R856:cfc45b00fb30: Fix tabsrunner DBus reply parsing (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6704?vs=16717=16722

D6705: Actually filter the tab properties sent to the host

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Previously it sent all information about a tab that it had, including a base64 encoded JPG screenshot, causing quite a lot of traffic. TEST PLAN dbus-monitor shows a lot less traffic, krunner

D6705: Actually filter the tab properties sent to the host

This revision was automatically updated to reflect the committed changes. Closed by commit R856:6d10d359a1c2: Actually filter the tab properties sent to the host (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D6711: Check for HUP/ERR/NVAL conditions on stdin

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY While Qt's event loop checks for POLLHUP, it treats it exactly like POLLIN and it's not possible to retrieve that information from Qt. So in the Connection read handler it needs to be checked for

D6714: Use same file descriptor for notification and reading

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Otherwise we wait for data on a different descriptor than we read from, which results in missing notifications if data lands in a buffer. TEST PLAN No modules were loaded after reloading the

D6711: Check for HUP/ERR/NVAL conditions on stdin

This revision was automatically updated to reflect the committed changes. Closed by commit R856:4c2a3b168036: Check for HUP/ERR/NVAL conditions on stdin (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6711?vs=16856=16857

D6711: Check for HUP/ERR/NVAL conditions on stdin

fvogt updated this revision to Diff 16856. fvogt added a comment. Use QCoreApplication, add BUG ref REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6711?vs=16736=16856 BRANCH arcpatch-D6711 REVISION DETAIL

D6714: Use same file descriptor for notification and reading

This revision was automatically updated to reflect the committed changes. Closed by commit R856:b70020061b67: Use same file descriptor for notification and reading (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D6717: Expose base64-encoded favicons to the tabsrunner

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The browser has them in the cache already, so we avoid loading it ourselves, also we might not even have access to the icons from our context. Some browsers (Opera does) set the favIconUrl of the

D6718: Fix occasional abort in the krunner plugin

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Sometimes the DBus reply has no arguments, so avoid trying to access them. TEST PLAN No crashes so far. REPOSITORY R856 Plasma Browser Integration BRANCH crashfix (branched from master)

D6717: Expose base64-encoded favicons to the tabsrunner

fvogt added a comment. It could also decode the base64 data in the plasma-browser-integration-host already and send it as bytearray, I'm not sure what's simpler/better/faster. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D6717 To: fvogt,

D6795: Honor system font settings

fvogt added a comment. > (since Chrome expects that in pixels but we use points) I guess we could convert that fairly easily, which kind of pixels does chromium expect? Device-independant or device-dependant or something entirely different? REPOSITORY R856 Plasma Browser Integration

D6718: Fix occasional abort in the krunner plugin

fvogt added a comment. In https://phabricator.kde.org/D6718#125807, @davidedmundson wrote: > This shouldn't be needed. > Even an empty QList will have an argument of that empty QList and errors will have a different type. I thought so too, until I got crashes without the

D6717: Expose base64-encoded favicons to the tabsrunner

fvogt updated this revision to Diff 16759. fvogt added a comment. Also send a request for the favicon without timeout to fill the cache for next time. Otherwise favicons from slow servers might never show up REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D6679: Treat Button/ToolButton labels as plaintext

This revision was automatically updated to reflect the committed changes. fvogt marked an inline comment as done. Closed by commit R242:48a8245db4d8: Treat Button/ToolButton labels as plaintext (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6717: Expose base64-encoded favicons to the tabsrunner

fvogt marked 4 inline comments as done. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D6717 To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6717: Expose base64-encoded favicons to the tabsrunner

This revision was automatically updated to reflect the committed changes. Closed by commit R856:d435a59b0514: Expose base64-encoded favicons to the tabsrunner (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D6717: Expose base64-encoded favicons to the tabsrunner

fvogt updated this revision to Diff 17287. fvogt added a comment. braces + const A hasOwnProperty check is not needed here, that's accounted for by the if (!favIconUrl) below REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D7160: Also specify a default StyleName for fonts

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY When saving, kcm_fonts adds the default selected StyleName, so it needs to specified here as well to avoid mismatches. BUG: 383191 TEST PLAN Ran pkcon install with no kdeglobals. Without

D7160: Also specify a default StyleName for fonts

fvogt added a comment. In https://phabricator.kde.org/D7160#132870, @cfeck wrote: > Note that saving the style name is a bug, see https://bugs.kde.org/show_bug.cgi?id=378523 While I'm not 100% sure that is true as that's how the user selects the font in kcm_fonts, I still think

D7123: Several cleanups

fvogt closed this revision. fvogt added a comment. Didn't get closed automatically... https://commits.kde.org/kwallet-pam/a33ec22b96e837899528b05963eae8ea6b01171a REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D7123 To: fvogt, #plasma,

D7046: Use xcb-icccm to read the name property

fvogt added a comment. In https://phabricator.kde.org/D7046#133383, @graesslin wrote: > ping Still works fine here, but I can't really comment on the sanity of the code changes. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7046 To: graesslin, #kwin,

D6697: Allow to change toolbar font separately again

fvogt added a comment. Looks good to me as well (+ the other patch), I just added two comments. INLINE COMMENTS > fonts_global_toolbar.pl:12 > +{ > +chomp; > +$generalFont = $1 if ($_ =~ /font=(.*)/); Not sure, but maybe the script should only read/change the `[General]` section? >

D7125: Check for a graphical session

fvogt closed this revision. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D7125 To: fvogt, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7125: Check for a graphical session

fvogt added a comment. No automatic close for some reason: https://commits.kde.org/kwallet-pam/f3b230f7f3bf39dc46b97a216aa7c28595d20a7a REPOSITORY R107 KWallet PAM Integration BRANCH patch4 REVISION DETAIL https://phabricator.kde.org/D7125 To: fvogt, #plasma, davidedmundson Cc:

  1   2   3   4   5   6   7   >