Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-09 Thread Kai Uwe Broulik
> On Feb. 7, 2014, 11:47 p.m., Eike Hein wrote: > > Sorry, I missed this yesterday due to an incorrect sieve filter. > > > > As Mark points out the thumbnail sizes will have to be made DPI-aware > > (there's an outstanding user wish for that), but it can go in this way for > > now. I'm merging

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-09 Thread Kai Uwe Broulik
If I had an idea how to get them properly scaled for high-dpi I'd do it > myself :-) > > Kai Uwe Broulik wrote: > regularThumbSize * QApplication::desktop()->physicalDpiX() / (qreal)96; > Or PlasmaCore.Units iirc - Kai Uwe -

Re: Review Request 115712: Do not show OSD for invalid percentage i.e -1 or 109

2014-02-13 Thread Kai Uwe Broulik
still hoping KMix will one day support this). - Kai Uwe Broulik On Feb. 13, 2014, 7:17 a.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/115409/diff/ Testing --- Has some minor glitches, please see bugreport. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/115409/diff/ Testing --- Has some minor glitches, please see bugreport. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Oxygen as default font

2014-03-05 Thread Kai Uwe Broulik
Hi, Yes I've been changing the default font to Oxygen an all machines I have set up. However, we should also enable font anti-aliasing and subpixel hinting (I use Medium) to make the font really shine. Cheers, Kai Uwe Am 05.03.2014 13:36 schrieb =?ISO-8859-1?Q?Sebastian_K=FCgler?= : > > Hey,

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-07 Thread Kai Uwe Broulik
> On March 7, 2014, 3:23 p.m., Frank Reininghaus wrote: > > We have had a complaint from a Dolphin user who uses the Oxygen font some > > time ago because it uses different widths for the digits 0-9, which makes > > the "Date" column in file managers/dialogs rather hard to read: > > > > https:

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-07 Thread Kai Uwe Broulik
> > I can't say much about this issue myself because I'm not familiar with font > > design, but maybe this problem should be taken into account. > > Kai Uwe Broulik wrote: > I cannot find anymore where I read it but iirc version 0.4 of Oxygen > Fonts fixed exactl

Re: Review Request 115409: Workaround battery detection at runtime

2014-03-07 Thread Kai Uwe Broulik
this patch in > for enlightenment as it sort of makes it work. :/ > > > Diffs > - > > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml > c1c0169 > > Diff: https://git.reviewboard.kde.org/r/115409/diff/ > > > Testing > --- > &g

Re: Review Request 115409: Workaround battery detection at runtime

2014-03-10 Thread Kai Uwe Broulik
auses two other regressions: bug 331797, bug 331831. > > > > I re-added the "onDataChanged:" handling and both bugs are gone, but I > > only have a single battery, so I cannot test if bug 324847 is still fixed. > > Kai Uwe Broulik wrote: > Sorry for

Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

2014-03-16 Thread Kai Uwe Broulik
ed in bottom, top, left and right panel and repeatedly typed in characters and removed them again :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

2014-03-16 Thread Kai Uwe Broulik
"I guess they know what they're doing" mode - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/#review53066 --------------

Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

2014-03-17 Thread Kai Uwe Broulik
ed in characters and removed them again :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

2014-03-18 Thread Kai Uwe Broulik
ts/ui/Kickoff.qml bfb1d16 Diff: https://git.reviewboard.kde.org/r/116836/diff/ Testing --- Tested in bottom, top, left and right panel and repeatedly typed in characters and removed them again :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list P

Re: Notifications in Next

2014-03-24 Thread Kai Uwe Broulik
Hi, Concerning the long notifications, I think when KMail lists subject and sender of all (or like 5-10) new mails that's a valid usecase imho. We do not have the possibility to show "x lines" all nowrap and elided to the right (like Android does it with E-Mail notifications [1]) but it's alway

Re: Review Request 115409: Workaround battery detection at runtime

2014-03-26 Thread Kai Uwe Broulik
auses two other regressions: bug 331797, bug 331831. > > > > I re-added the "onDataChanged:" handling and both bugs are gone, but I > > only have a single battery, so I cannot test if bug 324847 is still fixed. > > Kai Uwe Broulik wrote: > Sorry for

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Kai Uwe Broulik
/org.kde.passworddialog/contents/ui/Greeter.qml <https://git.reviewboard.kde.org/r/117276/#comment38234> Imho it should be possible to tell whether it failed due to credentials (wrong password) or the service is unavailable (eg. ldap/network error) - Kai Uwe Broulik On April 1, 2014, 7:

Re: Review Request 117276: Add password checking to screenlocker

2014-04-01 Thread Kai Uwe Broulik
> On April 1, 2014, 8:31 a.m., Kai Uwe Broulik wrote: > > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml, > > line 47 > > <https://git.reviewboard.kde.org/r/117276/diff/1/?file=262163#file262163line47> > > &

Re: Visual design for logout/login/lockscreen

2014-04-07 Thread Kai Uwe Broulik
Hi, What about QtGraphicalEffects ColorOverlay? I've been using it extensively for some time already to colorize white svg icons in my apps as needed. Cheers, Kai Uwe Am 07.04.2014 11:35 schrieb Marco Martin : > > On Monday 07 April 2014, David Edmundson wrote: > > I need to make a login scree

Review Request 117533: Fix batterymonitor popup closing when batter full, AC plugged in, and touching brightness slider

2014-04-13 Thread Kai Uwe Broulik
ontents/ui/batterymonitor.qml e87cf78 Diff: https://git.reviewboard.kde.org/r/117533/diff/ Testing --- Changing brightness does not cause the popup to close and status is still properly updated while the popup is not shown. Thanks, Kai Uwe Broulik ___ Pl

Review Request 117540: Improve powermanagement dataengine

2014-04-13 Thread Kai Uwe Broulik
/powermanagementengine.h 1f1f688 dataengines/powermanagement/powermanagementengine.cpp d0563a7 Diff: https://git.reviewboard.kde.org/r/117540/diff/ Testing --- Compiles. Data shows up properly in plasmaengineexplorer and is updated when the value changes. Thanks, Kai Uwe Broulik

Re: Review Request 117540: Improve powermanagement dataengine

2014-04-13 Thread Kai Uwe Broulik
the value changes. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117542: Improve battery monitor

2014-04-13 Thread Kai Uwe Broulik
terymonitor/contents/ui/PopupDialog.qml 0444199 applets/batterymonitor/contents/ui/batterymonitor.qml 4711c5e Diff: https://git.reviewboard.kde.org/r/117542/diff/ Testing --- Compiles. Information is properly displayed when expanding a battery. Than

Re: Review Request 117533: Fix batterymonitor popup closing when batter full, AC plugged in, and touching brightness slider

2014-04-20 Thread Kai Uwe Broulik
pup is not shown. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117542: Improve battery monitor

2014-04-23 Thread Kai Uwe Broulik
27;t actually *know* the value. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117542/#review56298 --- On April 13, 2

Re: Review Request 117542: Improve battery monitor

2014-04-24 Thread Kai Uwe Broulik
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117542/#review56354 ----------- On April 13, 2014, 1:45 p.m., Kai Uwe Broulik wrote: > > --

Re: Review Request 117542: Improve battery monitor

2014-04-24 Thread Kai Uwe Broulik
> On April 24, 2014, 9:33 a.m., Sebastian Kügler wrote: > > Screenshots? > > > > My main question is: Is this going to fit into the new systemtray? The > > popup is not resizable, so it might push out part of the UI underneath. > > Kai Uwe Broulik wrote: >

Re: Review Request 117542: Improve battery monitor

2014-04-24 Thread Kai Uwe Broulik
> On April 24, 2014, 9:33 a.m., Sebastian Kügler wrote: > > Screenshots? > > > > My main question is: Is this going to fit into the new systemtray? The > > popup is not resizable, so it might push out part of the UI underneath. > > Kai Uwe Broulik wrote: >

Re: Review Request 117542: Improve battery monitor

2014-04-24 Thread Kai Uwe Broulik
> On April 24, 2014, 9:33 a.m., Sebastian Kügler wrote: > > Screenshots? > > > > My main question is: Is this going to fit into the new systemtray? The > > popup is not resizable, so it might push out part of the UI underneath. > > Kai Uwe Broulik wrote: >

Re: Review Request 117542: Improve battery monitor

2014-04-25 Thread Kai Uwe Broulik
> On April 24, 2014, 9:33 a.m., Sebastian Kügler wrote: > > Screenshots? > > > > My main question is: Is this going to fit into the new systemtray? The > > popup is not resizable, so it might push out part of the UI underneath. > > Kai Uwe Broulik wrote: >

Re: RFC: Change Krunner's default key shortcut for Next

2014-05-08 Thread Kai Uwe Broulik
> I changed it to Win+R over ten years ago and never looked back. :) Ha! I knew I'm not the only one ;) > In the same style, Win+D can be used to show either virtual desktop grip (my > preference) I use Meta+D for showing the dashboard since I don't use virtual desktops. > Win+S (Search) would

Re: Review Request 118063: New Formats KCM

2014-05-09 Thread Kai Uwe Broulik
tps://git.reviewboard.kde.org/r/118063/#comment40097> Missing colon - Kai Uwe Broulik On May 9, 2014, 4:05 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Ship with Aurorae and Qtcurve or not...

2014-05-15 Thread Kai Uwe Broulik
Am 15.05.2014 12:10 schrieb =?UTF-8?B?SXZhbiDEjHVracSH?= : > > A bit off: > What do people think about adding an evil dialogue on startup, similar to > what > e17 had - to warn the users about the state of the software and its use in > production environment? Don't we have a plasmoid already

Re: Notification bloat (4.xx)

2014-05-23 Thread Kai Uwe Broulik
> In Plasma Next, the notifications stack/history now contains only and only > persistent notifications, all the rest just flies by and disappears forever > after the timeout. Hi, I think I already brought this up somewhere but do the notification watch for user interaction? Would be great if

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Kai Uwe Broulik
-workspace. I didn't push it forward that much as I also migrated it to the Solid PM import which is not yet ready and we're already past Beta. - Kai Uwe Broulik On May 22, 2014, 10:36 p.m., Sebastian Kügler wrote: > >

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Kai Uwe Broulik
. Any improvement to the battery monitor is welcome. Sorry for being a lazy maintainer :/ - Kai Uwe Broulik On May 23, 2014, 2:05 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

2014-05-27 Thread Kai Uwe Broulik
org/r/118361/#comment40793> Isn't comparison more efficient using QLatin1String? - Kai Uwe Broulik On May 27, 2014, 7:13 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To r

Re: [RFC] Which icon to use for kwin's killer helper

2014-05-28 Thread Kai Uwe Broulik
Hi, That bomb icon imho doesn't look very well in the titlebar and the app icon indeed is confusing. What about dialog-warning to emphasis even more that it will cause your changes do be lost? It's already in the dialog itself, however, but will make the window stick out in the taskbar. Cheers

Re: Review Request 118390: Powerdevil KCM Updates

2014-05-29 Thread Kai Uwe Broulik
g/r/118390/#comment40848> That should be come dpi independent - Kai Uwe Broulik On May 28, 2014, 11:33 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 118272: batterymonitor visual cleanups

2014-06-02 Thread Kai Uwe Broulik
lider lengths: Bug 335540 - Kai Uwe Broulik On May 23, 2014, 7:21 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Review Request 118558: Fix Plasma build with Review 117339

2014-06-05 Thread Kai Uwe Broulik
management/powermanagementengine.h 9429ade dataengines/powermanagement/powermanagementengine.cpp 1b1cb5e dataengines/soliddevice/soliddeviceengine.cpp 97d7c8d Diff: https://git.reviewboard.kde.org/r/118558/diff/ Testing --- Builds Thanks, Kai U

Re: Review Request 118558: Fix Plasma build with Review 117339

2014-06-05 Thread Kai Uwe Broulik
18558/diff/ Testing --- Builds Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118644: Update battery monitor popup to use new icons

2014-06-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118644/#review59718 --- Ship it! Thank you very much! - Kai Uwe Broulik On June

Review Request 118753: Handle mouse wheel in PlasmaComponents.Slider

2014-06-14 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/118753/diff/ Testing --- Tested in a horizontal slider with both mouse and touchpad scrolling with either vertical or (by holding Alt) horizontal scrolling Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list P

Review Request 118769: Use RotationAnimator in BusyIndicator

2014-06-15 Thread Kai Uwe Broulik
s, such as LIBGL_ALWAYS_SOFTWARE=1 or QML_FORCE_THREADED_RENDERER=1. Results varied but generally indicated a CPU relief. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118769: Use RotationAnimator in BusyIndicator

2014-06-15 Thread Kai Uwe Broulik
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118769/#review60134 --- On June 15, 2014, 7:19 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated

Re: Review Request 118769: Use RotationAnimator in BusyIndicator

2014-06-15 Thread Kai Uwe Broulik
requested a view from JobViewServer, ran top. Tried with different configurations, such as LIBGL_ALWAYS_SOFTWARE=1 or QML_FORCE_THREADED_RENDERER=1. Results varied but generally indicated a CPU relief. Thanks, Kai Uwe Broulik ___ Plasma-devel ma

Re: Review Request 118753: Handle mouse wheel in PlasmaComponents.Slider

2014-06-16 Thread Kai Uwe Broulik
er x values) Diffs - src/declarativeimports/plasmacomponents/qml/Slider.qml 142040a Diff: https://git.reviewboard.kde.org/r/118753/diff/ Testing --- Tested in a horizontal slider with both mouse and touchpad scrolling with either vertical or (by holding Alt) horizontal scrolling Thank

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
> On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: > > I really like the idea. I think we should keep our Scroll* components in to > > ease porting, but move away from using it for our own stuff first, and > > then, before a first API promise, revisit if we can remove our own > > implementa

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
icular, ScrollBar.qml was public api, so shouldn't be > removed, even if not used by this component in partibular. > > apart from that is good to go. > > Kai Uwe Broulik wrote: > Any news on this? Plasma-NM has recently switched over to a QtQuick > Controls S

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
icular, ScrollBar.qml was public api, so shouldn't be > removed, even if not used by this component in partibular. > > apart from that is good to go. > > Kai Uwe Broulik wrote: > Any news on this? Plasma-NM has recently switched over to a QtQuick > Controls S

Re: Review Request 117540: Improve powermanagement dataengine

2014-06-19 Thread Kai Uwe Broulik
updated when the value changes. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117542: Improve battery monitor

2014-06-19 Thread Kai Uwe Broulik
s properly displayed when expanding a battery. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
> On June 19, 2014, 8:42 p.m., David Edmundson wrote: > > Note: The property names don't line up 100% in the merge. > > > > flickableItem has now become contentItem (which is a default property) > > > > All instances in plasma-workspace/plasma-desktop are now updated. That doesn't matter: "fli

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
> On June 19, 2014, 8:42 p.m., David Edmundson wrote: > > Note: The property names don't line up 100% in the merge. > > > > flickableItem has now become contentItem (which is a default property) > > > > All instances in plasma-workspace/plasma-desktop

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Kai Uwe Broulik
Can't we just use QtGraphicalEffects and just blur (and/or desaturate and/or darken) whatever picture the user has chosen? The overall performance of these is great (at least on Android which is slow in any other QtQuick respect) but their instantiation takes ages, so might not be suitable for

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Kai Uwe Broulik
tps://git.reviewboard.kde.org/r/125810/#comment60018> Why not "not specified = everywhere"? - Kai Uwe Broulik On Okt. 26, 2015, 4:26 nachm., Marco Martin wrote: > > --- > This is an automatically generated e-mail.

Review Request 125820: [Desktop Toolbox] Keep hovered state while menu is open

2015-10-26 Thread Kai Uwe Broulik
n.qml 9b3e84d Diff: https://git.reviewboard.kde.org/r/125820/diff/ Testing --- File Attachments Glow while menu open https://git.reviewboard.kde.org/media/uploaded/files/2015/10/26/fbc04712-6b62-4de6-af7b-18a1fad2ceff__toolboxhover.png Thanks, Kai Uwe Br

Review Request 125821: [Kickerdash] Close when opening applet settings

2015-10-26 Thread Kai Uwe Broulik
Right clicked, "App dash settings", closed, settings dialog appeared. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125820: [Desktop Toolbox] Keep hovered state while menu is open

2015-10-26 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma and Andrew Lake. Changes --- Submitted with commit 45481bb57184fcd4b28adf9f741093ecbc281786 by Kai Uwe Broulik to branch Plasma/5.4. Repository: plasma-desktop Description --- Before the toolbox button would stop glowing as soon as

Review Request 125822: [Kickoff] Support mouse back button in ApplicationsView

2015-10-26 Thread Kai Uwe Broulik
sed back buton, ended up in "Games", pressed back again, ended up in the applications overview Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125822: [Kickoff] Support mouse back button in ApplicationsView

2015-10-26 Thread Kai Uwe Broulik
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125822/#review87476 --- On Okt. 26, 2015, 10:41 nachm., Kai Uwe Broulik wrote: > > ---

Re: Review Request 125822: [Kickoff] Support mouse back button in ApplicationsView

2015-10-26 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 23919d4f0552a4c7b361cbcf768c6d65d2174e8d by Kai Uwe Broulik to branch Plasma/5.4. Repository: plasma-desktop Description --- Clicking the back mouse button while hovering the applications list will

Re: Review Request 125817: Add plugin system for Calendar events

2015-10-27 Thread Kai Uwe Broulik
the Q_ENUMS macro (Q_ENUM if Qt >= 5.5) for QML to know this enum src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h (line 154) <https://git.reviewboard.kde.org/r/125817/#comment60105> QML understands QColor - Kai Uwe Broulik On Okt. 27, 20

Re: Review Request 125821: [Kickerdash] Close when opening applet settings

2015-10-27 Thread Kai Uwe Broulik
ts/ui/DashboardRepresentation.qml 17d2deb Diff: https://git.reviewboard.kde.org/r/125821/diff/ Testing --- Right clicked, "App dash settings", closed, settings dialog appeared. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 125817: Add plugin system for Calendar events

2015-10-27 Thread Kai Uwe Broulik
something else, this change has *not* been submitted yet. - Kai Uwe Broulik On Okt. 27, 2015, 9:10 nachm., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Review Request 125848: [kscreenlocker_greet] Fix QML fallback

2015-10-28 Thread Kai Uwe Broulik
/screenlocker/greeter/greeterapp.cpp a88b61a Diff: https://git.reviewboard.kde.org/r/125848/diff/ Testing --- Broke my lock screen. Got the fallback. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request 125849: [kscreenlocker_greet] Port fallback theme to SessionsModel

2015-10-28 Thread Kai Uwe Broulik
/fallbacktheme/SessionSwitching.qml b429bb3 Diff: https://git.reviewboard.kde.org/r/125849/diff/ Testing --- Switching sessions and creating new ones works Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 125849: [kscreenlocker_greet] Port fallback theme to SessionsModel

2015-10-28 Thread Kai Uwe Broulik
ksmserver/screenlocker/greeter/fallbacktheme/SessionSwitching.qml b429bb3 Diff: https://git.reviewboard.kde.org/r/125849/diff/ Testing --- Switching sessions and creating new ones works Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list

Review Request 125851: [kscreenlocker] Remove KWorkspace dependency

2015-10-28 Thread Kai Uwe Broulik
: https://git.reviewboard.kde.org/r/125851/diff/ Testing --- Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125870: Update drkonqui hints for relevant information

2015-10-29 Thread Kai Uwe Broulik
tps://git.reviewboard.kde.org/r/125870/#comment60165> There's no dashboard anymore drkonqi/applicationdetailsexamples.cpp (line 36) <https://git.reviewboard.kde.org/r/125870/#comment60166> you forgot parenthesis after "kwin_x11" - Kai Uwe Broulik On Okt. 2

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

2015-10-30 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma and Martin Gräßlin. Changes --- Submitted with commit 667ed80cbe9866c87f238cd1a54516820fb8da83 by Bhushan Shah on behalf of Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- This way it can be used in the

Re: Review Request 125774: [Lock Screen] Use org.kde.plasma.private.sessions for User Switcher

2015-10-30 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma and Martin Gräßlin. Changes --- Submitted with commit 987f4f76030d1dce5729285df3eb595d50951b04 by Bhushan Shah on behalf of Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- This migrates the Lock Screen

Re: Review Request 125678: Introduce User Switcher plasmoid

2015-10-31 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit 01824730acc49aea50bc0d0da1eb17b270125458 by Kai Uwe Broulik to branch master. Repository: kdeplasma-addons Description --- It is prety common in other desktop environments to have

Re: Review Request 125849: [kscreenlocker_greet] Port fallback theme to SessionsModel

2015-10-31 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma and Martin Gräßlin. Changes --- Submitted with commit 0ff4006610f960b21cd81d6361ffc27ac0c5708d by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- Required for removing the sessions stuff and thus the

Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

2015-10-31 Thread Kai Uwe Broulik
--- Some engines (eg. mpris) have invalid plugininfo causing plasmaengineexplorer to crash Diffs - engineexplorer/engineexplorer.cpp 31525ee Diff: https://git.reviewboard.kde.org/r/125895/diff/ Testing --- Doesn't crash anymore Thanks, Kai Uwe Br

Re: Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

2015-10-31 Thread Kai Uwe Broulik
: https://git.reviewboard.kde.org/r/125895/diff/ Testing --- Doesn't crash anymore Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

2015-10-31 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma. Changes --- Submitted with commit e3ed62cf9f44fb16adb7bfe8e347472757e2ae18 by Kai Uwe Broulik to branch Plasma/5.4. Repository: plasma-sdk Description --- Some engines (eg. mpris) have invalid plugininfo causing plasmaengineexplorer

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

2015-10-31 Thread Kai Uwe Broulik
like, though, is the entire header area being scrollable rather than the width-changing label. Also please make sure it doesn't break the MultiPointTouchArea. - Kai Uwe Broulik On Okt. 31, 2015, 2:59 nachm., David Rosca wrote: > > -

Re: Review Request 125893: calendar: Fix updating decade overview

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125893/#review87778 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 31, 2015, 2

Re: Review Request 125894: calendar: Don't use current day number in goToMonth

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125894/#review87779 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 31, 2015, 2

Review Request 125896: [desktopcontainment] Clip applet container while resizing it

2015-10-31 Thread Kai Uwe Broulik
/125896/diff/ Testing --- No more applet content outside when resizing like a normal person. You can briefly see contents reappearing when resizing the widget small and then immediately, before it loaded the compact rep, releasing the mouse, but whatever. Thanks, Kai Uwe Broulik

Review Request 125897: [Clipboard plasmoid] Fix line breaks

2015-10-31 Thread Kai Uwe Broulik
//git.reviewboard.kde.org/media/uploaded/files/2015/10/31/24d3504f-856d-4548-b01a-4cf86b2cd348__klipperlinebreaks2.png Without (currently) https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/d052169b-0026-4efa-b781-68b39cc20bf0__klipperlinebreaks1.png

Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-10-31 Thread Kai Uwe Broulik
/r/125898/diff/ Testing --- Works File Attachments Hovered item https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png Thanks, Kai Uwe Broulik

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-10-31 Thread Kai Uwe Broulik
/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

2015-10-31 Thread Kai Uwe Broulik
> On Okt. 31, 2015, 3:39 nachm., Kai Uwe Broulik wrote: > > I'm not sure, perhaps add Usability. > > One thing I would like, though, is the entire header area being scrollable > > rather than the width-changing label. > > Also please make sure it doesn

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-10-31 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125899: calendar: Make the entire header area clickable

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125899/#review87788 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 31, 2015, 8

Re: Review Request 125896: [desktopcontainment] Clip applet container while resizing it

2015-11-01 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma. Changes --- Submitted with commit ec990f55ea6f00fc9772591f4365bc27765ad809 by Kai Uwe Broulik to branch Plasma/5.4. Repository: plasma-desktop Description --- When dragging the applet it takes a while for it to collapse sometimes

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread Kai Uwe Broulik
eel scrolling That should work with PlasmaExtras.ScrollArea, if you can only scroll horizontally. - Kai Uwe Broulik On Nov. 1, 2015, 10:53 vorm., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-11-01 Thread Kai Uwe Broulik
--- Works File Attachments Hovered item https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread Kai Uwe Broulik
tents/ui/ToolTipDelegate.qml (line 50) <https://git.reviewboard.kde.org/r/125908/#comment60249> The ScrollArea clips its viewport on its own - Kai Uwe Broulik On Nov. 1, 2015, 2:06 nachm., David Rosca wrote: > > --- > This is an au

Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out

2015-11-01 Thread Kai Uwe Broulik
label is properly hidden, launchers work fine, too. But there are probably many other usecases and scenarios I didn't know/test. Also fixes task manager label with QT_DEVICE_PIXELRATIO > 1 (if we were to enable that) Thanks, Kai Uwe Broulik __

Re: Review Request 125848: [kscreenlocker_greet] Fix QML fallback

2015-11-01 Thread Kai Uwe Broulik
marked as submitted. Review request for Plasma and Martin Gräßlin. Changes --- Submitted with commit 5ce2e2b707db361a5e2377341167221dab3be190 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- With the change to the QQuickSharedEngine, it seems to load

Re: Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out

2015-11-01 Thread Kai Uwe Broulik
it again >on every render pass" rather than "never update it again". - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125913/#review87806 -----

Re: Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out

2015-11-01 Thread Kai Uwe Broulik
enable that) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125916: [kcm icons] Take into account device pixel ratio for icon preview

2015-11-01 Thread Kai Uwe Broulik
96px icon size. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: minutes monday plasma hangout

2015-11-02 Thread Kai Uwe Broulik
Hi, - merged new session model and user switcher plasmoid, migrated lock screen to it (thanks Bhushan for merging) - not sure if new user switcher makes it for 5 Nov - various bug fixes (back mouse button support in Kickoff, changing applet visibility in systray) I also fixed notification popup

Review Request 125926: [Image Wallpaper] Take into account orientation

2015-11-02 Thread Kai Uwe Broulik
--- Placed a 1440x2560 picture in my image package, it used to get picked and stretched, not it properly takes the 2560x1440 image consistently, or if not present, fall back to a different resolution image. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing

Re: Review Request 125926: [Image Wallpaper] Take into account orientation

2015-11-02 Thread Kai Uwe Broulik
as a last resort if it actually is a vertical photograph... - Kai Uwe Broulik On Nov. 2, 2015, 9:27 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

<    1   2   3   4   5   6   7   8   9   10   >