Port system tray away from SNI dataengine

(including images).Is it OK to put it in SystemTrayModel or should I create a singleton/plugin? Is there any example (similar migration) that I can check? -- Regards, Konrad Materka

Re: A lot of "Timers cannot be started from another thread" warnings

Nevermind... https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/178 sob., 26 gru 2020 o 11:51 Konrad Materka napisał(a): > Hi, > > In latest version compiled from sources, I have a lot of warnings like > these: > QObject::startTimer: Timers cannot be started from

A lot of "Timers cannot be started from another thread" warnings

. Is this only me? -- Regards: Konrad Materka

Re: Fix 'Connections' warnings in QML

x them in Plasma. Most of the ones we still have though > are in frameworks that still depend on Qt 5.12 and it's not trivial to > address this problem over there. > > Aleix > > On Mon, Nov 9, 2020 at 10:25 AM Konrad Materka wrote: > > > > Hi, > > > > Wit

Fix 'Connections' warnings in QML

that one by one (I mean one applet/module at a time)? -- Regards: Konrad Materka

D26992: [SystemTray] Use unified data model everywhere

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > kossebau wrote in systemtray.h:100 > Thanks for your reply. Okay, so seems you did not hit anything related. > > Thing is, you added > `` > Q_INVOKABLE Plasma::Service *serviceForSource(const QString );

D26992: [SystemTray] Use unified data model everywhere

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > kossebau wrote in systemtray.h:100 > Hi. Seeing this code, I have a question: from what I understood so far, for > this method to be useable from the JavaScript inside QML, the type > "Plasma::Service

D29395: Refactor MediaController

kmaterka added a comment. Any update on this? I really like the idea. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: kmaterka, iasensio, broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

Remove stale branches?

Hi, After GitLab migration it is very easy to fork repository, so that branches can live in forks. Should we remove all personal branches from main repository? Or at least stale ones? -- Regards, Konrad Materka

Re: GitLab - merging fixes from release branch into master

niedz., 24 maj 2020 o 20:17 Nate Graham wrote: > Land it on Plasma/5.19, then manually merge Plasma/5.19 into master, > same as before. OK, thank you for confirmation. -- Regards: Konrad Materka

GitLab - merging fixes from release branch into master

was not able to find any information. -- Regards, Konrad Materka

D29827: Give users the ability to disable the microphone indicator

kmaterka added a comment. In D29827#673720 , @ngraham wrote: > In D29827#673615 , @meven wrote: > > > In D29827#673611 , @davidedmundson wrote: > > > >

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

This revision was automatically updated to reflect the committed changes. Closed by commit R120:00e64bdb3fa9: [applets/systemtray] Show base icon when AttentionIcon not set (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

kmaterka added a comment. Can we have it reviewed before 5.19 release? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29544 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

kmaterka added a comment. Firstly, AttentionIcon support was introduced in D24865 . It had a bug, fixed for 5.18 in D29386 . When I merged branch 5.18 (with D29386 ) into master, by

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY If status is set to NeedsAttention it

D29529: Use INTERFACE IMPORTED target type instead of ALIAS for compatibility targets

kmaterka accepted this revision. kmaterka added a comment. plasma-workspace compiles using cmake 3.10 without issues now. REPOSITORY R111 KSysguard Library BRANCH ancient_cmake_fix REVISION DETAIL https://phabricator.kde.org/D29529 To: ahiemstra, #plasma, ngraham, kmaterka Cc:

D29302: Use KSysGuard namespace for KSysGuard library targets

kmaterka added a comment. In D29302#666138 , @ahiemstra wrote: > Which version of CMake are you using? I needed to promote the imported KSysGuard targets to "global" using set_target_property. Without that, I saw similar errors. The

D29302: Use KSysGuard namespace for KSysGuard library targets

kmaterka added a comment. With this change, plasma-workspace fails to build on my system (Neon User, kdesrc-build) Error message: CMake Warning at /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:27 (message): The KF5:: namespace for

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. @davidre can you extract your test improvement to a separate patch? it would help me in another issue and I don't want to "steal" your code :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28208 To: davidre, kmaterka, broulik,

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b34e88da7a5d: [applets/systemtray] Hide/show expander arrow - regression fix (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka updated this revision to Diff 82205. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28180?vs=78148=82205 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28180 AFFECTED FILES

D29386: [systemtray] Fix SNI icon not rendering

kmaterka added a comment. In D29386#663325 , @ngraham wrote: > Great thanks! Don't forget to merge `Plasma/5.18` into master, fixing the merge conflicts. Merged. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29386: [systemtray] Fix SNI icon not rendering

This revision was automatically updated to reflect the committed changes. Closed by commit R120:77975468dc10: [systemtray] Fix SNI icon not rendering (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29386?vs=81903=81925

D29386: [systemtray] Fix SNI icon not rendering

kmaterka updated this revision to Diff 81903. kmaterka added a comment. Additional check for real JavaScript null - to avoid conversion errors in native method. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29386?vs=81803=81903 BRANCH

D29386: [systemtray] Fix SNI icon not rendering

kmaterka added a comment. In D29386#662960 , @ngraham wrote: > Great catch. The logic seems sane to me. Note that if you plan to land this on the stable branch, there will be merge conflicts that you'll need to resolve carefully, since it looks

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added a comment. Separate Bug 420993 created for Media Player icon not rendering correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29344 To: kmaterka, #plasma_workspaces, #plasma, ngraham,

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

This revision was automatically updated to reflect the committed changes. Closed by commit R120:026a29174279: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka updated this revision to Diff 81842. kmaterka added a comment. Change warning message REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29344?vs=81724=81842 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29344 AFFECTED

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added a comment. In D29344#662586 , @ngraham wrote: > 5.19 hasn't branched yet, so code landed in master will still make it there. Maybe there was code freeze for frameworks? Or 5.18.5? Never mind :) > With this patch, I

D29386: [systemtray] Fix SNI icon not rendering

kmaterka added a comment. This patch is for "Plasma/5.18" branch only. Can we have it merged before 5.18.5? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29386 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: plasma-devel,

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

This revision was automatically updated to reflect the committed changes. Closed by commit R120:efe4b603e92f: [applets/systemtray] Fix value read in some onXyxChanged connections (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29386: [systemtray] Fix SNI icon not rendering

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY In some rare situations SNI icons are

D29380: [System Tray] Always draw the highlight behind the icon

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. OK, accepted REPOSITORY R120 Plasma Workspace BRANCH draw-behind-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D29380 To: filipf, kmaterka, #plasma

D29380: [System Tray] Always draw the highlight behind the icon

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. The same treatment is needed in `HiddenItemsView` to. Just move `z: -1` to `CurrentItemHighLight` component so that your fix will cover both cases. REPOSITORY R120 Plasma

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

kmaterka added a comment. Fix exctracted from D29344 , to make things clear - one commit, one change. INLINE COMMENTS > main.qml:81 > target: plasmoid > -function onUserConfiguringChanged(userConfiguring) { > -if

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Some `onXyzChanged` signals do not send value - fix

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka updated this revision to Diff 81724. kmaterka added a comment. Extract unrelated fix to seprate patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29344?vs=81698=81724 BRANCH master REVISION DETAIL

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added inline comments. INLINE COMMENTS > apol wrote in main.qml:92 > Why's this needed? This is needed to fix different bug. I will create a separate patch for this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29344 To: kmaterka,

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added a comment. This fix should go with Plasma 5.19, if it is not too late (code freeze). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29344 To: kmaterka, #plasma_workspaces, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n,

D29344: [applets/systemtray] Fix ivisible plasmoid icons when new plasmoid added

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY After adding a new plasmoid (applet), for example a new Media

D29130: [Applet] Show in system tray iff at least one vault is open

kmaterka added a comment. IMO it is the best **not** to add new status in System Tray - it is already quite confusing with "Disabled" state, the 3 other (Always hidden, Shown when relevant and Always shown) are OK and self-explanatory. "Shown when relevant" might be tricky and we will

D28631: Remove Icons from system tray item tooltips

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. In D28631#643325 , @ngraham wrote: > Remove no-longer-relevant reference to icon in `AbstractItem.qml` Thanks, accepted.

D28631: Remove Icons from system tray item tooltips

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. In D28631#643116 , @davidre wrote: > I would argue that the implementation is free to ignore it > `Data structure that

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. I looked at the `IconItem` implementation. Before add theme directory support I would like to perform some refactoring - D28470 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28208 To:

D28631: Remove Icons from system tray item tooltips

kmaterka added a comment. For SNI, maybe we should consider showing an icon, but only if it is explicitly set? It is part of the specification after all. From the other side it will be inconsistent...

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. In D28208#638846 , @davidre wrote: > Yes it's not pretty but I had no other Idea. One option would be trying to manually search for the icon in the path? Not a good idea, theme path only point to root of more

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. The best would be to add theme path support to `PlasmaCore.IconItem`. I will take a look at this tomorrow. INLINE COMMENTS > davidre wrote in systemtraymodel.cpp:331 > This works now, but I don't know how to manage the KIconLoader. The > KIconEngines are managed

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. In D28208#634593 , @davidre wrote: > Do you know if `IconThemePath` is specified somewhere? Initial commit: https://github.com/KDE/kde-workspace/commit/4c553dbf39f4189290387bba35589200ca051084 Someone

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. In D28208#634593 , @davidre wrote: > Do you know if `IconThemePath` is specified somewhere? Initial commit: What I could observe is that some apps create a folder hierachy under this path and palce their

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. > Some of the icons are not rendering now, for example: > Discord - iconName: chrome_app_indicator2_83406baa15c6e4f2766a6e3714fbee20 > Skype1 - iconName: chrome_app_indicator2_01cdeaaa54803d9c9c158a5cdcb1fbfb > I'm pretty sure I saw a workaround for that

D28259: [applets/systemtray] Default value for ItemLoader.source

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5b99315f75f9: [applets/systemtray] Default value for ItemLoader.source (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. Two problems: After running `plasmashell --replace &` I have these messages in the console output: > file:///home/konrad/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/items/StatusNotifierItem.qml:57:5: QML IconItem: Cannot

D28259: [applets/systemtray] Default value for ItemLoader.source

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. Herald added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY When none of the valid conditions are met, function should return default value for ItemLoader source. If not,

D28109: [applets/systemtray] Simplify icon size logic

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a9d941b38e05: [applets/systemtray] Simplify icon size logic (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28109?vs=78185=78386

D28208: Move sni icon handling logic from data engine to applet

kmaterka added inline comments. INLINE COMMENTS > davidre wrote in StatusNotifierItem.qml:90 > Hmm to me it looks it doesn't even have an margin. Or am I reading ` > p.drawPixmap(QRect(m_iconPixmap.width()-size, m_iconPixmap.height()-size, > size, size), overlay->pixmap(size, size),

D28208: Move sni icon handling logic from data engine to applet

kmaterka added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:58 > } > +// IconItem.overlays only supports names so we need a second item for > the overlay, using the same > +// positioning that KIconLoader::drawOverlays uses that IconItem uses > internally Should

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka added a comment. In D28180#632058 , @ngraham wrote: > This works, but I wonder if there's a conceptually cleaner way to do it. Not that I know of one, so I'll wait for a #plasma person to

D28183: [kioslave/desktop] Attempt at making test more robust

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. In D28183#632057 , @davidedmundson wrote: > That won't work as is because I would need to re-run > > const KFileItem fileItem =

D28109: [applets/systemtray] Simplify icon size logic

kmaterka updated this revision to Diff 78185. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28109?vs=78184=78185 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28109 AFFECTED FILES

D28109: [applets/systemtray] Simplify icon size logic

kmaterka updated this revision to Diff 78184. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28109?vs=77865=78184 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28109 AFFECTED FILES

D28185: [applet/systemtray] Use model binding instead of copy

This revision was automatically updated to reflect the committed changes. Closed by commit R120:17153c4ae204: [applet/systemtray] Use model binding instead of copy (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28185: [applet/systemtray] Use model binding instead of copy

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > broulik wrote in AbstractItem.qml:36 > You can simplify this to > > model.status || PlasmaCore.Types.UnknownStatus Done REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28185: [applet/systemtray] Use model binding instead of copy

kmaterka updated this revision to Diff 78181. kmaterka added a comment. Simplify JS REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28185?vs=78178=78181 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28185 AFFECTED FILES

D28185: [applet/systemtray] Us model binding instead of copy

kmaterka added a comment. In D28185#631972 , @apol wrote: > I'm not convinced this is all that better. Without this `effectiveStatus` never changes. Right now it works by happy coincidence - Item is simple destroyed and created in a

D28185: [applet/systemtray] Us model binding instead of copy

kmaterka updated this revision to Diff 78178. kmaterka added a comment. Bind model as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28185?vs=78169=78178 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28185 AFFECTED FILES

D28183: [kioslave/desktop] Attempt at making test more robust

kmaterka added a comment. In D28183#631966 , @davidedmundson wrote: > The failure was always on this line: > > > QCOMPARE(fileItem.targetUrl(), QUrl::fromLocalFile(destFilePath)); Oh, I see. So maybe this:

D28183: [kioslave/desktop] Attempt at making test more robust

kmaterka added a comment. In theory `QTRY_VERIFY` should wait up to 5 seconds until condition is met. `qWait(250)` shouldn't change much... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma Cc: kmaterka, plasma-devel, Orage,

D28185: [applet/systemtray] Us model binding instead of copy

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY The `effectiveStatus` parameter was passed as a copy, use proper binding. TEST

D28107: Fix overlayIcon sometimes not visible

kmaterka added a comment. In D28107#630144 , @davidre wrote: > It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time IMO, ideally `StatusNotifierItemSource` should

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka added inline comments. INLINE COMMENTS > ExpanderArrow.qml:31 > implicitHeight: implicitWidth > -visible: root.hiddenLayout.contentItem.children.length > 0 > +visible: root.hiddenLayout.itemCount > 0 > ideally `root.hiddenLayout.count` should be used, but `count` is not

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson. kmaterka added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Expander arrow should hide when all

D28109: [applets/systemtray] Simplify icon size logic

kmaterka added a comment. In D28109#629974 , @ngraham wrote: > This looks like a sensible refactor to me, and it solves the issue that I was having with icon size changing based on the expanded popup visibility. I can't detect any regressions

D28107: Fix overlayIcon sometimes not visible

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. Yep, icons in SNI are a mess... Icons are processed in `StatusNotifierItemSource`, including overlay - that's were this should be fixed. From you comment I see it won't be

D28096: Don't overwrite status

kmaterka added a comment. > Oh you're right. It was not wokring for me on 5.18 so I changed this and it worked. But matter of fact it worked on master all allong :) 5.18 is not using this data model, in 5.18 it is used only in configuration page. In 5.19 this model is everywhere.

D28096: Don't overwrite status

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. > The qml checks the value against the enum but updateItemData inserts the string. These are two different roles: "status" with enum value "Status" from SNI data

D28109: [applets/systemtray] Simplify icon size logic

kmaterka added inline comments. INLINE COMMENTS > ExpanderArrow.qml:31 > implicitHeight: implicitWidth > -visible: root.hiddenLayout.contentItem.children.length > 0 > +visible: root.hiddenLayout.count > 0 > This fixes issue (regression) with expander arrow not hiding when all

D28109: [applets/systemtray] Simplify icon size logic

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY This change simplifies icon size logic - now it is controled only in one place: AbstractItem.

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

kmaterka added inline comments. INLINE COMMENTS > cblack wrote in ExpandedRepresentation.qml:261 > This advice doesn't seem to be applicable here, as the `implicitWidth` of the > ColumnLayout child isn't able to be mutated due to the fact that all of its > child items (text) have fixed

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka added a comment. In D27958#627658 , @ngraham wrote: > After a few days of living with it, I've found that this patch causes the following issue with semi-random tray items getting smaller when a pop-up is opened: > > F8176616:

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

kmaterka added inline comments. INLINE COMMENTS > kmaterka wrote in ExpandedRepresentation.qml:261 > My last comment was not precise. Just check this > for all details :) As a general rule, you shouldn't refer to parents width in Layouts, including:

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

kmaterka added inline comments. INLINE COMMENTS > kmaterka wrote in ExpandedRepresentation.qml:261 > I have not seen your code yet, I will check tomorrow. Probably because you > have something like this: > > Layout.preferredWidth: parent.width / 2 > Layout.preferredHeight: parent.height /

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

kmaterka added inline comments. INLINE COMMENTS > cblack wrote in ExpandedRepresentation.qml:261 > I can't seem to reproduce a binding loop here. I have not seen your code yet, I will check tomorrow. Probably because you have something like this: Layout.preferredWidth: parent.width / 2

D27958: [SystemTray] Fix item size for very narrow panel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:85f646eb5649: [SystemTray] Fix item size for very narrow panel (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27958?vs=77321=77370

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka added a comment. In D27958#625431 , @broulik wrote: > Not sure if it is just me but the vertical alignment looks slightly off > F8169131: Screenshot_20200310_172654.PNG > Or maybe that's the

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. Fix for narrow panel in D27958 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage,

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka added a comment. I don't like how icon size and item size (container = icon + padding) are calculated and used... Firstly best icons size is calculated, but then padding are added. This combined size is used as item size (container size): - SNI icons are rounded to nearest icon

D27958: [SystemTray] Fix item size for very narrow panel

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY For very narrow panel item size is too big (item + paddings exceed panel size). This adds a

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. In D27466#624574 , @broulik wrote: > > I believe that D26992 , moves the icons down. > > It looks like with that patch the icon sizes differ between plasmoids and SNIs

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. In D27466#624447 , @broulik wrote: > This causes layouting issues in narrow panels: > F8167100: Screenshot_20200309_085328.PNG > The icons are also too far apart For

D26992: [SystemTray] Use unified data model everywhere

This revision was automatically updated to reflect the committed changes. kmaterka marked an inline comment as done. Closed by commit R120:39975673cb6a: [SystemTray] Use unified data model everywhere (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26992: [SystemTray] Use unified data model everywhere

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in AbstractItem.qml:34 > Lets look at fixing in a follow up patch > > QML can do enums now OK, I will change that in a separate patch REPOSITORY R120 Plasma Workspace BRANCH

Re: Plasma Sprint 2020 in Augsburg, Germany

Hi, What is the chance of this event being cancelled due to coronavirus? I have to book tickets on advance, unfortunately flight is the most reasonable. -- Regards, Konrad Materka

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

kmaterka added a comment. Should System Tray icons be larger then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: kmaterka, gvgeo, davidedmundson, ndavis, KonqiDragon, niccolove, The-Feren-OS-Dev, plasma-devel, Orage,

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. In D27466#620470 , @gvgeo wrote: > IMO this is the wrong way to do these changes. > > 1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. In D26992#614426 , @ngraham wrote: > UI looks good except for one thing: the changes to show a highlight effect on hover in the popup are unrelated and should be done in a separate patch (preferably in coordination

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 76028. kmaterka added a comment. Second (and last) change extracted from this one is in master. Rebased, ready for review. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=75134=76028 BRANCH master

D27088: [applets/SystemTray] Implement sorting in the model

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d86c690d133: [applets/SystemTray] Implement sorting in the model (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27088: [applets/SystemTray] Implement sorting in the model

kmaterka updated this revision to Diff 76026. kmaterka added a comment. Review fixes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27088?vs=75112=76026 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27088 AFFECTED FILES

D27088: [applets/SystemTray] Implement sorting in the model

kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in sortedsystemtraymodel.cpp:47 > I think calling QSortFilterProxyModel::lessThan(left, right); would do the > same > > then you don't need compareDisplayAlphabetically > > your implementation looks fine though, so do

  1   2   3   4   >