D25428: Improved support for desktop "Folder View"

ngraham added a comment. Awesome! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fba

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

ngraham added a comment. Yes, my own children make use of the "Show password" button on our family Windows 10 machine (Which I plan to put KDE Neon on soon) and I can confirm your exact use case and how this regresses it. Could you please file a bug report on `plasmashell | Theme - Breez

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

ngraham added a comment. And please mention the URL for this change, for reference purposes. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9040 To: davidedmundson, broulik Cc: boldewyn, kigwana, graesslin, ngraham, broulik, plasma-devel, Orage, LeGast0

D13988: Use subseq matching for service runner

ngraham added a comment. Still applies cleanly and seems to fix the bug. Landing. REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham Cc: meven, justinzo

D13988: Use subseq matching for service runner

ngraham closed this revision. ngraham added a comment. Manually merged because `arc land` doesn't seem to want to work anymore. You can see it at //invent.kde.org/plasma/plasma-workspace/commit/9f2abd0a54d51d9234a5a9489d1342b261429fa3. Thanks Michael! REPOSITORY R120 Plasma Workspace

T13927: Pop shell in KDE Plasma

ngraham added a comment. What is "pop shell"? TASK DETAIL https://phabricator.kde.org/T13927 To: plasma-devel, ngraham Cc: ngraham, rafasantos, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

T13927: Pop shell in KDE Plasma

ngraham added a comment. Ah ok, so you're asking for better tiling support to be built in. TASK DETAIL https://phabricator.kde.org/T13927 To: plasma-devel, ngraham Cc: cblack, niccolove, ngraham, rafasantos, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenB

T13927: Pop!_os style window tiling

ngraham renamed this task from "Pop shell in KDE Plasma" to "Pop!_os style window tiling". ngraham removed plasma-devel as the assignee of this task. ngraham added a subscriber: plasma-devel. ngraham edited projects, added KWin; removed Plasma. TASK DETAIL https://phabricator.kde.org/T13927 To

D23257: Allow for easier syncing of Plasma font

ngraham added a comment. Let's do it. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH easier-font-syncing (branched from master) REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngraham, #plasma, davidedmundson Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham abandoned this revision. ngraham added a comment. Moved over to https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/427. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: just

D25280: [Baloo KCM] Purge index when disabling indexing

ngraham abandoned this revision. ngraham added a comment. Moved over to https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/427. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25280 To: ngraham, tcanabrava, #plasma, #vdg, #baloo Cc: justinzobel, br

T13927: Pop!_os style window tiling

ngraham closed this task as "Invalid". ngraham added a comment. No need for two places to discuss the same thing; Let's close this in favor of https://invent.kde.org/plasma/kwin/-/issues/10, and take the discussion there. TASK DETAIL https://phabricator.kde.org/T13927 To: ngraham Cc: zamu

D24223: [RFC] Add global themes that mimic other platforms' workflows

ngraham abandoned this revision. ngraham added a comment. I no longer think this is a good idea. :( User feedback suggests that our default UX is too similar to another platform (Windows) already, which puts it in an "uncanny valley" where it is like 80% the same as that platform, but diverg

D27667: Align wallpaper dialog to bottom

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH anchor-thumbnail-to-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D27667 To: filipf

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Nice! Obviously this needs to be paired with appropriate changes to the default Breeze color scheme to replicate the desired look in T10201 :) Here's a quick-and-dirty version of the Breeze Evolved color scheme: {F8132321

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Could we draw the line in the window decoration theme then? Could it communicate in some way with the widgets theme to know what's beneath it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze Cc: ngraham, manu

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Looks like there are some QWidgets apps that aren't getting the new style. Kate's toolbar doesn't get the new color: F8133352: Screenshot_20200226_073753.png KWrite is fine, interestingly though: F8133374: Screenshot_20

D27679: [emojier] Set minimum window height and width

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch REPOSITORY R119 Plasma Desktop BRANCH emojier-minimum-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D27679 To: filipf, apol, #plasma, #vdg,

D27673: [applets/notes] Fix drag&drop links and cursor shape regression

This revision was automatically updated to reflect the committed changes. Closed by commit R114:b03539a0d8d3: [applets/notes] Fix drag&drop links and cursor shape regression (authored by Luca Pedrielli , committed by ngraham). Herald added a subscriber: plasma-devel. RE

D27673: [applets/notes] Fix drag&drop links and cursor shape regression

ngraham added a comment. Nice job, and nice first patch! May it be the first of many. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27673 To: luca, #plasma, ngraham Cc: plasma-devel, ngraham, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, f

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. Agreed. Otherwise it does work and fixes the bug, and the code looks sensible to me. However I know what @davidedmundson is going to say: "Working around Qt bugs requires a code comment mentioning the Qt bug report." :) So let's add that. Also I could not fi

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. Prior to 5.18, you had to set the GTK font separately; now it's auto-synced. Were you able to use an italic/bold/etc GTK font in 5.17 or earlier? I must admit I never tried, so if not being able to now is a regression, that's why I never noticed. :( REPOSITORY

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. In D27380#618528 , @IlyaBizyaev wrote: > In D27380#618526 , @ngraham wrote: > > > Prior to 5.18, you had to set the GTK font separately; now it's auto-synced. > > > R

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY There is a checkbox in the Task Manager settings with the text "Mark applications that play aud

D27685: Remove extra top and bottom padding from dock widgets

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This extra padding was no big deal when using the current Breeze style, where scrollable vi

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

ngraham updated this revision to Diff 76494. ngraham added a comment. Also check `audioIndicatorsEnabled` for safety REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27684?vs=76492&id=76494 BRANCH show-mute-feature-even-when-audio-indicators-are-dis

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

ngraham updated this revision to Diff 76495. ngraham added a comment. Brain fart; do it right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27684?vs=76494&id=76495 BRANCH show-mute-feature-even-when-audio-indicators-are-disabled (branched from m

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. In D27380#618599 , @gikari wrote: > So, I need to mention two bug reports: Qt one and GTK one. And should I create both of them? In case of GTK everything is somewhat clear, but in case of Qt I do not even know what to r

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Okular and Gwenview are now fixed for me. KMag and Filelight still consider the toolbar to be outside of the Tools Area for some reason. Awesome progress though. It looks so good! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cbla

D27199: [Applet]Update layout based on T10470

ngraham accepted this revision. ngraham added a comment. LGTM! Nice work. REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D27199_2 REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham Cc: ngraham, plasma-devel, Ora

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3b2e4ddaa01a: [applets/taskmanager] Show PA-related features even when audio indicators are… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Looking pretty great. The appearance of the Tools Area itself is good in all KDE apps tested. Visually, I only see a few remaining issues: There's no line under the titlebar in windows without a Tools Area: F8135611: Screenshot_20200227_151538.png

D27711: [Applet]Use gridLayout for details

ngraham added a comment. Even better than a GridLayout is a `Kirigami.FormLayout! That's what's being approximated here, so why not use the real thing? :) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ng

D27711: [Applet]Use gridLayout for details

ngraham added a comment. Yeah, that's fine. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragre

D27669: WIP: [kstyle] Tools area

ngraham added a comment. In D27669#619230 , @hpereiradacosta wrote: > Overall, this is good stuff I think (although we should also discuss whether this should be part of breeze or rather a next-gen theme). We discussed that in T12488

D27737: Fixed margin of digital clock

ngraham added a comment. Nice, this fixes https://bugs.kde.org/show_bug.cgi?id=417803. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27737 To: niccolove, #vdg, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus

D27577: [KCM]Fix content below scrollbars

ngraham added a comment. +1, go ahead REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cb

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9e0711ac408d: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet… (authored by The-Feren-OS-Dev, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE L

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham accepted this revision. ngraham added a comment. So at this point it's just one pixel, and I don't see the huge harm. :) However the last patch to adjust this (D27438 ) proved quite controversial, so we should wait for more opinions to avoid unduly

D27737: Fixed margin of digital clock

ngraham accepted this revision. ngraham added a comment. Visually +1 too. Stable branch? REPOSITORY R120 Plasma Workspace BRANCH margin_digital_clock (branched from master) REVISION DETAIL https://phabricator.kde.org/D27737 To: niccolove, #vdg, #plasma, davidedmundson, ngraham Cc

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham added a comment. It is (already) font-dependent, yes. A higher font size will result in larger spacing. IMO this is not super sensible, but, there is it. :p BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, n

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham added a comment. I mean, it's only one more pixel. :) But yes, for some people with certain fonts maybe it will be too much. But then again, could a single pixel really be enough to make it too much? BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.or

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Right, this is good to go now. We should remove the margin in the checkbox too. REPOSITORY R120 Plasma Workspace BRANCH smallspacingmargin (branched from master) REVISION DETAIL h

D27608: Fixes for applet configuration layout.

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. So with this patch, I see a new visual issue: the first time I open an applet config window, the vertical separator is not visible: F8147412: Screenshot_20200303_093031.png

D27807: Changed style of pressed list item to be consistent

ngraham added a comment. In D27807#621347 , @ndavis wrote: > It's strange that the plasma-devel mailing list isn't automatically added, even when it's a reviewer group. Because then people who are both subscribed to the mailing list and a

D27697: WIP: Added top area to notification header

ngraham added a comment. Man this looks nice. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27697 To: niccolove, broulik Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot

D27422: [KCM]Update Device item layout based on applet

ngraham accepted this revision. ngraham added a comment. Ship it, the jagginess is clearly caused by something lower in the stack. REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma,

D27645: [KCM]Align volume controls row

ngraham added a comment. Needs a rebase REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ra

D27608: Fixes for applet configuration layout.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep! Everything else looks good to me. REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #p

D24706: [RFC] Change button style

ngraham added a comment. In D24706#595764 , @ngraham wrote: > Thanks Noah. > > So you're the boss after all (as the de- facto Breeze maintainer now), and I think we should follow your lead design-wise. But it might also be interesting to hav

D27595: Watch for language change events, and forward those to the QML engine

ngraham added a comment. `git bisect` says this caused https://bugs.kde.org/show_bug.cgi?id=418447. F8148416: Spacing sometimes too high.mp4 Would be nice to fix that regression before it gets shipped with Frameworks 5.68. REPOSITORY R169 Ki

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

ngraham added a comment. -1 for using group boxes. :) I don't think they're needed at all. Just change the "Type:" label to "Authentication:" and that section is clear enough, then just separate the logical sections with whitespace REPOSITORY R116 Plasma Network Management Applet REVISION

D27823: Use consistent highlight

ngraham added a comment. This needs a rebase. Also you probably need to delete the existing mouseover highlight effect. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg Cc: ngraham, plasma-devel, Orage, LeG

D27824: Use consistent highlight

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Need to adjust the button's right margin in `DeviceItem.qml` as well: F8149546: Screenshot_20200304_084053.png Could be done in another patch.

D26992: [SystemTray] Use unified data model everywhere

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. UI and interaction are good, and a basic code review reveals no issues to me. Still, you may want to wait for a more thorough code review from a #plasma

D27608: Fixes for applet configuration layout.

ngraham added a comment. Yeah, this seems fine to land as-is. :) REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf, ngraham Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n

D27792: [Applet]Fix traffic monitor labels width

ngraham accepted this revision. ngraham added a comment. If you need to measure the width of text, then you're doing it the right way. However this problem wouldn't be happening in the first place if this UI used Layouts, which handle this kind of case more elegantly so you don't need to

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements the part of T12441 that was virtua

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. One other note: it might make sense to turn on the Digital Clock's date display by default if we go with this, as the clock text is currently rather gigantic and IMO adding the date results in both more information and also a better use of space: F8149908: clock

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of, D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it , after further discussion in T12441 . REP

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Sounds like a bug we should fix with the `preferred://` schemas then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fba

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Some folks in the #VDG channel have objected to the panel being 48px tall, so here's how it would look at 38 (the default Windows panel height): F8149938: 38.png Not as touch-frien

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Now to my eyes, 38px is too small. But apparently my tired old eyes and small screen (13.3" FHD) are not representative of other VDG people's views. :) Still it makes me realize that we really need to get https://bugs.kde.org/show_bug.cgi?id=356446 done so that P

D27792: [Applet]Fix traffic monitor labels width

ngraham added a comment. Yeah, if you want to keep the plotter dimensions constant, then there's no way around measuring the width of the labels. Regarding not opening any new patches, I hope you didn't have a bad experience in KDE that's left a bad taste in your mouth. If anything's gon

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 76967. ngraham added a comment. Use 38px as the height, and hardcode it since there's no good way to get there with a multiple of `gridUnit` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=76966&id=769

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As discussed in T12778 , the icon can never be in a corre

D27849: [applets/digital-clock] Remove the tooltip icon

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY To increase consistency and reduce redundancy, widget tooltip icons are being removed in D2

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

ngraham added a comment. It's just that in general we're trying to move away from group boxes and towards the use of whitespace to logically group sections. It's not a huge deal, but it would be appreciated. :) REVISION DETAIL https://phabricator.kde.org/D27764 To: dkosovic, jgrulich Cc:

D26718: aggregate text for KRunner in DesktopView

ngraham added a comment. Can confirm the fix when running from the desktop, but not when using the shortcut. So I wouldn't call 416145 fully fixed yet. Are you planning to work on that other part in this patch, or in a separate one? REPOSITORY R120 Plasma Workspace REVISION DETAIL https

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

ngraham added a comment. In D27847#622409 , @anthonyfieroni wrote: > Why? I think you forgot to read the description section. :) REPOSITORY R119 Plasma Desktop BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL htt

D26718: aggregate text for KRunner in DesktopView

ngraham added a comment. In D26718#622618 , @davidedmundson wrote: > > Are you planning to work on that other part in this patch, or in a separate one? > > To do what exactly? Find another way to fix the problem of keystrokes getting

D27869: Separate processcore/{formatter,unit} into its own library

ngraham added inline comments. INLINE COMMENTS > unit.h:81 > -// Misc units. > -UnitCelsius = 500, > -UnitDecibelMilliWatts, No Fahrenheit for us poor Americans? :) REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D27869 To: ahiemstra, #plasma Cc:

D27870: [applets/systemtray] Right align popup heading when in RTL mode

ngraham added a comment. Feels like this should be set by default in the `Heading` item, or else we'll be doing this everywhere, no? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27870 To: filipf, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27874: Disable the audio stream indicator for IOTM

ngraham added a comment. I can't say that it's gotten in the way for me either, with my thick panel. It does overlap the badge icon though which is a bit annoying. Also yes, if you want to remove this from the IOTM, you need to hide the setting on the IOTM's config page too. REPOSITORY

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. In D27845#622739 , @ndavis wrote: > I don't want to turn this into bikeshedding, but I think a size of 42 is better because that raises the size of task manager icons to 32px. 22px is pretty small for an IOTM. > With

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in layout.js:29 > why is this no longer unit based Because VDG people wanted a size that isn't a multiple or clean divisor of `gridUnit` and none of the other units values would evaluate for some reason. Some people think 38

D27870: [applets/systemtray] Right align popup heading when in RTL mode

ngraham added a comment. I doubt it. left-alignment is already the effective default anyway, so I'm actually surprised that explicitly setting it here makes RTL work. This hints at a deeper bug somewhere, unfortunately. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricato

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. @davidedmundson one problem here is that a `gridUnit` is a fairly coarse unit of measurement, and gridUnit * 3, or 54px is a bit larger than we'd like, but the current thickness (gridUnit *2, or 36px) is too thin. We initially settled on something in the mid 40s, but

D27823: Use consistent highlight

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConnectionItem.qml:54 > > +onContainsMouseChanged: { > +if (containsMouse) { `ConnectionItem.qml` already has `onContainsMouseChanged` (at the

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 77053. ngraham added a comment. Use a gridUnit-based measurement again, and increase the thickness a bit to effectively 46px tall, which I really don't think is excessive REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. In D27845#622970 , @kmaterka wrote: > Should System Tray icons be larger then? Here's how it would look to go from `iconSize=1` to `iconSize=2` (i.e, 16px to 22px): F815: Bigger.png

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. In D27845#623019 , @mart wrote: > In D27845#622178 , @ngraham wrote: > > > Not as touch-friendly, but the clock text looks better and it won't be so huge for people using lo

D27669: WIP: [kstyle] Tools area

ngraham added a comment. This latest iteration makes Telegram crash for me now. Backtrace: Thread 1 "telegram-deskto" received signal SIGSEGV, Segmentation fault. QAbstractAnimation::setDirection (this=0x583e16a0, direction=QAbstractAnimation::Forward) at animation/qabs

D27669: WIP: [kstyle] Tools area

ngraham added a comment. It still crashes with the same backtrace. :( REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGa

D27877: Make panel edit mode tooltip not unexpectedly disappear under certain circumstances

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The panel edit mode tooltip can currently disappear in an irritating manner under two circumstanc

D27877: Make panel edit mode tooltip not unexpectedly disappear under certain circumstances

ngraham updated this revision to Diff 77059. ngraham added a comment. Whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27877?vs=77058&id=77059 BRANCH stickier-panel-tooltip (branched from Plasma/5.18) REVISION DETAIL https://phabricato

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. @broulik I get the sense that you're boycotting this patch :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27565: Hide configure action in Info center mode

ngraham added a comment. Not sure about that, since it's shown in icons view too. So we would need to conditionally show it for icons+systemsettings view and sidebar+systemsettings view. This patch just hides it for sidebar+kinfocenter view, which seems simpler to me. Or maybe I'm misun

D27685: Remove extra top and bottom padding from dock widgets

ngraham added a comment. Can you think of an example of where there would be? If there's content inside this margin, that seems wrong to me anyway. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27685 To: ngraham, #vdg, #breeze, cblack, ndavis Cc: plasma-devel, Orage

D27685: Remove extra top and bottom padding from dock widgets

ngraham planned changes to this revision. ngraham added a comment. Oh I see now, like this, when unlocked: F8157256: Screenshot_20200306_064315.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27685 To: ngraham, #vdg, #breeze,

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

ngraham added a comment. +1 for the concept and resulting appearance. But, should this maybe be done in KWin instead? That way all window decoration themes would get this fix/change, not just Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davidre,

D27903: [applet/digital-clock] Show time zones in expanded representation too

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now time zones are only shown in the tooltip, which is annoying since the tooltip tim

D27663: Show tooltip with full URL for URL button with overridden text

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c1475bfa1781: Show tooltip with full URL for URL button with overridden text (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27663?vs=76422&i

D27664: Improve layout and appearance of app details view

This revision was automatically updated to reflect the committed changes. Closed by commit R134:9b0652d5c724: Improve layout and appearance of app details view (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27664?vs=76423

D26718: aggregate text for KRunner in DesktopView

ngraham added a comment. All right then. I guess it is a tricky problem. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26718: aggregate text for KRunner in DesktopView

ngraham added a comment. @davidedmundson stable branch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D27823: Use consistent highlight

ngraham added a comment. Now it needs a rebase, as there are merge conflicts. :) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblac

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1d769841d53: Increase the size of system tray icon hitboxes on the System Tray Plasmoid (authored by The-Feren-OS-Dev, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UP

D27823: Use consistent highlight

ngraham added a comment. you need to rebase on top of `master` from the remote. This looks to have been branched off of the state of master from last November or something. Try `git pull --rebase origin master` That should give you some merge conflicts that you can fix. REPOSITORY R11

D27915: Use breeze icons for categories

ngraham added a reviewer: apol. ngraham added a comment. Hmm, your before and after screenshots look identical to me. What's the reason for this? To make them look better in High DPI mode? I thought that was already fixed with D27515: Icon: fix rendering of image: urls on High DPI

  1   2   3   4   5   6   7   8   9   10   >