D16861: Improve crosshair cursor

ndavis added a comment. What color is the area on the inside of the cursor? I'm not sure, but it looks like it has a gradient, which doesn't really match the other Breeze cursors. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ngraham, #breeze, #vdg,

D16861: Improve crosshair cursor

ndavis added a comment. In D16861#359066 , @ngraham wrote: > It is indeed a weird gradient. I was just trying to make the minimum required number of changes to fix the bug, but I can fix that too if you'd like. Yes, if you're going to

D16861: Improve crosshair cursor

ndavis added a comment. You should probably do Breeze Snow as well since it has the exact same issue. In fact, it's probably even worse since a majority of websites use a white background.F6421382: Screenshot_20181113_135123.png REPOSITORY R31

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

ndavis planned changes to this revision. ndavis added a comment. Hmm some of the cursors seem blurrier than they used to be and I have no idea why. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #vdg, #plasma, ngraham Cc: ndavis,

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

ndavis added a comment. I think I found the reason why the prebuilt cursor themes are included in the repo in the README: > No trimming will have been done to the cursors, and X11 *may* give you split-second glitches when switching cursors making them appear to 'jump' for an instant.

D16861: Improve contrast for crosshair cursors

ndavis added a comment. In D16861#359193 , @ngraham wrote: > Imagine that, reading the README. :) If manual work is required for each image, that seems like all the more reason to only include the two changed ones in the diff. Yep. This

D16861: Improve contrast for crosshair cursors

ndavis updated this revision to Diff 45482. ndavis added a comment. Only change crosshair cursors and source SVG REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16861?vs=45434=45482 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16861

D16861: Improve crosshair cursor

ndavis added a comment. What's the best way to update this diff? What I'm doing completely discards your changes. Should I get this diff with `arc patch D16861` and then update the diff from that branch or can I make my own branch and do `arc diff --update D16861` to overwrite your changes?

D16861: Improve crosshair cursor

ndavis added a comment. Why do we have the cursor theme pre-built in the repo? It's making Arcanist take forever. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #vdg, #plasma, ngraham Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot,

D16861: Improve crosshair cursor

ndavis updated this revision to Diff 45434. ndavis added a comment. Improve contrast for Breeze Snow and Breeze crosshair REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16861?vs=45429=45434 BRANCH better-crosshair-cursor (branched from master) REVISION

D16861: Improve crosshair cursor

ndavis added a comment. I'd like to remove the extra junk, but I don't want to break anything either. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ndavis, #breeze, #vdg, #plasma, ngraham Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

ndavis added a comment. In D16861#359170 , @ngraham wrote: > So is there a script that regenerates all the X11 cursor files from the SVG whenever it's changed or something? Because I'm willing to bet you didn't change all 654 cursors...

D16861: Improve crosshair cursor

ndavis added a comment. Turns out there already is an outline, but it's at 10% opacity instead of 100% and the crosshair doesn't have a blurred shadow around it like the other breeze cursors. I think we should do our best to try to keep the crosshair feeling precise while also improving the

D16861: Improve crosshair cursor

ndavis added a comment. In D16861#359124 , @ngraham wrote: > Would you like to take over? I have a feeling that you can do a better job than I can, and you also know what you're doing with the tools, too. :) Sure. I've basically already

D16861: Improve crosshair cursor

ndavis added a comment. Those crosshair outlines seem to be a bit jagged, unlike the other breeze crosshairs. F6421397: Screenshot_20181113_135510.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D16861 To: ngraham,

D16861: Improve crosshair cursor

ndavis added a comment. In D16861#359106 , @ngraham wrote: > Yeah, they currently have hard edges. I'm sadly pretty abysmal with this kind of pixel art, but hopefully I'll muddle through... Maybe the original cursors were made with SVG

D16861: Improve crosshair cursor

ndavis added a comment. I find the Breeze Snow cursors to bee generally lacking in contrast because of the 60% opacity outline. Should I expand this commit to improve the contrast for all Breeze Snow cursors as well? REPOSITORY R31 Breeze REVISION DETAIL

D18005: Include only the largest size for each wallpaper

ndavis added a comment. What happens if my wallpaper is set to the 1080p version of the default wallpaper and then that version is removed with only the highest resolution version left? REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18005 To: ngraham,

D18004: Use "Scaled and Cropped" as the default wallpaper image fill mode

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 It works for the majority of wallpapers much better than just scaling. REPOSITORY R120 Plasma Workspace BRANCH scaled-and-cropped-by-default (branched from master) REVISION

D18005: Include only the largest size for each wallpaper

ndavis added a comment. Should I accept now or should I wait until that gets sorted out? REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18005 To: ngraham, #vdg, #plasma Cc: ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18005: Include only the largest size for each wallpaper

ndavis added a comment. In D18005#387324 , @ngraham wrote: > However, just removing files from the repo doesn't actually remove them from users' machines; their packaging system does that. Perhaps we should alert packagers that for the 5.15

D18381: Add tooltip to configure panel button

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think this is a good idea. We've always done a rather poor job of telling new users how to modify the panel and this helps a bit. Now let's wait for input from #plasma

D17751: Add shadow to Hour's hand

ndavis added a comment. In D17751#382113 , @shubham wrote: > In D17751#381435 , @ndavis wrote: > > > No, the SVG that the analog clock uses is in plasma-framework > > > Can you tell me how to

D17751: Add shadow to Hour's hand

ndavis added a comment. In D17751#381431 , @shubham wrote: > How could the shadow appearance be fixed? In breeze icons? No, the SVG that the analog clock uses is in plasma-framework REPOSITORY R120 Plasma Workspace REVISION DETAIL

D17393: [Folder View] make file context menu consistent with Dolphin's

ndavis added a comment. +1 to making the menus the same. In D17393#373155 , @hein wrote: > Can we patch Dolphin instead? I think the order there is pretty bad, with weird random dividers etc. (From the screenshots in the original user bug.)

D17410: Add alternatives button to applet configuration in panel edit mode

ndavis added a comment. I think we should be using a monochrome icon here. An equivalent monochrome icon would be `favorite`, but I don't think "favorite" is a good symbol for "alternatives". Maybe `preferences-other`/`application-menu` (same icon) would be good? It might be outside the

D17346: Support Bluetooth batteries

ndavis added a comment. Does it have to be in the Plasma theme? I want to move all icons into breeze-icons eventually. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17346 To: broulik, #plasma, bruns, #vdg Cc: ndavis, plasma-devel, ragreen, Pitel,

D17440: Rotate busy indicator clockwise

ndavis added a comment. Makes sense to me. Time moves clockwise on a clock. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D17440 To: GB_2, #breeze, #vdg Cc: ndavis, #vdg, plasma-devel, #breeze, alexde, IohannesPetros, trickyricky26,

D17073: Do not crop albumArt

ndavis added a comment. In D17073#364541 , @trmdi wrote: > In D17073#364393 , @ndavis wrote: > > > That blur looks nice, but I think the background should be more opaque like the Elisa header

D17152: Hide the badge if number too big

ndavis added a comment. Why not abbreviate the number and round the abbreviated number instead? Instead of using "9,999+" for 11000, use "11K". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17152 To: svuorela, #plasma, hein, broulik, #vdg, ngraham Cc:

D17038: Fix uncentered crosshairs

ndavis added a comment. In D17038#363375 , @ngraham wrote: > Whoops! Nice find, and nice fix. Since the other crosshair patch went into the `Plasma/5.12` stable branch, let's do the same thing here. You wanna have another go at

D17073: Do not crop albumArt

ndavis added a comment. In D17073#364003 , @trmdi wrote: > How about this ? > F6436415: test.png I think this version works much better than the other 2. It shows the entire image and it fills up

D17073: Do not crop albumArt

ndavis added a comment. If you want to try adding blur to the background, check out the code here: https://cgit.kde.org/elisa.git/tree/src/qml/HeaderBar.qml#n53 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc:

D17073: Do not crop albumArt

ndavis added a comment. That blur looks nice, but I think the background should be more opaque like the Elisa header background.F6437066: Screenshot_20181122_005432.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17038: Fix uncentered crosshairs

ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY For some reason, the centers of the generated PNGs are not the centers of the

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. I think some users may want to have a separate date format for their clock than the rest of the system. A user might prefer to use ISO date format with only the last 2 digits of the year in their clock because it saves space, but they might prefer to use regular ISO

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. > Should I add presets like Event Calendar? I'm leaning towards no, but an example of the custom time formatting and another of HTML styling would be a good idea. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren,

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. In D18019#388819 , @Zren wrote: > In D18019#388811 , @ndavis wrote: > > > I'm leaning towards no, but a second link to text formatting documentation might be a good idea. >

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. In D18019#388876 , @mart wrote: > is this the right place for it? (a text field to enter the "magic" date format letters is a very geeky ui, and i would prefer to not go there) shouldn't be a generic localization/date

D18546: [Desktop Toolbox] Use "tools" icon

ndavis added a comment. In D18546#400325 , @Codezela wrote: > In D18546#400256 , @GB_2 wrote: > > > In D18546#400253 , @hein wrote: > > > > > How about

D18546: [Desktop Toolbox] Use "tools" icon

ndavis added a comment. I'm not sure if the `tools` icon is actually appropriate here. I know it's called the Desktop Toolbox, but it doesn't work at all like the tools menus in Spectacle or KSysGuard. It's almost like a button to open the desktop context menu, except it also shows the

D18546: [Desktop Toolbox] Use "tools" icon

ndavis added a comment. If we are going to change the name, I would suggest changing it to something that has a similar meaning to "edit the desktop" and change the icon to something that means "edit". That's the primary use for this widget anyway. REPOSITORY R119 Plasma Desktop REVISION

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 to this. It's nice when you already know what you're doing and want to change a setting quickly. REPOSITORY R119 Plasma Desktop BRANCH new-kcms-apply-on-double-click (branched from

D12055: Remove border around menubars

ndavis added a comment. In D12055#436424 , @filipf wrote: > In D12055#436412 , @ndavis wrote: > > > I don't see this border at all in the current version of Breeze GTK with Firefox. F6711302:

D19874: [Kickoff] Reduce the margins of KickoffItem

ndavis updated this revision to Diff 55500. ndavis added a comment. Use smallSpacing for KickoffItem and KickoffHighlight REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19874?vs=54292=55500 BRANCH KickoffItem-margins (branched from master)

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:51f7912368e6: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use… (authored by ndavis). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

ndavis added a comment. I haven't tested this with many different fonts, but the current version works well for Noto Sans at 10, 11 and 12 pts. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19874 To: ndavis, #plasma, #vdg, ngraham, hein Cc: hein, ngraham,

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

ndavis added a comment. In D19874#444153 , @filipf wrote: > This makes Kickoff even a bit more more left-centered = looking like it's wasting horizontal space. That's why I prefer the way it was before, but I tested the patch and everything

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

ndavis updated this revision to Diff 55502. ndavis marked 2 inline comments as done. ndavis added a comment. - Remove commented out bit of old code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19874?vs=55500=55502 BRANCH KickoffItem-margins

D19044: [InlineMessage] Do not draw shadows around the message

ndavis added a comment. TBH, I like the shadow. Breeze as a widget theme tends to be a bit too flat. Here's how it looks with Breeze Dark.F6622189: Screenshot_20190218_172518.png REPOSITORY R169 Kirigami REVISION DETAIL

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

ndavis added a comment. In D19148#415123 , @rooty wrote: > I like this idea, more variety > Especially considering that the default setting doesn't really change, just gets renamed essentially? Not quite. Very Small is about the same

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Before, shadow size doubled with each new size until Very Large and the smaller shadows were

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

ndavis updated this revision to Diff 52036. ndavis added a comment. Change default shadow size to medium REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19148?vs=52035=52036 BRANCH shadow-sizes (branched from master) REVISION DETAIL

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

This revision was automatically updated to reflect the committed changes. Closed by commit R31:cd04f42432a6: Multiply radius by 0.5 in calculateBlurStdDev() (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19134?vs=52016=52020 REVISION

D19134: Multiply radius by 0.5 in calculateBlurStdDev

ndavis created this revision. ndavis added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Fix TODO to follow w3.org standard for shadow-blur REPOSITORY R31 Breeze BRANCH shadow-sizes

D19148: Make shadow sizes linear

This revision was automatically updated to reflect the committed changes. Closed by commit R31:8bfe474ac585: Make shadow sizes linear (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19148?vs=52421=52424 REVISION DETAIL

D19148: Make shadow sizes linear

ndavis added a comment. This is directional (64 size, 100% opacity) and ambient (1000 size, 100% opacity). F6632129: Screenshot_20190223_194638.png F6632131: Screenshot_20190223_194651.png REPOSITORY R31

D19148: Make shadow sizes linear

ndavis updated this revision to Diff 52421. ndavis added a comment. Update kstyle and increase size of kdecoration ambient shadows to 1/2 of directional shadows. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19148?vs=52107=52421 BRANCH shadow-sizes

D19148: Make shadow sizes linear

ndavis added a comment. TBH, I can't tell a difference between the old KStyle shadows and the new ones. Maybe I should have just left them as they were or maybe I should increase the opacity, but at least the numbers look pretty. ¯\_(ツ)_/¯ REPOSITORY R31 Breeze BRANCH shadow-sizes

D19148: Make shadow sizes linear

ndavis added a comment. In D19148#418158 , @zzag wrote: > In D19148#418083 , @ndavis wrote: > > > @zzag Is the only difference between the ambient and directional shadow the Y axis offset? If so,

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis added a comment. In D19230#421215 , @abetts wrote: > Do you think that "locale" is a very specific term? Could it be different? The alternative would be "region", which is the term we use in the related settings KCM.F6643106:

D19379: [sddm-theme] Add a bottom panel

ndavis added a comment. In D19379#421001 , @rooty wrote: > Center how? Vertically? > Where would the elements be placed (with respect to the Clock / user names/avatars / action buttons)? Horizontally and maybe vertically. They could

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis accepted this revision. ndavis added a comment. +1 This is a much more usable design and more in line with our HIG. REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis added a comment. In D19230#421924 , @ngraham wrote: > I mean, what do you think about the specific string "Use region's default setting". Too wordy? Just right? You could use use "Default" and maybe have a button to open the

D19392: shannon entropy to guess monochrome icon

ndavis added a comment. In D19392#421903 , @ngraham wrote: > Actually we're discussing in VDG-land whether or not this is something we should do anyway, because right now we have no way of forcing the use of a monochrome icon for a >22px size

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis added a comment. Can you hide the button to open the Formats KCM when "Use Region Defaults" is not selected? REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230 To: ngraham,

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis accepted this revision. ndavis added a comment. I think so REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230 To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis Cc:

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis added a comment. In D19230#422088 , @ngraham wrote: > We could, but is that really necessary? In general we try to avoid having UI elements dynamically show and hide themselves outside of the narrowly-defined exception of when a UI

D19444: Make long menus scrollable instead of expanding horizontally

ndavis added a comment. Horizontal menus are fast, but unusable or hard to read if they get too large. Scrollable menus with the arrows that you hover over are annoyingly slow if you don't use a scroll wheel to scroll, but don't block the entire screen if you have a large number of items.

Re: Plasma Sprint 2019 in València

What is the address of the place we will meet? On 3/4/19, Aleix Pol wrote: > Does that mean you can't on those days? How does this change the > prospect sprint? > > Aleix > > On Mon, Mar 4, 2019 at 11:08 AM Marco Martin wrote: >> >> On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik

D19096: Improvements for long label items in Application Dashboard

ndavis added a comment. +1 from me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, #vdg Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D19148: Make shadow sizes linear

ndavis added a comment. In D19148#415929 , @zzag wrote: > What about kstyle? Is it okay? kstyle uses entirely different shadows, even more so compared to the original values for kdecoration. Should it not be that way? REPOSITORY R31

D19379: [sddm-theme] Add a bottom panel

ndavis added a comment. -1 I don't think it looks very nice. If you're worried about those UI elements not being visible, wouldn't it be better to move them towards the center? Then, if it's necessary, you can add a background to all the floating UI elements so that they're all

D19148: Make shadow sizes linear

ndavis added a comment. In D19148#417251 , @zzag wrote: > Well, I guess that depends on the light. After all we don't try to model "physically correct" shadows. > > Anyway, I've asked that question about opacity because most folks do the

Re: Plasma Sprint 2019 in València

Not immediately, but I've never traveled outside the US and I'd like to be prepared. On March 4, 2019 9:34:16 PM EST, Aleix Pol wrote: >I don't have it at hand, but does that really matter? > >Aleix > >On Mon, Mar 4, 2019 at 6:54 PM Noah Davis wrote: >> >> What is

Re: Plasma Sprint 2019 in València

I will, thank you. On 3/5/19, Aleix Pol wrote: > Please, remember to submit your reimbursement request here: > https://reimbursements.kde.org/events/88 > > Aleix > > On Tue, Mar 5, 2019 at 1:12 PM Noah Davis wrote: >> >> Not immediately, but I've never travel

D19148: Make shadow sizes linear

ndavis added a comment. In D19148#416749 , @zzag wrote: > In D19148#416006 , @ndavis wrote: > > > kstyle uses entirely different shadows, even more so compared to the original values for

D19148: Make shadow sizes linear

ndavis added a comment. @zzag Is the only difference between the ambient and directional shadow the Y axis offset? REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf,

D19745: Fix system tray UI/UX & refactor

ndavis added a comment. +1 to this. Fitts' law comes to mind. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik Cc: ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19651: Improve the look of the Application Style KCM UI

ndavis added a comment. Can it have the same default width as the toolbar text location comboboxes? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,

D19651: Improve the look of the Application Style KCM UI

ndavis added a comment. Is that "Application style" combobox long enough to accommodate longer strings like "MS Windows 9x"? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg Cc: ndavis, #vdg, plasma-devel, #plasma, jraleigh,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

This revision was automatically updated to reflect the committed changes. Closed by commit R31:be9f150abe2d: Sharpen ApplicationMenu, Shade, ContextHelp icons (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19605?vs=53405=53764 REVISION

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis added a comment. In D19605#427037 , @zzag wrote: > This patch makes buttons sharp only for one particular button size and font size. You're right, but this makes it sharper at the default button+font size. Smaller sizes suffer,

D19694: [RFC] Reduce sidebar icon size/increase list information density

ndavis added a comment. In D19694#434169 , @ngraham wrote: > I was talking about the problem of small monochrome icons in the sidebar itself, not in the tooltip. But anyway since then I fixed the tooltip too. > > Any more #VDG

D19874: Reduce the margins of KickoffItem

ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY A lot of space on the left and right of each KickoffItem was wasted, so I've reduced the

D19874: [Kickoff] Reduce the margins of KickoffItem

ndavis added a comment. Another thing is the ratio between the left/right margins and the top/bottom margins varies with font size, so maybe Kickoff really does need some fixing up. The height is `2 * units.smallSpacing`, plus the maximum value of the icon, title+subtile or arrow

D19874: [Kickoff] Reduce the margins of KickoffItem

ndavis added a comment. In D19874#434319 , @ngraham wrote: > +1 conceptually. Since Kickoff has its own side margins, these additional margins in the items themselves are just unnecessary. I tried to see how they would look with no

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis added a comment. @zzag Is there anything you want me to change? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis added a comment. In D19605#429711 , @ngraham wrote: > I think I agree that it's much better to improve things universally if we can. But if we can't, then improving things for the default settings is good too. > > @ndavis, how well

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Parts of these icons did not line up well with the pixel grid making them seem blurry or faded.

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis updated this revision to Diff 53405. ndavis added a comment. Fix formatting on line parameters for Shade button REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19605?vs=53403=53405 BRANCH fix-titlebar-buttons (branched from master) REVISION DETAIL

D19606: [Task Manager] Reorganize and improve presentation of context menu

ndavis added subscribers: trickyricky26, ndavis. ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I like it overall, but some of those icons need changing. Not just here, but in breeze-icons as well. Resize: I don't like

D19694: [RFC] Reduce sidebar icon size/increase list information density

ndavis added a comment. > Though the icons are indeed pretty, and the problem with small monochrome icons has been resolved, the information density is now quite low. When? I still get a mix of color and monochrome icons in System Settings with the git master versions of it and

D12055: Remove border around menubars

ndavis added a comment. I don't see this border at all in the current version of Breeze GTK with Firefox. F6711302: Screenshot_20190322_152144.png REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ndavis added a comment. I thought we primarily used 22px and not 24px? While it does make the icons look more consistent as long as there are no monochrome 24px versions (there are some) should there be an exception to the norm? If so, we would have to remove all 24px monochrome icons. That

D18861: Improve the Fonts KCM UI

ndavis added a comment. I don't like the look of the `|` character between the font name and the font size. I think the existing "Noto Sans 10" format looked better, but I'm not going to formally request changes. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D18861: Improve the Fonts KCM UI

ndavis added a comment. In D18861#408286 , @ngraham wrote: > Personally my preference would be for the strings to be like this: `10 pt Noto Sans` That would be fine too since it reads like English. The `|` character makes it seem like

D19124: Change shadow color to 0,0,0

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY The current shadow color is Shade Black, which is also used as the ViewBackground color in Breeze

D19124: Change shadow color to 0,0,0

ndavis added a comment. alright REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19124 To: ndavis, #vdg, ngraham, filipf Cc: zzag, filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D19125: Change shadow color to 0,0,0 for KStyle

ndavis added a comment. In D19125#414786 , @zzag wrote: > Should we adjust opacity as well? That's the strength value, right? I don't think so. REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL

  1   2   3   4   5   6   7   >