Re: Review Request 120050: Wallpaper package structure fixes

2014-09-20 Thread Aaron J. Seigo
. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review67019 --- On Sept. 19, 2014, 2:28 p.m., Aaron J. Seigo wrote

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-20 Thread Aaron J. Seigo
On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: This causes a regression: normal images can no longer be loaded. Plasmashell outputs No metadata file in the package, expected it at: /path/to/parent/dir/of/wallpaper/metadata.desktop Aaron J. Seigo wrote: this has been

Review Request 120284: sanity checking in desktops/activities scripting

2014-09-19 Thread Aaron J. Seigo
that was failing due to the above issues. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-19 Thread Aaron J. Seigo
Diff: https://git.reviewboard.kde.org/r/120050/diff/ Testing --- Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120284: sanity checking in desktops/activities scripting

2014-09-19 Thread Aaron J. Seigo
Diff: https://git.reviewboard.kde.org/r/120284/diff/ Testing --- Ran plasmashell and a layout.js that was failing due to the above issues. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-19 Thread Aaron J. Seigo
tested with a shell package that sets wallpaper data on start, that works now too. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120284: sanity checking in desktops/activities scripting

2014-09-19 Thread Aaron J. Seigo
/desktopview.cpp 2df96b94bb924251bb7023149cc11cb1bc7dba8e Diff: https://git.reviewboard.kde.org/r/120284/diff/ Testing --- Ran plasmashell and a layout.js that was failing due to the above issues. Thanks, Aaron J. Seigo ___ Plasma-devel

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-19 Thread Aaron J. Seigo
, etc. All worked as expected. Also tested with a shell package that sets wallpaper data on start, that works now too. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Aaron J. Seigo
On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: I need some the concept explaining, why would a developer set a fallbackpackage? Is it not always org.kde.breeze.desktop? Marco Martin wrote: It would usually be the packagestructure setting it, in initPackage(), so

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Aaron J. Seigo
than sorry :p Aaron J. Seigo wrote: Is it not always org.kde.breeze.desktop? No, because of third party developers. Not every project targets the desktop. That said, this applies to any use of Plasma::Package, which is meant to be a generic concept not something

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Aaron J. Seigo
than sorry :p Aaron J. Seigo wrote: Is it not always org.kde.breeze.desktop? No, because of third party developers. Not every project targets the desktop. That said, this applies to any use of Plasma::Package, which is meant to be a generic concept not something

Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Aaron J. Seigo
--- Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Aaron J. Seigo
d672dfebcfb6849776aaf3faf4362a19182f7045 wallpapers/image/wallpaperpackage.h 45e8736685ce50cb0b1c21a4ab80734f304ccde2 wallpapers/image/wallpaperpackage.cpp 1ee524e34470acdec3e79238b1ba7151584ca858 Diff: https://git.reviewboard.kde.org/r/120050/diff/ Testing --- Thanks, Aaron J. Seigo

Re: Plasma Plugin Loading

2014-09-02 Thread Aaron J. Seigo
supported / advertised methods. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Plugin Loading

2014-09-02 Thread Aaron J. Seigo
On Tuesday, September 2, 2014 14.00:58 Sebastian Kügler wrote: On Tuesday, September 02, 2014 12:45:37 Aaron J. Seigo wrote: Whatever path is taken, Plasma::PluginLoader is currently internally inconsistent. Picking a path and then making all plugins load via the same pattern would

Review Request 119984: more plasmashell code cleaning

2014-08-29 Thread Aaron J. Seigo
://git.reviewboard.kde.org/r/119984/diff/ Testing --- Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119984: more plasmashell code cleaning

2014-08-29 Thread Aaron J. Seigo
shell/shellcorona.cpp 84442ae60cf0f576a077e770ceae82a17721a456 Diff: https://git.reviewboard.kde.org/r/119984/diff/ Testing --- Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
Plasma Desktop session. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread Aaron J. Seigo
0d986e845e3b9821ef39a874d431a087e2390e8a Diff: https://git.reviewboard.kde.org/r/119989/diff/ Testing --- Ran a full Plasma Desktop session with these changes. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
. To reply, visit: https://git.reviewboard.kde.org/r/119988/#review65481 --- On Aug. 29, 2014, 11:51 a.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread Aaron J. Seigo
Plasma Desktop session with these changes. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread Aaron J. Seigo
--- Ran a full Plasma Desktop session with these changes. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
On Aug. 29, 2014, noon, David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two reasons

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
On Aug. 29, 2014, noon, David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two reasons

Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

2014-08-29 Thread Aaron J. Seigo
/packagestructure.h fb32c22a6e7df1528b3d7a5b30b94c60a85a93e3 Diff: https://git.reviewboard.kde.org/r/119992/diff/ Testing --- Ran a Plasma Desktop 5 session with these changes. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
Diff: https://git.reviewboard.kde.org/r/119988/diff/ Testing --- Ran a full Plasma Desktop session. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

2014-08-29 Thread Aaron J. Seigo
0833a4ed1b5704efffccade5e52589878e8b4957 src/plasma/package.cpp 6ad332167bb83c2f794f9f5d059e9f369ad33841 src/plasma/packagestructure.h fb32c22a6e7df1528b3d7a5b30b94c60a85a93e3 Diff: https://git.reviewboard.kde.org/r/119992/diff/ Testing --- Ran a Plasma Desktop 5 session with these changes. Thanks, Aaron J. Seigo

Re: Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread Aaron J. Seigo
session with these changes. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
--- On Aug. 28, 2014, 8:17 a.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119965

Re: Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
--- Run with a shell package with InteractiveConsole.qml, used the console to run scripts, opened and closed it, etc. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119966: add an InteractiveConsole.qml

2014-08-28 Thread Aaron J. Seigo
: https://git.reviewboard.kde.org/r/119966/diff/ Testing --- Tested in plasmashell. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119942: give the applet alternatives QML file an entry

2014-08-26 Thread Aaron J. Seigo
/packages.cpp 585ab1f272d48f9b998c64968beeccf0f6dd979f Diff: https://git.reviewboard.kde.org/r/119942/diff/ Testing --- Loaded plasmashell and the alternatives UI. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request 119944: Remove UI assumptions about the alternatives dialog

2014-08-26 Thread Aaron J. Seigo
as expected and the QmlObjects are cleaned up appropriately as well. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
--- Used Plasma Desktop with this shell package. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/#review65293 --- On Aug. 26, 2014, 5:37 p.m., Aaron J. Seigo wrote

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
://git.reviewboard.kde.org/r/119946/diff/ Testing --- Used Plasma Desktop with this shell package. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
://git.reviewboard.kde.org/r/119946/#review65295 --- On Aug. 26, 2014, 7:39 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119942: give the applet alternatives QML file an entry

2014-08-26 Thread Aaron J. Seigo
. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119942/#review65294 --- On Aug. 26, 2014, 5:25 p.m., Aaron J. Seigo wrote

Re: Review Request 119942: give the applet alternatives QML file an entry

2014-08-26 Thread Aaron J. Seigo
point in the package, so it should have a well known name. Diffs - src/plasma/private/packages.cpp 585ab1f272d48f9b998c64968beeccf0f6dd979f Diff: https://git.reviewboard.kde.org/r/119942/diff/ Testing --- Loaded plasmashell and the alternatives UI. Thanks, Aaron J. Seigo

Re: Review Request 119944: Remove UI assumptions about the alternatives dialog

2014-08-26 Thread Aaron J. Seigo
/ Testing --- Run with a modified desktop shell package and alternatives come up as expected and the QmlObjects are cleaned up appropriately as well. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
de99b1ca370c819687230c1bcd54d2839b08dab9 Diff: https://git.reviewboard.kde.org/r/119946/diff/ Testing --- Used Plasma Desktop with this shell package. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 119929: Cleaning up plasma-shell, episode 1

2014-08-25 Thread Aaron J. Seigo
/widgetexplorer.cpp 0ad5cc8519c8f37ce20e49332491ea0469ee7a29 shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f Diff: https://git.reviewboard.kde.org/r/119929/diff/ Testing --- Thanks, Aaron J. Seigo ___ Plasma-devel mailing

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

2014-08-25 Thread Aaron J. Seigo
Diff: https://git.reviewboard.kde.org/r/119929/diff/ Testing --- Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

2014-08-25 Thread Aaron J. Seigo
/#review65205 --- On Aug. 25, 2014, 2:50 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119929

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

2014-08-25 Thread Aaron J. Seigo
--- Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112208: KMix qml applet

2014-08-19 Thread Aaron J. Seigo
: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated May 4, 2014, 9:46 p.m.) Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor

Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-30 Thread Aaron J. Seigo
On Jan. 29, 2014, 1:50 p.m., Aaron J. Seigo wrote: plasma/theme.cpp, lines 273-276 https://git.reviewboard.kde.org/r/115326/diff/3/?file=240803#file240803line273 it's nice to clean up the svg elements files; however without an active cache file it doesn't matter

Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Aaron J. Seigo
--- changed desktop theme version in meatadata.desktop between runs of plasma-desktop: cache files changed to correct versions changed config file *during* plasma-desktop running: caches files changed to correct versions no change between runs: cache files retained Thanks, Aaron J. Seigo

Re: Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Aaron J. Seigo
to correct versions changed config file *during* plasma-desktop running: caches files changed to correct versions no change between runs: cache files retained Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Aaron J. Seigo
Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Aaron J. Seigo
runs of plasma-desktop: cache files changed to correct versions changed config file *during* plasma-desktop running: caches files changed to correct versions no change between runs: cache files retained Thanks, Aaron J. Seigo ___ Plasma-devel

Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-29 Thread Aaron J. Seigo
= new KImageCache(pixmapCacheFileName, config.themeCacheKb() * 1024); - Aaron J. Seigo On Jan. 28, 2014, 9:18 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-29 Thread Aaron J. Seigo
On Jan. 29, 2014, 1:50 p.m., Aaron J. Seigo wrote: this patch doesn't actually improve anything. in fact, the actual bug is left: pixmapCache = new KImageCache(pixmapCacheFileName, config.themeCacheKb() * 1024); pixmapCacheFileName should have the version

Re: Review Request 114429: use of time data engine - less code

2013-12-13 Thread Aaron J. Seigo
let the DataEngine update you. so the Timer here should just go away and the label with the text should be bound to the results of the DataSource. - Aaron J. Seigo On Dec. 13, 2013, 7:07 a.m., Heena Mahour wrote

Re: Looking around and thinking ahead

2013-12-12 Thread Aaron J. Seigo
given that we can drop a number of hacks and workarounds with the move to pure QML. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Looking around and thinking ahead

2013-12-12 Thread Aaron J. Seigo
of unused / deprecated API * move some business logic methods back into Plasma::Applet * move the rest of it into DeclarativeAppletScript thoughts? problems? -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Looking around and thinking ahead

2013-12-12 Thread Aaron J. Seigo
and contains the applet qml was the way that caused less pain) if a container QQuickItem is absolutely required, this sounds good -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Looking around and thinking ahead

2013-12-12 Thread Aaron J. Seigo
was designed (and by whom/where), this is a folk etymology of the kickoff UI which bears no resemblance to what actually transpired. get the motives wrong, learn the wrong lessons. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Looking around and thinking ahead

2013-12-12 Thread Aaron J. Seigo
On Thursday, December 12, 2013 15:41:05 Eike Hein wrote: On Thursday 12 December 2013 15:29:00 Aaron J. Seigo wrote: as an aside: this really makes zero sense to have. it requires plasmoid A to work with plasmoid B in a way that makes lots of assumptions. Add to Desktop and Add to Panel

Re: Looking around and thinking ahead

2013-12-12 Thread Aaron J. Seigo
, the “no” was pointed at the idea of presenting solutions before we have questions. I don't like that these things even happen in our ranks. I'm happy to take rejoice: you don’t have to worry about it any longer. -- Aaron J. Seigo ___ Plasma-devel mailing

Re: activities and scripting

2013-12-11 Thread Aaron J. Seigo
, but would be good to get that right as well. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: activities and scripting

2013-12-11 Thread Aaron J. Seigo
On Wednesday, December 11, 2013 15:57:28 Nowardev-Team wrote: var activity = new Activity(folderview) activity.name = i18n(Mac Activity”) activity.wallpaperPlugin = image activity.wallpaperMode = SingleImage activity.currentConfigGroup = Array(Wallpaper, image) hm.. does the attached patch

Re: activities and scripting

2013-12-11 Thread Aaron J. Seigo
On Wednesday, December 11, 2013 21:28:21 Nowardev-Team wrote: i tried it and the resolution issue seems to be gone great; i’ll test the other use cases and get it functioning before commit. cheers. -- Aaron J. Seigo ___ Plasma-devel mailing list

Re: activities and scripting

2013-12-11 Thread Aaron J. Seigo
to a new activity created with your script .. or with any activity? the reason i ask: i can’t reproduce this behavior. if it only happens with activities created with your script, can you send me your scripts in a tarball? -- Aaron J. Seigo ___ Plasma

Re: activities and scripting

2013-12-09 Thread Aaron J. Seigo
to do maxpect iirc? as for why it isn’t picking the correct size of wallpaper, i can only speculate. does setting that same wallpaper in the config dialog work? -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Plasmate next

2013-12-06 Thread Aaron J. Seigo
On Friday, December 6, 2013 10:28:02 Giorgos Tsiapaliokas wrote: So what do you think? sounds fine to me... -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Remove X-Plasma-DefaultSize

2013-11-27 Thread Aaron J. Seigo
determine this from the root item's implicitWidth/implicitHeight can I remove this property from the .desktop files? +1 this was primarily necessary when we had script engines which didn’t have a reliable root item they created and had access to. no longer the case, obviously. -- Aaron J. Seigo

Re: Review Request 113971: improve screenlocker multiscreen handling

2013-11-22 Thread Aaron J. Seigo
meant by add comments was explain *why* the events need to be shared. :) - Aaron J. Seigo On Nov. 21, 2013, 9:14 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 113971: improve screenlocker multiscreen handling

2013-11-21 Thread Aaron J. Seigo
On Nov. 20, 2013, 5:01 p.m., Thomas Lübking wrote: ksmserver/screenlocker/greeter/greeterapp.cpp, line 238 http://git.reviewboard.kde.org/r/113971/diff/1/?file=215038#file215038line238 this loop is required to make the qml/graphicsscene properly hadnle the forwarded events.

Re: Review Request 113971: improve screenlocker multiscreen handling

2013-11-21 Thread Aaron J. Seigo
/screenlocker/greeter/greeterapp.cpp http://git.reviewboard.kde.org/r/113971/#comment31605 a comment in the code here explaining why this is needed / why it is important would be good. - Aaron J. Seigo On Nov. 20, 2013, 4:52 p.m., Thomas Lübking wrote

Re: PIM Sprint (The bits relevant to Plasma)

2013-11-19 Thread Aaron J. Seigo
, then we would know to disable events and so never wake Akonadi up. That would be fantastic. If there was a simple library call that could tell what sorts of resources were configured and active (email, calendar, TODO..) this would really help. -- Aaron J. Seigo

Re: Panel desktop scripting

2013-11-18 Thread Aaron J. Seigo
On Saturday, November 16, 2013 20:10:13 Eike Hein wrote: Thoughts on a clean(er) fix? call flushPendingConstraintsEvents this kind of use case is exactly why it is a public slot :) -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Panel desktop scripting

2013-11-18 Thread Aaron J. Seigo
On Tuesday, November 19, 2013 00:06:11 Eike Hein wrote: On Monday 18 November 2013 16:49:57 Aaron J. Seigo wrote: call flushPendingConstraintsEvents this kind of use case is exactly why it is a public slot :) Thanks, I missed that bit of API :) i carefully hid it ;) I've added

Re: Semi-modal sidebar paradigm

2013-11-05 Thread Aaron J. Seigo
. would be very interesting to know how it feels in practice. i’ve got mockups that show such a thing, but you never really can tell until you feel it in practice. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Semi-modal sidebar paradigm

2013-11-05 Thread Aaron J. Seigo
, then the contents of the picker will almost certainly need to be adjusted. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: Move Session Switching to the Display Manager

2013-11-05 Thread Aaron J. Seigo
On Tuesday, November 5, 2013 20:57:29 David Edmundson wrote: One of the goals of the Look and Feel package is to make all session related things consistent, given we're talking about depending on functionality in the DM can I propose we move session switching there too. +1 -- Aaron J. Seigo

Re: minutes Monday Plasma hangout

2013-11-04 Thread Aaron J. Seigo
if there is needed DBus communication I’m sure we can continue that trend. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: minutes Monday Plasma hangout

2013-11-04 Thread Aaron J. Seigo
On Monday, November 4, 2013 15:21:27 Martin Klapetek wrote: On Mon, Nov 4, 2013 at 3:04 PM, Aaron J. Seigo ase...@kde.org wrote: On Monday, November 4, 2013 13:19:37 Martin Klapetek wrote: On Mon, Nov 4, 2013 at 1:06 PM, Sebastian Kügler se...@kde.org wrote: and means more maintenance

Re: minutes Monday Plasma hangout

2013-11-04 Thread Aaron J. Seigo
for that, so soon, soon! -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Semi-modal sidebar paradigm

2013-11-04 Thread Aaron J. Seigo
to be uncomfortable visually / workflow-wise, then perhaps we could at least borrow the drawer visuals from PA for these overlays? -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Semi-modal sidebar paradigm

2013-11-04 Thread Aaron J. Seigo
kwin could have a desktop effect that takes these windows and Adds Awesome(tm). the only reason it makes sense to think about this *now* rather than later is that kwin would then need a way to identify such windows. -- Aaron J. Seigo ___ Plasma-devel

Re: QML and IOJOb

2013-11-03 Thread Aaron J. Seigo
access I/O stile write? no. the save dialog is there to give destinations to things that do (e.g. http requests) -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: on Activities on Plasma2

2013-10-30 Thread Aaron J. Seigo
multiple screens in a presentation mode (e.g. not clone), and the desktop shell can put some relevant applications (e.g. presentation apps) on the panel/desktop. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: on Activities on Plasma2

2013-10-30 Thread Aaron J. Seigo
. without a thorough examination, my initial thought is “key/value store please and yes, i agree with you that a uniform API is probably best in this case. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Bookmarked activities (OT: Activities on Plasma2)

2013-10-30 Thread Aaron J. Seigo
activities” isn’t it. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

plasma 2 coordination meeting

2013-10-29 Thread Aaron J. Seigo
management framework that ties the above three things together * possibilities for Tokamak.next() it’s only 5 points, but that’s probably 2 hours right there. tea, coffee and snacks at hand recommended ;) -- Aaron J. Seigo ___ Plasma-devel mailing list

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-27 Thread Aaron J. Seigo
an application API POV. - Aaron J. Seigo On Oct. 27, 2013, 12:19 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113447

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Aaron J. Seigo
that should be fixed before pushing. cheers .. plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml http://git.reviewboard.kde.org/r/113471/#comment30810 missing {}s (even one-liners get them) - Aaron J. Seigo On Oct. 27, 2013, 10:36 a.m

Re: Review Request 113443: Attempt to unbreak pre-configuring QML applets via desktop scripting

2013-10-26 Thread Aaron J. Seigo
are getting lost as a result. note that KConfig::reparseConfiguration() does this: if (!d-isReadOnly() d-bDirty) sync(); so that sync() is already happening if it is dirty. which also really sucks imho. kconfig in general is full of such really non-optimal things. - Aaron J. Seigo

Re: Revamping KSplash KCM

2013-10-26 Thread Aaron J. Seigo
is happening is a non-coordinated “port all the codes!” effort and that will result in a lot of wasted effort, not to mention an end result that does not resemble something better, which is the goal (i hope you’ll all agree) -- Aaron J. Seigo ___ Plasma

a much needed plasma2 coordination meeting

2013-10-26 Thread Aaron J. Seigo
. http://doodle.com/3ayqx3byxnivracm -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Keep the Things You Forgot

2013-10-22 Thread Aaron J. Seigo
remind others to believe as much as we do in the things we’re doing. love ‘n hugs to you all ... -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Activities in Plasma2

2013-10-21 Thread Aaron J. Seigo
and quality that would result. activities are considered a core feature, and will remain that way. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Removing kcontrol/screensaver

2013-10-19 Thread Aaron J. Seigo
, now i understand! thanks ... and in that case - a big +1. that module is pretty .. bad. too much baggage over too many years. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Removing kcontrol/smartcard

2013-10-18 Thread Aaron J. Seigo
are no longer fit to even use as starting points. too much time and too many changes to how technology works have passed in most cases. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Can we drop kcontrol/workspaceoptions?

2013-10-18 Thread Aaron J. Seigo
On Friday, October 18, 2013 17:08:41 Kai Uwe Broulik wrote: which sometimes don't go away properly which is a problem with event handling in QGraphicsView. it’s also why widget handles on the desktop don’t always disappear when they should, btw. -- Aaron J. Seigo

Re: Can we drop kcontrol/workspaceoptions?

2013-10-18 Thread Aaron J. Seigo
for the first release the latter is probably the most sensible. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Removing kcontrol/screensaver

2013-10-18 Thread Aaron J. Seigo
they are for? and yes, you will bring fire down on your head by removing those settings. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Removing kcontrol/screensaver

2013-10-18 Thread Aaron J. Seigo
On Friday, October 18, 2013 17:52:55 Marco Martin wrote: On Fri, Oct 18, 2013 at 5:37 PM, Aaron J. Seigo ase...@kde.org wrote: or ... does nobody know what they are for? and yes, you will bring fire down on your head by removing those settings. been there, done that... yep, i confirm

  1   2   3   4   5   6   7   8   9   10   >