D15683: Add lock icon to desktop context menu

anemeth added a comment. My arcanist is still borked. Could someone please push this? Thank you. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D15683: Add lock icon to context menu

anemeth created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 AFFECTED FILES

D15435: Add translucent background attribute to desktop icon popup menu

anemeth added a comment. I'm having problems with my arcanist. Could someone please land this for me? REPOSITORY R119 Plasma Desktop BRANCH fix_desktop_menu_tp REVISION DETAIL https://phabricator.kde.org/D15435 To: anemeth, hein, davidedmundson, #plasma Cc: ngraham, plasma-devel,

D15435: Add translucent background attribute to popup menu

anemeth updated this revision to Diff 41432. anemeth added a comment. Add translucent background attribute to popup menu REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15435?vs=41431=41432 BRANCH fix_desktop_menu_tp REVISION DETAIL

D15435: Add translucent background attribute to popup menu

anemeth created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH fix_desktop_menu_tp REVISION DETAIL https://phabricator.kde.org/D15435 AFFECTED FILES

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. F6100511: breeze2x.PNG REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12804 To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel,

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. As others said the dpi scaling should normally be dealt with `QImage::setDevicePixelRatio()` As far as I can tell this is not working with Breeze for the following reason: The decoration rendering starts here:

D12804: Fix window frame rounding when scaling is used

anemeth updated this revision to Diff 37718. anemeth added a comment. Rebase on master REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12804?vs=33941=37718 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12804 AFFECTED FILES

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. Here is Breeze close button modified to use `QPainter::drawRoundedRect()` and uses the same radius (3) as the titlebar: F5848210: aa.PNG This scales well, so I don't think it is a bug in Qt. REPOSITORY R31 Breeze

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. In D12804#262333 , @zzag wrote: > Also, what session it is? (X11 or Wayland) > > I think you're facing one of X11 issues. X11 On Wayland it scales right REPOSITORY R31 Breeze REVISION DETAIL

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. In D12804#260610 , @hpereiradacosta wrote: > Also: how does it work with multiple monitors ? (I see you get the info from ::primaryScreen, not for the screen the window is actually on ? As far as I know KWin

D12804: Fix window frame rounding when scaling is used

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R31 Breeze BRANCH titlebar-round-scaling (branched from master) REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. In D9848#234268 , @zzag wrote: > > `GLRenderTarget::attachTexture` This was not changed. It was used by old blur and simple blur. Looks like it's not used anymore. >

D10878: Changed default context menu entries on the desktop

anemeth abandoned this revision. anemeth added a comment. This is not removing settings, just disabling them by default. These could be enabled in the standard right click menu settings again. F5732210: Képkivágás.PNG I'll abandon this revision

D10878: Changed default context menu entries on the desktop

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Plasma, VDG. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10878 To: anemeth, #plasma, #vdg Cc: plasma-devel, ZrenBot, lesliezhai,

D10878: Changed default context menu entries on the desktop

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10878 AFFECTED

D10837: bad textarea width for rename file if filename too short

anemeth added a comment. works great REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10522: Added vertical separator

anemeth abandoned this revision. anemeth added a comment. This change was submitted to supplement D10438 Because it was reverted in D10530 this change is not needed anymore. REPOSITORY R31 Breeze REVISION DETAIL

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. @hpereiradacosta I don't have commit access. Could you please commit it for me? REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts,

D10522: Added vertical separator

anemeth added a comment. The best looking solution would be that menu entries that have checkbox/radiobutton, do not get an icon and then we can show the icon and the checkbox/radiobutton on the left column. Like you see in the Windows 7 pic in the test plan. Or maybe I'm just used to

D10522: Added vertical separator

anemeth updated this revision to Diff 27202. anemeth added a comment. Reduced the width of the horizontal line so it doesn't intersect with the vertical line. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10522?vs=27201=27202 BRANCH master REVISION

D10522: Added vertical separator

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: ngraham, hpereiradacosta, Breeze, VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10522 To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg Cc:

D10522: Added vertical separator

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10522 AFFECTED FILES

D10521: Accidental diff. Sorry.

anemeth removed R31 Breeze as the repository for this revision. anemeth removed a project: Plasma. anemeth removed a subscriber: plasma-devel. REVISION DETAIL https://phabricator.kde.org/D10521 To: anemeth Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10521: Accidental diff. Sorry.

anemeth retitled this revision from "Added vertical separator" to "Accidental diff. Sorry.". REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10521 To: anemeth Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10521: Accidental diff. Sorry.

anemeth abandoned this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10521 To: anemeth Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10521: Added vertical separator

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10521 AFFECTED FILES

D10500: Make the review pop-up a bit more user-friendly

anemeth added a comment. What purpose does the empty space serve? If it has no purpose then the Review textbox could be larger or the window smaller. F5711965: review,_empty.png REPOSITORY R134 Discover Software Store REVISION DETAIL

D10438: reserve space for checkable widgets in menu items

anemeth added a comment. Maybe you could align the checkbox better? The numbers are pixels F5708060: a.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta

D10438: reserve space for checkable widgets in menu items

anemeth added a comment. In D10438#205119 , @zzag wrote: > In D10438#205118 , @anemeth wrote: > > > @zzag Did you accidentally removed the changes in breeze.h and breezestyle.h? :) > > > Yes.

D10438: increase left/right margin of menuitems

anemeth added a comment. @zzag Did you accidentally removed the changes in breeze.h and breezestyle.h? :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz, fabianr, mmustac, abetts, anemeth,

D10438: increase left/right margin of menuitems

anemeth added a comment. In D10438#205042 , @zzag wrote: > Did you change the left margin? Could you please test the left margin with values 20/24/28 and pick the best one? I didn't change the margins previously, only applied the patch.

D10438: increase left/right margin of menuitems

anemeth added a comment. In D10438#205005 , @abetts wrote: > Are we thinking we should/not use icons in menus, keep the same? Looks quite good in my opinion with this patch applied and no icons F5707729: .PNG

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In D10170#205000 , @hpereiradacosta wrote: > Can you post an updated screenshot about the configuration option, and can we get VDG's opinion on it ? This is how it looks now F5707716: cvb.PNG

D10170: Added optional transparency/blur to menu frames

anemeth marked 4 inline comments as done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 27010. anemeth added a comment. Removed the _helper variable from the breezeblurhelper class REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=27008=27010 BRANCH master REVISION DETAIL

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In D10170#204889 , @hpereiradacosta wrote: > Also, for the config ui, maybe it makes more sense to call the "Transparency" tab, only "Menus" and change "Menu:" into "Transparency:" > Unless of course one wants to add

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 27008. anemeth added a comment. Simplified the breezeblurhelper class REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26814=27008 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED

D10170: Added optional transparency/blur to menu frames

anemeth marked an inline comment as done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10438: increase left/right margin of menuitems

anemeth added a comment. In D10438#204922 , @zzag wrote: > Just to clarify that other DE and OS have some space on the left side: > > - Windows: https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.png >

D10438: increase left/right margin of menuitems

anemeth added a comment. How does it look when a menu has a checkbox on it, for example the 'View' menu on Konsole F5705719: Screenshot_20180212_011947.png What other DE or OS that you used has such a wide menu that it feels natural to you?

D10429: Disable the title bar separator by default

anemeth added a comment. Strawpoll linked from this reddit post : http://www.strawpoll.me/15036330/r Looks like the majority does not like the separator. REPOSITORY R31 Breeze REVISION

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26814. anemeth added a comment. Fixed a visual glitch when using a scaled display REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26658=26814 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170

D10170: Added optional transparency/blur to menu frames

anemeth marked 2 inline comments as done. anemeth added a comment. KDE4 Breeze has no trasnparency and blur anymore REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar,

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26658. anemeth added a comment. Implemented the changes suggested by @hpereiradacosta Only KDE5 Breeze has transparency and blur now REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26407=26658 BRANCH master

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26407. anemeth added a comment. Added breezeblurhelper files REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26406=26407 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED FILES

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26406. anemeth added a comment. Moved blur handling to breezeblurhelper REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26329=26406 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED

D10170: Added optional transparency/blur to menu frames

anemeth marked 4 inline comments as done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26329. anemeth added a comment. Now only enabled blur when the frame is transparent. @hpereiradacosta drawPanelMenuPrimitive only runs once per panel creation and not 60 times per second, right? This is what enabled blur behind a window:

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In https://phabricator.kde.org/D10170#198972, @hpereiradacosta wrote: > IMHO this change somewhat muddies Breeze's identity (flat and simple, not bloated) for no real gain. This said, I do appreciate your work. The exact opposite. By default the Breeze

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. Just to show you how it looks compared to something that is generally considered good design: Deepin I choose the same wallpaper and menu locations. I tested it with 30% and 40% transparency and 10/15 blur strength (that is likely going to be the new default).

D10181: Removed the "fastblur" path

anemeth updated this revision to Diff 26279. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Undone unrelated change REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10181?vs=26181=26279 BRANCH master REVISION

D10181: Removed the "fastblur" path

anemeth marked an inline comment as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff,

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26278. anemeth added a comment. . REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26160=26278 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED FILES kstyle/breeze.kcfg

D10170: Added optional transparency/blur to menu frames

anemeth added inline comments. INLINE COMMENTS > zzag wrote in breezestyle.cpp:3630 > buggy.. > > `background.setAlphaF(StyleConfigData::menuTransparency() / 100.0f);` The slider has 10 steps and goes from 0 to 10, that's why it's `/ 10.0` 100 steps would be too much in my opinion. And we

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In https://phabricator.kde.org/D10170#197849, @zzag wrote: > In https://phabricator.kde.org/D10170#197845, @anemeth wrote: > > > I presume you mean the Background contrast effect. It was in the half-enabled state. I checked it to be fully enabled but I did

D10170: Added optional transparency/blur to menu frames

anemeth added inline comments. INLINE COMMENTS > zzag wrote in breeze.kcfg:188 > Redundant comment. What's redundant about it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: zzag, ngraham, plasma-devel, ZrenBot,

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In https://phabricator.kde.org/D10170#197812, @zzag wrote: > Looks great! > > BUT, it would be nice to have a little bit bigger contrast. Could you please enable background contrast and upload a screenshot what it looks like? I presume you mean the

D10181: Removed the "fastblur" path

anemeth edited the summary of this revision. anemeth added reviewers: graesslin, KWin, Plasma. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application added a subscriber: plasma-devel. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181

D10170: Added optional transparency/blur to menu frames

anemeth added a project: Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

anemeth retitled this revision from "Added transparency/blur to menu frames" to "Added optional transparency/blur to menu frames". REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff,

D10170: Added transparency/blur to menu frames

anemeth edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10170: Added transparency/blur to menu frames

anemeth edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10170: Added transparency/blur to menu frames

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: hpereiradacosta, Plasma, VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: plasma-devel, ZrenBot,

D10170: Added transparency/blur to menu frames

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED FILES

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#196036, @zzag wrote: > File mode bits are slightly off. Fixed in https://phabricator.kde.org/D10100 REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25948. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Rebased to master. There was a conflict with https://phabricator.kde.org/D9879 This change reverts those changes since it is superseded by this change

D10027: Removed duplicate preview screenshots

anemeth added a comment. I don't think I have push access. Can you do it instead? REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10027 To: anemeth, apol, #discover_software_store, davidedmundson, abetts Cc: ngraham, plasma-devel,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked an inline comment as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25782. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Implemented the change suggested by @fredrik REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25720=25782 BRANCH

D10027: Removed duplicate preview screenshots

anemeth updated this revision to Diff 25776. anemeth added a comment. Checking for duplicate now added to appendIfValid() instead REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10027?vs=25774=25776 BRANCH master REVISION DETAIL

D10028: Checking for duplicate now added to appendIfValid() instead

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10028

D10027: Removed duplicate preview screenshots

anemeth updated this revision to Diff 25774. anemeth added a comment. Now I see what you mean. :) That makes it a lot smaller. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10027?vs=25773=25774 BRANCH master REVISION DETAIL

D10027: Removed duplicate preview screenshots

anemeth added a comment. In https://phabricator.kde.org/D10027#194443, @apol wrote: > Please modify appendIfValid to not add duplicates. What do you mean? In what situation would it add duplicates? This change is to make sure it does not add duplicates. REPOSITORY R134

D10027: Removed duplicate preview screenshots

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: apol, Discover Software Store. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10027 To: anemeth, apol, #discover_software_store Cc:

D10027: Removed duplicate preview screenshots

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10027

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fredrik wrote in blur.cpp:255 > Does calling effects->addRepaintFull() also work? It does. Changed to that. REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25720. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Implemented the changes suggested by @fredrik REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25643=25720 BRANCH

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 3 inline comments as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190176, @graesslin wrote: > I would like to see this reviewed by @fredrik, @mart , @davidedmundson and in general the https://phabricator.kde.org/tag/vdg/

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25643. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Moved a shader variable to a uniform, so that the calculation can be done on the CPU instead. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25638. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fixed a bug where updating the blur strength would not update the blurred area. With this fix every window gets updated when the blur strength is

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > anemeth wrote in blur.cpp:145 > I checked if I have these extensions. Just to make sure it works I included > another extension I know my card supports. > >

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fredrik wrote in blur.cpp:145 > Okay, I see what you mean. I think this is a trade-off between two > undesirable effects though, because the clamping causes abrupt changes near

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#193152, @davidedmundson wrote: > Changing the blur size at runtime didn't seem to have an effect, it all worked after kwin restart. > Your code looks fine,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 2 inline comments as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25615. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updated the blur amount value configuration to use less magically numbers and added an explanation comment. This new method creates an evenly distributed

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 6 inline comments as done. anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > romangg wrote in blur.cpp:152 > I think 5 blur strength steps to select from is fine, if that means we can > get rid off the magic

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25596. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Made the changes that were suggested by @frederik Now only the taskbar doesn't have the extended blur effect. REPOSITORY R108 KWin CHANGES SINCE LAST

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25551. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. With one of my previous changes I accidentally introduced an extended blur effect. Not it's corrected. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25511. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added the .arcconfig file REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25504=25511 BRANCH master REVISION

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked an inline comment as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25504. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added a new function to GLRenderTarget called `setRenderTargets` With this function I implemented the changes suggested by @fredrik to remove unnecessary

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 13 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25490. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added a new constructor to GLRenderTarget Added a new function `detachTexture()` to GLRenderTarget Implemented most of the changes suggested by @fredrik

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fredrik wrote in blur.cpp:145 > Why is this needed? > > I'm probably missing something here, but it looks to me as if the effect > copies the contents of the framebuffer to the

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > fredrik wrote in blur.h:41 > This number could use an explanation. I don't know why it's 5 This was in the old blur too:

D9879: [effects/blur] Disable texture cache on Wayland

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. This change will be superseded by: https://phabricator.kde.org/D9848 I just removed the caching blur altogether. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9879 To:

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25436. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Removed the option the cache blur. The reason was that since it was disabled in wayland (https://phabricator.kde.org/D9879) because it does not work

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#191008, @zzag wrote: > In https://phabricator.kde.org/D9848#190964, @luebking wrote: > > > I'm not actually smiling ... > > > > Anyway, instead of

  1   2   >