D24371: [KCM] Make the warning message wider

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Makes a lot of sense and looks visually good in the screenshot. I'm taking the liberty to give a +2. REPOSITORY R104 KScreen BRANCH wide-message (branched from master) REVISION

D24370: [KCM] Display scale factor as a percentage, not a decimal

dhaumann added a comment. +1. This is also in line with typical zoom factors in other applications such as Okular, which also use percent values. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24370 To: ngraham, #vdg, #plasma, romangg Cc: dhaumann, plasma-devel,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

dhaumann added a comment. Thanks Nate for the update, I think this is very transparent to users and makes using bad values by default a bit hardet. +1 for the patch. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

dhaumann added a comment. As far as I understand, the reasoning of @cullmann is that 0.1 cannot be accurately be represented by a computer. Following this discussion , the

Re: CI system maintainability

Kevin Ottens schrieb am Do., 28. März 2019, 09:29: > Hello, > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > Please note that the commits in this instance were pushed without > > review, so restrictions on merge requests wouldn't make a difference > > in this case

D14855: Add applet with screen layouts and presentation mode

dhaumann added a comment. @broulik Could we clarify the copyright? INLINE COMMENTS > kscreenapplet.h:3-4 > + * Copyright (c) 2018 Kai Uwe Broulik > + *Work sponsored by the LiMux project of > + *the city of Munich. > + * Hi Kai. Imo this copyright is

D7087: Add "Copy Info" button to the About System KCM

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Ok from my side, although it still *feels* a bit messy :-) - please consider using QVector before committing - possibly fix the "Distro" thing, if applicable INLINE COMMENTS >

D7087: Add "Copy Info" button to the About System KCM

dhaumann added a comment. Looks pretty good to me already. Is there anything that needs to be addressed? What do you think about i18nc? INLINE COMMENTS > rkflx wrote in Module.cpp:253 > @dhaumann I wonder why you suggested to use `i18n` here too, as `text()` > should already give you the

D12835: Draw borders around side panels by default

dhaumann added a comment. I as someone being around for 15 years now also immediately thought "huh? Why this forth and back and forth..."? I believe you need much more investigation here and discussion with the visual design group, maybe a blog asking about what people like more.

D11559: Fix default colour used by Swap monitor

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. An obvious typo. Thanks for this fix! PS: A Screenshot would have been nice, though :-) REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL

D7087: Add "Copy Info" button to the About System KCM

dhaumann added a comment. One small suggestion to improve the clipboard code. INLINE COMMENTS > Module.cpp:256 > +{ > +auto clipboard = QGuiApplication::clipboard(); > +QMapIterator i(collectedData); Nitpicking: Why do you declare the clipboard here, when you use

D7087: Add "Copy Info" button to the About System KCM

dhaumann added a comment. Thinking about it, what about this: The dialog already has all the QLabels. What you could do is something along the lines: QString text; if (!ui->plasma.text().isEmpty()) { text += i18n("%1: %2", ui->plasmaLabel, ui->plasma.text()); } if

D7087: Add "Copy Info" button to the About System KCM

dhaumann added a comment. I can see the reason for English text only. Then again, I think that @rkflx has a very valid argument as well. I do not know any other place in KDE that intentionally uses non-translatable text. That's why I agree with @rkflx to better translate this. In fact,

D7087: Add "Copy Info" button to the About System KCM

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Translation is not yet working correctly, see above comment. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham,

D7087: Add "Copy Info" button to the About System KCM

dhaumann added a comment. All the keys in collectedData are not properly translated. As such, creating a final string out of this is not translation friendly. Given you seem to know exactly what data is going to be exported, you could also create a small helper class that gets filled.

D5034: Add support for x-gvfs style options in fstab

dhaumann added a comment. @broulik Ping. Is there anything that keeps you from submitting this? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D5034 To: broulik, #plasma, dhaumann, dfaure Cc: bruns, dhaumann, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)

https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #7 from Dominik Haumann <dhaum...@kde.org> --- @James: You have to create a patch at phabricator.kde.org (make an account at identity.kde.org first). Then, you patch is much more visible to developers. -- You are receiving thi

D5077: Port Kate Sessions Runner

dhaumann accepted this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D5077 To: broulik, #plasma, dhaumann, cullmann, mart Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5034: Add support for x-gvfs style options in fstab

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. The patch looks good to me (without testing this locally here). I think the one QStringRef can be turned by to QStringList, since you finally need the QString anyways it seems...

D5034: Add support for x-gvfs style options in fstab

dhaumann added a comment. Just some minor comments, besides that, looks sane. INLINE COMMENTS > fstabdevice.cpp:40-41 > +if (m_device.startsWith(QLatin1String("//"))) { > +m_vendor = m_device.mid(2, m_device.indexOf(QLatin1String("/"), 2) - > 2); > +m_product =

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

=1420501=kdeplasma-addons - Dominik Haumann On Feb. 5, 2017, 6:11 p.m., Pascal VITOUX wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

n any case. - Dominik Haumann On Feb. 4, 2017, 12:03 a.m., Pascal VITOUX wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

[Differential] [Commented On] D1816: Switch to Hack as default monospace font

dhaumann added a comment. Is this still an open issue or can this be closed? REVISION DETAIL https://phabricator.kde.org/D1816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, #plasma, #plasma:_design, dhaumann Cc: sebas, mak, jensreuterberg,

Re: Scrap Baloo Thread Feedback

Hi all, CC: plasma-devel, due to stability issues On Fri, Oct 7, 2016 at 5:56 PM, Christoph Cullmann wrote: > Hi, > [...] > Actually, the bugs.kde.org page tells you the facts: The bug number > was constant increasing since > 1 year. The thread lists some other facts > what

Re: Taking over maintainership of Baloo

Hi, indeed I also did take a look at the bug list, and out of the 200 bugs, without much exaggeration almost all of them are crashes. In fact, I believe it's important to CC the plasma-devel mailing list here: Given we are about to release a LTS Plasma 5.8, and baloo is tightly integrated into

[Differential] [Updated] D1816: Switch to Hack as default monospace font

dhaumann added a comment. Yes, the font faces are all there, so HACK does qualify. On a personal note, I think the 'i' looks a bit strange, but that's probably to distinguish it form better form a 'j'. Here, to my eyes, the 'i' from the Source Code Pro font looks better, but given I did

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

dhaumann added a comment. Or what about the Source Code Pro font? https://en.wikipedia.org/wiki/Source_Code_Pro REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1816 EMAIL PREFERENCES

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

dhaumann added a comment. Hm, that doesn't sound as if the problem will solved within the next weeks. I personally am using Bitstream Vera Sans Mono [1] in Kate. I don't know about its completeness, though. It is often said that the DejaVu fonts [2] extend the Bitstream Vera fonts and

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

dhaumann added a comment. Maybe I should have added: Since you already contacted the Noto devs on the googlegroup, can you also ask whether a bold-face variant and italic variant exists? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

dhaumann added a comment. It's important to chime in here. There is a huge issue with fonts in general, that do not provide all font faces. What we need is: regular (sometimes called roman?), bold, italic (sometimes called oblique), and bold italic (4 flavours in total). As

Re: Review Request 127549: const

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127549/#review94203 --- Ship it! Looks good to me. - Dominik Haumann On April

Re: kio-mtp

On Thu, Mar 31, 2016 at 1:32 PM, Marco Martin <notm...@gmail.com> wrote: > On Thursday 31 March 2016, Dominik Haumann wrote: >> > Still, if you get regressions with respect to pluggable mtp devices, >> > please let me know. >> >> Again me ;) >> &g

Re: kio-mtp

On Thu, Mar 31, 2016 at 1:01 PM, Dominik Haumann <dhaum...@kde.org> wrote: > On Thu, Mar 31, 2016 at 12:55 PM, Marco Martin <notm...@gmail.com> wrote: >> On Thursday 31 March 2016, Dominik Haumann wrote: >> >>> Since the 16.04 release is about to happen, can we

Re: kio-mtp

On Thu, Mar 31, 2016 at 12:55 PM, Marco Martin <notm...@gmail.com> wrote: > On Thursday 31 March 2016, Dominik Haumann wrote: > >> Since the 16.04 release is about to happen, can we still get this >> change committed? For close to two weeks I got no reply/review. >>

kio-mtp

Hi all, I'm writing to this list, since the kio-mtp slave most certainly affects the experience of KDE Plasma5 users. In https://git.reviewboard.kde.org/r/127386/ I found out that the kio-mtp slave uses libmtp in a wrong way, namely it uses LIBMTP_Check_Specific_Device() for every device before

QML Units

Hi everyone, on qt-devel there currently is a discussion about units for QML (think of width: 3cm) and similar techniques (thread titles are "Units in QML" and "Scalable UIs in QtQuick"). The idea of using grid units was also once raised in the threads. If I understand correctly, Plasma also

Re: Disk Quota Applet: Icon sizes

). Btw, with regard to dependencies: There are no compile-time dependencies. The only runtime dependency to make it useful is the `quota` command line tool. Cheers, Dominik > thanks > Andreas > > 2016-02-15 20:59 GMT+01:00 Dominik Haumann <dhaum...@kde.org>: >> >>

Re: Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

nerated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127083/#review92416 --- On Feb. 15, 2016, 9:07 p.m., Dominik Haumann wrote: > > --- > This is an automaticall

Re: Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

ontents/ui/main.qml c749c8b Diff: https://git.reviewboard.kde.org/r/127083/diff/ Testing --- Compiles and works as expected, tested with plasma development version. Thanks, Dominik Haumann ___ Plasma-devel mailing list Plasma-devel@kde

Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

Compiles and works as expected, tested with plasma development version. Thanks, Dominik Haumann ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Disk Quota Applet: Icon sizes

Hi all, the disk quota applet's icons are still too big, see http://i.imgur.com/cBVPXuu.png At Akademy 2015, I was asking some developers what do do about it, but noone could give me hint. Since these icons are *really* too big, I think we should do something about it at least now. Obviously

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 > > Dominik Haumann wrote: > Thanks for the bump, I will have some time next weekend, will go over the > reviews again and then

Re: Review Request 124589: Add Disk Quota Plasmoid

a QAbstractItemModel derived class, so inserting/removing quotas all works (tested). - filelight installed: the item under mouse gets highlighted. If clicked, filelight starts with the correct location. Thanks, Dominik Haumann ___ Plasma-devel maili

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 > > Dominik Haumann wrote: > Thanks for the bump, I will have some time next weekend, will go over the > reviews again and then

Re: Review Request 124589: Add Disk Quota Plasmoid

-- On Aug. 3, 2015, 5:34 p.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124589/ > --

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83498 --- On Aug. 3, 2015, 5:34 p.m., Dominik Haumann wrote

Re: Review Request 124589: Add Disk Quota Plasmoid

the plasmoid tooltip Dominik Haumann wrote: Really? Then, if the users installs 'quota', nothing happens. The user needs to remove/add the plasmoid in order to get it working (or worse, logout/login). That might lead to some confusion. I'd prefer the current solution, OK? David Edmundson

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review8 --- On Aug. 2, 2015, 2:06 p.m., Dominik Haumann wrote

Re: Review Request 124589: Add Disk Quota Plasmoid

(tested). - filelight installed: the item under mouse gets highlighted. If clicked, filelight starts with the correct location. Thanks, Dominik Haumann ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124589: Add Disk Quota Plasmoid

highlighted. If clicked, filelight starts with the correct location. Thanks, Dominik Haumann ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124589: Add Disk Quota Plasmoid

, filelight starts with the correct location. Thanks, Dominik Haumann ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124589: Add Disk Quota Plasmoid

are in a QAbstractItemModel derived class, so inserting/removing quotas all works (tested). - filelight installed: the item under mouse gets highlighted. If clicked, filelight starts with the correct location. Thanks, Dominik Haumann ___ Plasma-devel mailing list

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83321 --- On Aug. 2, 2015, 1:59 p.m., Dominik Haumann wrote

Re: Review Request 124589: Add Disk Quota Plasmoid

mouse gets highlighted. If clicked, filelight starts with the correct location. Thanks, Dominik Haumann ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

://git.reviewboard.kde.org/r/120110/#comment46137 Please fix the spaces. - Dominik Haumann On Sept. 9, 2014, 8:15 a.m., Joseph Wenninger wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)

https://bugs.kde.org/show_bug.cgi?id=158379 Dominik Haumann dhaum...@kde.org changed: What|Removed |Added Component|part|general Product

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

March 25, 2014, 10:24 p.m.) Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan Čukić. Repository: kdeplasma-addons Description --- Summary --- Add two options: 1. Show confirmation before sending (to prevent accidental sending of maybe sensible

Re: Plasma as a knotify backend bug?

On Wednesday, May 12, 2010, Ivo Anjo wrote: After testing it, it's perfect now, thanks! Screenshot: [image: freespacenotifier-plasma-fixed.png] Just some ideas: - open filelight if installed - open konqueror in fsview both apps provide a view that graphically shows the sizes of folders and

Re: dropping content onto Plasma

On Tuesday 24 March 2009, Sebastian Kügler wrote: The short version Is there a way to offer plasma applet creation based on mimetypes of content dropped onto Plasma also for URLS? [...] I'd like to have this fine mechanism also working URLs and be a bit smarter about that. I'm not sure

Re: System Load Viewer in kdereview (done)

On Tuesday 03 March 2009, Aaron J. Seigo wrote: On Tuesday 03 March 2009, Dominik Haumann wrote: Hi, the System Load Viewer plugin [1] is in kdereview for quite some time now and I wanted to ask for feedback as the plan is to move it to kdeplasma- addons for KDE 4.3 provided

Re: Review Request: Add fade effect to wallpaper plugin.

On Tuesday 03 March 2009, Aaron J. Seigo wrote: On Monday 02 March 2009, Dominik Haumann wrote: @Crossfade effect: maybe also the type of the easein/out, but that's probably already included in the timeelapse parameter. what would be the use case for ease in vs ease out? (not that it's

System Load Viewer in kdereview

Hi, the System Load Viewer plugin [1] is in kdereview for quite some time now and I wanted to ask for feedback as the plan is to move it to kdeplasma- addons for KDE 4.3 provided there are no objections. The plugin itself ships with the same featues as the System Monitor in KDE3 plus some more

Re: Review Request: Add fade effect to wallpaper plugin.

[...] Also the PictureFrame plasmoid comes to my mind here. A fade effect would be very nice as well and is the same code. Can it be shared somehow? this sort of thing really belongs in Animator or its successor; this needs to become a set of standardized effects that we can implement

Re: Review Request: Add fade effect to wallpaper plugin.

On Thursday 26 February 2009, Artur de Souza (MoRpHeUz) wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/195/#review287 ---

Re: Version Number from .desktop

On Friday 30 January 2009, Aaron J. Seigo wrote: On Friday 30 January 2009, David Baron wrote: For the same reason I might want to display the name(), i.e. in an about box or other UI feature that would carry such information. this should not be done per applet, otherwise we get a bunch of

Re: Ruby Plasma Tutorial

On Sunday 18 January 2009, Aaron J. Seigo wrote: On Sunday 18 January 2009, Niels Slot wrote: In the last week I've written a Plasma tutorial for Ruby. In the tutorial the reader creates a simple but functional applet using widgets and Ruby. I've put it on a personal subpage on Techbase[1].

Re: Python tutorial page on TechBase

On Saturday 17 January 2009, Luca Beltrame wrote: Hello Plasma team, for reference, I have created a page on TechBase that deals with writing applets in Python[1]. It's currently very empty, but I plan on adding more stuff soon, hopefully,. My idea would be to show how to create applets in

Re: Python tutorial page on TechBase

On Saturday 17 January 2009, Luca Beltrame wrote: On Saturday 17 January 2009 15:38:24 Dominik Haumann wrote: Can you integrate or move over the content from pate + discussion page http://techbase.kde.org/Talk:Paths/Developer/Creating_plasmoids_with_sc ript Sime from IRC (#plasma) did most

Re: [Kourse 3] Fixing krazy2 issues

Hi Philipp, On Thursday 15 January 2009, Philipp Klaffert wrote: @@ -54,7 +53,7 @@ return true; } -if (!name.startsWith(Timeline:) !name.startsWith(TimelineWithFriends:) !name.startsWith(Profile:)) { +if (!name.startsWith(QString(Timeline:))

Re: Review Request: Add the ability for applets to change autohide timeout value

On Saturday 10 January 2009, Aaron J. Seigo wrote: On Friday 09 January 2009, Matthew Dawson wrote: Currently if you update the tooltip's content faster then three seconds, the tooltip will never autohide. This occurs because the timer counting the three seconds resets when data is

Re: Review Request: Add the ability for applets to change autohide timeout value

On Saturday 10 January 2009, Chani wrote: so what is the use case for hiding a tooltip where the data is changing? snip So sometimes the autohide does not work. I was able to reproduce this like this: I hvae two instances of the systemloadviewer side by side. - hover over plasmoid1

systemmonitor data engine: memory usage? (was: Re: System Monitor)

Huhu, On Tuesday 23 December 2008, Aaron J. Seigo wrote: On Tuesday 23 December 2008, Dominik Haumann wrote: into my mind are System Status, System Load Watcher, System Load Viewer, TimeMon, System Essentials, System Usage, ... System Load Viewer is quite straight forward and says it all

Re: systemmonitor data engine: memory usage? (was: Re: System Monitor)

On Friday 26 December 2008, Aaron J. Seigo wrote: On Friday 26 December 2008, Dominik Haumann wrote: Huhu, On Tuesday 23 December 2008, Aaron J. Seigo wrote: On Tuesday 23 December 2008, Dominik Haumann wrote: into my mind are System Status, System Load Watcher, System Load

Re: System Monitor

On Wednesday 10 December 2008, Aaron J. Seigo wrote: On Wednesday 10 December 2008, Dominik Haumann wrote: So does it make sense to remove the data engines of [1] and [2] and try to implement the applet by just using the above? i think so, yes.. the bonus

System Monitor

Hi, some months ago I blogged about KDE3's system monitor applet ported to plasma [1]. It provides a data engine and an applet. The data engine is more or less just the code taken from KDE3, i.e. it supports more than just e.g. /proc/cpuinfo depending on the OS. So I'd expect it to work in KDE4