Re: Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Wed, May 2, 2012 at 5:47 AM, Sebastian Kügler wrote: > > Congrats, Viranch! You've done some excellent work here and delivered high- > quality replacements for those important components. > > Thanks a lot, and chapeau! > I'm glad I could be a part of contributing to kde! Marco has helped me i

Re: Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Wednesday, May 02, 2012 00:12:26 Viranch Mehta wrote: > http://git.reviewboard.kde.org/r/104226/#review13258 > --- > > Merged to master with commit bf1a11f5d9bcf73ba8f071bc4cd532ed8652e1d3 > > - Viranch Mehta Congrats, Viranch! You've do

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review13258 --- Merged to master with commit bf1a11f5d9bcf73ba8f071bc4cd532ed86

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On April 17, 2012, 11:18 a.m., Kai Uwe Broulik wrote: > > I just applied it to latest master and found a few usability issues: > > * The settings dialog that contains all the configs is way too small > > * The slider "grab" is 10 pixels to the left, some QML component issue > > And the showstop

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review12560 --- I just applied it to latest master and found a few usability is

Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Tue, Apr 3, 2012 at 7:25 PM, Marco Martin wrote: > > * the c++ applet shows a confirmation box for suspend & hibernate, > > how can this be done in QML? how about showing our regular applet-popup > > like in the battery monitor? with this option, the user also wouldn't > have > > to > > move t

Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Tue, Apr 3, 2012 at 7:24 PM, Daniel Nicoletti wrote: > doesn't the kworskspace API handle the confirmation already? > (I know it does for Shutdown, logoff and restart) > > kworkspace API is only used for "leave" (a combined action for logout, turn off, restart). for suspend actions, dbus calls

Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Tuesday 03 April 2012, Viranch Mehta wrote: > On Tue, Apr 3, 2012 at 1:45 PM, Marco Martin wrote: > > here the biggest challenge i guess is making all resize correctly in > > horizontal/vertical panels. > > Yes, just spent 5 hours on this. Finally resizing works almost fine inside > and outsid

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012/4/3 Viranch Mehta : > On Tue, Apr 3, 2012 at 1:45 PM, Marco Martin wrote: >> >> here the biggest challenge i guess is making all resize correctly in >> horizontal/vertical panels. > > > Yes, just spent 5 hours on this. Finally resizing works almost fine inside > and outside panels, except: >

Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Tue, Apr 3, 2012 at 1:45 PM, Marco Martin wrote: > here the biggest challenge i guess is making all resize correctly in > horizontal/vertical panels. > Yes, just spent 5 hours on this. Finally resizing works almost fine inside and outside panels, except: * it does not resize/change when the

Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Tuesday 03 April 2012, Viranch Mehta wrote: > On Mon, Apr 2, 2012 at 7:52 PM, Marco Martin wrote: > > hmm, not too happy about both, let's make lock/logout work as well then > > merge > > everything? > > That sounds fine. I'll soon open a review request. here the biggest challenge i guess is

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated April 3, 2012, 5:12 a.m.) Review request for Plasma. Changes --

Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Mon, Apr 2, 2012 at 7:52 PM, Marco Martin wrote: > hmm, not too happy about both, let's make lock/logout work as well then > merge > everything? > That sounds fine. I'll soon open a review request. Viranch ___ Plasma-devel mailing list Plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Monday 02 April 2012, Viranch Mehta wrote: > > On April 2, 2012, 12:25 p.m., Sebastian Kügler wrote: > > > Looking good now, thanks a lot for your patience! > > > > > > I'm getting this TypeError still, haven't looked into the reason behind > > > it: > > > file:///home/sebas/kdesvn/install/shar

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On April 2, 2012, 12:25 p.m., Sebastian Kügler wrote: > > Looking good now, thanks a lot for your patience! > > > > I'm getting this TypeError still, haven't looked into the reason behind it: > > file:///home/sebas/kdesvn/install/share/apps/plasma/plasmoids/battery/contents/ui/batterymonitor.q

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review12114 --- Ship it! Looking good now, thanks a lot for your patience! I'

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 23, 2012, 6:20 p.m.) Review request for Plasma. Changes -

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 21, 2012, 9:20 a.m., Marco Martin wrote: > > let's merge then fix all the things that may remain ok? > > (if you are rady to quickly fix issues as they come in, because many will > > report ;) > > Viranch Mehta wrote: > Yep, I'm ready. > > Sebastian Kügler wrote: > I'd prefe

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 21, 2012, 9:20 a.m., Marco Martin wrote: > > let's merge then fix all the things that may remain ok? > > (if you are rady to quickly fix issues as they come in, because many will > > report ;) > > Viranch Mehta wrote: > Yep, I'm ready. > > Sebastian Kügler wrote: > I'd prefe

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 21, 2012, 9:20 a.m., Marco Martin wrote: > > let's merge then fix all the things that may remain ok? > > (if you are rady to quickly fix issues as they come in, because many will > > report ;) > > Viranch Mehta wrote: > Yep, I'm ready. I'd prefer if we wait with merging until al

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 21, 2012, 9:20 a.m., Marco Martin wrote: > > let's merge then fix all the things that may remain ok? > > (if you are rady to quickly fix issues as they come in, because many will > > report ;) Yep, I'm ready. - Viranch --- T

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11683 --- let's merge then fix all the things that may remain ok? (if you

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11667 --- Screenshot:

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 20, 2012, 10:02 p.m., Vishesh Handa wrote: > > Screenshot: > > > > > > This looks kind bad. There should be a certain amount of padding. There is already some default padding in the popup. It is stripped off while viewing in plasmoidviewer for so

Re: Review Request: Merge the final and fixed QML battery monitor to master.

On Tuesday 20 March 2012, Viranch Mehta wrote: > > On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote: > > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line > > > 97 > > > > > ine97> > > > > > >

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 20, 2012, 10:27 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 97 > > > > > > horizontalAlignment: Text.AlignRight This doesn't work for some rea

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 19, 2012, 7:23 p.m., Marco Martin wrote: > > as for comments on the screenshot, labels on the left should be > > right-aligned, the code seems fine now Labels now right-aligned. Screenshot updated. - Viranch --- This is an a

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 20, 2012, 9:44 p.m.) Review request for Plasma. Changes -

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11650 --- Looking better, I think the translation issues are resolved now

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11632 --- as for comments on the screenshot, labels on the left should be

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11631 --- are there updates on this? still issues to work out? - Marco M

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11360 --- Read up on i18n, ideally most of http://techbase.kde.org/Devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 14, 2012, 6:46 p.m.) Review request for Plasma. Changes -

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 13, 2012, 5:32 p.m., David Edmundson wrote: > > Read up on i18n, ideally most of > > http://techbase.kde.org/Development/Tutorials/Localization/ and double > > check everything again. > > > > Also personally I like to submit a screenshot with any very visual change. Thanks for the

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 14, 2012, 6:39 p.m.) Review request for Plasma. Changes -

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 13, 2012, 5:32 p.m., David Edmundson wrote: > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66 > > > > > > This i18n string doesn't really work. > > > > 1) This string

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 14, 2012, 5:48 p.m.) Review request for Plasma. Changes -

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 11:59 a.m.) Review request for Plasma. Changes

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 66 > > > > > > The word puzzle here is not translatable. You'll need to enclose a f

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 11:14 a.m.) Review request for Plasma. Changes

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 10:26 a.m.) Review request for Plasma. Changes

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81 > > > > > > This should not be in there, basically only if it has been enabled b

Re: Review Request: Merge the final and fixed QML battery monitor to master.

Hi Viranch, On Tuesday, March 13, 2012 09:52:27 Viranch Mehta wrote: > > On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: > > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line > > > 81 > > > >

Re: Review Request: Merge the final and fixed QML battery monitor to master.

> On March 12, 2012, 10:31 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml, line 81 > > > > > > This should not be in there, basically only if it has been enabled b

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated March 13, 2012, 9:51 a.m.) Review request for Plasma. Changes -

Re: Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11311 --- The changes as they are add a few translation problems. There's

Review Request: Merge the final and fixed QML battery monitor to master.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- Review request for Plasma. Description --- I fixed the QML battery mo