Re: Review Request 123888: [krunner] Bring back history

2015-07-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/ --- (Updated July 29, 2015, 8:57 a.m.) Status -- This change has been

Re: Review Request 123888: [krunner] Bring back history

2015-07-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/ --- (Updated Juli 28, 2015, 3 nachm.) Review request for Plasma, KDE

Re: Review Request 123888: [krunner] Bring back history

2015-07-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/ --- (Updated Juli 28, 2015, 5:57 nachm.) Review request for Plasma, KDE

Re: Review Request 123888: [krunner] Bring back history

2015-05-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/#review80844 --- +1 history feature itself works fine here. only thing one

Re: Review Request 123888: [krunner] Bring back history

2015-05-25 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/#review80790 --- Good work! Let me try it out myself and see how it feels.

Re: Review Request 123888: [krunner] Bring back history

2015-05-25 Thread Kai Uwe Broulik
On Mai 25, 2015, 7:55 vorm., Vishesh Handa wrote: lookandfeel/contents/runcommand/RunCommand.qml, line 104 https://git.reviewboard.kde.org/r/123888/diff/2/?file=370597#file370597line104 We need the cursor position to be updated for runners which change the query string. You can

Re: Review Request 123888: [krunner] Bring back history

2015-05-24 Thread Kai Uwe Broulik
On Mai 24, 2015, 8:44 vorm., Heiko Tietze wrote: It's not intuitive to type 'pla' and get a list (with radio buttons!) that contains 'dolphin'. Expanding the dropdown without content should show previous search items and 'pla' could prioritize stuff from the history. And I'm

Re: Review Request 123888: [krunner] Bring back history

2015-05-24 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/#review80764 --- It's not intuitive to type 'pla' and get a list (with radio

Review Request 123888: [krunner] Bring back history

2015-05-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/ --- Review request for Plasma, KDE Usability and Vishesh Handa. Bugs: 335731

Re: Review Request 123888: [krunner] Bring back history

2015-05-23 Thread Kai Uwe Broulik
On Mai 23, 2015, 11:21 nachm., Mark Gaiser wrote: lookandfeel/contents/runcommand/RunCommand.qml, lines 98-102 https://git.reviewboard.kde.org/r/123888/diff/1/?file=370582#file370582line98 Hmm, this looks interesting. Suppose my history looks like this: - plasmashell

Re: Review Request 123888: [krunner] Bring back history

2015-05-23 Thread Mark Gaiser
On mei 23, 2015, 11:21 p.m., Mark Gaiser wrote: lookandfeel/contents/runcommand/RunCommand.qml, lines 98-102 https://git.reviewboard.kde.org/r/123888/diff/1/?file=370582#file370582line98 Hmm, this looks interesting. Suppose my history looks like this: - plasmashell