Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/ --- (Updated May 3, 2016, 12:20 a.m.) Status -- This change has been

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Feb. 23, 2016, 2:09 p.m., David Edmundson wrote: > > Martin, what is the state of this? > > > > You're in danger of missing Plasma 5.6. > > Martin Klapetek wrote: > I very likely won't be able to finish it in this cycle. > > David Edmundson wrote: > well, what's missing? > I

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Feb. 23, 2016, 1:09 p.m., David Edmundson wrote: > > Martin, what is the state of this? > > > > You're in danger of missing Plasma 5.6. > > Martin Klapetek wrote: > I very likely won't be able to finish it in this cycle. well, what's missing? I don't want to miss 5.7 too. - David

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Feb. 23, 2016, 2:09 p.m., David Edmundson wrote: > > Martin, what is the state of this? > > > > You're in danger of missing Plasma 5.6. I very likely won't be able to finish it in this cycle. - Martin --- This is an automatically

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review92660 --- Martin, what is the state of this? You're in danger of

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review89413 --- Ship it! Ship It! - David Edmundson On Nov. 18, 2015,

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Dec. 4, 2015, 7:52 p.m., Martin Klapetek wrote: > > I just found out that KHolidays is actually not a framework but part of KDE > > Applications. Will a dependency like that be ok? if it is optional and doesn't introduce a dependency loop I think it's fine. - Martin

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review89133 --- I just found out that KHolidays is actually not a framework

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Nov. 18, 2015, 10:14 a.m., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > > > > > Add context this Isn't "this" caputred implicitly? - Martin

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Nov. 18, 2015, 9:14 a.m., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > > > > > Add context this > > Martin Klapetek wrote: > Isn't "this"

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Nov. 18, 2015, 10:14 a.m., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > > > > > Add context this > > Martin Klapetek wrote: > Isn't "this"

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Nov. 18, 2015, 9:14 vorm., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > > > > > Add context this > > Martin Klapetek wrote: > Isn't "this"

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review88512 --- plasmacalendarintegration/HolidaysConfig.qml (line 62)

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/ --- (Updated Nov. 18, 2015, 1:33 a.m.) Review request for Plasma. Changes

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review87715 --- CMakeLists.txt (line 31)

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Oct. 30, 2015, 7:51 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 31 > > > > > > Should it be a required dep? I think it wasn't in 4.x? And reading the > > code it should be easy to have it optional

Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/ --- Review request for Plasma. Repository: plasma-workspace Description