D10835: [kicker] Never execute recent documents

aleksejshilin updated this revision to Diff 28171. aleksejshilin added a comment. - Use proper coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10835?vs=28032=28171 BRANCH always_open_recent_documents REVISION DETAIL

D10791: Fixed the Wikimedia Commons Picture of the Day provider

manuelc planned changes to this revision. REVISION DETAIL https://phabricator.kde.org/D10791 To: manuelc, #plasma Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10791: Fixed the Wikimedia Commons Picture of the Day provider

manuelc reclaimed this revision. REVISION DETAIL https://phabricator.kde.org/D10791 To: manuelc, #plasma Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10896: show config selection osd when display button is pressed

sebas created this revision. sebas added reviewers: Plasma, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY This makes the working of the display button much more

D10892: Make it possible to support exclusive action groups

mart added a comment. unfortunately this will need the cmake preprocessing hack it's used in qqc2-desktop style.. or, you could even ship 2 candidate ActionsMenu.qml and install one or the other based on cmake version check REPOSITORY R169 Kirigami REVISION DETAIL

D10892: Make it possible to support exclusive action groups

ngraham added a dependent revision: D10893: Use an action group for the sort options. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10892 To: apol, #kirigami Cc: mart, plasma-devel, apol, davidedmundson, hein

D10893: Use an action group for the sort options

ngraham edited the summary of this revision. ngraham added a dependency: D10892: Make it possible to support exclusive action groups. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10893 To: apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10896: Show config selection OSD when display button is pressed

ngraham retitled this revision from "show config selection osd when display button is pressed" to "Show config selection OSD when display button is pressed". ngraham edited the summary of this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D10896 To: sebas,

D10892: Make it possible to support exclusive action groups

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY We need to find away to import 2.3 if available otherwise

D10893: Use an action group for the sort options

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we get ugly checkboxes. Requires Qt 5.10. BUG: 391144 REPOSITORY R134 Discover

D10901: Add "move to device" functionality to hamburger menu

Fuchs added a comment. In D10901#215263 , @ngraham wrote: > At this point, let me also mention that screenshots are not only much appreciated, but vastly increase the chance of your patch (and name!) being featured in the next week's

D10901: Add "move to device" functionality to hamburger menu

drosca added inline comments. INLINE COMMENTS > ListItemBase.qml:340 > +var menuItem = newMenuItem(); > +if(type == "sink-input") { > +menuItem.text = i18nc("Heading for a list of possible > output devices (speakers, headphones, ...) to

D10855: Emit clicked when double click expires

graesslin added a comment. In D10855#214923 , @broulik wrote: > > Given that I'm not sure whether the base assumption that this is not intuitive holds. > > Having to explain to a user what to do hardly qualifies as intuitive. No

D10901: Add "move to device" functionality to hamburger menu

drosca added a comment. +1. No more code comments. Just a note, we can't guarantee that audio is actually playing from that stream. INLINE COMMENTS > drosca wrote in ListItemBase.qml:338 > `sinkView.model.count > 1` -> `sinkView.count` Sorry about this comment, it's nonsense. It was

D10901: Add "move to device" functionality to hamburger menu

Fuchs updated this revision to Diff 28219. Fuchs added a comment. Move text back to if/else for at least a bit of readability, reverted the check to go for > 1 since that is what we are interested in. Final revision, hopefully. CHANGES SINCE LAST UPDATE

D10901: Add "move to device" functionality to hamburger menu

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. I'm not sure on the wording "Output on" "Record from", I would prefer simple "Move to" or "Move to device", but I am not native speaker so I leave others to decide. Can you

D10901: Add "move to device" functionality to hamburger menu

ngraham added a comment. At this point, let me also mention that screenshots are not only much appreciated, but vastly increase the chance of your patch (and name!) being featured in the next week's installment of https://pointieststick.wordpress.com/category/usability-productivity/,

D10901: Add "move to device" functionality to hamburger menu

Fuchs created this revision. Fuchs added reviewers: broulik, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Fuchs requested review of this revision. REVISION SUMMARY This patch adds the possibility to choose a device for a

D10901: Add "move to device" functionality to hamburger menu

Fuchs updated this revision to Diff 28214. Fuchs added a comment. Updated the text, tried to merge the code blocks. Due to most of it happening in a for loop depending on the type, this was not possible in a sane way without having a helper method created. Personally I think legibility

D10901: Add "move to device" functionality to hamburger menu

Fuchs updated this revision to Diff 28218. Fuchs marked an inline comment as done. Fuchs added a comment. According to discussion on IRC, sacrifice some more readability for brevity. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10901?vs=28214=28218 REVISION DETAIL

D10901: Add "move to device" functionality to hamburger menu

Fuchs updated this revision to Diff 28221. Fuchs added a comment. Adapt code style. With regards to wording: even if we can't guarantee that audio is playing / being recorded, the wording is still correct. Since if there will be audio played / recorded, it will be on the device the

D10901: Add "move to device" functionality to hamburger menu

drosca added a comment. @ngraham This is not a new feature, only people didn't know about the drag functionality, which is understandable, but nevertheless the functionality is there for a long time already (since around Plasma 5.7/5.8). REVISION DETAIL https://phabricator.kde.org/D10901

D10901: Add "move to device" functionality to hamburger menu

Fuchs added a comment. In D10901#215244 , @drosca wrote: > > Can you merge the code into one block? Technically yes, but due to some edge cases it will make it hacky and difficult to read. Example: you can have a second

D10901: Add "move to device" functionality to hamburger menu

Fuchs edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10901 To: Fuchs, broulik, drosca Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

ngraham added a comment. In D10901#215244 , @drosca wrote: > I'm not sure on the wording "Output on" "Record from", I would prefer simple "Move to" or "Move to device", but I am not native speaker so I leave others to decide. [puts on

D10901: Add "move to device" functionality to hamburger menu

Fuchs marked an inline comment as done. Fuchs added a comment. In D10901#215274 , @ngraham wrote: > You're definitely not the only one who wants this. See: > > -

[Breeze] [Bug 350684] lock window when switching between users is very hard to use

https://bugs.kde.org/show_bug.cgi?id=350684 Lauris changed: What|Removed |Added Status|NEEDSINFO |REOPENED Ever confirmed|0

D10835: [kicker] Never execute recent documents

aleksejshilin marked 3 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10835 To: aleksejshilin, #plasma Cc: hein, anthonyfieroni, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Alex Barrero changed: What|Removed |Added CC||alex.brrsc...@gmail.com

D10885: Cleanup dbus interface, add dbus recipeskill method

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Ref T7174 cleaned up dbus interface,

D10885: Cleanup dbus interface, add dbus recipeskill method

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:2e8a1ec7cfbf: Cleanup dbus interface, add dbus recipeskill method (authored by Aiix). REPOSITORY R846 Mycroft

D10887: Show a radiobutton when we are showing an exclusive control

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY CCBUG: 391144 TEST PLAN MenuItem { autoExclusive: true } shows radio buttons instead of check boxes

D10887: Show a radiobutton when we are showing an exclusive control

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D10887 To: apol, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10887: Show a radiobutton when we are showing an exclusive control

This revision was automatically updated to reflect the committed changes. Closed by commit R858:55dbbdb9315c: Show a radiobutton when we are showing an exclusive control (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D10878: Changed default context menu entries on the desktop

anemeth abandoned this revision. anemeth added a comment. This is not removing settings, just disabling them by default. These could be enabled in the standard right click menu settings again. F5732210: Képkivágás.PNG I'll abandon this revision

D10878: Changed default context menu entries on the desktop

mart added a comment. -1 as well, removing entries is a no go, especially I won't accept the removal of anything related to widget manipulation REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10878 To: anemeth, #plasma, #vdg Cc: mart, rizzitello, zzag,

D10855: Emit clicked when double click expires

broulik added a comment. > Given that I'm not sure whether the base assumption that this is not intuitive holds. Having to explain to a user what to do hardly qualifies as intuitive. > The behavior by the way was inspired by other components such as toolbar buttons with dropdown

D10890: Prepare for KIO KRecentDocument fix (D10863)

aleksejshilin created this revision. aleksejshilin added reviewers: Plasma, broulik, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY Revision D10863

D10890: Prepare for KIO KRecentDocument fix (D10863)

anthonyfieroni added a comment. So why you called hack, why no just add conditional compilation against 5.44 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot,

[Breeze] [Bug 350684] lock window when switching between users is very hard to use

https://bugs.kde.org/show_bug.cgi?id=350684 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

D10896: Show config selection OSD when display button is pressed

dvratil requested changes to this revision. dvratil added a comment. This revision now requires changes to proceed. Hmm, I guess you can now kill `m_buttonTimer`, `m_iteration`, `resetDisplaySwitch()` and `applyGenericConfig()` as well, as those are used exclusively by the config iteration.

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma, hein Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai,

D10588: No icons on the desktop by default

ngraham retitled this revision from "Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948; to "No icons on the desktop by default". ngraham edited the summary of this revision. ngraham added a task: T7948: