D11842: Remove categories from app delegates

2018-04-07 Thread Henrik Fehlauer
rkflx added a comment. FWIW, have a +1 for the idea. Removing the categories is not ideal, but having the ratings can be much more enticing for the user to install the app, and there is only so much space… Thus I think it's the better compromise to go with the ratings. --- BTW, cou

D11876: Display star ratings

2018-04-07 Thread Henrik Fehlauer
rkflx added a comment. +1 for the concept and a version without the line and the bigger stars everywhere: F5787605: Without blue lines.png More comments: - Having the stars roughly the same height as the text next to it (like in the screen

D11876: Display star ratings

2018-04-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 31629. ngraham added a comment. Restore original design, but without the blue line CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11876?vs=31295&id=31629 BRANCH show-star-ratings (branched from master) REVISION DETAIL https://phabricator.kd

D11876: Display star ratings

2018-04-07 Thread Nathaniel Graham
ngraham added a comment. In D11876#241864 , @rkflx wrote: > - Having the stars roughly the same height as the text next to it (like in the screenshot above, from an earlier iteration) works good enough for me. You might want to check how this lo

D11842: Remove categories from app delegates

2018-04-07 Thread Nathaniel Graham
ngraham added a comment. In D11842#241862 , @rkflx wrote: > FWIW, have a +1 for the idea. Removing the categories is not ideal, but having the ratings can be much more enticing for the user to install the app, and there is only so much space… Th

D12035: Bump KF5 version requirement to 5.45

2018-04-07 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Discover depends on a feature in Kirigami (D

D11842: Remove categories from app delegates

2018-04-07 Thread Nathaniel Graham
ngraham added a comment. Patch to bump the version required: D12035: Bump KF5 version requirement to 5.45 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11842 To: ngraham, apol, #discover_software_store Cc: rkflx

D12036: Change "different user" icon on login screen

2018-04-07 Thread Scott Harvey
sharvey created this revision. sharvey added a reviewer: ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Replace "different user" icon on SDDM login screen to match icon

D12036: Change "different user" icon on login screen

2018-04-07 Thread Nathaniel Graham
ngraham added reviewers: Plasma, davidedmundson. ngraham accepted this revision. ngraham added a subscriber: davidedmundson. ngraham added a comment. This revision is now accepted and ready to land. I think I understand why the icons are currently different: because the functionalities are dif

D12035: Bump KF5 version requirement to 5.45

2018-04-07 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:f05895f3cec1: Bump KF5 version requirement to 5.45 (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12035?vs=31630&id=31645 RE

D11876: Display star ratings

2018-04-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 31646. ngraham added a comment. Revert accidental whitespace change CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11876?vs=31629&id=31646 BRANCH show-star-ratings (branched from master) REVISION DETAIL https://phabricator.kde.org/D11876 A

D12040: [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-04-07 Thread Chris Holland
Zren created this revision. Zren added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Patch 1/2 (other patch is for plasma-desktop) BUG: #386621 - http

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-07 Thread Chris Holland
Zren created this revision. Zren added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Patch 2/2 (other patch is D12040 for

D11876: Display star ratings

2018-04-07 Thread Henrik Fehlauer
rkflx added a comment. In D11876#241499 , @ngraham wrote: > Should we tweak it a bit more? One more thing to look into as a follow-up (besides the font size of the title) could be the vertical alignment of the text, i.e. how the first and